GitLab

Uses SearchResultDisplayType instead of SearchResult as input.

Bug: 733662
Change-Id: I52f11485d3a90fce44acf2abf4a93424ba5895d4
Reviewed-on: https://chromium-review.googlesource.com/998680Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#548577}

To support several versions of the WebView Support Library within the
same app/process we need to ensure the support library glue doesn't hold
any global state referencing the (app-side of the) support library.

With this CL we remove the only current global reference to the support
library: SupportLibraryInfo. The only information kept within that
reference was a list of feature flags. Those feature flags will now live
in individual callback objects instead, like WebViewClientCompat.

Corresponding Android Support Library CL:
https://googleplex-android-review.git.corp.google.com/#/c/platform/frameworks/support/+/3849471/

Bug: 752521
Change-Id: I9f8c67784fff9900f99b7c12f09f8cb1a39e64ea
Reviewed-on: https://chromium-review.googlesource.com/995212
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548576}

This adds three tests: before metadata, after metadata, and after
have enough. It doesn't clone the have future data test that src=
has since has_future_data == has_enough_data when using MSE.

BUG=756897
TEST=all tests!

Change-Id: I99c2cff3668c471bcd3d3d4549e53690788b0813
Reviewed-on: https://chromium-review.googlesource.com/989073Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548575}

By removing the default case the compiler will throw an error if any CBOR type is unhandled.

Change-Id: I6efd5c2fde89cf15ea4363cdc4d60b511979d6e8
Bug: 827564
Reviewed-on: https://chromium-review.googlesource.com/982736
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548574}

While in VR we hide the browser controls. This leads to an offset at the
top of the history page. And this results in distorted graphics showing
up due to an ininitialized buffer. To fix that move the UI up while in
VR.

Bug: 818817
Change-Id: I2e6113f410f644447a741ae7d339d2c8454db2f5
Reviewed-on: https://chromium-review.googlesource.com/963502Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548573}

This adds explicit rule to protect CloudDPC

Test: unit_test
Bug: b:73064229
Change-Id: If56eec0800d3a7be4c2a1775e6ceedec0583833f
Reviewed-on: https://chromium-review.googlesource.com/996568Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#548572}

Add a new org.chromium.ScreenLockService D-Bus service that
exports a single ShowLockScreen method. This uses the
existing ScreenLockServiceProvider class that already
exports an identical LockScreen method on
org.chromium.LibCrosService.

The org.chromium.LibCrosService method will need to continue
to be exported until session_manager has been updated to use
org.chromium.ScreenLockService instead.

Bug: 827680
Change-Id: I8c907f4a3304ed9f1bb3953a138b10b9ce90363e
Reviewed-on: https://chromium-review.googlesource.com/998437
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548571}

Adds a simple cache with prime modulo hashing. This cache gets 95% hit
rate and gives us 30% performance improvement compared to without cache
for running heap profiler.

BUG=819888

Change-Id: I4c3dd6cf34ee1db21469e56886eaa3f62dd1881d
Reviewed-on: https://chromium-review.googlesource.com/985234Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548570}

DevTools: deprecate devtools_protocol helpers on the chrome level, use inspector_protocol generator.

Change-Id: Icc3564e892d4f05277d3d62250346af2601c89f0
Reviewed-on: https://chromium-review.googlesource.com/996915
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548569}

Changes:
Use the relative y of work area to display bounds to set fullscreen app
list bounds. This fixes the app list bounds in non-primary displays.

BUG=828207

Change-Id: I2bf2ebc49c617240ef9df869020c95996ef18e3f
Reviewed-on: https://chromium-review.googlesource.com/998517Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548568}

Create separate unit test to separate logic of FidoRequestHandler and
MakeCredentialHandler. Unit test for FidoRequestHandler should only test
two things.
  1) At most one response from multiple authenticators should be passed
     to the relying party.
  2) Second, cancel operation should be invoked to authenticators that
     error out.

Bug: 826132
Change-Id: I785c53a39dc64d7974e57aeb87bc0baaecd7b4e8
Reviewed-on: https://chromium-review.googlesource.com/982558
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548567}

Gerrit threw a 500 when uploading the final version of [1] and I didn't
notice. Then the CQ landed the wrong version.

This change includes the final set of code-review replies.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/982634

TBR=engedy

Change-Id: I400c713dedadb2bfac5629994a048a775c0c14b8
Reviewed-on: https://chromium-review.googlesource.com/998184Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548566}

This CL is a refactor with no intended behavior change.

Bug: 827545
Change-Id: Ibdbcdad3f2e6f0d14a8cb1bc15cc797af6224a98
Reviewed-on: https://chromium-review.googlesource.com/998572
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548565}

Change-Id: Ic06a5f3b7cd9d150afa715f491b19582b11fcc5b
Reviewed-on: https://chromium-review.googlesource.com/998815
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548564}

Per the explainer[1] and tests: "Cookies with an empty name cannot be
set using values containing = as this would result in ambiguous
serializations in the majority of current browsers."

Also, fix a test glitch now that this restriction is implemented.

[1] https://github.com/WICG/cookie-store/blob/gh-pages/explainer.md

Bug: 729800
Change-Id: I9ed02885c217cbdb4c86d8fd236d49c6c56b6e96
Reviewed-on: https://chromium-review.googlesource.com/994145
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548563}

Merge two sets of tests that cover __Secure- and __Host- prefixed
cookies in the API. Tests cover secure and non-secure contexts,
getting, setting, deleting, and setting already-expired cookies.

Bug: 729800
Change-Id: Ie7e84eeda03ba8192f5062cbf5240ff8ab13816a
Reviewed-on: https://chromium-review.googlesource.com/994174
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548562}

This allows CT Policy to be enforced when the Network Service is enabled.
It is a small refactoring of the CTPolicyManager so that it no longer
knows about preferences, but instead is passed the required and exclude lists.

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibb369371d14a14d4e5fdb216da0e906494120fa2
Reviewed-on: https://chromium-review.googlesource.com/978587
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548561}

Home launcher is a feature to show fullscreen launcher in tablet mode.
And home button will minimize all windows instead of opening/closing
the launcher.

BUG=828945

Change-Id: If9ce1f287a72cc7dc6e2424819cb54e7b47b3f3d
Reviewed-on: https://chromium-review.googlesource.com/996177
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548560}

These class no longer has any dependencies on content/.
Move them to components/download for servicification work.
Also move some classes from components/download/public to
components/download/internal.

BUG=803135

Change-Id: I7f41ba131d7a184da2090cad733c9f5b3106aadc
Reviewed-on: https://chromium-review.googlesource.com/996020
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548559}

The offline files which were saved before the feature was enabled reside
in internal directory. To share them, we need to publish them first.

Bug: 758690
Change-Id: I8750c77f120d3fad144c6a309304d54e26227c32
Reviewed-on: https://chromium-review.googlesource.com/994118Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548558}

BUG=chromium:819444
TEST=Manually tested.

Change-Id: If772cc1efaf8105e92fa6bbfa709ee56110dfe90
Reviewed-on: https://chromium-review.googlesource.com/998514Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548557}

The DCHECK is incorrect when there are both border radius clip and
overflow clip.

Remove the DCHECK, and use FragmentData::PostOverflowClip() and
PreClip() in this function.

Bug: 828164
Change-Id: I3e9d36b26bfb72c90a37ffd492c44236920cc6f7
Reviewed-on: https://chromium-review.googlesource.com/994052Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548556}

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I03e4872ac677bc507f53df78938b7b70ef509aac
Reviewed-on: https://chromium-review.googlesource.com/998314Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548555}

This reverts commit 7a462a5d.

Reason for revert: This CL seems to be the cause for a
views_unittests failure:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26901

Original change's description:
> Added material refresh layout provider. Updated material design controller.
> 
> Added IsMaterialRefreshMode() function to ChromeLayoutProvider.
> 
> Bug: 822000
> Change-Id: I379d7603838cdec60b3f94fc0e163e9907995b61
> Reviewed-on: https://chromium-review.googlesource.com/988052
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548413}

TBR=sky@chromium.org,pkasting@chromium.org,kylixrd@chromium.org

Change-Id: I173a8e69440ee564accc1824d6f1406dc7b1cb92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 822000
Reviewed-on: https://chromium-review.googlesource.com/998852Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548554}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I884fbeef63c4566ecbcaee9fcc5b598af499aef5
Reviewed-on: https://chromium-review.googlesource.com/988953Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548553}

Bug: 828477
Change-Id: I32cc91281be6ac1336359f891e5aa3042b366b81
Reviewed-on: https://chromium-review.googlesource.com/993238
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548552}

BUG=829068

Change-Id: I8966cf06a31c12d50804c810a6b85f9a53b9bf59
Reviewed-on: https://chromium-review.googlesource.com/996587
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548551}

https://chromium.googlesource.com/catapult.git/+log/5d3d40fb8894..883d59ef7027

$ git log 5d3d40fb8..883d59ef7 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 eakuefner [Dashboard] Don't create summary stats for benchmark_total_duration

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I4fe8454a09519bd610dfb3b7a9e1ca424c8ad1e9
Reviewed-on: https://chromium-review.googlesource.com/998433
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548550}

There are no logic changes in this CL.

This CL adds comments to parameters of SuggestResult instance creation.
It also corrects a comment about NULL to nullptr.

TBR=mpearson@chromium.org

Bug: None
Change-Id: I2620d3fb9382513dbc2033760b2a14b8516a115a
Reviewed-on: https://chromium-review.googlesource.com/998189Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548549}

This test could be sensitive to platform configuration since it relied
on generating a filename extension based on a MIME type. In particular,
if the platform configration associated anything other than .htm on
text/html on Windows the test would fail. (Same for .html on Posix).

This change refactors the test for readability, and removes its
dependence on local configuration.

Bug: 828954
Change-Id: Iad2b838e0f044ccdbf7eb2caf2a08d65a4dab857
Reviewed-on: https://chromium-review.googlesource.com/996354
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548548}

This was added to WebRTC in
https://webrtc-review.googlesource.com/c/src/+/57220

Bug: 811683
Change-Id: I8a53ed68fd1b76ae222f82f3246120bba4ac3ee2
Reviewed-on: https://chromium-review.googlesource.com/998432Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548547}

Bug: webrtc:7932
Change-Id: I6d9a97754e6f19f5917927a24652786a4d9624c5
Reviewed-on: https://chromium-review.googlesource.com/986509
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548546}

This DCHECK has been hit by developers too often, making a checked build
useless. Disabling the DCHECK in the meantime while a fix can be done.

BUG=816490

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3b9d020978b4ebabf00233c35ba3059a8ba2f9fd
Reviewed-on: https://chromium-review.googlesource.com/998529
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548545}

This change implements the SetNextUnsubscribeFromNotifications function
for fake characteristics.

BUG=569709

Change-Id: I99c59a4caffd524e727921fcb54f48cc868d545f
Reviewed-on: https://chromium-review.googlesource.com/988223
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548544}

Wayland does implicit capture. This adds plumbing to track when the
WaylandWindow has implicit capture, and adds function to
PlatformWindow to test for capture.

Also notifies when activation changes.

BUG=none
TEST=covered by tests

Change-Id: I9d73ade6cb8e5e909fe3fe3940eb6f48b0dbd5c7
Reviewed-on: https://chromium-review.googlesource.com/998307
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548543}

This change updates the generated characteristics tests for
calling disconnect/device disconnecting before an operation on a
characteristic.

BUG=509038

Change-Id: I16b7ffbfd6df473ee0c4c0bfb34982473c41482f
Reviewed-on: https://chromium-review.googlesource.com/986890
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548542}

The tab grid was not behaving properly in rotations. The page would
change when it is not supposed to. This is due to the page being set
inside |-scrollViewDidScroll:| while the rotation was occurring.
The fix is to separately set the page for non-user-dragging scroll
in |-scrollViewDidEndScrollingAnimation:|.

Bug: 828735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib325eb6ef5d5ebb98274ec565cdbb03a21b8e9e1
Reviewed-on: https://chromium-review.googlesource.com/998055Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548541}

Adds conversion from gfx::ColorSpace to SkYUVColorSpace.

Bug: 754986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I22260ea9542afc5306c82b7ec6d2e2d0cf4b7a0a
Reviewed-on: https://chromium-review.googlesource.com/869147Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548540}

NOTRY=true
TBR=nednguyen@google.com

Bug: 829504
Change-Id: Id45cfb893bde4cced66a95ee2a1b1e73a9d430ec
Reviewed-on: https://chromium-review.googlesource.com/998622Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548539}

This implements support library callbacks (WebViewclientCompat). This
creates a new layer (support_library/callback) which the glue layer
depends on. This dependency lets us instantiate a
SupportLibWebViewContentsClientAdapter inside setWebViewClient(), and
benefit from the glue layer's parameter cleanup code (e.g., in
onReceivedError2()).

The support_library/callback glue must be a separate layer from
support_library/ glue, as that already depends on the webkit glue to
initiate state. Implementing callbacks as a separate target avoids the
circular dependency.

This refactors the (post-L) glue layer callback methods to take the
following precedence:

 1. SupportLibWebViewContentsClientAdapter (if it supports the callback)
 2. WebViewClient (if on the appropriate platform level)
 3. Default behavior (implementation provided by the glue layer)

This implements both category 1 and 2 APIs.

Design doc: http://go/wv-support-library-callbacks

Bug: 781764
Test: manual - built test application with latest support-lib changes
Change-Id: I21e28493873e670cfd428c7eeef12b0e212aeec4
Reviewed-on: https://chromium-review.googlesource.com/989015Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548538}