- 27 Apr, 2018 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24871c6b..4bcdfad6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0083f8a64dda1e213e2677f4f7b0f1d4830dabf5 Reviewed-on: https://chromium-review.googlesource.com/1032470Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554349}
-
Noel Gordon authored
Disable this test on MSAN. Bug: 837551 Change-Id: I8e5f6480ab4e274420f5b2f339dc1b44ec49454e Reviewed-on: https://chromium-review.googlesource.com/1032455Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554348}
-
Fredrik Hubinette authored
... for Pixel_Video_VP9 Bug: 754986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5fd7742ca773d8a5abbb8ad8326f559af246f19c Reviewed-on: https://chromium-review.googlesource.com/1024497Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#554347}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 51249958. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" 7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight" a8385691 "Make web font timeouts work for preloaded fonts" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16303 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/service-workers/cache-storage yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=foolip No-Export: true Change-Id: I367f0de0fbd437f27a73e28e21efc7a16b17f0a4 Reviewed-on: https://chromium-review.googlesource.com/1032370 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554346}
-
Rune Lillesveen authored
Just replaced by LayoutBlockFlow. Change-Id: I7ad382af6078de151fb906ca3a65e16d423c29bd Reviewed-on: https://chromium-review.googlesource.com/1032391Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554345}
-
https://webrtc.googlesource.com/src.git/+log/ad7f6e5ccf77..6a8f30e5a36f $ git log ad7f6e5cc..6a8f30e5a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib3465d9adba3ff1dd42c002acf0135324752b7b1 Reviewed-on: https://chromium-review.googlesource.com/1032256 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554344}
-
Kouhei Ueno authored
I couldn't find any occurrence in tests that attempt to dynamically reconfigure this. This CL just makes them use constants to reduce complexity. Bug: 689702 Change-Id: I431aaec674a439d82499a1b4099d4de64e75f5c1 Reviewed-on: https://chromium-review.googlesource.com/1032313 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/414be9b332f7..a886544a7bf7 $ git log 414be9b33..a886544a7 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 angle-skia-autoroll Roll third_party/externals/angle2/ 1633663b3..467c15f97 (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ibe6f00425fb3f8d701ace6e1f3146407eaf2237b Reviewed-on: https://chromium-review.googlesource.com/1032290 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554342}
-
Yoav Weiss authored
Currently `Request.destination` is set to "unknown" prefetch, but that was recently changed: Issue: https://github.com/whatwg/fetch/issues/658 PR: https://github.com/whatwg/fetch/pull/659 This CL aligns the destination values to the spec change. Bug: 832105 Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f Reviewed-on: https://chromium-review.googlesource.com/1029858 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554341}
-
Yoichi Osato authored
Since we don't paint list marker selection today, the override is no longer needed(return null Rect as default). Bug: 837521 Change-Id: Ic31f773b82c08c5d758441e6dd15fd33c33e6bd8 Reviewed-on: https://chromium-review.googlesource.com/1032351Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#554340}
-
Jonas Olsson authored
|session_id| used to be passed to AudioCapturerSource::Initialize, then on to AudioInputIPC::CreateStream, and finally into the stream creation callback. Change that to pass it into AudioInputIPCFactory::CreateAudioInputIPC at AudioInputDevice creation time, and bind it into the callback at that point. We don't pass it to factory_->CreateAudioCapturerSource branch, as that one is only used for testing. This means that the caller has to provide the session id at IPC creation time, instead of the call to Initialize. Note that we currently don't currently support calling Initialize more than once, so we don't need to support changing the session_id later. BUG=834704 TBR=bbudge@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibfaaa80e1552e7166fc18b6c935ac1c03a2cef00 Reviewed-on: https://chromium-review.googlesource.com/1024170 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#554339}
-
Tetsui Ohkubo authored
This CL fixes Screenshot notification to be shown on UnifiedSystemTray. Screenshot notification is the easiest example to reproduce, but it could happen on other notifications. MessageListView scroller's Layout() should be explicitly called before UnifiedMessageCenterView's PreferredSizeChanged is called, as the result of the layout affects the preferred size of UnifiedMessageCenterView. TEST=manual BUG=836699 Change-Id: I1f6c519052f8bd0561a26a40943acaffdb6e586f Reviewed-on: https://chromium-review.googlesource.com/1027392Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#554338}
-
Yutaka Hirano authored
At https://crrev.com/08d9e1d29b685f8bc5da44d14727751d3f29f7be I forgot to add a reference from DetachedClient to DocumentThreadableLoader to keep it alive. This CL fixes that. Bug: 837511 Change-Id: Ie9549e6a7789bfbc6783cbfcd8fb4951ea78de40 Reviewed-on: https://chromium-review.googlesource.com/1032272Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554337}
-
Kent Tamura authored
The main change of this CL is that MakeNamesWriter.__init__() sets a qualified header path and a correct include guard to _template_context. In order to do it, - json5_generator.Writer.__init__() takes output_dir argument, and stores a directory name relative to "gen/". - Introduce json5_generator.Writer.make_header_guard(). Bug: 836071 Change-Id: I75a8ce8849071cb5a32e19f4304dc070937a8554 Reviewed-on: https://chromium-review.googlesource.com/1025351 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#554336}
-
Hitoshi Yoshida authored
Before this CL, the main thread is set up only for core module. i.e. In V8ContextSnapshot::EnsureTemplate, it creates V8Window function template for modules, and it is used for default contexts. After this CL, those elements are set with modules component. Bug: 834642 Change-Id: I94bb23376d8138abbf9806b7bbad4f59eaee6d8f Reviewed-on: https://chromium-review.googlesource.com/1030530 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Traffic annotation auditor is updated as follows: 1- It ignores clang tool's errors if the tool has been able to produce outputs. This is done because we might pass files to clang tool that belong to other platforms, and the tool's errors on these files should not prevent processing of the other returned results. 2- safe_list.txt is updated and all tests are excluded. 3- A bug in usage of safe listed exception type ALL is fixed. If a file that is in safe list type ALL is processed by the clang tool, its outputs are ignored when clang tool results are parsed. Bug: 690323 Change-Id: I61334f2bc5170bc04b399439daac6f6b6f20bc0a Reviewed-on: https://chromium-review.googlesource.com/1024010 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#554334}
-
Tetsui Ohkubo authored
According to UX prototype, label texts of Feature Pod buttons will fade out when UnifiedSystemTray is collapsed. UX prototype: http://shortn/_EAeqJNHpAg Design doc: go/cros-qs-restyling (See "Support animation" section) TEST=manual BUG=826999 Change-Id: I5d65897d071522cb78c9a707a7daf3da33a1fc8b Reviewed-on: https://chromium-review.googlesource.com/1029938Reviewed-by:
-
Tetsui Ohkubo authored
As a result of rouding UnifiedSystemTray bubble corners in https://crrev.com/c/1003015, now TrayBubbleView::GetBubbleInsets() does not return 0. It breaks SetMaxHeight we set to give enough space on top of UnifiedSystemTray bubble. (See the bug for screenshot) TEST=manual BUG=837150 Change-Id: I031b2b3a7ce8c53615e3aef1730ea3ed139edf79 Reviewed-on: https://chromium-review.googlesource.com/1029932Reviewed-by:
-
Tetsui Ohkubo authored
In old SystemTray, "This device is managed by example.com" row is a long to learn more. In UnifiedSystemTray, enterprise management state is shown on the right bottom, but it was not clickable. This CL makes it clickable. Screenshot: http://screen/2q9GG6nqpZY TEST=manual BUG=b/78304937 Change-Id: I893144e61473e983ab56cff1c6f379340cf51fcb Reviewed-on: https://chromium-review.googlesource.com/1032030Reviewed-by:
-
Friedrich Horschig authored
This CL completes the MVC structure of the keyboard accessory component. The accessory view is changed only as reaction to model changes. It now lives in the ChromeActivity and is properly destroyed like other high-level UI components. Bug: 828832 Change-Id: I8dac0e79a6032abc6df36014bf9925df9a53bc92 Reviewed-on: https://chromium-review.googlesource.com/1013702Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554330}
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //chrome. R=thestig@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ieb2216cb355b5cba4406a43dbb6a82f3a5e16875 Reviewed-on: https://chromium-review.googlesource.com/1031051Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554329}
-
Koji Ishii authored
Following bot results are included. 5019 5022 5027 5029 5032 5035 5041 1 lines were removed and 4 lines were deflaked by consecutive results since 4969. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icf6933fa3c7fdfac0dd228a9f0671be0320f2cf7 Reviewed-on: https://chromium-review.googlesource.com/1030111 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/e782abab190e..ad7f6e5ccf77 $ git log e782abab1..ad7f6e5cc --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:836979,chromium:None,chromium:829238 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I972385f763f181ae3e2f599e8db257bb3ae1f730 Reviewed-on: https://chromium-review.googlesource.com/1032051Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0d59624af6929d120050f3b64a4b1914d31a988b Reviewed-on: https://chromium-review.googlesource.com/1032250 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554326}
-
Kuo-Hsin Yang authored
Bug: 834659 Change-Id: I5df0bc9b923c7a780de896f71cc68443902de12b Reviewed-on: https://chromium-review.googlesource.com/1031991Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#554325}
-
Darren Shen authored
Quick patch to change some DCHECKs to DCHECK_EQ. Gives better logging when the DCHECKs fail. Change-Id: I1ca330a68fc1409a016e76fcb71db9b0afd56083 Reviewed-on: https://chromium-review.googlesource.com/1023532Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#554324}
-
Manuel Rego Casasnovas authored
When computing the percentage height of table cell children, if the table cell has horizontal scrollbar we have to subtract its height from the OverrideLogicalHeight(). The patch is just following a suggestion from a TODO in LayoutBox::ComputePercentageLogicalHeight(). BUG=837408 TEST=external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children-002.html Change-Id: I5fc818545ce5ffcbb14112616f602668f492cc6d Reviewed-on: https://chromium-review.googlesource.com/1031590Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#554323}
-
Yuri Wiitala authored
This is a simple test utility that will be used in upcoming tests to fake the behavior of an audio::GroupMember that can be "snooped" upon. Tests can configure it to generate a sine wave tone, per channel, and also manually push each successive AudioBus to an audio::GroupMember::Snooper. This will be used in later changes to support testing of the new loopback functionality in the Audio Service. Bug: 824019 Change-Id: I4358319f215fc6692143d4ab0ae52703c1c30427 Reviewed-on: https://chromium-review.googlesource.com/1029546 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
It looks like some clients (OOPIFs, mostly like) are submitting compositor frames to viz, but they are not drawn on screen. As a result, the display compositor keeps accumulating the LatencyInfo associated with the frames. This can grow unbounded. Impose a limit of at most 100 such LatencyInfos being accumulated for a single client. BUG=834421 Change-Id: I144db30ef2264ea4e9e1b952fe7b1cbcc53ebc46 Reviewed-on: https://chromium-review.googlesource.com/1027432Reviewed-by:
Brian Anderson <brianderson@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#554321}
-
Fady Samuel authored
We would like to allocate viz::LocalSurfaceIds on the cc impl thread which means moving the ResizeOrRepaintAck to the impl thread. As a first step, resize and repaint should be unified. Repaint is equivalent to simply allocating a new LocalSurfaceId and the "ResizeAck/SynchronizeVisualPropertiesAck" is simply sent to the browser if a LocalSurfaceId changes with the new RenderFrameMetadata. With this CL, we plumb the parent provided LocalSurfaceId all the way through cc even if surface sync is off which can be used to trigger repaints. After this CL we can unify resize and repaint. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I58a1666d24d73b3642db0bd38454a8643065d041 Reviewed-on: https://chromium-review.googlesource.com/1029616 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#554320}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74d7d171a121..bec9b446c412 $ git log 74d7d171a..bec9b446c --date=short --no-merges --format='%ad %ae %s' 2018-04-17 gmeinke Make parallel_emerge save install plan Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4e3e42dbdf5b7fcc6a583707a6ae30a5cedb474a Reviewed-on: https://chromium-review.googlesource.com/1032071 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554319}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation of chrome://settings from GYP to GN, and fixes a number of type-checking issues that were somehow suppressed due to the way the compiler used to be run. A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. A more localized compile may look like: ninja -C out/Default chrome/browser/resources/settings:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1957d6e0d7bddf2f108197c60c1ca9d9b8f74ca Reviewed-on: https://chromium-review.googlesource.com/1023520 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554318}
-
Tatsuhisa Yamaguchi authored
When the app was unloaded, it seems loaded right before sending the onLaunched event. Therefore asynchronously adding the listener will miss the first event, being unable to respond for the user action in this case. https://developer.chrome.com/apps/app_lifecycle The issue was introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/1018624 Bug: 837251 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d613f9e877a39b3db0e92919a83d05bc45a0e06 Reviewed-on: https://chromium-review.googlesource.com/1031752 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554317}
-
Timothy Loh authored
As Crostini is not supported on guest and ephemeral profiles, we change IsExperimentalCrostiniUIEnabled() into IsCrostiniUIAllowedForProfile() so we can avoid creating the various controllers and builders, as well as not showing UI in the settings page. This makes us less likely to assume a CrostiniRegistryService exists when one actually doesn't. This is a reland of https://crrev.com/c/1029934, which happened to land at the same time as https://crrev.com/c/1013824 causing a compile fail. TBR=xiyuan Bug: 836187 Change-Id: Ifefe467d1135388fa1a25c2fed22d34c09108ddb Reviewed-on: https://chromium-review.googlesource.com/1032131Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554316}
-
Kouhei Ueno authored
TokenizedChunkQueue is a deprecated optimization where it reduced number of tasks being posted from BackgroundHTMLParserThread to the main thread. Now that we actually run the BackgroundHTMLParser on the main thread, we no longer need this optimization, we can queue the speculation anytime we want. Bonus: Now that we have move semantics, just use CompactHTMLToken directly, not via unique_ptr. Bug: 689702 Change-Id: I0a219b0baba79a4293d8e8bd09300837c1c6bf4c Reviewed-on: https://chromium-review.googlesource.com/1029552Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
-
Nicholas Verne authored
Bug: 822507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieee1606155667561c88fc8360eeafb4067361e5d Reviewed-on: https://chromium-review.googlesource.com/1032112Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#554314}
-
Gyuyoung Kim authored
This reverts commit 673c3aa4. The original fix missed to solve other flaky places. The new flaky test seems to be due to not waiting long enough as well. This CL is to fix them. Original CL description: > The flaky failure of the test seems to be due to not waiting long enough after > resuming work again. This Cl changes the workaround logic to actually wait until > the javascript work again (or let the test fail by timing out otherwise). Bug: 832191 Change-Id: I2e36af87b341d6593dc2f10095f57742e37d5aad Reviewed-on: https://chromium-review.googlesource.com/1031790Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#554313}
-
tzik authored
As std::mem_fun is deprecated in C++11 and removed in C++17, we need to update it to compile the code in C++17. Bug: 752720 Change-Id: I8f1c6bb8d6b302ec20799b6d2d636f7ac4d62e2b Reviewed-on: https://chromium-review.googlesource.com/1032111Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#554312}
-
Yuta Kitamura authored
Scheduler classes are being renamed and relocated as part of scheduler architecture refactoring. The header file is moved to its new location: scheduler/public, since the file is referred from Blink. Bug: 826203 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1c28c5c59ea8a2efd42eb896d89cd7539df4f609 Reviewed-on: https://chromium-review.googlesource.com/1029794Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/b221486a8dfd..467c15f970b9 $ git log b221486a8..467c15f97 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 jiawei.shao Use ShaderMap in ProgramD3D - Part II 2018-04-17 jmadill Optimize ValidateDrawAttribs: Part 3. 2018-04-24 geofflang Don't test for device loss in SwapBuffers and MakeCurrent. 2018-04-26 courtneygo Cleanup for "Add angle library apk" Created with: roll-dep src/third_party/angle BUG=chromium:621240 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I73c736ed72e46efad018fb0266ba2bb230a2a1b6 Reviewed-on: https://chromium-review.googlesource.com/1031780Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554310}
-
