GitLab

On Android, the sandbox logic is put into a shared library and the linker errors
out on having a TEXTREL.

The LDR pseudo-instruction directs the assembler to place the address of the
label in a "literal pool"[1], and then use a PC-relative load from that pool to
get the address during execution. The pool is responsible for generating
the R_ARM_RELATIVE TEXTREL.

Using the ADR instruction[2] does not produce the TEXTREL. This instruction
directs the assembler to calculate the PC-relative address to the label using an
immediate.

The text makes this difference more clear:

...
   8:   4805            ldr     r0, [pc, #20]   ; (20 <SyscallAsm+0x20>)
   a:   e007            b.n     1c <SyscallAsm+0x1c>
...
  1c:   bd80            pop     {r7, pc}
  1e:   0000            .short  0x0000
  20:   0000001c        .word   0x0000001c

Versus:

...
   8:   4804            ldr     r0, [pc, #16]   ; (1c <SyscallAsm+0x1c>)
   a:   e007            b.n     1c <SyscallAsm+0x1c>
...
  1c:   bd80            pop     {r7, pc}
  1e:   bf00            nop


[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0041c/Babbfdih.html
[2] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0040d/Cihdhgbe.html

BUG=308763

Review URL: https://codereview.chromium.org/119453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242141 0039d316-1c4b-4281-b951-d872f2087c98

A follow on to crrev.com/112293002 - replace holding an extra
pointer to determine state with querying an existing member object.

R=dgrogan

Review URL: https://codereview.chromium.org/110983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242140 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330212
TEST=Manual, see bug
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/101193007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242139 0039d316-1c4b-4281-b951-d872f2087c98

R=caitkp@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/119433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308318,309131,308681
TEST=manual, added MergeSessionTest.MergeSessionThrottle

Review URL: https://codereview.chromium.org/118733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/118343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158004

Review URL: https://codereview.chromium.org/116093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242133 0039d316-1c4b-4281-b951-d872f2087c98

The referrer policy is not ignored, but already read out of the extra
data before willSendRequest()

BUG=none
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/112373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242132 0039d316-1c4b-4281-b951-d872f2087c98

Add GetNSSCertDatabaseForResourceContext to nss_context to get one.

BUG=218643

Review URL: https://codereview.chromium.org/111273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242131 0039d316-1c4b-4281-b951-d872f2087c98

This does NOT cause Chrome to use QUIC 13, that will come later.
Refactors the mechanims that QUIC tests use to to create packets.

Review URL: https://codereview.chromium.org/110853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242130 0039d316-1c4b-4281-b951-d872f2087c98

If we fail to create the java MediaCodec, we should early return in VideoCodecBridge::CreateDecoder(). Otherwise, we will hit NPE.

BUG=329742

Review URL: https://codereview.chromium.org/99423010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242129 0039d316-1c4b-4281-b951-d872f2087c98

Requests using all idempotent HTTP methods (See RFC 2616) should be
retried after receiving a bypass message from the data reduction
proxy. Before this CL, only GET was being retried.

BUG=327740

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241714

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241927

Review URL: https://codereview.chromium.org/99283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242128 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to need to install a another singleton client for
transients. Rather than touch all places to explicitly set n clients
I'm creating Environment to centralize common setup and teardown.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/105813013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242126 0039d316-1c4b-4281-b951-d872f2087c98

Unify the code that dispatches touch events to native, making it easier to
follow touch event flow through the pipeline.  Also guard against nested loops
for touch dispatch, triggered by synchronous acks when there are multiply
enqueud touch events.

Review URL: https://codereview.chromium.org/119333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242124 0039d316-1c4b-4281-b951-d872f2087c98

consistency

Review URL: https://codereview.chromium.org/119043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330112

Review URL: https://codereview.chromium.org/108843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242122 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a utility class to streamline the task of testing that metrics have been updated as expected. Specifically, the HistogramRecorder class allows a client to obtain the differential value of a given histogram in the interval since the given HistogramRecorder instance was created.

This reverts commit b957026f.

BUG=232414
TBR=rsleevi, mark, groby, thakis

Review URL: https://codereview.chromium.org/19866004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242121 0039d316-1c4b-4281-b951-d872f2087c98

Broke this test Mac ASAN 64 Tests (1):
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%2064%20Tests%20%281%29/builds/402

AppBackgroundPageNaClTest.BackgroundKeepaliveActive (run #1):
[ RUN      ] AppBackgroundPageNaClTest.BackgroundKeepaliveActive
[6102,475938816:04:26:31.429668] Native Client module will be loaded at base address 0x000066c200000000
[6104,475938816:04:26:32.535943] Native Client module will be loaded at base address 0x00003d5a00000000
ASAN:SIGSEGV
=================================================================
==6095==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000106384d7b sp 0x7fff5d44fde0 bp 0x7fff5d450000 T0)
    #0 0x106384d7a (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103bdbd7a)
    #1 0x106384a31 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103bdba31)
    #2 0x11296475a (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101bb75a)
    #3 0x112964905 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101bb905)
    #4 0x1061f4e33 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a4be33)
    #5 0x1061f45af (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a4b5af)
    #6 0x1049070ec (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10215e0ec)
    #7 0x104902b5b (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x102159b5b)
    #8 0x109457b06 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106caeb06)
    #9 0x109ca6d33 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1074fdd33)
    #10 0x109453876 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106caa876)
    #11 0x10945e99e (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106cb599e)
    #12 0x10944b514 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x106ca2514)
    #13 0x112896341 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1100ed341)
    #14 0x1061f1486 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a48486)
    #15 0x106f2bac3 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x104782ac3)
    #16 0x106f2e6f0 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1047856f0)
    #17 0x106f2f63e (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10478663e)
    #18 0x106f438e8 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x10479a8e8)
    #19 0x106f42939 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x104799939)
    #20 0x10645d4e5 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103cb44e5)
    #21 0x1061ecafe (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a43afe)
    #22 0x11295833d (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1101af33d)
    #23 0x1061ec995 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x103a43995)
    #24 0x1027ab5c3 (/Volumes/data/b/build/slave/Mac_ASAN_64_Tests__1_/build/src/out/Release/browser_tests+0x1000025c3)
    #25 0xe
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV ??:0 ??
==6095==ABORTING

> Test Keeping NaCl plugins used in app background pages alive when active.
> 
> Activity in Native Client plugins results in IPC messages 
> sent to the BrowserPpapiHostImpl and routed to call 
> extensions::ProcessManager::KeepaliveImpulse. 
> 
> Testing patch, builds on implementation. See: 
> https://codereview.chromium.org/61063003/ Implementation.
> https://codereview.chromium.org/105873003/ Cumulative patch. 
> 
> Design doc: 
> https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# 
> 
> BUG=298339
> 
> Review URL: https://codereview.chromium.org/111563006

TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/118533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242120 0039d316-1c4b-4281-b951-d872f2087c98

Precisely, fixes up URL-like inputs before comparing to the shortcuts
fill_into_edit in order to better determine inlineability.

This is especially useful for inputs such as about: which need to have
their scheme fixed up to be recognized as comparable to chrome://
shortcuts.

BUG=328220

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242029

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/108643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242119 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242118 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164222:164231&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/118543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242117 0039d316-1c4b-4281-b951-d872f2087c98

Use a single ToplevelWindowEventHandler for the ash::Shell. This is part 1 in disabling the few cases in which dragging multiple windows is possible (which causes crashiness)

BUG=324038
TEST=None

Review URL: https://codereview.chromium.org/114643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242116 0039d316-1c4b-4281-b951-d872f2087c98

R=grt@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/113143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242115 0039d316-1c4b-4281-b951-d872f2087c98

R=grt@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/119733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242114 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves RevokeCredentialsOnServer and GetRequestContext from
ProfileOAuth2TokenService to MutableProfileOAuth2TokenService.

BUG=320625

Review URL: https://codereview.chromium.org/101633009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gn, ninja -C out/Default translate_common
R=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/117813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242112 0039d316-1c4b-4281-b951-d872f2087c98

It was added in r20038 when WebMediaPlayerImpl was made refcounted (!).

Review URL: https://codereview.chromium.org/115993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
R=nasko@chromium.org, yoz@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/105553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242110 0039d316-1c4b-4281-b951-d872f2087c98

A common problem is that if something goes wrong with Telemetry, the command
line file which points all network traffic at Web Page Replay can be left in
place which results in users not understanding why no pages will load.

So if we detect this setting, simply clear the file.

BUG=

Review URL: https://codereview.chromium.org/108573008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242109 0039d316-1c4b-4281-b951-d872f2087c98

When downloading a url, the state of the BackgroundDownloader must be
reset.

A better solution later on would be implementing a BitsFetcher that can
only do one download, similar to UrlFetcher. This avoids the situation
when dirty state post-download is carried over to a subsequent
download.

BUG=304354

Review URL: https://codereview.chromium.org/102993014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242108 0039d316-1c4b-4281-b951-d872f2087c98

Accidentally didn't check in the latest patch of this changeset.

> Omnibox: Bug Fixes for Shortcuts Inlining
> 
> Precisely, fixes up URL-like inputs before comparing to the shortcuts
> fill_into_edit in order to better determine inlineability.
> 
> This is especially useful for inputs such as about: which need to have
> their scheme fixed up to be recognized as comparable to chrome://
> shortcuts.
> 
> BUG=328220
> 
> Review URL: https://codereview.chromium.org/108643003

TBR=mpearson@chromium.org

Review URL: https://codereview.chromium.org/106573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/106793011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261628

Review URL: https://codereview.chromium.org/98643008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242100 0039d316-1c4b-4281-b951-d872f2087c98

This adds a new enum value to Policy.AssociationState, indicating that
the server side dropped the client from management. The association
state is now also surfaced in the Status line in about:policy.

BUG=chromium:329834

Review URL: https://codereview.chromium.org/117253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242099 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=329295

Review URL: https://codereview.chromium.org/113203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242096 0039d316-1c4b-4281-b951-d872f2087c98

The reasons for the move are:

- it's actually a blink embedder, so it can't use blink/wtf types
- it can't use base either
- we want to replace CppBoundClass with gin::Wrappable, not possible in blink

In the first step, this is mostly a 1:1 copy (except for include paths).
Follow-up CLs will move the test plugin and layout tests helpers and
clean up the coding style

BUG=324658
R=abarth@chromium.org, maruel@chromium.org, torne@chromium.org, jam@chromium.org
TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/110533009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
R=glider@chromium.org
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/105213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242093 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242092 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/107803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242091 0039d316-1c4b-4281-b951-d872f2087c98

DialServiceImpl now binds to all ipv4 interfaces instead of just the first ipv4 found. Dedup is done using address family + interface index.
It now also checks if there are any other open sockets when notifying observers on error and sends a different error code (DIAL_SERVICE_NO_INTERFACES instead of the usual DIAL_SERVICE_SOCKET_ERROR) if there are no other open sockets. The error codes are treated the same upstream currently. Later we should make sure DIAL_SERVICE_SOCKET_ERROR doesn't clear the device list.

Added unit tests for multiple interfaces and open sockets checking.

TEST=unit tests, did some manual testing at the lab.

Review URL: https://codereview.chromium.org/117853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242090 0039d316-1c4b-4281-b951-d872f2087c98