- 19 Dec, 2019 40 commits
-
-
Bruce Dawson authored
The feature flag that I added to control whether the Windows timer interval on DC power should be 4 ms or 8 ms had a race condition in that we might query the feature flag before the feature-flag system was configured. This change fixes that by adding the ReadMinTimerIntervalLowResMs function which is called after the feature system is initialized. While working on this I realized that ActivateHighResolutionTimer and EnableHighResolutionTimer were extremely subtle so I simplified them. When calling timeBeginPeriod you *must* eventually call timeEndPeriod to undo your request, and you must call it with exactly the same value. With the raised timer frequency now having three possible values (1, 4, or 8 ms) the logic was getting far too messy so I now do the simpler task of just recording the value passed to timeBeginPeriod and using it in timeEndPeriod. This is more obviously correct. The new rule is that timeBeginPeriod and timeEndPeriod should always be called with g_last_interval_requested as the parameter. I also tidied up and expanded on some comments - I always get confused by the purpose and semantics of ActivateHighResolutionTimer and EnableHighResolutionTimer. I tested with --disable-highres-timer, with and without --enable-features=SlowDCTimerInterruptsWin, using trace_timer_intervals.bat to confirm that all Chrome processes were lower the timer interrupt setting to 4 ms or 8 ms as requested. Bug: 1033108, 927165 Change-Id: I69b9253b456d7e3273ea1823a61c20926b0a4510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965846Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726561}
-
Dominic Mazzoni authored
Blink keeps track of a 32-bit integer DOMNodeId for every node in the DOM, when needed. This is already used for the content capture API and for DevTools. Add an option to include these IDs in an accessibility tree, too. Note that this has nothing to do with the ID attribute that an HTML element can have. This ID is for any node and it's internal to Blink. It's a bit confusing. This will be used in order to implement support for exporting tagged PDFs in http://crrev.com/c/1970742 Bug: 607777 Change-Id: I5a7838de4b2a74f86cb68cc9989491d3faf22ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970582 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#726560}
-
John Budorick authored
instead of pool:Chrome-GPU. Bug: 1011474 Change-Id: If024ceb3b14914636e762191576321c62a4b7673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976430Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726559}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a892219ced42..05934953bfd9 git log a892219ced42..05934953bfd9 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 ehmaldonado@google.com gclient: Make smoketests run on Windows. Created with: gclient setdep -r src/third_party/depot_tools@05934953bfd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1024683 Tbr: agable@chromium.org Change-Id: Ib126200ff9446ee5b99f2d937feea4afc2c7a888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976804Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726558}
-
Kent Tamura authored
It should handle only XML white spaces; #x20, #x9, #xD, and #xA. We incorrectly handled other white spaces such as U+3000. Bug: 893929 Change-Id: I59708f978ba1c23141f748de7a8f4c58d58c7acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974713 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#726557}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dougarnett@chromium.org Bug: 1023677 Change-Id: I947641610097a19e4c4f1db6c2eca32045869f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957492 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726556}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6d3c7f5526ec..750660e15c3c git log 6d3c7f5526ec..750660e15c3c --date=short --first-parent --format='%ad %ae %s' 2019-12-19 bclayton@google.com Kokoro: Add style presubmit checks Created with: gclient setdep -r src/third_party/swiftshader@750660e15c3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8a5df0f3e970b258e534ffcdf8ce26f1733a13bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976806Reviewed-by:
-
Markus Handell authored
This change fixes omitted propagation of changes in - ready state - enabled state - content hint state to encoded sinks. Bug: 1013590 Change-Id: I97f73bf2b2732b2411779ea7a0d7a56c2fccef57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970553 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#726554}
-
manukh authored
Previous version broke in python3 with the message: 'NameError: name 'unichr' is not defined'. Change-Id: Ia32f7a3b6e2848e72d29ca8126021febbd4389b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976828 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726553}
-
Michael Forney authored
This allows the builder to specify the path of the ninja binary in case they want to use a specific version, or an alternate implementation like samurai[0]. Also, when calling ninja, make sure build target comes after any options. [0] https://github.com/michaelforney/samurai Change-Id: I4295baa9e0e04e61ae092a9b86ea6ddc943b3c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975453Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Michael Forney <mforney@mforney.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#726552}
-
Rakib M. Hasan authored
Bug: 986447 Change-Id: I4b5989c23643defc10ce52a329f326cdaaf28ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975864 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#726551}
-
zhaoyangli authored
Added sync after some ChromeEarlGrey operations where a UI change in app might be triggered. This should eliminate undesirable racing conditions before UI change finishes at app. TabUsageRecorderTestCase is an example and this CL fixes it. Bug: 1034196, 1033879 Change-Id: Ib260414371b832eed517d8bf72b2ee0c10f5cfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970914 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726550}
-
Xiaoqian Dai authored
Turns out the bubble dialog native window is included in the MRU window list, which seems a bug - filed a separate bug for it crbug.com/1035998. The fix in this CL still makes sense though. Bug: 1034653 Change-Id: I079f2256631fdd39f7102a61bd81ea4a6e88a9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975086Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#726549}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=shivanisha@chromium.org Bug: 1023677 Change-Id: I5c0076283f6820c7f65d307a6f5280630093afc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957532 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726548}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/addc9bfc6cd1..1c9b1c07affb git log addc9bfc6cd1..1c9b1c07affb --date=short --first-parent --format='%ad %ae %s' 2019-12-19 thestig@chromium.org Fix bitmap size calculation in EmbedderTest::HashBitmap(). 2019-12-19 tsepez@chromium.org De-virtualize CFFL_FormFiller::GetFocusBox(). 2019-12-19 tsepez@chromium.org Remove unused argument from CFFL_FormFiller::WndtoPWL() and FFFLtoWND(). Created with: gclient setdep -r src/third_party/pdfium@1c9b1c07affb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iceb1f7a33f395f17bd210f8701a82b3f18940005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976805Reviewed-by:
-
manukh authored
- Replaced 'Building, Running, and Debugging' section - Previously, this section was incomplete and only described how to build chromium. - Added instructions to run and visually debug as well. - Updated build instructions to support debugging. - Simplified recommended CMakeLists.txt file - Simplified instructions for creating a desktop entry - Increased recommended VM option Xmx from 5g to 10g - Marked optional steps as optional - Punctuation fixes - Added link to clion.md to docs/README.md Change-Id: Id0514b1498517e0c10fafb1a9639aeda44717921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976280 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#726546}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=shivanisha@chromium.org Bug: 1023677 Change-Id: I4ecb846b64a36236013f36b7d16a663c134f3412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955082 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
rbpotter authored
Size comparison: Polymer 2: app.crisper.js: 142k app.vulcanized.html: 90k lazy_load.crisper.js: 30k lazy_load.vulcanized.html: 26k Total: 288k Polymer 3: history.rollup.js: 108k lazy_load.rollup.js: 55k shared.rollup.js: 125k Total: 288k Note that Polymer 2 version also pulls in 2 non-generated files (constants.*, around 2k) that are bundled in Polymer 3. Also compared load times, and found that the additional JS import of shared.rollup.js does not slow down page load; Polymer 3 version of the page appears to load 3-4% faster. Bug: 1022212 Change-Id: I0d32864436390b9226bd05abfb6af4cbbf40de5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975080Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#726544}
-
Peter Qiu authored
We're currently using GenericPendingReceiver::interface_name() when forwarding the bind request to the system connector, which is returning a reference string. However, the |interfae_name_| is resetted in GenericPendingReceiver::PassPipe(), which is invoked in the same bind request. This results in system connector getting corrupted interface name. So make a copy of the interface name, and use it for the bind request. Bug: 146448872 Test: Verify no crash when CastAudioOutputStream uses ServiceConnector to request MultiroomManager interface. Change-Id: Ia6987045e4c6ab39f46fe097fb98e6dfa5e00468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977023 Commit-Queue: Peter Qiu <zqiu@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726543}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=zmo@chromium.org Bug: 1023677 Change-Id: Idd0b624a2f277dab6dc1b900e315fc3d4966df1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954579 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726542}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=bsazonov@chromium.org Bug: 1023677 Change-Id: Id4f3e848e4d7dd6e30fad14238fcfa0313a29b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957497 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726541}
-
Albert Chaulk authored
Cropping with a SurfaceDrawQuad is done a little differently than with a texture quad, it need to be scaled up and positioned in the target space and then clipped using the clip_rect. Bug: b/143612326 Test: manually Change-Id: I38e78fd5ff4c60df2c44f9054136d8b27ac55ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972259Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#726540}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=pkotwicz@chromium.org Bug: 1023677 Change-Id: I1ad33980e6f5e05694ef1ec080049b5043078112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957544 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726539}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a509bcf2af35..5acad7aa14e2 Created with: gclient setdep -r src-internal@5acad7aa14e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0406d771ab807bf5b590dc8fd1dd995f1fc38dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976664Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726538}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0340c945..1ba8de1a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I12900322ec49bf86dcc9db3a8572dd7adb1e2a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976840Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726537}
-
Olivier Li authored
This test had brittle behavior that was hidden by the way HistoryService used to be coded. The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: I4f3bae453c93454eb8cecc6cd3046cfd07958bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976150 Auto-Submit: Oliver Li <olivierli@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726536}
-
Mikel Astiz authored
The API is refactored to isolate the flow for incoming encryption keys. This better separates the API from other functions that are intended to be used by actual UI (e.g. user-entered passphrases), and sets the foundation for triggering fetches initiated by the TrustedVaultClient implementation itself (useful on Android). There is a behavioral difference as a result of rewriting the logic in SyncServiceCrypto, which is arguably desirable: trusted vault keys are not propagated to the sync engine (and hence the Nigori keybag unless there is an actual need to do so, which excludes, most importantly, users that are not in the relevant passphrase type). Bug: 1012659 Change-Id: I009e02ebd0370eb98e95c50368299b0bf947cfb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973823 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#726535}
-
Joshua Peraza authored
b411976ca5f4 [log minidump] add tool to encode/decode minidump log 38f4bae3ad84 chromeos: fix minidump-dir-for-tests flag Change-Id: Ibd0d5fc15aa286951de9da2f3e923b45ad44fe13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976831 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#726534}
-
Amy Huang authored
Change-Id: I34125effba684908abb1a6983b641419d63242b6 Bug: 1035977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976019 Commit-Queue: Amy Huang <akhuang@google.com> Reviewed-by:
-
Etienne Bergeron authored
The glyph_spacing(...) is only valid for Obscured text. As an example, this cannot work with arabic characters. It will break words in piece. The concept is only used for password. Let rename to ObscuredGlyphSpacing to make it obvious it is only working when the text is obscured. Also removing the DCHECK failing when the text is not obscured. It is assumed now that the width is not used for un-obscured text. That DCHECK was often failing while fuzzing. TBR=tbarzic@chromium.org Bug: 1025561 Change-Id: I1700b4047bec9090d5c6719381923f14d9cd8e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976013 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726532}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mpearson@chromium.org Bug: 1023677 Change-Id: I8457197c508331469733229d84653115c9d77705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957559 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#726531}
-
minch authored
Separate the logic to add 'sign out', 'lock' and 'feedback' items to power button menu. This will help make the logic clear and easier to understand. The logic is based on current login status, do not show 'feedback' item while in login, lock screen or kiosk mode. We may have the plan to add 'feedback' to login and lock screen page. Add 'feedback' item to the menu in these two cases is not enough to support it, since the actual logic to send feedback is different while in login or lock screen. Tracked at crbug.com/1019743. Test: PowerButtonControllerTest* Bug: b/143769143 Change-Id: Id0d0327fc56bdd39c0d7f80b9313311e5f69837e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976435Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726530}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9dec123fec99..7b55aac3b366 git log 9dec123fec99..7b55aac3b366 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 gary.sweet@broadcom.com Add Broadcom as a known vendor Created with: gclient setdep -r src/third_party/angle@7b55aac3b366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I69501b9eed09cf98bb3cbcbdc32ee51ef6a61d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976660Reviewed-by:
-
Yulun Wu authored
Bug: 1035139 Change-Id: I606d940b5939382b94f1b7f068729f58f0e2e3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972788 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#726528}
-
yjliu authored
Because blur turns out to be very expensive and we'd like to detect and remove double background blur when unnecessary for ui when DCheck is on and the command line switch --log-on-ui-double-background-blur is on. The calculation is done in CalculateDrawProperties() when the screen space rects are available to avoid double calculation at ui side. TEST=manual with dcheck on Bug: 1030115 Change-Id: I8caca0fa536553ff50a8ae5657e0387e7008c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958586Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726527}
-
Mike Wittman authored
Records timestamps along with samples and plumbs them through to the ProfileBuilder interface. The CallStackProfileBuilder subclass will be updated in a following CL to record the timestamps, to support retrospective tagging of metadata on the samples. Bug: 1034758 Change-Id: Ic631d47773db5ce8ed5117c08aba5d5931cb7884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972931Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726526}
-
meacer authored
This CL adds a list of Ethiopic characters that look like Latin characters. A domain consisting only of these characters and not having .et or .er ccTLDs will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. This change doesn't affect any popular real world domain. Bug: 722167 Change-Id: I847e31d1d999a0ec8dafc699068797990636f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976822 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#726525}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a8352ccaae37..e6d31bd0894c git log a8352ccaae37..e6d31bd0894c --date=short --first-parent --format='%ad %ae %s' 2019-12-19 benjaminwagner@google.com [infra] Use unbuffered I/O for run_recipe 2019-12-19 reed@google.com extend imageshader updater to handle perspective 2019-12-19 jvanverth@google.com Tweak smallpaths so new paths will show up in GM. Created with: gclient setdep -r src/third_party/skia@e6d31bd0894c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ic86dc15fecf43e9f8058c4aae9cdb77645ba85d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976663Reviewed-by:
-
Tomasz Wiszkowski authored
Bug: 992024, 991039 Change-Id: I3359e20a67c5a40d10a704c92525e6c7a1cc9f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976799Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#726523}
-
Eric Stevenson authored
This reverts commit 4ede9b9f. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/7663 Original change's description: > Android: Clean up trichrome synchronized proguard build rules. > > * Remove static_library_proguard_disabled and instead separate > static_library_provider and static_library_synchronized_proguard > into separate flags. > * Only enable synchronized proguard for the most basic Trichrome > targets (can enable for others when we want to ship). > * Add a real dep on static library provider APKs (so that they don't > both need to be compiled explicitly). > * Clean up stale GN variables. > > Bug: 921284, 901465 > Change-Id: I346fe3e824ece041cd1df064e81b2939e64c6882 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955802 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726483} TBR=torne@chromium.org,cjgrant@chromium.org,agrieve@chromium.org,estevenson@chromium.org Change-Id: Ic3aaba93577e7f6b7bd92bc21bc72782cc4f981c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921284, 901465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977063Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726522}
-
