- 01 Aug, 2017 40 commits
-
-
Jan Krcal authored
The test is flaky on Win7 dbg buildbot. TBR=jkrcal@chromium.org, sammc@chromium.org Bug: 751081 Change-Id: Iaada8582830ebdade9f004bbf572ffed3cb3eed7 Reviewed-on: https://chromium-review.googlesource.com/595631Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#490985}
-
Rune Lillesveen authored
Style sharing code is removed and these stats will always be 0. Bug: 721517 Change-Id: Iae76778bd564ad22645d3d14709c1d8d13d796c6 Reviewed-on: https://chromium-review.googlesource.com/595744Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#490984}
-
Randall Raymond authored
This new class is used to find and validate the payment apps that can handle a a set of url payment method identifiers. In the short term, iOS will be working under the assumption that there is only one payment app that can handle a specified payment method. This however will change in the long run to match Android/Desktop implementations such that any number of payment apps can handle a payment method identifier as specified by payment method manifest. Most of the unittests and parsing are based off of the parsing code originally written here: https://cs.chromium.org/chromium/src/components/payments/content/utility/payment_manifest_parser.cc?rcl=6a53ba2305e2d0196d8f46f8590e0ad1fa45d636 This is another component of this CL that for the short term works fine but in the long term will need to be refactored to avoid code duplication. Bug: 748556 Change-Id: Ib0ce3be91830555cb9a3e1fc919d98b6ad9898f4 Reviewed-on: https://chromium-review.googlesource.com/582494Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Randall Raymond <rayraymond@google.com> Cr-Commit-Position: refs/heads/master@{#490983}
-
James Cook authored
The button is only shown when enabled by enterprise policy prefs, which are observed in chrome in SystemTrayDelegateChromeOS. For go/mustash this code cannot directly call into ash because it runs in a different process. Migrate the prefs observation into ash. Add unit tests for LogoutButtonTray. Remove some unused pref declarations and fix some USE_AURA vs. OS_CHROMEOS confusion. Bug: 747019 Test: ash_unittests Change-Id: Ifae5fedd163d0f3f9913369538856f13ba37c332 Reviewed-on: https://chromium-review.googlesource.com/590154Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#490982}
-
Dominik Röttsches authored
Preparation for updating font-style to behave as in CSS Fonts Level 4 [1]. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Bug: 739139 Change-Id: Ia65d84b19d44e15dd8ac9faa194526246434b73d Reviewed-on: https://chromium-review.googlesource.com/579429Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#490981}
-
Oleg Maximenko authored
R=haraken@chromium.org, tkent@chromium.org object but pointer to regular field of PluginData. This caused failing check in HeapObjectHeader::CheckHeader() in debug. PluginListBuilder: :results_ of type Member<...> was assigned not heap Change-Id: Ia5beab6944ebdd0f8251fe86a9670387b7cac59e Reviewed-on: https://chromium-review.googlesource.com/579053Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#490980}
-
Peng Huang authored
In mus, the local surface id is allocated during resize an aura::Window. So we need resize the host_window() first before submitting a frame to it. Otherwise, exo may submit a frame with an invalid local surace id. Bug: None Change-Id: Ie756744073bd4bfb445ae3f596b11257aa85ae9f Reviewed-on: https://chromium-review.googlesource.com/594550Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#490979}
-
Andy Paicu authored
This patch adds functionality to parse the `report-to` csp directive It does not actually do any reporting It does not update the content layer csp version Spec: https://wicg.github.io/reporting/ Bug: 726634 Change-Id: I31546a56a18504684fc292ce76973ae6fab50fec Reviewed-on: https://chromium-review.googlesource.com/563210 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#490978}
-
gaschler authored
Correct traffic annotation that was copied from JsonRequest but not updated. Bug: n/a Change-Id: I9d48fe082467d635d7ec77b13eeadfc83ae27808 Reviewed-on: https://chromium-review.googlesource.com/593653 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#490977}
-
Jan Krcal authored
The tests cause a lot of flakes on Windows 7 dbg buildbot. TBR=horo@chromium.org, jkrcal@chromium.org, adithyas@chromium.org Bug: 443374 Change-Id: Id1145fcb274fc39b7672782ceb45224be0580daa Reviewed-on: https://chromium-review.googlesource.com/595688Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#490976}
-
Mike Case authored
Change-Id: Idf2fe1f593133c4ee2f105fb794afc6fa05bae0d Reviewed-on: https://chromium-review.googlesource.com/592549Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Michael Case <mikecase@chromium.org> Cr-Commit-Position: refs/heads/master@{#490975}
-
gambard authored
Long press on the omnibox should not trigger a context menu, regardless of a possible content below it. Bug: 750646 Change-Id: I762dbc144142775636d8fc4818bd225e12dc9c5e Reviewed-on: https://chromium-review.googlesource.com/595628Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490974}
-
Jan Krcal authored
This reverts commit 59784d15. Reason for revert: it breaks compilation (linking of v8_context_snapshot_generator), see https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/19741 Original change's description: > (Reland)[Bindings] Create and use V8 context snapshots. > > This CL does two things. > > 1. In compile time, creates a snapshot file, which consists of V8 contexts. > 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext(). > > We expect this speeds up context creation for 3 times faster on Android. > Detailed information is described in the design doc [1]. > > > [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30 > > > This CL is a re-land of https://codereview.chromium.org/2841443005 (and the 1st patch is same with it) > Test expectations are changed due to http://crbug.com/705364 > > BUG=588893, 617892, 705364 > TBR=rkc, jochen, dchen, kinuko, eroman, thakis > > Change-Id: If85e68a6498f7d35a0c59f4af9323ba72fc36d5f > Reviewed-on: https://chromium-review.googlesource.com/594608 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490955} TBR=rkc@chromium.org,dcheng@chromium.org,peria@chromium.org,kinuko@chromium.org,thakis@chromium.org,eroman@chromium.org,yukishiino@chromium.org,haraken@chromium.org,jochen@chromium.org Change-Id: I67f166ae37b2103100c066334586a3b49a3a21e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 588893, 617892, 705364 Reviewed-on: https://chromium-review.googlesource.com/596087Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#490973}
-
Takeshi Yoshino authored
- Remove an unused include - Access root_ directly than via Root() Bug: Change-Id: I2b9abe974dd7c3bcfc4921a1bd86833dc0b2efe4 Reviewed-on: https://chromium-review.googlesource.com/586212 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#490972}
-
Emilio Cobos Álvarez authored
Not doing it results in incorrect behavior when there are multiple adjacent text nodes, either script-generated ones or because of display: contents. BUG=746437,657748 Change-Id: If5aa9209d16d5532629a0f0e2f1730d18a193ebf Reviewed-on: https://chromium-review.googlesource.com/575982Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Emilio Cobos Álvarez <ecobos@igalia.com> Cr-Commit-Position: refs/heads/master@{#490971}
-
Julian Pastarmov authored
The value could change during startup when delivered through policy but the backend can not be switched on the fly. So make sure the first seen value is preserved. BUG=736408 Change-Id: Ie608e9735b6009df3cd7070338412bd5b83376f4 Reviewed-on: https://chromium-review.googlesource.com/586688Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#490970}
-
Koji Ishii authored
Change-Id: I8a26eda72944a0c4d043275ffcde814bb6630f4c Reviewed-on: https://chromium-review.googlesource.com/594757Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490969}
-
Andrew Grieve authored
Deletes google_play_services_library GN variable. This should reduce compile times a bit, but mostly is just a good idea in general. Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f Reviewed-on: https://chromium-review.googlesource.com/585450 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Michael Case <mikecase@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490968}
-
gaschler authored
Add FakeContextualSuggestionsFetcher, MockFetchContextualSuggestionsCallback and a unittest for ContextualSuggestionsSource suggestion fetching. Bug: 749988 Change-Id: I958744e74fa54204d5dd764da49fc2ca45d6b9b3 Reviewed-on: https://chromium-review.googlesource.com/593656 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490967}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ab3909796cf2..de7c9620c374 $ git log ab3909796..de7c9620c --date=short --no-merges --format='%ad %ae %s' 2017-08-01 art-snake Prevent use of null pFileRead in CPDF_DataAvail. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifbf8ecee9c19109874bb2d0758e547bd4195f9f2 Reviewed-on: https://chromium-review.googlesource.com/595867 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490966}
-
Roman Sorokin authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/542963a5cdc8..3eac6aef29eb $ git log 542963a5c..3eac6aef2 --date=short --no-merges --format='%ad %ae %s' 2017-06-29 ljusten authpolicy: Add proto for Kerberos files Created with: roll-dep src/third_party/cros_system_api Bug: 737960 Change-Id: I84ac71002f0427e01e8a4f576dc8536237d1b330 Reviewed-on: https://chromium-review.googlesource.com/594050 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490965}
-
Raphael Kubo da Costa authored
Using wpt-import in Chromium 208c0175. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dom-dev@chromium.org: external/wpt/html domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams TBR=qyearsley@chromium.org No-Export: true Change-Id: I946fd58c943f2535ecbb3229ac94ab8563e38fd9 Reviewed-on: https://chromium-review.googlesource.com/595648 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#490964}
-
Vitalii Iarko authored
Previously, the suggestions were sorted by score. However, pushed suggestions must stay on top independetly of their score. This CL stores suggestion order in the database by recording suggestion position as its rank and then sorting by rank. Score is used as a fallback. Bug: 750100 Change-Id: Ic799f9a2e72d79908435b48185f7c6d74fa2d297 Reviewed-on: https://chromium-review.googlesource.com/593318 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#490963}
-
Patti authored
Site Details shows a 'Usage' section, which describes the amount of storage used by a website. Only show this when #enable-site-settings is on, since it's not in scope for the first version of Site Details. Manual test - With #enable-site-details on and #enable-site-settings off, navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fpermission.site. It should not show the 'Usage' heading, nor the 'Permissions' heading. With both flags on, navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fpermission.site and verify 'Usage' and 'Permissions' headings are both there, most likely with 'No usage data' under 'Usage'. Then navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fwww.google.com and again verify both headings are there, probably with a non-zero storage number under 'Usage'. Bug: 656758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2a5dd7de7fcd6f4c3270dce2bb51e22ab6e1cec0 Reviewed-on: https://chromium-review.googlesource.com/587516 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#490962}
-
Xida Chen authored
Right now in ScrollingCoordinator::SetTouchEventTargetRects, we always send TouchAction::kTouchActionNone when we pass the rect to cc. This CL change the kTouchActionNone to the real value associated with that rect. TBR=flackr@chromium.org Bug: 716668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I92c450fac165c59ba01ae1ef9f037c3001d56403 Reviewed-on: https://chromium-review.googlesource.com/581907 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490961}
-
Xida Chen authored
In the current implementation of MailboxInfo, we keep a RefPtr to Canvas2DLayerBridge, and when the MailboxReleased function gets called, we do a self_ref to keep the Canvas2DLayerBridge alive. Now that the MailboxReleased function is called through a WTF::Bind to a WeakPtr of Canvas2DLayerBridge, we don't need the self_ref anymore. Also, we can remove the mailboxes_ that is kept in this class, we just need to remove the associated resources. Bug: None Change-Id: I7f087a23a7fca32272d0ad05efb66f92d9eabba8 Reviewed-on: https://chromium-review.googlesource.com/579690 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#490960}
-
Hajime Hoshi authored
The test is now timed out on the flakiness dashboard because idle tasks are never called on tests until testRunner.runIdleTasks explcitly (crbug.com/595152). This doesn't leak now. This CL also fixes a comment regarding crbug.com/726218. Bug: 595152, 662477 Change-Id: I757bd5e72063933b28d92dc69cb4a3e42e9e4c56 Reviewed-on: https://chromium-review.googlesource.com/595792Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#490959}
-
Rune Lillesveen authored
After style sharing code was removed, this mode is no longer in use. Bug: 721517 Change-Id: Ia0997792f5641b722d86922f40d631613552c137 Reviewed-on: https://chromium-review.googlesource.com/595728Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#490958}
-
Yutaka Hirano authored
Supporting <link rel="preload" as="fetch" crossorigin> was considered to be hard because we have two CORS handling logic. CORS for preload is checked in ResourceLoader and CORS for xhr is checked in DocumentThreadableLoader. Resource::CanReuse is a function that determines whether we can reuse a resource for a request, and it returns false in such a case. On the other hand, it should be safe to run the CORS check twice. If the CORS check for the existing resource is run in ResourceLoader, we can reuse it for an XHR request. This CL changes Resource::CanReuse in that sense. Bug: 702845 Change-Id: Ifa5580c4465ff683e65455256266cbeeecde3d92 Reviewed-on: https://chromium-review.googlesource.com/582063 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#490957}
-
gambard authored
When rotating the device, the omnibox width should be set to the new width. This width computation needs to take into account the y offset of the collection and its new size. So the calculation needs to be started from the collection. Bug: 750637 Change-Id: I14dc8f878b815f7f32bd33f88691e9b39782e0d4 Reviewed-on: https://chromium-review.googlesource.com/595741Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490956}
-
Hitoshi Yoshida authored
This CL does two things. 1. In compile time, creates a snapshot file, which consists of V8 contexts. 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext(). We expect this speeds up context creation for 3 times faster on Android. Detailed information is described in the design doc [1]. [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30 This CL is a re-land of https://codereview.chromium.org/2841443005 (and the 1st patch is same with it) Test expectations are changed due to http://crbug.com/705364 BUG=588893, 617892, 705364 TBR=rkc, jochen, dchen, kinuko, eroman, thakis Change-Id: If85e68a6498f7d35a0c59f4af9323ba72fc36d5f Reviewed-on: https://chromium-review.googlesource.com/594608Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#490955}
-
Marc Treib authored
It's not always safe to use cached data for the OneGoogleBar. For now, always wait for the network request to come back before serving the OGB. This is similar to the behavior of the remote NTP. This also allows us to simplify the observer interface a bit. Note that if the network request fails due to a transient error, the cached data is still used. Bug: 742937 Change-Id: Iadd2e72bfe06265d006629719c4792b2aefd15ec Reviewed-on: https://chromium-review.googlesource.com/593909Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#490954}
-
stkhapugin@chromium.org authored
Create OminboxPopupViewSuggestionsDelegate to abstract out OmniboxViewIOS API from OmniboxPopupViewIOS. PopupView now does not directly receive a pointer to OmniboxView, getting a browser state and a delegate instead. OmniboxViewIOS implements the delegate methods. Bug: Change-Id: I42bf3a2ca0d88f1215181981a3f66d8089be385a Reviewed-on: https://chromium-review.googlesource.com/579727 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#490953}
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: I4fcee351c4fe8f639ad7c65abc83563f3afb13df Reviewed-on: https://chromium-review.googlesource.com/590394 Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#490952}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b50fdbf..1e8730d2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Icd290ff0834593d1714f2a6bdabb49d482770f3d Reviewed-on: https://chromium-review.googlesource.com/595847Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#490951}
-
Jérôme Lebel authored
The struct returned by protocol_copyMethodDescriptionList() should be freed after being used. Bug introduced with crrev.com/2785153002 Bug: 751066 Change-Id: I869ddfb4e6e3d9a489fa756ed48074a3f63175d8 Reviewed-on: https://chromium-review.googlesource.com/595739Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#490950}
-
Dominik Röttsches authored
At the same time change computed style to a number type according to CSS Fonts Level 4 [1]. [1] https://drafts.csswg.org/css-fonts-4/#font-stretch-prop Bug: 739139 Change-Id: I30db184559e7f047efcca999ae1b63aaa18b5eab Reviewed-on: https://chromium-review.googlesource.com/574590 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#490949}
-
Takeshi Yoshino authored
WebDataSource is an interface to expose DocumentLoader to outside of Blink together with ExtraData. Naming this class WebDocumentLoader makes it easier to understand correspondence between this interface and DocumentLoader. This patch also - adds Get.* prefix to the getters using this opportunity. - just removes unused includes and forward declarations from some files Bug: Change-Id: I6c9c0e49b4eeac94cae349439f85c3163d35f04a Reviewed-on: https://chromium-review.googlesource.com/590840 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#490948}
-
Helen Li authored
Bug: 730036 Change-Id: I2f7f64619276df1ab75c2514507dd6c0581dc045 Reviewed-on: https://chromium-review.googlesource.com/590413Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#490947}
-
Helen Li authored
This CL converts DCHECKs to CHECKs to see if |active_jobs_| and |job_requests_map_| can go out of sync. If that's the case, OnJobComplete() can be called when there's no longer a server_id entry in |job_requests_map_| and |requests_iter| is invalid in OnJobComplete(). Bug: 750271 Change-Id: I06fde6921668acb33456c2f65e102136ef0aae10 Reviewed-on: https://chromium-review.googlesource.com/594189Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#490946}
-