GitLab

Sort kill_simulators and fix comments.
Add new owners to ios/build/bots/scripts.

Followup to https://chromium-review.googlesource.com/c/596669.

Bug: 684305
Change-Id: I36b552f47e205d032d35781fe8af1736a73efa5b
Reviewed-on: https://chromium-review.googlesource.com/599046Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: smut <smut@google.com>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491720}

The fix of LAP context is under preparation at
https://chromium-review.googlesource.com/c/563152 .

Some of layout tests will be broken when the LAP context gets fixed
(actually, they're wrong).  So, this CL fixes those tests before
the fix.

Other LAP-related (broken) tests will be disabled while landing the
fix and later will be updated using the correct context.

Bug: 6156
Change-Id: Iadb04d6326a6285fe6dbaef68de5e3e100bcc765
Reviewed-on: https://chromium-review.googlesource.com/597990Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491719}

Fix typo in background.persistent declaration in manifest. This might have
been an issue as its default value is true.

Bug: 750830
Change-Id: I8154bc72bc22bac613494c035951526dfdfcc770
Reviewed-on: https://chromium-review.googlesource.com/599907Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Julien Brianceau <jbriance@cisco.com>
Cr-Commit-Position: refs/heads/master@{#491718}

Javascript variable is declared and tested as "succeeded", but affected with a
typo ("suceeded").

Bug: 750830
Change-Id: Ia3bb9e4c7488dac82410a3fea2c2496aae3b456f
Reviewed-on: https://chromium-review.googlesource.com/599808Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Julien Brianceau <jbriance@cisco.com>
Cr-Commit-Position: refs/heads/master@{#491717}

This CL also refactors how it works in the case when the
network service is disabled to go through the IOThread's
NetworkService.

Bug: 715695
Change-Id: I3df5126207df21065a42309b8e786f74dabae6cf
Reviewed-on: https://chromium-review.googlesource.com/594670Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491716}

This is a reland of 44e59041

Changes of original is replace |const SelectionForUndo&| to 
|const SelectionForUndo| at end of DeleteKeyPressed() and
ForwardDeleteKeyPressed() as work around of clang's bug which
doesn't handle extent of |const T&| as end of scope.

Original change's description:
> Introduce SelectionForUndoStep
> 
> This patch introduces |SelectionForUndoStep| to hold selection for undo/redo
> instead of |VisibleSelection| and avoid dirty |VisibleSelection|[1] for
> improving code health.
> 
> Before this patch, we hold selection as |VisibleSelection| in |UndoStep| and
> recompute "visible selection" by |CorrectedSelectionAfterCommand()| at undo/redo
> time, DOM tree can be different when we save |VisibleSelection| in |UndoStep|.
> 
> After this patch, we use |SelectionForUndoStep| to hold selection at command
> execution and change |EndingVisibleSelection()| to compute visible selection
> before we used.
> 
> This patch looks large, but most of them are replacing
> |EndingVisibleSelection()| to |EndingSelection()| to use |SelectionInUndoStep|
> instead of updated |VisibleSelection|.
> 
> Essential part of this change is
>  * "CompositeEditCommand.{cpp,h}": holding starting and ending selection in
>    |SelectionInUndoStep|
> 
>  * "TypginCommand.{cpp,h}": Computing |SelectionInUndoStep| other than
>    |FrameSelection|.
>  * "SelectionInUndoStep.{cpp.h}": The implementation
>  * "UndoStep.{cpp,h}": holding staring and ending seleciton in
>  |SelectionInUndoStep|
> 
> Just for reference, there is another attempt in the patch:
> - http://crrev.com/2457523004: Introduce SelectionForUndoStep
> - http://crrev.com/c/582724 Introduce SelectionForUndoStep
> 
> [1] Dirty VisibleSelection: |VisibleSelection| holds canonicalized base and
> extent positions by using layout tree. Once layout tree is updated, e.g. by
> DOM change or style change, |VisibleSelection| may not be canonicalized. In
> other words, once we get |VisibleSelection|, it is valid only until layout tree
> updated.
> 
> Bug: 747795
> Change-Id: I2da864e03fbd2e06f5150072eafe133430dcbfcb
> Reviewed-on: https://chromium-review.googlesource.com/588874
> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491667}


TBR=xiaochengh@chromium.org

Bug: 747795, 752013
Change-Id: I3135599416fea2af25aeba1ce76348dbf3b36628
Reviewed-on: https://chromium-review.googlesource.com/600007Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491715}

This simplifies working out which frame a document belongs to when
processing the scanphot.

Bug: 
Change-Id: Ice1b02fab606c7ccd57154a195b509c35c4cce50
Reviewed-on: https://chromium-review.googlesource.com/597691
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491714}

https://skia.googlesource.com/skia.git/+log/fba26ea9b7fc..ae532f68a035

$ git log fba26ea9b..ae532f68a --date=short --no-merges --format='%ad %ae %s'
2017-08-02 benjaminwagner Add Win10 QuadroP400 bots.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Iea385fb13333f0027ebe1c9e7e05bd07e6c2d6fd
Reviewed-on: https://chromium-review.googlesource.com/600087Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491713}

Bug: 
Change-Id: Ie06a13d99cd0b7f5112201e64e1d7774dd0700ad
Reviewed-on: https://chromium-review.googlesource.com/600054Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491712}

NOTRY=true
TBR=lunalu, horo, stgao, guidou

Bug: 
Change-Id: Id30e0adf8d32524c819025037605f4b0adec6354
Reviewed-on: https://chromium-review.googlesource.com/600190Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491711}

crrev.com/f8d10a08 added metrics for measuring EQT accuracy, but
did so incorrectly for the type of analysis we need to perform.

Previously, we reported queueing time with various threshold on expected
queueing time. However, in order to compute the error in estimating queueing
time based on expected queueing time, we need to instead report expected
queueing time with various thresholds on queueing time.

We plan to use the expected queueing time metric to estimate renderer
main thread responsiveness from the renderer compositor. If the
renderer main thread is unresponsive, we'll then avoid blocking scroll
on input.

This patch measures how good the expected queueing time metric is
at predicting main thread responsiveness.

See the document here for details:
https://docs.google.com/document/d/1R4AMGyo1vyrfeCofqVSb06RqPExuRddVFDJdONenwt0/edit#heading=h.uamzit3mgd7h

Bug: 599609
Change-Id: Ib594933a24711aac9f158293bdece81eaf301c51
Reviewed-on: https://chromium-review.googlesource.com/598112Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491710}

DeferredGpuCommandService is created before gpu driver bug list is loaded,
so GpuDriverBugWorkarounds of DeferredGpuCommandService is empty in WebView.
In order to fix the bug, Delay creating DeferredGpuCommandService until
gpu driver bug list is loaded.

Change-Id: Ie594ad326cb1b3e6970efc007cfd6dfc4a826ebb
Reviewed-on: https://chromium-review.googlesource.com/597375
Commit-Queue: Bo Liu <boliu@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491709}

This flag was already present in chrome, but it was ignored in headless.
This commit makes headless behave as expected.

R=eseckler@chromium.org, rvera@chromium.org

Bug: 747953
Change-Id: I39084bbb289157d0162d9b3a6ebc72d436983dad
Reviewed-on: https://chromium-review.googlesource.com/598367
Commit-Queue: Roxana Pavelescu <pavelescu@google.com>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491708}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a7461e3..262f12e

$ git log a7461e3..262f12e --date=short --no-merges --format=%ad %ae %s
2017-08-03 mbonadei@webrtc.org Revert "Track recreation of DxgiTextureStaging"
2017-08-03 mbonadei@webrtc.org Revert "Add histogram for FallbackDesktopCapturerWrapper and BlankDetectorDesktopCapturerWrapper"
2017-08-02 zhihuang@webrtc.org Revert of Break peerconnection_jni.cc into multiple files, in "pc" directory. (patchset #6 id:100001 of https://codereview.webrtc.org/2992103002/ )
2017-08-02 braveyao@webrtc.org windowCapture: return 1x1 frame to minimized winodw on Linux.
2017-08-02 deadbeef@webrtc.org Break peerconnection_jni.cc into multiple files, in "pc" directory.
2017-08-02 deadbeef@webrtc.org Reject negative values for "b=AS".
2017-08-02 eladalon@webrtc.org Protected streams report RTP messages directly to the FlexFec streams
2017-08-02 magjed@webrtc.org Add denicija@ and kthelgason@ as owners of webrtc/sdk/objc
2017-08-02 eladalon@webrtc.org Make FlexfecReceiveStreamImpl::started_ into std::atomic<bool>
2017-08-02 eladalon@webrtc.org Add PacketRouterTest.Sanity_NoModuleRegistered_*
2017-08-02 eladalon@webrtc.org Don't use the Force(Demuxer), Luke.
2017-08-02 magjed@webrtc.org ObjC: Add implementationName for injectable codecs
2017-08-02 philipel@webrtc.org Don't clear newer packets from the video_coding::PacketBuffer when calling ClearTo.
2017-08-02 philipel@webrtc.org Revert of Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. (patchset #5 id:80001 of https://codereview.chromium.org/2993513002/ )
2017-08-02 philipel@webrtc.org Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame.
2017-08-02 asapersson@webrtc.org Remove ProcessParams struct.
2017-08-01 zijiehe@chromium.org Irrational check in the constructor of DesktopFrame: stride_ may be negative
2017-07-31 zijiehe@chromium.org Add new constructors for all DesktopFrame inheritances
2017-08-01 eladalon@webrtc.org Remove PacketRouterTest fixture
2017-08-01 magjed@webrtc.org ObjC: Fix quality scaling for injected encoders
2017-08-01 eladalon@webrtc.org Explicitly inform PacketRouter which RTP-RTCP modules are REMB-candidates
2017-08-01 alessiob@webrtc.org TestDataGenerators attempts to create missing input signal files. If the input file name matches the "<name>-<params>.wav" pattern and <name> is a valid signal creator name, then <params> is parsed and used to create a new signal which is written in place of the missing file.
2017-08-01 brandtr@webrtc.org Enable large-scale FEC tests on iOS.
2017-08-01 alessiob@webrtc.org This CL is a refactoring of the APM QA tool; it includes the following changes: - render stream support, required to assess AEC; - echo path simulation and input mixer, to generate echo and add it to the speech signal; - export engine: improved UI, switch to Pandas DataFrames; - minor design improvements and needed adaptions.
2017-08-01 danilchap@webrtc.org Remove NullReceiveStatistics rtcp_sender accepts nullptr as indication statistics shouldn't be used, Other uses of NullReceiveStatistcs were already deleted.
2017-08-01 gnish@webrtc.org Added implementations for entering/exiting STARTUP, DRAIN, PROBE_BW, PROBE_RTT modes, also updated MaxBandwidthFilter class, with the filter implementation which stores three best estimates for the filter window.
2017-07-31 perkj@webrtc.org Reland of Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on wt Added documentation of thread expectations for video tracks and sources to the API.
2017-07-30 yujo@chromium.org Fix incorrect memset on muted frames.
2017-07-31 zijiehe@chromium.org Track recreation of DxgiTextureStaging
2017-07-28 zijiehe@chromium.org Do not reset resolution_tracker_ in DxgiFrame::PrepareFrame()
2017-07-28 zijiehe@chromium.org Remove resolution_tracker_ from dxgi_texture
2017-07-31 kwiberg@webrtc.org G711 implementation of the Audio{En,De}coderFactoryTemplate APIs
2017-07-31 magjed@webrtc.org ObjC RTCEAGLVideoVideo: Check GL context is non-nil in constructor
2017-07-31 terelius@webrtc.org Add probing to recover faster from large bitrate drops. A single probe at 85% of the original bitrate is sent when transitioning from underusing back to normal state. The actual sending of the probes is disabled by default, and enabled by the field trial string WebRTC-BweRapidRecoveryExperiment/Enabled/. Existing code that did probing after large drops in ALR have been restructured so that it also delays the probe until we are no longer overusing.
2017-07-31 magjed@webrtc.org ObjC style fix for injectable video codecs
2017-07-27 zijiehe@chromium.org Update ResolutionChangeDetector to make it match common practices
2017-07-28 eladalon@webrtc.org Only one implementation of MockRtpPacketSink once
2017-07-28 danilchap@webrtc.org Simplify FakeReceiveStatistics in video send stream tests
2017-07-28 ehmaldonado@webrtc.org Make RTCStatsReport::ToString() return JSON-parseable string.
2017-07-28 sakal@webrtc.org Move matrix from VideoFrame to TextureBuffer.
2017-07-28 tschumim@webrtc.org Removed an obsolete DCHECK in AudioEncoderOpus.
2017-07-28 eladalon@webrtc.org Remove DCHECK from Call's ctor that could never fail
2017-07-27 deadbeef@webrtc.org If adapter type is unknown and interface name is "ipsec", treat as VPN.
2017-07-27 jbauch@webrtc.org Remove libsrtp 2.0.0 compatibility code.
2017-07-27 minyue@webrtc.org Turning on Opus 120ms frame length switch.
2017-07-27 deadbeef@webrtc.org Adding Android binding for RTCConfiguration::max_ipv6_networks.
2017-07-27 sakal@webrtc.org Fix a crash in PeerConnectionFactory.SetVideoHwAccelerationOptions.
2017-07-27 sakal@webrtc.org Add a comment that RTCAVFoundationVideoSource is deprecated.
2017-07-27 minyue@webrtc.org Adding missing resources to audio_codec_speed_tests.
2017-07-27 danilchap@webrtc.org Take smaller interface for RtpRtcp::Configuration::receive_statistics
2017-07-27 philipel@webrtc.org Revert of Disable SeqNumUnwrapper death tests to avoid breaking downstream builds. (patchset #1 id:1 of https://codereview.chromium.org/2985083002/ )
2017-07-26 minyue@webrtc.org Renable some Opus tests after Opus 1.2.1 update.
2017-07-26 zijiehe@chromium.org Do not crop DesktopFrame if the size won't change
2017-07-26 deadbeef@webrtc.org Adding Obj-C binding for RTCConfiguration::max_ipv6_networks.
2017-07-26 zijiehe@chromium.org Add histogram for FallbackDesktopCapturerWrapper and BlankDetectorDesktopCapturerWrapper
2017-07-26 deadbeef@webrtc.org Add "max_ipv6_networks" field to RTCConfiguration.
2017-07-26 deadbeef@webrtc.org Relanding: Move "max IPv6 networks" logic to BasicPortAllocator, and fix sorting.
2017-07-26 jbudorick@chromium.org Add gn dependency between ana_debug_dump_proto and ana_config_proto.
2017-07-24 zijiehe@chromium.org Return translated position in MouseCursorMonitor
2017-07-26 deadbeef@webrtc.org Fix issues with NetworkMonitor singleton when used by multiple clients.
2017-07-26 philipel@webrtc.org Disable SeqNumUnwrapper death tests to avoid breaking downstream builds.
2017-07-26 philipel@webrtc.org Implemented a new sequence number unwrapper in sequence_number_util.h.
2017-07-26 minyue@webrtc.org Reland "Allow AudioSendStream to reconfig AudioNetworkAdaptor"
2017-07-26 minyue@webrtc.org Revert "Allow AudioSendStream to reconfig AudioNetworkAdaptor"
2017-07-25 minyue@webrtc.org Allow AudioSendStream to reconfig AudioNetworkAdaptor
2017-07-26 eladalon@webrtc.org Make ~webrtc::AudioSendStream public, and s/config()/GetConfig(), as well as make public.
2017-07-25 gyzhou@chromium.org Update native plugin dll for turn servers and video.
2017-07-25 jtteh@webrtc.org Removed file RTCCameraVideoCapturer.mm that isn't needed Also added post commit review changes.
2017-07-25 peah@webrtc.org Avoid that previous settings in APM are overwritten by WebRtcVoiceEngine
2017-07-25 jamiewalch@chromium.org Add jamiewalch to OWNERS.
2017-07-25 jtteh@webrtc.org [iOS] Fix incorrectly oriented frames when rapidly switching between cameras.
2017-07-25 danilchap@webrtc.org Refactor composing report blocks for rtcp Sender/Receiver reports. Compose them while creating sr/rr instead of presaving in temporary member variable
2017-07-25 eladalon@webrtc.org Shrink critical-section scope in ReceiveStatisticsImpl::GetActiveStatisticians()
2017-07-25 danilchap@webrtc.org Add SetReportBlocks to rtcp Sender/Receive Report classes.
2017-07-25 kthelgason@webrtc.org Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ )
2017-07-25 danilchap@webrtc.org Remove deprecated RtpRtcp::SetAudioPacketSize was deprecated in https://codereview.webrtc.org/2545753002
2017-07-25 ilnik@webrtc.org Rename isolated_output to test_output and add a method to get the test_output directory.
2017-07-25 eladalon@webrtc.org Get rid of unnecessary cast of FlexfecReceiveStreamImpl to FlexfecReceiveStream
2017-07-25 ilnik@webrtc.org Report minimum PSNR in VideoQualityTest and save corresponding frame to file
2017-07-25 danilchap@webrtc.org Remove NullObjectReceiveStatistics() in rtp_rtcp module use (already supported) nullptr as indication for no statistics
2017-07-25 danilchap@webrtc.org Remove RtpRtcp::RemoteRTCPStat(RTCPSenderInfo*) as unused
2017-07-25 oprypin@webrtc.org Fix NSInteger formatting warning from clang 6
2017-07-24 korniltsev.anatoly@gmail.com When a track is added/removed directly to MediaStream notify observer->OnRenegotionNeeded
2017-07-24 ehmaldonado@webrtc.org Remove traces from {send,receive}_statistics_proxy.cc
2017-07-24 philipel@webrtc.org Throttle log message in FrameBuffer.
2017-07-24 danilchap@webrtc.org Remove setting configuration parameter to itself. when creating RtpRtcp module for video send stream.
2017-07-24 magjed@webrtc.org iOS AppRTCMobile: Close peerconnection when disconnecting
2017-07-24 aleloi@webrtc.org Integer overflow bug in low_cut_filter.
2017-07-24 flim@webrtc.org Disable some Opus tests pending an update
2017-07-24 korniltsev.anatoly@gmail.com Delete unused field from AndroidVideoTrackSource
2017-07-23 zijiehe@chromium.org Add zijiehe@chromium.org as OWNERS in WebRTC DesktopCapturer related logic
2017-07-21 zijiehe@chromium.org Create new constructors and fields to support a better mouse cursor monitor
2017-07-21 deadbeef@webrtc.org Revert of Move "max IPv6 networks" logic to BasicPortAllocator, and fix sorting. (patchset #2 id:20001 of https://codereview.webrtc.org/2983213002/ )
2017-07-21 steveanton@webrtc.org Use array declaration for extension URIs.
2017-07-21 deadbeef@webrtc.org Move "max IPv6 networks" logic to BasicPortAllocator, and fix sorting.
2017-07-21 steveanton@webrtc.org Add parsing/serializing for MID RTP header extension.
2017-07-21 henrika@webrtc.org Fixing lint issue
2017-07-21 henrika@webrtc.org Adds WebRtcAudioTrack.setAudioTrackUsageAttribute API
2017-07-21 henrika@webrtc.org Modifies closing of AudioTrack resource on Android
2017-07-21 sakal@webrtc.org Set target API to 18 for MediaCodecUtils.
2017-07-20 emadomara@webrtc.org Add common TLS extensions
2017-07-20 zstein@webrtc.org Move total audio energy and duration tracking to AudioLevel and protect with existing critial section.
2017-07-20 terelius@webrtc.org Print general usage information for event_log_analyzer
2017-07-19 minyue@webrtc.org Correct the calculation of discard rate.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Bug: 
Change-Id: I1f7ba0c5b531fd20041c6391eb07be9c40ce19e4
Reviewed-on: https://chromium-review.googlesource.com/599869Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491707}

BUG=740099

Change-Id: I14bd58d22bc5cfbadd0428836bc2a01dd45e121a
Reviewed-on: https://chromium-review.googlesource.com/593658Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491706}

As we confirmed the new oenership edges works correctly, let's remove
the logic to switch back to the old ownership edges

Bug: 604726
Change-Id: I16845d41a5aecd0d2e565157e88cf67eb9322d15
Reviewed-on: https://chromium-review.googlesource.com/593667Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491705}

Commit 87454345 ("[Owners Extractor] Fix
issues found in the actual run") added an assertion to the code to verify
that we are not passing a directory above LayoutTests/external to
find_and_extract_owners().

The assertion gets triggered with valid paths though; for example, changes
to LayoutTests/TestExpectations means //third_party/WebKit/LayoutTests gets
passed to the function, which aborts instead of just skipping that path.
This, in turn, broke our automatic web-platform-tests imports, as a recent
change there meant our scripts had to delete a test from TestExpectations.

For example:
https://luci-milo.appspot.com/buildbot/chromium.infra.cron/wpt-importer/415

leads to
Traceback (most recent call last):
  File "/mnt/data/b/rr/tmps9aWJe/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmps9aWJe/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 122, in main
    self._upload_cl()
  File "/mnt/data/b/rr/tmps9aWJe/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 385, in _upload_cl
    directory_owners = self.get_directory_owners()
  File "/mnt/data/b/rr/tmps9aWJe/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 409, in get_directory_owners
    return extractor.list_owners(changed_files)
  File "/mnt/data/b/rr/tmps9aWJe/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py", line 42, in list_owners
    owners_file, owners = self.find_and_extract_owners(self.filesystem.dirname(relpath))
  File "/mnt/data/b/rr/tmps9aWJe/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py", line 69, in find_and_extract_owners
    assert directory.startswith(external_root)
AssertionError

This change just turns the assertion into a check to unbreak the imports, a
better one that increases test coverage should probably be landed later.

TBR=qyearsley@chromium.org,robertma@chromium.org

Bug: 713987
Change-Id: I192f37bf10dad98bc32cf2ff15cefa09e440c4ee
Reviewed-on: https://chromium-review.googlesource.com/599908
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#491704}

headless_shell --determinstic-fetch was totally borked. This seem to fix it.

Bug: 714772
Change-Id: I4a6747a113cd999cb53fb1c1790761320a2b4035
Reviewed-on: https://chromium-review.googlesource.com/599947
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491703}

This reverts commit d95936bd.

Reason for revert: Breaks component_tests on some bots.
See:
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/14332

Original change's description:
> Move the task runner creation to password store from the factory.
> 
> In addition the CL changes some tests to use ScopedTaskEnvironment where appropriate instead of MessageLoop.
> 
> Bug: 741660
> Change-Id: I9993eaba6bd92e30dfe4a39a5fb89518d5ba4a3d
> Reviewed-on: https://chromium-review.googlesource.com/584908
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491693}

TBR=vasilii@chromium.org,cfroussios@chromium.org

Change-Id: I03224c0b0eeb33a18daa021046394d34062e242d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 741660
Reviewed-on: https://chromium-review.googlesource.com/599829Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491702}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/19f1033a..a14a5f4f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I07f9addf567ec03ec654a26d5302af9f777a8784
Reviewed-on: https://chromium-review.googlesource.com/599767Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491701}

Bug: 751180, 739458
Change-Id: Iceb120b6ddf94f9e032ad5e22d002a6ab44dbbd5
Reviewed-on: https://chromium-review.googlesource.com/598093
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491700}

Incorporate review feedback for font-stretch range parsing code
analogously for font-weight.

Bug: 749091
Change-Id: Ibd83d6e55fc2e025a57fc78fa1c8273eabc2445e
Reviewed-on: https://chromium-review.googlesource.com/599812Reviewed-by: Rune Lillesveen <rune@opera.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491699}

The section identifiers of the added sections part of ContentSuggestions
need to be reset when all the data concerning the added items is reset.

Bug: 752037
Change-Id: Ic37871e9f8f8bb3e43bc63af03a47d1756902fbe
Reviewed-on: https://chromium-review.googlesource.com/600048Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491698}

Allow ranges for font-stretch in @font-face, compare
https://drafts.csswg.org/css-fonts-4/#font-prop-desc

Bug: 749091
Change-Id: I79cafc1f7c496617bfb4eca21e28b4b451bdfae5
Reviewed-on: https://chromium-review.googlesource.com/582862
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491697}

This reverts commit 01f38b46.

Reason for revert: Sorry, this broke compilation on 3 bots:
- https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29
- https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29
- https://build.chromium.org/p/chromium.android/builders/Android%20MIPS%20Builder%20%28dbg%29

With the following linker error:

obj/ui/message_center/message_center/notification.o: In function `message_center::Notification::CreateSystemNotification(...)':
../../ui/message_center/notification.cc:182: undefined reference to `gfx::kNoneIcon'
obj/ui/message_center/message_center/notification.o: In function `message_center::Notification::CreateSystemNotification(...)':
../../ui/message_center/notification.cc:232: undefined reference to `gfx::CreateVectorIcon(gfx::VectorIcon const&, unsigned int)'


Original change's description:
> Add first-party notification styling in MD notification.
> 
> In new-style notification, first-party notification should have
> different styling compared to general web notifications.
> To do this, all system notifications should be created by
> new CreateSystemNotification. (Previously, it was not a requirement.)
> 
> By using the function,
> * the display source defaults to string "ChromeOS system".
> * the notification has single accent color based on
>   SystemNotificationWarningLevel.
> * gfx::VectorIcon will be passed as small_image instead of gfx::Image
>   to perform icon coloring on CreateSystemNotification side.
> 
> TEST=out/Debug/message_center_unittests
> BUG=738779,726241,740807,740813
> 
> Change-Id: I9e85b3f1de33b6499297f060b5305d0b02157eef
> Reviewed-on: https://chromium-review.googlesource.com/566765
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491592}

TBR=jamescook@chromium.org,yoshiki@chromium.org,peter@chromium.org,fukino@chromium.org,tetsui@chromium.org

Change-Id: I10fe30dbdad6012fbafe32c17a439065f4d816d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 738779, 726241, 740807, 740813
Reviewed-on: https://chromium-review.googlesource.com/600067Reviewed-by: John Mellor <johnme@chromium.org>
Commit-Queue: John Mellor <johnme@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491696}

This reverts commit 9869d2f1.

Reason for revert: Suspect of making console tests to fail consistently on WebKit Win7 (dbg) (stats) bot.

See
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10448


Unexpected Failures:
* http/tests/devtools/console/console-correct-suggestions.js
* virtual/mojo-loading/http/tests/devtools/console/console-correct-suggestions.js



Original change's description:
> DevTools: transform console tests (part 2)
> 
> F/u from https://chromium-review.googlesource.com/c/595238
> 
> Bug: 667560
> Change-Id: I4e387fae79ab4de0965f84a045c4fd04631b9e7d
> Reviewed-on: https://chromium-review.googlesource.com/597312
> Commit-Queue: Will Chen <chenwilliam@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491501}

TBR=dgozman@chromium.org,chenwilliam@chromium.org

Change-Id: Ib2d71bb01073eedd692d2416c688c2985b16b3c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 667560
Reviewed-on: https://chromium-review.googlesource.com/599828Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491695}

This flag was present in chrome, but ignored in headless.
This commit makes headless behave as expected.

R=eseckler@chromium.org

Bug: 714287
Change-Id: I2b06c345c1f29eb4390e7853537af9cf5d809bb8
Reviewed-on: https://chromium-review.googlesource.com/599809Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Luca Versari <veluca@google.com>
Cr-Commit-Position: refs/heads/master@{#491694}

In addition the CL changes some tests to use ScopedTaskEnvironment where appropriate instead of MessageLoop.

Bug: 741660
Change-Id: I9993eaba6bd92e30dfe4a39a5fb89518d5ba4a3d
Reviewed-on: https://chromium-review.googlesource.com/584908
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491693}

This is a reland of aecc33fc

Added test files for the bookmark appp. Without these tests fail in release
builds.


Original change's description:
> desktop-pwas: Open Bookmark app when link is within scope
> 
> The DesktopPWAWindowing feature must be on in order for this to work.
> 
> Makes it so that, once a user has installed a Bookmark App for a website, all
> navigations to that website will open the installed Bookmark App. This includes
> typing the address in the omnibox, clicking any links to an in-scope url, and
> opening any links to an in-scope url from the context menu. Future patches
> will change some of these so that the result is more intuitive.
> 
> For example, if the user has installed https://www.foo.com through
> "Add to shelf" and the site's manifest defines scope as "/scope" and then the
> user visits https://www.foo.com/scope/test.html, a new app window to
> https://www.foo.com/scope/test.html will open. If the user
> navigated to https://www.foo.com/index.html, we would not open a new app
> window since the address is not in-scope as defined by the site's manifest.
> 
> Three changes:
> 
> 1. Use 'scope' in the site's manifest to create a url handler for
>    the bookmark app.
> 2. Allow Hosted Apps that are Bookmark apps to use url handlers.
>    This means that any non-bookmark hosted app that has url handlers
>    will fail to load.
> 3. When handling a url that a Bookmark app could handle open the
>    the bookmark app with the specified url.
> 
> Bug: 740783
> Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0
> Reviewed-on: https://chromium-review.googlesource.com/566199
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Reviewed-by: Sky Malice <skym@chromium.org>
> Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491644}

TBR=benwells@chromium.org,mgiuca@chromium.org,skym@chromium.org,jochen@chromium.org

Bug: 740783
Change-Id: I6fe97df85507d1e5fbb209ea0877c4345a8e03ab
Reviewed-on: https://chromium-review.googlesource.com/599647
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491692}

While we are still compiling the report from the field trial, disable prerender
to be on the safer side in M61.

Bug: 678332, 735153, 520275
Change-Id: I30a2169533d30cbb85f53291223897caceddeb89
Reviewed-on: https://chromium-review.googlesource.com/584871
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491691}

Bug: 715998
Change-Id: I0066c9f3e87c2e3327ece2d1b357de1c4bd9c191
Reviewed-on: https://chromium-review.googlesource.com/595981
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491690}

When the user opens a Reading List page, it should not be taken into
account for the computation of the Most Visited tiles.

Bug: 734067
Change-Id: Iec28e8086051777ab4c43a2e53778c7bab3d54b1
Reviewed-on: https://chromium-review.googlesource.com/596367
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491689}

For marker property, CSSPropertyInvalid was used as the 
"current_shorthand" in the old/non-API parsing method 
because it's not used. In its API, we use 
CSSPropertyMarker just to avoid confusion.  There is no 
real difference.

Bug: 668012
Change-Id: I528f7da64d6dc6537a248e8b6a08b3940c0f3b90
Reviewed-on: https://chromium-review.googlesource.com/597092
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491688}

Follow up to https://chromium-review.googlesource.com/c/589927

Bug: 738881
Change-Id: I8234c93e7557fea982cf6f98fce45a5a6e2bf5c4
Reviewed-on: https://chromium-review.googlesource.com/593649
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491687}

Change-Id: If1e1ad4b48d3b97a209c8fe3727d885c64fdc8bd
Reviewed-on: https://chromium-review.googlesource.com/599136
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491686}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/43bd6d3f..19f1033a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ib0623cadd4349df94d0d1743d11c8e75df73a288
Reviewed-on: https://chromium-review.googlesource.com/599375Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491685}

Sorry, I reverted wrong cl.

BUG: 751948
TBR=bcwhite@chromium.org,holte@chromium.org,olivierrobin@chromium.org

This is a reland of 433d6917
Original change's description:
> Make MetricsLog not need a PrefService.
> 
> Move system profile persistence to MetricsService.
> 
> Bug: 
> Change-Id: I5c31dc53de267dd9699a83af926f8a575bab18a0
> Reviewed-on: https://chromium-review.googlesource.com/592689
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491573}

Change-Id: Iea3ebc29e92f3e12fc56f7b7ba767c531f216041
Reviewed-on: https://chromium-review.googlesource.com/598759
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491684}

This reverts commit 44e59041.

Reason for revert: Caused LayoutTest failures on ASAN bot.
BUG:752013

Original change's description:
> Introduce SelectionForUndoStep
> 
> This patch introduces |SelectionForUndoStep| to hold selection for undo/redo
> instead of |VisibleSelection| and avoid dirty |VisibleSelection|[1] for
> improving code health.
> 
> Before this patch, we hold selection as |VisibleSelection| in |UndoStep| and
> recompute "visible selection" by |CorrectedSelectionAfterCommand()| at undo/redo
> time, DOM tree can be different when we save |VisibleSelection| in |UndoStep|.
> 
> After this patch, we use |SelectionForUndoStep| to hold selection at command
> execution and change |EndingVisibleSelection()| to compute visible selection
> before we used.
> 
> This patch looks large, but most of them are replacing
> |EndingVisibleSelection()| to |EndingSelection()| to use |SelectionInUndoStep|
> instead of updated |VisibleSelection|.
> 
> Essential part of this change is
>  * "CompositeEditCommand.{cpp,h}": holding starting and ending selection in
>    |SelectionInUndoStep|
> 
>  * "TypginCommand.{cpp,h}": Computing |SelectionInUndoStep| other than
>    |FrameSelection|.
>  * "SelectionInUndoStep.{cpp.h}": The implementation
>  * "UndoStep.{cpp,h}": holding staring and ending seleciton in
>  |SelectionInUndoStep|
> 
> Just for reference, there is another attempt in the patch:
> - http://crrev.com/2457523004: Introduce SelectionForUndoStep
> - http://crrev.com/c/582724 Introduce SelectionForUndoStep
> 
> [1] Dirty VisibleSelection: |VisibleSelection| holds canonicalized base and
> extent positions by using layout tree. Once layout tree is updated, e.g. by
> DOM change or style change, |VisibleSelection| may not be canonicalized. In
> other words, once we get |VisibleSelection|, it is valid only until layout tree
> updated.
> 
> Bug: 747795
> Change-Id: I2da864e03fbd2e06f5150072eafe133430dcbfcb
> Reviewed-on: https://chromium-review.googlesource.com/588874
> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491667}

TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org

Change-Id: I84188673f225161fc65da6ad1693a1721d2d8f5a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 747795
Reviewed-on: https://chromium-review.googlesource.com/599667Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491683}

As the benchmark page_cycler_v2 is located under
src/tools/perf/contrib/cros_benchmarks, the patch fixes the failure
of deps searching for page_cycler_v2.typical_25 by adding the
benchmarks directory 'src/tools/perf/contrib' into search path.

BUG=728973
TEST=python src/tools/perf/fetch_benchmark_deps.py
  page_cycler_v2.typical_25 --platform=cros
Signed-off-by: Chung-yih Wang <cywang@chromium.org>
Change-Id: Id9e31488cba07bb433551b768ddaaa99e70a2b9d
Reviewed-on: https://chromium-review.googlesource.com/598127Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491682}

See "Print Is A Function".

Bug: 742592
Change-Id: Ic2744a01a4149a466dab9a7c1208d36238206008
Reviewed-on: https://chromium-review.googlesource.com/599567Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491681}