GitLab

The CL does the following:

1. Replace GuestViewManager::FromBrowserContext with GuestViewManager::CreateWithDelegate.
2. Rename GuestViewManager::FromBrowserContextIfAvailable to GuestViewManager::FromBrowserContxt.
3. Creates a GuestViewManagerDelegate interface and ExtensionsGuestViewManagerDelegate.
4. GuestViewManager is created with a particular delegate implementation.
5. GuestView permission checks and registration is moved to the ExtensionsGuestViewDelegate.
6. owner_extension_id() is renamed to owner_host().

After this patch the following classes can be moved to Components (once GuestViewEvent is decoupled from EventRouter):

1. GuestViewManager
2. GuestViewManagerDelegate
3. GuestViewBase
4. GuestViewMessageFilter
5. GuestView

BUG=444869
TBR=noms@chromium.org for chrome/browser/profiles, nkostylev@chromium.org chrome/browser/chromeos/login, thestig@chromium.org for chrome/browser/printing.

Review URL: https://codereview.chromium.org/1066563006

Cr-Commit-Position: refs/heads/master@{#326774}

Packed relative relocations do not currently participate in
relocation of shared RELRO pages into a service process's load
addresses.  This undermines RELRO sharing, by reducing the
number of swapped RELRO pages (often to zero).

Fix by processing packed relative relocations a second time when
relocating shared RELRO pages.  Also, tidy up and rationalize
some duplicated code through use of templates.

BUG=385553

Review URL: https://codereview.chromium.org/1099253002

Cr-Commit-Position: refs/heads/master@{#326773}

https://folio.googleplex.com/login-m44/Redlines

BUG=478449
TEST=manual

Review URL: https://codereview.chromium.org/1100623003

Cr-Commit-Position: refs/heads/master@{#326772}

Reland of https://codereview.chromium.org/1087133005/ (Add a WinHeap dump provider to the memory profiler.)

Reason for reland: A flaky test has been removed. (WinHeapDumpProviderTest.GetHeapInformation)

Add a WinHeap dump provider to the memory profiler.

TBR=nduca@chromium.org
BUG=466141

Review URL: https://codereview.chromium.org/1083003003

Cr-Commit-Position: refs/heads/master@{#326771}

Review URL: https://codereview.chromium.org/1104813003

Cr-Commit-Position: refs/heads/master@{#326770}

This CL adds extension icons in the install dialog as well as the "was installed" bubble.

Followup to https://codereview.chromium.org/855513002/

XIB changes in ExtensionInstallPromptBundle.xib:
* convert the "bundle items" NSTextField (filled with a multiline string) to an NSView (filled with dynamically created per-item subviews)
* add an NSImageView in the top right to hold the bundle item

XIB changes in ExtensionInstalledBubbleBundle.xib:
* convert the "installed" and "failed" NSTextFields (filled with multiline strings) to NSViews (filled with dynamically created per-item subviews)

BUG=448724

Review URL: https://codereview.chromium.org/816223008

Cr-Commit-Position: refs/heads/master@{#326769}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fa1e205..cb3d77a

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1093503005

Cr-Commit-Position: refs/heads/master@{#326768}

Inject PrefService, prefs::kNtpMostVisitedURLsBlacklist and
HistoryService through the constructor of TopSitesImpl.

Add public method TopSitesFactory::BuildTopSites() that can
be used by tests to avoid code duplication.

BUG=390953,479174

Review URL: https://codereview.chromium.org/1080403003

Cr-Commit-Position: refs/heads/master@{#326767}

R=jochen@chromium.org
TBR=kalman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1085733006

Cr-Commit-Position: refs/heads/master@{#326766}

Please take a look at my post here

https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/pIQjhkVl4cE

I am not sure about build/common.gypi
Please correct me if I am wrong.

PS:
This is just to start, there are more places to refactor.

BUG=

Review URL: https://codereview.chromium.org/1090213002

Cr-Commit-Position: refs/heads/master@{#326765}

Regarding the latest code on linux,
It was always setting by default language even if value of language was existed.
So we need to add routine for setting language via "spd_set_language".

BUG=289548

Review URL: https://codereview.chromium.org/1043933002

Cr-Commit-Position: refs/heads/master@{#326764}

BUG=429756

Review URL: https://codereview.chromium.org/1107583002

Cr-Commit-Position: refs/heads/master@{#326763}

This brings in the output streaming decode support.

BUG=472009

Review URL: https://codereview.chromium.org/1061993007

Cr-Commit-Position: refs/heads/master@{#326762}

Stats are updated and logged continuously when echo cancellation is enabled. Being enabled is no guarantee for actually running since it, for example, is enabled by default when opening the microphone.
All these invalid data clutter the UMA histogram.

The improvement is a check for the first frame containing an echo state before start logging. This can only happen when the echo cancellation is actually running.

BUG=450193

Review URL: https://codereview.chromium.org/1081063003

Cr-Commit-Position: refs/heads/master@{#326761}

This patch introduces the basic browser tests of download notification.

BUG=480489
TEST=run newly added browsertest

Review URL: https://codereview.chromium.org/1047243002

Cr-Commit-Position: refs/heads/master@{#326760}

Test that we're exposing the cursor position correctly
and that the value is replaced with bullets.

Depends on: https://codereview.chromium.org/1009543009/

BUG=84250

Review URL: https://codereview.chromium.org/1019633003

Cr-Commit-Position: refs/heads/master@{#326759}

When NonUIDataTypeController was stopped while in the ASSOCIATING
state, the models were not stopped even though this state is only
accessible when the models are already loaded.

BUG=479737

Review URL: https://codereview.chromium.org/1096093004

Cr-Commit-Position: refs/heads/master@{#326758}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5894a94..fa1e205

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1104793002

Cr-Commit-Position: refs/heads/master@{#326757}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/18297c96..5b5f7c18

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1102883002

Cr-Commit-Position: refs/heads/master@{#326756}

The most important change here is getting rid of code in
renderer_accessibility.cc that recreated the subtree whenever
AXSelectedChildrenChanged was fired. This is no longer
necessary because Blink now fires the right events on each
individual option in a menu list or list box.

The rest of the changes just make sure the exact attributes
and events match the spec and match what Firefox and
Safari do when interacting with these elements, including
adding some good tests for those.

BUG=323462

Review URL: https://codereview.chromium.org/1057083002

Cr-Commit-Position: refs/heads/master@{#326755}

tested anywhere. Removed those from all related files. Recursive is
used only with NO_SORT so removed the option to use it in
combination with sorting.

Review URL: https://codereview.chromium.org/1096323003

Cr-Commit-Position: refs/heads/master@{#326754}

Originally SetVersionInternal() was quite simple function, but that has been
puzzuled as the codebase has evolved.

This CL decomposes the function for readability and simplifies lifetime
management for a version to be set, that is, passes a refcounted version
as an argument instead of making temporary protect object.

BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/1106723002

Cr-Commit-Position: refs/heads/master@{#326753}

MidiManagerAlsa needs udev for manufacturer extraction and robust device reconnection. Without udev, we cannot reliably get this information from the kernel.

This CL is the first step. It puts a hard requirement on udev for MidiManagerAlsa, but doesn't actually do anything useful with it yet.

Review URL: https://codereview.chromium.org/1079333002

Cr-Commit-Position: refs/heads/master@{#326752}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e2ee9248..18297c96

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1096743004

Cr-Commit-Position: refs/heads/master@{#326751}

Cr-Commit-Position: refs/heads/master@{#326750}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2de4669..5894a94

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1106733002

Cr-Commit-Position: refs/heads/master@{#326749}

In order to rename blink::EventTargetNames::LocalDOMWindow to
blink::EventTargetNames::DOMWindow, we have to temporarily disable
the test while the transition.  Once the renaming gets done, we'll
enable the test.

The following CLs should be landed.
http://crrev.com/1086663003
http://crrev.com/1088943008

NOPRESUBMIT=true
BUG=

Review URL: https://codereview.chromium.org/1064563005

Cr-Commit-Position: refs/heads/master@{#326748}

A WebMIDI port has properties such as .manufacturer, .name and .version
that remain empty in the current WebMIDI implementation on Android.
This CL fixes that by setting them to values got from USB descriptors.

BUG=473639

Review URL: https://codereview.chromium.org/1098913003

Cr-Commit-Position: refs/heads/master@{#326747}

These are designed to give us more information about production-only
crashes occurring in ChromeAppSorting. These checks should help narrow
down the times at which extension_scoped_prefs_ is null.

Added TODOs to remove most of the checks later (although I plan to leave
one in as a safeguard).

BUG=476648

Review URL: https://codereview.chromium.org/1055453007

Cr-Commit-Position: refs/heads/master@{#326746}

In the PasswordFormManager::OnRequestDone method, I found some usage of
raw pointers to elements of a ScopedVector with confusing ownership over
a lot of code. Rewrote the code to use scoped_ptrs so that the ownership
is always clear, and nothing needs to be manually deleted.

BUG=451018

Review URL: https://codereview.chromium.org/1094013002

Cr-Commit-Position: refs/heads/master@{#326745}

This is possible now that the data deps handling bug has been rolled.

BUG=477104

Review URL: https://codereview.chromium.org/1095873003

Cr-Commit-Position: refs/heads/master@{#326744}

These strings should only be included if enable_media_router is true.

Review URL: https://codereview.chromium.org/1105663003

Cr-Commit-Position: refs/heads/master@{#326743}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d641e95..2de4669

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1099963005

Cr-Commit-Position: refs/heads/master@{#326742}

In Async readback if the requested readback format is not supported.
Then fallback to RGBA_8888 format.

Removed RenderWidgetHostViewAndroid::PreferredReadbackFormat() API

Review URL: https://codereview.chromium.org/1095993002

Cr-Commit-Position: refs/heads/master@{#326741}

- Remove unused friendliness
- Remove DCHECK and if-statement combination forbidden by our coding standard
http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-
- Make some instance variables const

BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/1100003005

Cr-Commit-Position: refs/heads/master@{#326740}

This makes it explicit why server_ip is blank when the connection was
proxied, so we can tell when it's blank because of a bug instead.

BUG=

Review URL: https://codereview.chromium.org/1088933007

Cr-Commit-Position: refs/heads/master@{#326739}

BUG=475699
TEST=None

Review URL: https://codereview.chromium.org/1085703002

Cr-Commit-Position: refs/heads/master@{#326738}

BUG=none
TEST=run closure compiler

Review URL: https://codereview.chromium.org/1104463004

Cr-Commit-Position: refs/heads/master@{#326737}

Fix bugs related to the latest GN roll.

1) the new GN binary will return an error if you pass it
a file it doesn't know anything about in 'gn refs'.

2) for some reason with the new GN binary we're triggering a
code path in gyp_flag_compare.py that wasn't running before,
and that code path was busted.

TBR=brettw@chromium.org
BUG=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/1109453002

Cr-Commit-Position: refs/heads/master@{#326736}

No behavioral change.

BUG=none

Review URL: https://codereview.chromium.org/1104543006

Cr-Commit-Position: refs/heads/master@{#326735}