- 02 Feb, 2018 40 commits
-
-
Sam Zackrisson authored
This CL removes the render_fifo_ buffer from MediaStreamAudioProcessor and DCHECKs that the input audio is 10 ms long. MediaStreamAudioProcessor currently buffers audio provided to OnPlayoutData, to feed frames in 10 ms chunks to the APM. However, the caller of OnPlayoutData already DCHECKs that this is the case. This CL also modifies the unit tests. They use the same configuration for capture input as for render input, even though only capture needs to support input other than 10 ms. Bug: 804277 Change-Id: Ia20cf0e0810c59570305f1ca295016e0ca11057e Reviewed-on: https://chromium-review.googlesource.com/875862 Commit-Queue: Sam Zackrisson <saza@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533990}
-
Scott Violet authored
Original is here: https://chromium-review.googlesource.com/c/chromium/src/+/882558 This differs from the patch that landed in two ways: 1. I completely misunderstood RunsTasksInCurrentSequence(). It may be called on any thread and basically comes down to checking if the current thread matches the thread the TaskRunner runs on. Changed implementation of DeferredSequencedTaskRunner and DeferringTaskRunner appropriately (added test for this). 2. Master prefs need ResourceBundle loaded with the data pack, so, shuffled around loading of that. This is covered by browser_tests that sadly only run on official builder. There are two motivations for this change: 1. In order to run a field trial for state setup in creating toolkit. 2. To have local state ready at the time ash is created. In order to have field trial ready I need to load local state and everything it touches. This ended up including ResourceBundle (not really the ResourceBundle, but the ResourceBundle code is used to determine the locale, and the locale is needed by code related to metrics, specifically ChromeMetricsServiceClient::GetApplicationLocale). As much of this code was previously created at a time when task runners were available I had to create a deferring task runner that queues up tasks and then flushes them when the real task runner is available. I've tried to only move what is necessary and leave as mush initialization as possible in the place before this change. You'll notice this creates g_browser_process early on. I explored not doing this, but it turns out very painful as instead some code then has to cache state that is later available in g_browser_process. The camel that broke the straws back was the application locale. See https://chromium-review.googlesource.com/c/chromium/src/+/853300 for the early approach. BUG=800358 TBR=mark@chromium.org,jamescook@chromium.org,mpearson@chromium.org Change-Id: I3343e8959321900daec0de16f6a86715d3760f29 Reviewed-on: https://chromium-review.googlesource.com/898070 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#533989}
-
tzik authored
WebMIDI backend implementations have used double as a time type. As base::TimeTicks is available in Blink now, it's better fit to use as the timestamp. Change-Id: Ide762f3a8dd503b3bd77eae9077f5ecde18e3796 Reviewed-on: https://chromium-review.googlesource.com/892726Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#533988}
-
Yuta Kitamura authored
TBR=ssid@chromium.org Bug: 808152 Change-Id: I50f6ef21551e59aa7aa92f21863b0b24cc2b56c3 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/897237Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533987}
-
Takashi Toyoshima authored
This is a preparation to implement CORS preflight in content/network. These methods originally in FetchUtils are used to create a blink ResourceRequest or URLRequest for a CORS preflight request. Original code roughly implements the mime-type checks, but new implementation relies on //net API that checks mime-type strictly. This will cause a behavior change, and some that were in a wrong format but luckily passed will start failing. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iaac0809d4af9011cf4bcc9e7e431a1b1ad762e0a Reviewed-on: https://chromium-review.googlesource.com/883861 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/ed7b4ff9e38c..c7b964cd71fb $ git log ed7b4ff9e..c7b964cd7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b24b726bda4dbb0f2eaa80f9c5a5db5055460ad Reviewed-on: https://chromium-review.googlesource.com/898193 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533985}
-
Sean Kau authored
Without this observer, we never see printers for the new policy. Bug: 805825 Change-Id: I4d5f0b3f3035e65572631c4464e795c5a56549c3 Reviewed-on: https://chromium-review.googlesource.com/887281 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#533984}
-
Mike Dougherty authored
This feature flag will be used for adding Context Menu support to iFrames by using the PostMessage WebKit API to return the found element. (Instead of directly returning the element details from __gCrWeb.getElementFromPoint) Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I17fec9afb74e7fe5f7b2818902f4b872ba8d445a Reviewed-on: https://chromium-review.googlesource.com/896546 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533983}
-
Yuta Kitamura authored
TBR=qyearsley@chromium.org,treib@chromium.org,sfiera@chromium.org Bug: 805756, 808153 Change-Id: Id7e8b218cf37d51c7ef0d6cd34b2abe6bd9d1be2 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/897236Reviewed-by:
-
Erik Luo authored
This test was flaky because it logged console messages but did not wait for the viewport to render their elements in DOM. This CL unflakes the test by waiting for pending viewport refreshes. Bug: 789225 Change-Id: I9861b067df72c66b00021050cf07562b0064f66c Reviewed-on: https://chromium-review.googlesource.com/898389Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#533981}
-
Yoichi Osato authored
On SlimmingPaintV175, we should point LayoutRect to invalidate with DisplayItem::PartialInvalidationRect() virtual function but PaintFragment didn't override it. This patch implements the override that returns visual rect of including NGBlockFlow. This patch reduces 7 image failures of selection in NG. Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9342e72791e4a8eec533081fb5da2f6d16c3d4b2 Reviewed-on: https://chromium-review.googlesource.com/897303Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#533980}
-
Yuta Kitamura authored
TBR=treib@chromium.org,sfiera@chromium.org Bug: 808185 Change-Id: Ie18b58450b9893f0f3b8a92f719769fe20eec0c0 Reviewed-on: https://chromium-review.googlesource.com/896772Reviewed-by:
-
Takeshi Yoshino authored
It doesn't need to be a part of the interface. Each implementation of the interface can just have their implementation as their private method. Change-Id: I7acac5e71c70534998345147dba487394fc2737b Reviewed-on: https://chromium-review.googlesource.com/897317Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#533978}
-
tzik authored
This adds FromNanoseconds{,D}() and FromMicrosecondsD() to TimeDelta to align to existing InNanoseconds(). Change-Id: I1043d2fad8b47e5791418225a1d2e236be09ead5 Reviewed-on: https://chromium-review.googlesource.com/898722Reviewed-by: -
Yuta Kitamura authored
This test is flaky on Fuchsia. TBR=treib@chromium.org,sfiera@chromium.org,sahel@chromium.org,tdresser@chromium.org Bug: 807803 Change-Id: Ie05cca6552c447af612bb36cb86663a8ba118b05 Reviewed-on: https://chromium-review.googlesource.com/898763 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Dominick Ng authored
This CL ensures that native app banners resolve the userChoice promise on beforeinstallpromptevent. Specifically, the |weak_manager_| of AppBannerInfoBarDelegateAndroid was not being set in the constructor for native app banners. Now it is set correctly, which allows userChoice to resolve. BUG=806923 Change-Id: I468c8dbc24e2451a3f6c044d8a2d95768d25347d Reviewed-on: https://chromium-review.googlesource.com/892183Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#533975}
-
Jia authored
This means we will only log events after user remains inactive for 30sec. This will also reduce number of events logged to UKM by ~55%. Bug: 784232 Change-Id: I558505ac3bd9daacd25458852d549e1f44071ecd Reviewed-on: https://chromium-review.googlesource.com/896769 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#533974}
-
Yuta Kitamura authored
This reverts commit 767edb03. Reason for revert: Causing layout test failure everywhere. Seems like dependent scripts aren't loaded: > CONSOLE ERROR: line 49: Uncaught ReferenceError: selection_test is not defined Original change's description: > Move doubleclick-inline-first-last-contenteditable.html to editing/selection/mouse > > This patch moves "doubleclick-inline-first-last-contenteditable.html" to > "editing/selection/mouse" because this test verifies selection with mouse for > ease of maintenance. > > This is a follow-up of reviewer's suggestion in the patch[1]. > > [1] http://crrev.com/c/896903 Rewrite > editing/selection/doubleclick-inline-first-last-contenteditable.html to use > selection_test() > > NOTRY=true > TBR=yoichio@chromium.org > > Bug: 679977 > Change-Id: I35e79f27723204dd697b8920028300c6584ee354 > Reviewed-on: https://chromium-review.googlesource.com/897391 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533951} TBR=yosin@chromium.org Change-Id: I47eb8154a7c873d21adc94a57633d7ebad77abf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 679977 Reviewed-on: https://chromium-review.googlesource.com/898822Reviewed-by:
-
Kent Tamura authored
custom-elements: Fix a DCHECK failure with external/wpt/custom-elements/upgrading/Node-cloneNode.html. V0CustomElementRegistrationContext::SetTypeExtension() is not expected to be called for autonomous custom elements. Element:: AttributeChangedFromParserOrByCloning() should check it. Bug: 805061 Change-Id: Ie91256bb6b6b8671d4a6a65374db31394a08d2ea Reviewed-on: https://chromium-review.googlesource.com/897169Reviewed-by:
-
Chandan Padhi authored
This reverts commit 2b33f996. Reason for revert: <INSERT REASONING HERE> Original change's description: > Migrate MediaStreamDispatcherHost to be per frame > > Currently, there is only one MediaStreamDispatcherHost per renderer > process, but almost all its methods require a frame ID to be supplied > by the caller. This CL migrates this object to be per frame. > > Bug: 807274 > Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890 > Reviewed-on: https://chromium-review.googlesource.com/894864 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533970} TBR=avi@chromium.org,tsepez@chromium.org,c.padhi@samsung.com,guidou@chromium.org Change-Id: I3b35db7ae519b3b5111b290a8611dff5a2101d76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807274 Reviewed-on: https://chromium-review.googlesource.com/897320Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#533971}
-
Chandan Padhi authored
Currently, there is only one MediaStreamDispatcherHost per renderer process, but almost all its methods require a frame ID to be supplied by the caller. This CL migrates this object to be per frame. Bug: 807274 Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890 Reviewed-on: https://chromium-review.googlesource.com/894864Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533970}
-
Victoria Su authored
Design doc: https://docs.google.com/document/d/1dfbT1mnIuwm9HTyUWDe5PS5FygZgMuQGsyw49oxBcXk/edit?usp=sharing Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kqD_G4sxfZE/6CJM01X2BwAJ Bug: 568705 Change-Id: I57e619e462f8323496aad477c50c45f9537003c4 Reviewed-on: https://chromium-review.googlesource.com/879982Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Victoria Su <victoriaytsu@google.com> Cr-Commit-Position: refs/heads/master@{#533969}
-
Ramin Halavati authored
Network traffic anntoation is added to socket writes of: remoting/protocol/fake_authenticator.cc remoting/protocol/ssl_hmac_channel_authenticator.cc Bug: 656607 Change-Id: Ifd157307c70ea936194c2bcb9395deb3c95d3929 Reviewed-on: https://chromium-review.googlesource.com/885807 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533968}
-
Istiaque Ahmed authored
These tests extend ExtensionRegistryObserver to wait for extension load/unload etc. TestExtensionRegistryObserver already provides this functionality. Bug: 808136 Test: None Change-Id: I195f206163f54b7547079b10c48e677a86eaf6db Reviewed-on: https://chromium-review.googlesource.com/897468Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533967}
-
Dominick Ng authored
This CL implements a mini-infobar that is displayed when users visit any PWA. Tapping the infobar will trigger add to home screen. The intention is to inform users that they are browsing a PWA, give easier access to add to home screen, and encourage developers to adopt PWAs through privileged UI. App install currently fulfill the informational role that ambient badges will now take. This CL will enable future work to stop app banners from automatically appearing, and change them to adopt a modal, developer-triggered flow which hands more control to sites. Future CLs will: - disable automatic app install banner triggering when the ambient badge feature is active - change the string of the ambient badge such that it launches the PWA if it is already installed Eventually, it is hoped that a less intrusive UI will take the place of the mini infobar for the ambient badge. BUG=782120 Change-Id: Id012522982699d61293c57b79c4eb3ef0fe9e55f Reviewed-on: https://chromium-review.googlesource.com/879701 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#533966}
-
Hayato Ito authored
There should be no functional changes from this patch. Bug: 776656 Change-Id: I975e32a2cd2fa2610352ce1c85f10b3afe5bc688 Reviewed-on: https://chromium-review.googlesource.com/897288Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#533965}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: I5d81a2044e1467e19d3b99edc8bad6192829a7e6 Reviewed-on: https://chromium-review.googlesource.com/895238 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#533964}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I3909b2f6232569df1889471d07132a90c1023009 Reviewed-on: https://chromium-review.googlesource.com/897386Reviewed-by:
-
Ehsan Chiniforooshan authored
This adds two stories for measuring UI compositor FPS: 1- Loads news.yahoo.com; goes to overview mode; exits overview mode. 2- Loads poster circle; goes to overview mode; exits overview mode. The stories run only when the browser backend supports overview mode actions; so this will not break perf bots. For now, we will run these stories manually. Note: this should be landed after 884511, due to using --always-request-presentation-time browser arg. Bug: 795928 Change-Id: Ib09348334ba3708d316c46a7a89f0febc8532264 Reviewed-on: https://chromium-review.googlesource.com/895411Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533962}
-
Tien-Ren Chen authored
This reverts commit 19374016. Reason for revert: crbug.com/806848 Original change's description: > Reland "LayoutView::StyleWillChange viewport invalidation" > > This reverts commit 8c08d938: > > Revert LayoutView::StyleWillChange viewport invalidation > > > > This patch is a speculative revert of the following patch: > > "Let LayoutView::StyleWillChange handle viewport invalidation." > > https://chromium-review.googlesource.com/c/chromium/src/+/609984 > > r495573 > > 1fac40c9 > > > > This patch could be responsible for regressions in the following: > > * Blink.Paint.UpdateTime > > * Blink.Compositing.UpdateTime > > > > Bug: 768612 > > Change-Id: I8d12b80473afee2eecdb3ff1a8c3538f334eaf59 > > Reviewed-on: https://chromium-review.googlesource.com/719336 > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Reviewed-by: Rune Lillesveen <rune@opera.com> > > Commit-Queue: Rune Lillesveen <rune@opera.com> > > Cr-Commit-Position: refs/heads/master@{#509012} > > Unfortunately we couldn't observe performance metric recovery from the > speculative revert, thus landing the CL again and we will be watching if > performance fluctuated. > > BUG=768612 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I05c2a6bfe0f85cffdbf0b2ea1813a3ff7a83f05d > Reviewed-on: https://chromium-review.googlesource.com/848153 > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532087} TBR=trchen@chromium.org,chrishtr@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768612 Change-Id: Icd9d0febbee618735c7ae60b639d8b45ea19f644 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/892124 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533961}
-
David Tseng authored
Test: chromevox_tests. Prior to the change, BackgroundTest.ActiveDescendantUpdates fails because 'Selected' is not spoken. Compute text content for list items without names Chrome doesn't compute descendant name on focus. Test: manually on twitter.com using j/k. Verify all text gets read. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie75dff41f98b8aa3904e435afa4bd245b9771cce Reviewed-on: https://chromium-review.googlesource.com/891676 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533960}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c1a69bb..09eb87e6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I99040eac63e97d1be2f656a38920ee155da6e498 Reviewed-on: https://chromium-review.googlesource.com/897754Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533959}
-
khmel authored
Custom app icon loading is started immidiatelly when it is assigned, including the case when it is set as a create parameter for Chrome app window. In last case icon gets loaded in together with main page content loaded. Here is the race. If page is loaded first it commits navigation which abort all pending resource load requests, including the custom icon. As result custom icon is not loaded. Solution is to start custom icon loading only when app window is ready. Test: Manually Bug: 788531 Change-Id: If72a094a846b87f45bfe60bfbbcb7889281579c5 Reviewed-on: https://chromium-review.googlesource.com/895200 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533958}
-
https://webrtc.googlesource.com/src.git/+log/5f94aa2c013e..ed7b4ff9e38c $ git log 5f94aa2c0..ed7b4ff9e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I942dec5d9938f6fb937c2b06c358ccf26bace46c Reviewed-on: https://chromium-review.googlesource.com/898587Reviewed-by:
-
Yoichi Osato authored
htmlElementTypeForTag(tagName) returns HTMLElementType for the name. However this returned wrong type for each tag that's DOM interface is HTMLElement but Blink implements the class inheriting HTMLElement, e.g. ruby element. htmlElementTypeForTag is generated function by make_element_type_helpers.py using HTMLTagNames.json5. This patch modifies the python script to return each appropriate DOM interface. Bug: 805281 Change-Id: I81525ae0a79d7b37e8e5e0df664375e2019f37c2 Reviewed-on: https://chromium-review.googlesource.com/892843Reviewed-by:
-
Kevin Marshall authored
Enable the new-style (SSH-based) test runner on the "Fuchsia" chromium.fyi bots on test suites which don't depend on dynamic linking or multiple packaged executables. * Add a command line switch to conditionally redirect execution to the v2 runner script (--use-new-test-runner). * Include archive_manifest file in v2 runner's runtime deps. * Relativize archive_manifest source paths for isolate portability. * Automatically resolve paths to unstripped binaries during symbolization. Change-Id: I4f482c666c4f1e0f546f0f07d4498f721776215b Reviewed-on: https://chromium-review.googlesource.com/895386Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533955}
-
Darren Shen authored
This patch removes the tentative extension from CSSURLImageValue and adds an IDLHarness test for it. TBR=nainar@chromium.org Bug: 774887 Change-Id: I3dceb0a91231f40ff7a44a620146bcf77baf260f Reviewed-on: https://chromium-review.googlesource.com/897229Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533954}
-
Joel Hockey authored
This fixes a number of bugs found on clusterfuzz. Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 Bug: 790944 Bug: 793715 Bug: 796804 Bug: 799707 Reviewed-on: https://chromium-review.googlesource.com/897220 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533953}
-
Wenzhao Zang authored
1) Opening wallpaper picker is NOT allowed if: a) The active user is policy controlled (must be checked by //ash/WallpaperController), or b) The active user type is GUEST or KIOSK etc. (can be checked from //ash or //chrome). 2) The wallpaper picker can be opened either from the setting page (//chrome) or the shelf context menu (//ash). In addition, the setting page need to distinguish between cases a) and b), in order to show different UI. So we need to create two mojo callbacks. 3) In addition, WallpaperControllerClient should not rely on the setting page to check a) and b): it must call into //ash to ask, in case a refactoring of the setting page will cause regression (there was once a bug because of this.) 4) The check of b) used to rely on LoginState but it was recently deprecated, so it's using SessionController in //ash instead. TBR=blundell@chromium.org in Settings is a) invisible for guest session, b) disabled for users controlled by wallpaper policy, c) enabled for other cases. Bug: 798604 Test: 1) ash_unittests 2) Manual test by checking the 'Wallpaper' item Change-Id: Icb1479d2112f02b823237c418622cc0cdbae65fc Reviewed-on: https://chromium-review.googlesource.com/848193Reviewed-by:Oliver Chang <ochang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch moves "doubleclick-inline-first-last-contenteditable.html" to "editing/selection/mouse" because this test verifies selection with mouse for ease of maintenance. This is a follow-up of reviewer's suggestion in the patch[1]. [1] http://crrev.com/c/896903 Rewrite editing/selection/doubleclick-inline-first-last-contenteditable.html to use selection_test() NOTRY=true TBR=yoichio@chromium.org Bug: 679977 Change-Id: I35e79f27723204dd697b8920028300c6584ee354 Reviewed-on: https://chromium-review.googlesource.com/897391Reviewed-by:
-
