GitLab

Bad things happen if you delete the profile that started the Metro
process (at best, you crash), since relaunching Metro with a new user
is not supported. Hiding the button selectively depending on the
profile selected is a bit weird, so in Metro mode, hide it for all
profiles.

BUG=448352

Review URL: https://codereview.chromium.org/863063002

Cr-Commit-Position: refs/heads/master@{#313449}

This CL is split off from http://crrev.com/785463002 and
Window::GetFocusedTextInputClient is necessary in that CL.

BUG=290701

Review URL: https://codereview.chromium.org/860983004

Cr-Commit-Position: refs/heads/master@{#313448}

This pulls in the following Native Client changes:

939a13a (teravest@chromium.org) Provide an irt_core_lib GN target.
dbf2af4 (sbc@chromium.org) Remove include of build_config.h from nacl_exception.h
e205317 (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
7c8a96b (jfb@chromium.org) Update revision for PNaCl
3d00a54 (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
1de8ba8 (mseaborn@chromium.org) Update codereview.settings following the switch from SVN to Git
7a6cf46 (jfb@chromium.org) Update revision for PNaCl
bc28c0b (jvoung@chromium.org) Fix the native_client URL in the PNaCl REV file.
f8aa9dc (bradnelson@google.com) Adding le32-nacl build of pnacl tools.
cfda521 (teravest@chromium.org) Explicitly include build_config.h.
61b7ba9 (teravest@chromium.org) Output depfile from build_nexe.
2d65c23 (jfb@chromium.org) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
5f5cd88 (sbc@chromium.org) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
1baa204 (jvoung@chromium.org) Remove some more dead code and variables from pnacl/build.sh.
f116471 (dschuff@chromium.org) Update revision for PNaCl
01f3d97 (teravest@chromium.org) Always define product_dir in build_nexe.
8a5a846 (mseaborn@chromium.org) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
c14b58a (mseaborn@chromium.org) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
c5d8394 (bradnelson@google.com) Change driver bash scripts to work in devenv.
490e554 (dschuff@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
2a7391a (sbc@chromium.org) Fix several issues with update_pnacl_tool_revisions.py
fbc3b5c (dschuff@chromium.org) Support filenames with spaces in the PNaCl driver scripts.
4f726e8 (sbc@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
28a1341 (dschuff@chromium.org) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
9f9d773 (sbc@chromium.org) Update GCC revision in tools/REVISIONS
29ae54a (jfb@chromium.org) Update revision for PNaCl

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/881893003

Cr-Commit-Position: refs/heads/master@{#313447}

The CL dumps gesture property values for touch devices that run
with the CrOS gesture library. The format is designed to be
backward-compatible with the X11 behaviour.

Contributed by sheckylin@chromium.org

BUG=450159
TEST=samus ChromeOS build

Review URL: https://codereview.chromium.org/864253002

Cr-Commit-Position: refs/heads/master@{#313446}

This CL refactors the check for invalid render_frame_message_source_ to a common method and uses it in all of the relevant IPC handlers. Ideally it will all be removed once RenderViewHost disappears or all of its IPC handling is removed.

BUG=451932, 449777

Review URL: https://codereview.chromium.org/877203002

Cr-Commit-Position: refs/heads/master@{#313445}

Previously, the PDF extension UI was zoomed to the default zoom level
and the PDF was inversely affected (due to various calculations using
zoomed and not zoomed sizes). This resets the zoom level for extensions
used as mime handlers on mime handler WebContents creation and for print
preview (as the PDF extension zoom as controlled by the embedding print
preview dialog WebContents.

BUG=450910

Review URL: https://codereview.chromium.org/881553003

Cr-Commit-Position: refs/heads/master@{#313444}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6dbfb21..25b7611

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/878163003

Cr-Commit-Position: refs/heads/master@{#313443}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/885543002

Cr-Commit-Position: refs/heads/master@{#313442}

In preparation for moving SynthesizeKeyEvent to cocoa_test_event_utils,
this refines the behavior of SynthesizeKeyEvent to more closely match
actual events. There were two bugs:

The unichar character being set on a simulated "Delete" key was actually
the unichar that Mac uses for "Backspace" (0x7f). Cocoa actually uses
0xf728 for the delete key (NSDeleteFunctionKey). Note "Backspace" stays
sending 0x8 (Ctrl+H) rather than being updated to 0x7f (ASCII DEL).
Either seems to work for Backspace (which meant simulated Deletes were
becoming deleteBackward action messages rather than deleteForward).

Also, SynthesizeKeyEvent is updated to closely follow the behavior on
Mac wrt Command/Shift modifiers. The bug here was that when *just*
Shift+letter is pressed, characters and charactersIgnoringModifiers
should *both* be uppercase. (r311815 swapped them for Ctrl, but didn't
try to fix Shift).

These changes are needed for comprehensive testing of views::TextField
on Mac. Specifically, to get TextfieldTest.ControlAndSelectTest and
TextfieldTest.ControlAndSelectTest passing with simulated NSEvents.

BUG=378134

Review URL: https://codereview.chromium.org/856313003

Cr-Commit-Position: refs/heads/master@{#313441}

This is used by enhanced bookmarks to choose an image to show for each
bookmark.

BUG=450287

Review URL: https://codereview.chromium.org/885513002

Cr-Commit-Position: refs/heads/master@{#313440}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/884603002

Cr-Commit-Position: refs/heads/master@{#313439}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/862403005

Cr-Commit-Position: refs/heads/master@{#313438}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/872363004

Cr-Commit-Position: refs/heads/master@{#313437}

Review URL: https://codereview.chromium.org/878773002

Cr-Commit-Position: refs/heads/master@{#313436}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/12a5230..7f3bd0d

TBR=timloh@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/882883002

Cr-Commit-Position: refs/heads/master@{#313435}

BUG=451272

Review URL: https://codereview.chromium.org/872993003

Cr-Commit-Position: refs/heads/master@{#313434}

found by the vc /analyze bot

BUG=440500

Review URL: https://codereview.chromium.org/876343004

Cr-Commit-Position: refs/heads/master@{#313433}

My understanding is that by-default javac
pulls encoding from the user's environment
http://stackoverflow.com/questions/9661935/how-to-change-the-defaults-system-java-encode-form-in-windows
http://stackoverflow.com/questions/11343828/file-encoding-has-no-effect-lc-all-environment-variable-does-it
which is wrong for Chromium where all of our
source files are known to be UTF-8, regardless
of what the user has set in their environment.

In my case I was using Chrome Remote Desktop
to connect to my linux machine and for
whatever reason LANG was missing from the
resulting environment.  After this patch
mojo_shell builds correctly for Android again.

BUG=419378

Review URL: https://codereview.chromium.org/869673002

Cr-Commit-Position: refs/heads/master@{#313432}

This patch prevents the overlay scrollbars from showing up when we're near the
minimum scale. The threshold can be set per-platform; by default it's 0 so the
scrollbars will be visible regardless of the scale. On Windows/Linux/CrOS we'd
like to prevent the scrollbars from overlaying over the window scrollbars so
we set a small non-0 threshold.

BUG=446411

Review URL: https://codereview.chromium.org/877863002

Cr-Commit-Position: refs/heads/master@{#313431}

The class derives from WAPI, which is no longer used.

BUG=357038
TEST=syncfs unit tests pass
TBR=rogerta@chromium.org
# for google_apis/{BUILD.gn,google_apis.gyp)

Review URL: https://codereview.chromium.org/881723002

Cr-Commit-Position: refs/heads/master@{#313430}

VS /analyze complains about this.

BUG=427616

Review URL: https://codereview.chromium.org/878333002

Cr-Commit-Position: refs/heads/master@{#313429}

Sometimes we get into situations where we get frequent UpdateTiles,
but no AppendQuads. As a result we can start accumulating tilings
(during pinch zoom for example), but we never free any of them, since
the code to free tilings happens only during AppendQuads. This patch
remedies this by ensuring that if AppendQuads doesn't clean up the
tilings, and we've added some since last time we ran UpdateTiles,
we clean them up.

R=danakj
BUG=452304

Review URL: https://codereview.chromium.org/881083002

Cr-Commit-Position: refs/heads/master@{#313428}

We suspect that this method may be causing jankiness of QuicClientSession constructor

BUG=422516

Review URL: https://codereview.chromium.org/879943003

Cr-Commit-Position: refs/heads/master@{#313427}

This is the first of several steps in bringing a material design friendly cloud import feature.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/883973002

Cr-Commit-Position: refs/heads/master@{#313426}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

The mouse button map is a UI thread object, so move all of the mouse
processing that needs button map information outside of the
device-specific object. Devices no longer get a MouseButtonMapEvdev*
since they will execute on a different thread.

BUG=449710
TEST=boot link_freon & click mouse

Review URL: https://codereview.chromium.org/872683006

Cr-Commit-Position: refs/heads/master@{#313425}

R=lcwu@chromium.org,dougsteed@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/876373004

Cr-Commit-Position: refs/heads/master@{#313424}

OOP PDF is now enabled by default, so remove the check in ChromeBrowserMainPartsWin::PreCreateThreads

BUG=442157
TEST=launch with --enable-win32k-renderer-lockdown or --force-fieldtrials=Win32kLockdown/Enabled/ check chrome://histograms that Win32k lockdown is enabled.  Check OOP PDF still works both with and without --disable-direct-write switch.

Review URL: https://codereview.chromium.org/872673002

Cr-Commit-Position: refs/heads/master@{#313423}

Rename termination, suspend, and dark resume action time histograms. This is to
accomodate to the change in the max value of these non-enumerated histograms
introduced in Chrome OS CL:238890.

BUG=chromium:443458
TEST=none.

Review URL: https://codereview.chromium.org/819713007

Cr-Commit-Position: refs/heads/master@{#313422}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/866803003

Cr-Commit-Position: refs/heads/master@{#313421}

The rasterize_and_record benchmark was not using data from the
DisplayItemList. Now it does.

R=ajuma@chromium.org,vmpstr@chromium.org
BUG=451448

Review URL: https://codereview.chromium.org/867803003

Cr-Commit-Position: refs/heads/master@{#313420}

Metrics have been added for the GPU using the GPU Tracer. Currently
we record the average, max, and stddev ms for each category
per frame for the following categories:
  render_compositor: Both CPU/GPU side spent on the render compositor.
  browser_compositor: Both CPU/GPU spent on browser compositor.
  total: Both CPU/GPU and total frame time spent in renderer.
  swap: Time between swaps, total FPS.

R=vmiura@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/854833003

Cr-Commit-Position: refs/heads/master@{#313419}

Currently if the RenderFrame is destroyed prior to the MimeHandlerViewContainer
then we will look for the wrong entry in the map. This fixes that issue by
removing the entry when the RenderFrame is destroyed.

Review URL: https://codereview.chromium.org/874293004

Cr-Commit-Position: refs/heads/master@{#313418}

Review URL: https://codereview.chromium.org/839653002

Cr-Commit-Position: refs/heads/master@{#313417}

AudioDecoderJob maintains an object audio_timestamp_helper_ for use with AV sync. Previously, this object was configured with demuxer value for sample rate, whereas it should instead be synced with the decoder's reported sample rate.

This CL enables AudioDecoderJob to track decoder output rate, and ensures change in output format is propagated to this object.

BUG=internal b/18873488

Review URL: https://codereview.chromium.org/805273007

Cr-Commit-Position: refs/heads/master@{#313416}

Changes in this CL:
 - In request_build.py, add a URL for linux try bot.
 - Add sample config for functional bisect.
 - Make perf-related config parameters optional.
 - Use builder type when starting build try jobs, and when fetching builds.

A few other changes:
 - Update bisect_perf_regression.py file docstring.
 - Rename _BuilderTryjob to _StartBuilderTryJob and refactor.
 - Remove unused code in request_build.py.

Proposed follow-up:
 - Move functions related to builder to be methods of one class, so that the builder-specific info/logic (e.g. builder bot and archive location) is in one place.

BUG=

Review URL: https://codereview.chromium.org/806943007

Cr-Commit-Position: refs/heads/master@{#313415}

BUG=452266

Review URL: https://codereview.chromium.org/858093003

Cr-Commit-Position: refs/heads/master@{#313414}

BUG=418375

Review URL: https://codereview.chromium.org/883853004

Cr-Commit-Position: refs/heads/master@{#313413}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8ece6eb..6dbfb21

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/871193004

Cr-Commit-Position: refs/heads/master@{#313412}

Refactor into a virtual method on TabDialogs, with overrides for Views and
Cocoa.
ValidationMessageBubble is moved out of chrome namespace to be more
consistent with other dialogs.

BUG=425229

Review URL: https://codereview.chromium.org/867323005

Cr-Commit-Position: refs/heads/master@{#313411}

d:\src\cr3\src\net\cert\crl_set.cc(53): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\net\cert\crl_set.cc(53): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr3\src\net\cert\crl_set.cc(47): note: see declaration of 'i'

R=mattm@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/882833002

Cr-Commit-Position: refs/heads/master@{#313410}