- 09 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2d525fe9bd56..f87536c9de24 git log 2d525fe9bd56..f87536c9de24 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 sprang@webrtc.org Reland "Reland "Refactors UlpFec and FlexFec to use a common interface."" 2020-03-09 phoglund@webrtc.org Whitespace change to kick bots. Created with: gclient setdep -r src/third_party/webrtc@f87536c9de24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052323,chromium:1055974 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ead2ff3c4b5bce9a3f278c6ef96fd1b318e622a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095325Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748292}
-
Corentin Wallez authored
This simplifies some redundant logic in tests and allows future tests to create multiple devices. Bug: chromium:1059777 Change-Id: I1ae7d91090a5c13269513328691fab7fed4374a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095121Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#748291}
-
Sophie Chang authored
This allows us to run the Client-Side Reactive Preconnect in the below configs: 1) Default - Local predictions only 2) Local predictions with optimization guide filling in 3) Optimization guide only 4) No predictions Bug: 1050101 Change-Id: I9eb87170aa0079f3384f1797b03cd3d850b1228e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094246Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748290}
-
Justin Donnelly authored
Document suggestions are still under post-launch development so these may still be useful for a while. Bug: 1053091 Change-Id: I2e714165218c6f8260d2a8f5852e47e6f923c982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065352Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#748289}
-
Rodney Ding authored
Boolean params without a value is now defaulted to True. Bug: 1048757 Change-Id: I2c3ed2562671ae64cf9eceeaa5ba5cc0d69501e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085697 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#748288}
-
Donn Denman authored
Speculatively re-enables the ContextualSearchManagerTest suite with the hope that the mysterious underlying flakiness issue has gone away, or that the longer timeout in this version of the code will help. Original disabling CL: https://crrev.com/c/2088007 TBR=twellington@chromium.org BUG=1058362 Change-Id: I02ea4f209b86b730cc6f40622839ffb12f3753c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094245 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#748287}
-
Eugene But authored
These actions are helpful for Breadcrumbs feature that attaches steps to reproduce to crash reports. Hence the code was written to log UserActions right after the user Tapped Done and before any other code could run and crash the app. Bug: 1046231 Change-Id: I5e7e811f27fd5018e7a562330f2841a25272ce7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089985 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#748286}
-
Stefan Zager authored
Change-Id: Iaa04227763c118fc285ee1e9bf4cc3bd32329ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092935Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#748285}
-
Zhenyao Mo authored
BUG=1026447 TEST=viz_perftests R=backer@chromium.org Change-Id: Ic47959a863c42a4a23c9077336f65ff955e2d85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076767Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748284}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. Bug: 1058614 Change-Id: I4b21639bcbc1e78e0417e75614c0232f700ffe71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094239Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748283}
-
Phillis Tang authored
The BluetoothDiscoverySession::Stop method callback params will be removed and |Stop| will be equivalent to the session destructor, update BluetoothBlueZTest tests to reflect the ongoing refactoring. Bug: 991682 Change-Id: If5e743407fb08c42c50f0e5ace4da3c7771d8567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090768Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#748282}
-
Denis Kuznetsov authored
Polymer v2 evaluates i18nDynamic(as it has defined locale param), but does not evaluate !domain as only one undefined param. Fixed: 1059735 Change-Id: Ia8ac3a166590e669d77760f1bdd0c1786712c6f7 Bug: 1059735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095009 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#748281}
-
Peng Huang authored
Bug: 1059598 Change-Id: I4ec9ae96b97606d4e64d6ce8874471b00586def8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094235Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748280}
-
Toni Barzic authored
Currently, we show gesture navigation screen in tablet mode only, though for touch centric devices, the screen should be shown even if the device is in clamshell mode. To achieve this, add support for a command line switch "oobe-force-tablet-first-run" that would force tablet mode flow for the first user run, even if the device is in clamshell during setup. The flag is expected to be passed in by login manager during chrome setup. BUG=976949 Change-Id: I754eb09c4b3ddbb85af2148f5f062e971e6a1e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092696Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#748279}
-
Takashi Toyoshima authored
Following tests were modified or added by https://chromium-review.googlesource.com/c/chromium/src/+/2054468. * http/tests/inspector-protocol/network/xhr-cors-preflight-redirect-failure.js * http/tests/inspector-protocol/network/xhr-post-replay-cors.js They started reaching timeout after the CL, and we won't fix it for Blink CORS. NOTRY=true Bug: 958524, 941297 Change-Id: I349e00a5ff6c7590fc843797e75246bb14413c10 TBR: horo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094902Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748278}
-
Jan Wilken Dörrie authored
This change adds a pluralized string for the number of compromised passwords. In order to do so it makes use of the recently introduced PluralStringProxy that dispatches to the C++ backend to get the correct string. Bug: 1047726 Change-Id: I1b6223d72e67d5b32690b42c04b5644c5f9da067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093594 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748277}
-
Rainhard Findling authored
* Makes safety check elements focusable independently of their state. * Attaches dynamic accessibility info to the elements to allow screen readers informing users about their state even in states they would otherwise not be focusable. * DD: http://shortn/_uEauSbBMVy Bug: 1015841 Change-Id: I52d2c932478d6e66661938b08f7d43f5d82a394a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089698Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748276}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4869d471b9d6290064162dc83ca65961fdb78eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748275}
-
John Budorick authored
Disabling all parameterizations of tests disabled in crrev.com/c/2089975. Bug: 1054829 Change-Id: Ifcccfb6040a0eb0637b43aa18b0ff4f845778a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094901Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#748274}
-
Jan Wilken Dörrie authored
This change improves the formatting of elapsed time since a compromised password was found. Time deltas smaller than a minute are now shown as "Just now", while deltas exceeding 30 and 365 days are formatted with months and years, respectively. Bug: 1047726 Change-Id: Ic08bf80ac300724a64fe304e032936ee0968b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095298Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748273}
-
jonross authored
Video on Android using Vulkan was broken. This suppresses the failures until the root cause can be fixed. TBR=ynovikov@chromium.org TEST=vulkan_content_browsertests vulkan_pixel_skia_gold_test Bug: 1059724, 1051705 Change-Id: I77abd2bf710620b76c9ddbc1ff56253f72a630fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093912Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748272}
-
Sadrul Habib Chowdhury authored
The INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT component is set from the browser, and immediately looked up in the same cycle. So remove the component, and use the timestamp directly instead. BUG=849719 Change-Id: Id28352d7ad0f56c5b0b89df26c9aa45d3d190f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093019 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748271}
-
Scott Violet authored
This reverts commit ea173bd3. Reason for revert: Still seeing failure of mini_installertests. Hoping this will fix the flake. Bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 Original change's description: > Fix InstallServiceWorkItemTest deletes Chrome key under ClientState. > > Greg discovered that InstallServiceWorkItemTest.Do_ServiceName will > create Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96} > if it does not exist and then delete it. If the test is run on a > development machine, it will corrupt the stable Chrome install. > > Bug: 1057233 > Change-Id: I5e71c6ab9776f376dcffe0a415bfb084baec8e26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086353 > Auto-Submit: S. Ganesh <ganesh@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746738} TBR=ganesh@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057233 Change-Id: I57c3d50264dcf433a123e2802f04a70af8742935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094466Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748270}
-
David Jean authored
Move from /ios/chrome/browser/settings/ui/password to /ios/chrome/common/reauthenticaton Moved metrics out of it and into (non test) callers. Changed result from BOOL to 3 states enum for success, failure and skipped. The goal is to be able to use it in the credential extension. Bug: 1045455 Change-Id: I94104044c82b637b9d183f07fc6d8ce291e5b7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089864 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748269}
-
Ali Juma authored
This creates an iOS version of SafeBrowsingService, which handles creating and initializing a SafeBrowsingDatabaseManager, and also handles starting and stopping the database manager depending on the value of the Safe Browsing opt-out preference. Behind the kSafeBrowsingAvailableOnIOS flag, this creates a SafeBrowsingServiceIOS owned by ApplicationContextImpl and initialized during IOSChromeMainParts::PreMainMessageLoopRun. Change-Id: I5eaf3ee1a92ab55ef84eb38936a4818a246f6df9 Bug: 1028755,1049327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044521 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#748268}
-
Stepan Khapugin authored
Moves isTabSwitcherActive, dismissingTabSwitcher to SceneController. Bug: none Change-Id: If90fd2ee706f42a57433beabc3d564058bada511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087401 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#748267}
-
Vasiliy Telezhnikov authored
This CL removes restriction for ext_srgb_write_control for WebGL context types. While extension is not supported in WebGL underlying context might and the GL_FRAMEBUFFER_SRGB must be restores in this case. Bug: 1019787 Change-Id: I9d06b70d6fc712cdfd68f068a68eceaed72166eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091600Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#748266}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I948f68fb5e7487a072617ed07911fd4d4213f6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094302 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748265}
-
Friedrich Horschig authored
This CL updates the status according to native events instead and queries the status initially. This enables continuous updates (e.g. during or after a password check). Bug: 1047726 Change-Id: I075a56b4713782cc1df782b93d3569946e8d9ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089769 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748264}
-
Andrew Grieve authored
This will let GN validate that deps are not missed. Note: deps->public_deps needed in order to appease GN's "do you depend on the targets that produce your inputs" check (you can directly depend on them, or indirectly when listed as public_deps). Bug: 1054892 Change-Id: I1f5c752590a259cb932a6ccdf5cf61cbf33d45f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088804 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748263}
-
Rainhard Findling authored
* Sync extension state names within safety check (see also crrev.com/c/2091353) by using "blocklisted" for potentially problematic extensions. Bug: 1015841 Change-Id: Ib93054834ae8b86c81d2725e1d6d2da70c6bf9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095006Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748262}
-
mark a. foltz authored
The Cast SDK expects a MEDIA_STATUS message with an IDLE player after stopping media. This updates the Cast MRP to send it. Bug: 1040185 Change-Id: Ieae8f30906026d2c9d067aecc31a61bcf9027eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087700Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748261}
-
Andrey Zaytsev authored
Bug: 1059753 Change-Id: I6c36d8729372fb93d35f73c214cf7c253139cd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095067 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748260}
-
Mason Freed authored
The [1] CL attempted to change the focus ring to #005FCC, but ended up actually changing it to #CC5F00. Because there are no tests (until [2]), this got missed. This CL fixes that. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2088296 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1986972 Bug: 1054813 Change-Id: I0eb848a99efd8d3e99f75ab5335e3453c63ab202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092412 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748259}
-
Monica Basta authored
As part of friendly settings, the title of the Advanced sync page is changed. Bug: 1043122 Change-Id: Ifd98b613907916f7547e310c1d6c2b8788dfe537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093478Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#748258}
-
Takashi Toyoshima authored
Mark as [ Failure ] for now, but bisect and triage would be needed later. NOTRY=true TBR=yhirano@chromium.org, yoichio@chromium.org Bug: 1059776 Change-Id: Icb51c2af1314e2991528d935993144aa4b67d05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093969 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748257}
-
Scott Violet authored
This reverts commit b256ed1f. Reason for revert: I'm hoping reverting this and your other patch will fix the flake. Bug is here: https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 Original change's description: > Better registry cleanup in InstallServiceWorkItemTest. > > mini_installer_tests ChromeUserLevel and ChromeUserLevelUpdate are > failing with the following error: > > AssertionError: In state 'chrome_user_installed_not_inuse', Registry key > HKEY_LOCAL_MACHINE\Software\Chromium exists. > > This is most likely due to the change I made in change 2086353 to delete > a value instead of the key. > > Now the test will delete the key if the test is the one that created the > key in the first place. > > Bug: 1059314 > Change-Id: I2b85e1f4c979c52a41aebb41c4951b60cf58a50a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092939 > Commit-Queue: Greg Thompson <grt@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Auto-Submit: S. Ganesh <ganesh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748062} TBR=ganesh@chromium.org,grt@chromium.org Change-Id: I875c730322f5bc4cc9fdfa8b5497e26f2b8b81da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095201Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748256}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/424d28b0701d..c27e70235ff5 git log 424d28b0701d..c27e70235ff5 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 borenet@google.com [infra] Overhaul gen_tasks_logic Created with: gclient setdep -r src/third_party/skia@c27e70235ff5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I979f73daad7d5e5b3f12f038c86ae6a642fe3a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748255}
-
Yann Dago authored
When the user deletes browsing data, snapshot files are deleted if they are in relation to the deleted data. Prefs are deleted if one of the deleted data also affects the prefs. Snapshotted data created before the start of the time range where browsing data is deleted will not be affected. Bug: 1052788 Change-Id: I560a844183905a58cdab2c2266869dd91c5b0f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066564 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#748254}
-
Anna Malova authored
Bug: 1007815 Change-Id: Icae708380d0ac98643e6620e2d593a240e6872ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089786 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#748253}
-