- 13 Jul, 2020 40 commits
-
-
Scott Violet authored
And some minor changes for markdown. BUG=none TEST=none Change-Id: I4ff852ae6e24bfe035ada7671d0876eaa8bc6e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285284Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#787726}
-
Kevin Ellis authored
The patch adds a section documenting the web animation model with an example that illustrates the evaluation process and with links to relevant snippets of code. Change-Id: I3f2ae25869e8de7941dbe0b725b0c33a79cde0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293218Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#787725}
-
Sebastien Marchand authored
Change-Id: I9f9b477b2d2fbad916c6366315638576f08f87b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292490Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787724}
-
Richard Knoll authored
This adds support for receive progress notifications in addition to send progress ones. Bug: 1102348 Change-Id: Ie6dcfc7d1dee02c6ee190e6511f67284cef89c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292221Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#787723}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c28f64b4b6d0..7ebe48cd83a3 2020-07-13 tvanderlippe@chromium.org Cleanup indirection of data_deps in devtools_all_files 2020-07-13 tvanderlippe@chromium.org Move front_end html_entrypoints to data_deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4404750bd70f67abf48cf1fd3c91c4e606235b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787722}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7d22cca0b49f..7e7bc3075505 2020-07-13 treehugger-gerrit@google.com Merge "Allow to statically link heapprofd into client." 2020-07-13 ddrone@google.com Merge "Add .ccls to .gitignore" 2020-07-13 lalitm@google.com Merge "ui: fix annotation slice selection" 2020-07-13 lalitm@google.com Merge "traced: implement lifecycle events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If596e1ef7fc5a14c489cdb4a630749913939f55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294913Reviewed-by:
-
Leonard Grey authored
Per her request: https://chromium-review.googlesource.com/c/chromium/src/+/2267646 Bug: None Change-Id: Ib86e37f02c1be226d38edbf03e0b85c8e533ba36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276293 Auto-Submit: Leonard Grey <lgrey@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#787720}
-
sandromaggi authored
Resolve the state name from the abbreviation to be available for patterns. Bug: b/159309560 Change-Id: Idaabfb39f6f2b064df8ac02aa553b579730ff802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294799 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#787719}
-
Colin Blundell authored
This CL moves //chrome's behavior of warning the user when they are about to leave incognito mode via an external intent down into //components, thus having WebLayer benefit from this behavior as well. Bug: 1063399 Change-Id: I03b2905b06de1d2eae536ee2fb73037c44f58900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287293Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#787718}
-
kylechar authored
ericrk@, fsamuel@ and samans@ are no longer working on Chrome and not actively reviewing code. Remove them from relevant OWNERS files to avoid confusion on reviews. Bug: none Change-Id: Ica8d3ba211be52091eeac3cecee7580be58c9954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292828Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#787717}
-
Jorge Lucangeli Obes authored
Added in Chrome OS in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2284454. BUG=1102940 TEST=validate_format.py, pretty_print.py Change-Id: I348fbc36969939387d1c4b3f7a6df06b16981a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289950 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#787716}
-
Mugdha Lakhani authored
Move the tests that verify NoStatePrefetch behavior around fragments from PrerenderBrowsertests to NoStatePrefetchBrowserTests. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I39942e88cab7be78aa1aef09d7fafab8cabaaab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279999 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#787715}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1a3a2b6a9111..f3f891c51471 2020-07-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 94f1ce331e85 to 04c82ec6f36f (9 revisions) 2020-07-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 5aaa0c2bc821 to 4e13c90944e9 (7 revisions) 2020-07-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 145050bf2b98 to d704d1bc0e11 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I140222f924df4ff3c7c3d4783595a677b29a3975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294907Reviewed-by:
-
Rohit Rao authored
These tests attempt to create an __NSCFURLSessionConfiguration, which is no longer available on iOS 14. BUG=1102903 Change-Id: Ifb6f2e0555c3bbd7e595384959c7756033ea003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295079Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#787713}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594619844-912178519bb1004852ab23f2e1c1769d435241f8.profdata to chrome-mac-master-1594640123-ecf0c679b64f8e063828d3c68ecfae268f1bc244.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia76c43f98ece57afcfc309be335a2e68a6e54040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294912Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594626787-c7e74c2484b154ae117dace4298db4630d2504b7.profdata to chrome-win32-master-1594629784-da8b390fd981475e55c5716b256e0384d0033bc0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com Change-Id: Id7c94b91f098e177475f4c40f51eedf28e8db68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294903Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f060a9f9. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ie1c43271dc73af1bfec27ddd65314b3e2099bc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293202Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787710}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I449e8e7a35043a4dac127bd18607bbce47b4302e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294348Reviewed-by:
-
Friedrich Horschig authored
If the local password check is available, all android dialogs should open that page first before redirecting to the account checkup. Bug: 1102391 Change-Id: Id7912b510ba1a3381a0c783ab1a42555b62cc3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292278Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#787708}
-
Omer Katz authored
This CL strongifies weakly held references for the current GC. Bug: 1104619 Change-Id: Icdabad7bab53ff86d8156893a4221a1f716b89c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294663 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#787707}
-
Omer Katz authored
This CL sets kCanTraceConcurrently for VectorBackedLinkedListNode according to its ValueType. The CL also resolve a data race caused by moving element in the vector. Moving an element uses the copy constructor. The race is caused by writing to the value stored in the element (of type VectorBackedLinkedListNode), which uses the value's copy constructor. If that type is a Member<T>, the copy constructor uses non-atomic writes. The new construct traits override this behavior for garbage collected types and replaces it an atomic memcpy. This is needed for concurrently marking NewLinkedHashSet. Bug: 986235 Change-Id: I3758bcd4fe1090b8ef452711ea052113a2324be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292215Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787706}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4bf640308b98..c28f64b4b6d0 2020-07-13 mathias@chromium.org Fix final stylelint issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ff137a4dbf2935cf902bf8221ea98cd32fb6878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294902Reviewed-by:
-
Ravjit Singh Uppal authored
Scheme wildcards are now allowed for exceptions defined for Plugins. Updated the error message to reflect the change. Bug: 1073883, 1104815 Change-Id: I90827b7a9f5117afa0c232323fc7a608436aebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292434Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#787704}
-
Joel Hockey authored
When running linux-chromeos, we need FakeConciergeClient to act like a the real Concierge particularly when the Recovery dialog is shown. Bug: 1092657 Change-Id: I29cb39fc7c1a9377521932333f46452151c1793c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291823 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#787703}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb5b460e9d7c..91d4008f64e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mamir@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mamir@google.com Change-Id: I398e09d2c18c7a3fb30edcb727a373669dc59e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294496Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787702}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5799f5befeab..f5add0b20d2a 2020-07-13 johnkslang@users.noreply.github.com Merge pull request #2337 from KhronosGroup/revert-ANGLE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I5596467d9e9925489d7d01df1e3e42a157005a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294899Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e476030..9329d030 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0052b1f2409c215a485b4b25cf03b063f3da9bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294554Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787700}
-
Eric Seckler authored
This is a reland of 3c1f99e3. With fix of android x86 compile (diff from PS1). Original change's description: > chrome/android: Record battery capacity drain into UMA > > Adds AndroidBatteryMetrics to chrome/android, which track changes in > remaining battery capacity levels while Chrome is in foreground and > the device is on battery power. The deltas are reported into a > cumulative UMA histogram. so that we can reconstruct per-user daily > battery drain in the dashboard. We also report per-30-second drain > values to facilitate using battery drain as a trigger for field tracing. > > Test: Run Chrome locally (Pixel 4), check chrome://histograms. > Bug: 1102048 > Change-Id: I77aa38d9926b155633a8e6d81f46062ff26dccbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281181 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787200} TBR: avi@chromium.org, thakis@chromium.org, bcwhite@chromium.org Bug: 1102048 Cq-Include-Trybots: luci.chromium.try:android_compile_x86_dbg Change-Id: I794a49c1d220158f7f64cc15bd547ad1cefe777b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294803 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#787699}
-
Anna Malova authored
Bug: 1085115 Change-Id: I94ff2e0119506eee8b954845c80a75b88e5cf861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270149 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#787698}
-
Richard Stotz authored
The return type of read and write are unsigned int64. Bug: 914488 Change-Id: I701df2e457988c0bd7db9b8c63bcf96d1e37c2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292474 Commit-Queue: Richard Stotz <rstz@chromium.org> Auto-Submit: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#787697}
-
Maksim Ivanov authored
This adds an integration browsertest for the login-screen functionality of logging in as an existing user via a smart card. The most important bits covered by this test: * loading the user's public key from the Local State; * the challenge-response "start" button on the user pod; * the login-screen views-based PIN dialog. Bug: 1033936 Change-Id: Iea995ff7260d9ae00e0f5b9d80603fe140af7a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289411 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#787696}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594619844-d5053288f580f604630f8165bdd4c71186bbf354.profdata to chrome-win32-master-1594626787-c7e74c2484b154ae117dace4298db4630d2504b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I882739ff2ac6b7f1a91a0f0fc00c13e27ee7d2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294731Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6ef441ecad8e..7d22cca0b49f 2020-07-13 treehugger-gerrit@google.com Merge "Added custom OutOfMemory error window" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie6d90bdad03ba83d49d8dc0017e6335dc719b4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294495Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ef4cb58b72bb..4bf640308b98 2020-07-13 jacktfranklin@chromium.org Create {copy_sources,copy_gen}_to_resources gni helpers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2644926183b5a988b03d608a12deb422746b4690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294730Reviewed-by:
-
sandromaggi authored
The navigation action can break scripts, because its navigations are not declared as |is_renderer_initiated|. This can break in PROMPT (long standing issue) and now also breaks in RUNNING after crrev/c/2283342. Bug: b/160948417 Change-Id: I9f165547ff31c314e928a2bbf48e549cae8941ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292470 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787692}
-
Hiroki Nakagawa authored
To remove the following legacy IPC messages, this CL introduces ContentSecurityNotifier mojom interface. - FrameHostMsg_DidRunInsecureContent - FrameHostMsg_DidDisplayContentWithCertificateErrors - FrameHostMsg_DidRunContentWithCertificateErrors This new interface (and the legacy IPC messages) is used for that a renderer process notifies the browser process of errors related to mixed contents and certificate errors. [BEFORE THIS CL] The legacy IPC messages were sent from RenderFrameImpl for frames and from WebWorkerFetchContext for dedicated workers to WebContents. These were not sent for shared worker and service workers because the messages were routed to the ancestor render frame host but those workers do not have the concept of the ancestor render frame. [AFTER THIS CL] The new IPC messages were routed via ContentSecurityNotifier mojom interface. This interface is used only when an error happens so it is lazily created. For frames, ContentSecurityNotifier is created and owned by DocumentLoader. For keeping consistency with workers (see below), this could be done by FrameFetchContext, but it is not feasible because the notifier can be used for navigation before context creation. For workers, ContentSecurityNotifier is created and owned by WorkerFetchContext. The notifier is created for shared workers and service workers, but the pending receiver is simply ignored in the browser process for the reasons mentioned above. See also comments in BrowserInterfaceBinder. Bug: 1093940 Change-Id: I527c7da08bda24aedac53dfcef41a9f1e42ee8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274818Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#787691}
-
Maksim Ivanov authored
Add the missing accessible name for the PinRequestView's input field (i.e., the Textfield owned by FlexCodeInput). Also fix the focus behavior to be only allowed for the input field itself, not for its parent (i.e., the Textfield instead of the FlexCodeInput). Without this fix, the a11y DCHECK complained that there's a focusable control without an accessible name set. This was caught thanks to the DCHECKs in the AccessibilityChecker. Bug: 1001288 Test: run the browser_test from CL:2289411 with dchecks enabled Change-Id: I8fa46004b8835f6d1d0afb19e5977ae61fc58240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290151Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
Reupload of bookmarks may lead to undesirable behaviour like uploading of bookmarks without favicons or uploading removed bookmarks in some corner cases. To prevent this it is better to disable the feature by default until all known issues are fixed. Bug: 1061411 Change-Id: I92840f9e95c1bb974fd1e661a440354be13aff44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292218Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#787689}
-
Yutaka Hirano authored
At [1], we introduced one round trip in Worker creation to get the parent COEP value, but it led to a regression for worker creation from a blob URL in a page with local schemes such as file://. As file:// resources always have empty COEP, call DedicatedWorker::OnHostCreated synchronously and remove the round trip. 1: https://crrev.com/8007a3d5e289c8b8d31dad0a0ccae09ead4556d2 Bug: 1101603 Change-Id: I17b8283983113d5fa95ec3149a28481dff936fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286094 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#787688}
-
Side Yilmaz authored
This CL replaces |ImageFetcherFactory#createImageFetcher| functions in QueryTileSection by using newer function with profile parameter. Today, image fetcher is created with regular profile always, even in incognito mode. By this CL, QueryTileSection will create image fetcher with the profile coming via constructor. Bug: 1041781, 1083923, 1075562 Change-Id: I1ececf86263547cf84246456c3a4fedfc9550f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279530Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787687}
-
