- 28 Nov, 2019 40 commits
-
-
Michael Ershov authored
Create certificite via net::CertBuilder to avoid flakiness. Bug: 877416, 787602, 1028183 Change-Id: Ibd62d293ed795a25961b3789ebaa6dc299339b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937071Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#719915}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53493ff38604..cbbafc60ae10 Created with: gclient setdep -r src-internal@cbbafc60ae10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I9ec8d97e58c40140b5b327ee07cdbf1cb44ca7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719914}
-
Balazs Engedy authored
CrowdDenySafeBrowsingRequest interfaces with Safe Browsing to fetch whether a certain origin is known to show unsolicited notification permission requests to users. Bug: 1028642 Change-Id: I9942350500e88115b0d2f42954222423d0eddd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940253 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719913}
-
Alex Clarke authored
Startup.BrowserMessageLoopStartTimeFromMainEntry3 UMA is needed by androidStartupMetric. This patch wires that up. Bug: 1027736, 1022812 Change-Id: If7c7ef8efcd5557e9cd2a15ebf7950d0a8e46ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932547Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#719912}
-
Hitoshi Yoshida authored
Implements Trace() method. Change-Id: Ib32779b94e16dc824cf075cbb995664f19f5820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941461 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719911}
-
Alex Ilin authored
This CL updates all deprecated methods of base::Value and base::JSONReader in OAuth2MintTokenFlow to use recommended APIs. Bug: 1026237 Change-Id: I4e15970bc6215b74c9d4cea2d96f0923e1c7b878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940177Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719910}
-
Alexandre Courbot authored
The V4L2DevicePoller was silent up to now, but knowing what it does is useful to debug issues. Add a few logs at the relevant places. Bug: None Test: Chromium builds for Kukui. Change-Id: I52494e32a89a24fab5e5cad4937e8bceaa8ed5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939996 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719909}
-
Rune Lillesveen authored
There is no repro for this and I haven't been able to find a shorthand that is not handled in shorthandForProperty(), or has a length > 17, but if there is one, we might end up crashing in CommonShorthandChecks since we both write to a stack array that has a fixed length of 17 and we also access longhands[0] without checking if we have a non-zero length. Bug: 1026569 Change-Id: I86bc71947dbd663be9a96a73404f29b737f49266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939797Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#719908}
-
Andreas Haas authored
Again I added a checked getter of return type unsigned for legacy code. We will replace uses of that getter eventually. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I29176e012f3e56fe60fa41668b4e7791b1f62e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932549Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719907}
-
Takashi Toyoshima authored
These entries are not in NeverFixTests any more, and probably some checks in these tests are failing with OOR-CORS. Let's remove these entries, and see how it goes. Bug: 870173 Change-Id: I33476e255a4c304b0ca98f0bf99b5d512928677c TBR: yhirano@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941463Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#719906}
-
Takashi Toyoshima authored
Update expected failure that is caused by a new virtual test. Change-Id: I824d96591aa4c0752a710a9b1591746ddb6b062a TBR: yhirano@chromium.org NOTRY: tue Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941648 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Christopher Lam authored
This CL plumbs the Chrome OS semantic colors into cr-radio-buttons similar to http://crrev.com/c/1925834. To test, go to chrome://os-settings and type $$('html')[0].style.setProperty( '--cros-default-button-color-rgb', '255, 0, 0') into DevTools which should change the color of all radio buttons on the page. Bug: 1018654 Change-Id: I31bcca35d5b0d21d4f3dcf1adead86314647da12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935569Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#719904}
-
Alexey Baskakov authored
Add proper constness. Change ReadIconCallback signature to return `const SkBitmap&`. These changes are required for the integration with AppService. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 1029221 Change-Id: I4ec06716014686c607ea86da864efe017b0ad585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941458 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#719903}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8ebb625d7f4..53493ff38604 Created with: gclient setdep -r src-internal@53493ff38604 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I71a271260a6a5f1729a3f8673b9a367c8d11e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941568Reviewed-by:
-
Fergal Daly authored
These tests are newly added and failing. Bug: 1029248 Change-Id: I5d9860183de06b876d76a87de06badfd31c4179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941647Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#719901}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I91319a95211eceefbbbf1353f1449094f1ca2640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939162Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#719900}
-
Hayato Ito authored
ServiceWorkerTimeoutTimer is using std::set, which is banned in Blink. See the bug 1028982 for the details. This issue is rising in https://crrev.com/c/1906452/. We are renaming ServiceWorkerTimeoutTimer to ServiceWorkerEventQueue there, however, the renaming triggers presubmit warnings for existing usages of std::set. So I've decided to remove the usage of std::set in this CL. Since there is no std::set equivalent in WTF, we have to compromise. |id_event_map_| and |inflight_events_| are now merged, and the code became simpler. Regarding the performance impact, I think it's okay because UpdateStatus() is not called frequently. BUG: 1028982 Change-Id: I9f1c5a141d755772b5c96acb313a6c5fe3f27374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939161Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#719899}
-
Koji Ishii authored
Following r719562 <crrev.com/c/1937953> that moves the logic for |NodeForHitTest| from |NGPaintFragment| to |NGPhysicalFragment|, this patch removes the function and all references to it. Bug: 982194 Change-Id: Ie43a51a22e829249a9ef21791d42c1e3a702e06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941456Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719898}
-
Yoshifumi Inoue authored
This patch introduces next for same layout object cache in |NGFragmentItem| to make following functions faster: - NGInlineCursor::NextForSameLayoutObject() - ItemsForLayoutObject::Iterator::operator++() Once we utilize |NGInlineCursor| for all |LayoutObject::FirstInlineFragment()| usages[1], following patch will make following functions to utilize cache: - NGInlineCursor::MoveTo(const LayoutObject&) - ItemsForLayoutObject constructr [1] https://bit.ly/2MSgvxN List of FirstInlineFragment() usages Bug: 982194 Change-Id: Id34e08b0b87d9471058ee5899b0fbe6e591883f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930370 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719897}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I0579f908410d0c45eab45af9818262a853427e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941086Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719896}
-
Austin Tankiang authored
This mimics how cros-disks does external drive label validation. See http://crrev.com/c/1697542 for the cros-disks change. Bug: 983044 Change-Id: I460523bc7a3856a94328160b992052b700744d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941454 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#719895}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4c5faa87b84..e8c96d8e6116 git log f4c5faa87b84..e8c96d8e6116 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c373dfd84194..fc3ec57ddf27 (13 commits) 2019-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c493edcc..43fc40ae (368 commits) 2019-11-28 herb@google.com Reland "Naive CPU large emoji" Created with: gclient setdep -r src/third_party/skia@e8c96d8e6116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: I231dd349af899bab11337895bd1788b4616cede5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941567Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719894}
-
Andreas Haas authored
This reverts commit 22d5de04. Reason for revert: https://crbug.com/1028766 TBR=haraken@chromium.org Original change's description: > [arraybuffer] Allow transfer of empty ArrayBuffer > > With a recent change, ArrayBuffers are allowed to have nullptr as their > `Data` pointer. However, a condition in ArrayBuffer::Transfer bailed out > if Data() was nullptr. I changed the condition now, and added a test. > > R=haraken@chromium.org > > Bug: chromium:1027937 > Change-Id: I2fe466bcfe016d850f11211f2ef8104f1f27d41f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932791 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719113} TBR=haraken@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1027937 Change-Id: Ief03dde1bc2c92264a55aa1082da537fca589047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939982Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719893}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81668204..d9cce7d1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c6f0d5366e3c8a5c194ba6d6d0806810ee2bdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940138Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719892}
-
Joel Hockey authored
GetTerminalId will return the old terminal ID or the new Terminal System App ID if the feature is on. This allows the new Terminal app to have the same launch and shelf context menu items. ExtensionApps is modified to not register TerminalSystemApp since it will be registered as a crostini app by CrostiniRegistryService. This will change once System Apps support hiding apps. See crbug.com/1028898 Added on_initilized() OneShotEvent to AppListSyncableService so that callbacks can be registered to run after initialization. CrostiniRegistryService::MigrateTerminal removes old terminal from registry and registers on_initialized() callback with AppListSyncableService to copy attributes from old terminal to new. MigrateTerminal will be removed after a few releases once the TerminalSystemApp feature is removed. Bug: 1019021 Bug: 1028898 Change-Id: Ic35488bf8606a17a8806925dfa31ed0310cc9367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925833 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719891}
-
Koji Ishii authored
Also fixes a DCHECK that incorrectly hits. Bug: 1028817 Change-Id: I43cb472031f4d3842eb302a5460e6dea047120e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941451Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
V4L2MemoryToString() returns a string constant, so change its type to const char* to save some processing and make it more generic. Bug: None Test: Chromium builds and runs for Kukui. Change-Id: I4cab66813e702493cbbce52a9956021dfdb4e818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939997 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGUseElement> and DynamicTo<SVGUseElement> as new downcast helper 2. Use IsA<SVGUseElement>(element) in place of IsSVGUseElement(element) Bug: 891908 Change-Id: Iaee4699208b6af8813ff110c385a729496b8e402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936688 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719888}
-
Yutaka Hirano authored
...due to flakiness Bug: 1029233 Change-Id: I40199a93dfe2ae3a344cc663930beeaebad87607 Tbr: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941453Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#719887}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a5262fb3c246..a8ebb625d7f4 Created with: gclient setdep -r src-internal@a8ebb625d7f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I4b0e72e4a6f36ec04fbbadec9a977540024ecd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941085Reviewed-by:
-
Alexandre Courbot authored
All operations on the V4L2 device should happen in the device thread. Make sure our reference to the V4L2 device is discarded there so its destructor can be called in the proper thread. Bug: None Test: VEA unittest builds and runs on Kukui in debug mode. Change-Id: I763389e7bd2946b6ff89f8dffd1e13d7fdd8211c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939995Reviewed-by:
-
Kuo Jen Wei authored
Remove usage of browser view which function as gallery app on non ChromeOS platform. Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I0f0c164e0a36385b4f843d2c11812e24773c492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939149 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
-
Jeremie Boulic authored
When the menu storage menu item had the focus, the color of the background was too similar to the color of the "available size" bar. Colors from UX: Used storage bar: Grey 600 #80868B Available storage bar: Grey 700 #5F6368 30% opacity Bug: 944747 Change-Id: I62c56e0388f3c9acb09d9046e0b7ab42ea2959c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940326Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719883}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. Before this CL, ServiceWorkerContextCore manageed pairs of client UUID and a rawptr to ServiceWorkerProviderHost. This pairs were mainly used for collecting service worker client information. After this CL, ServiceWorkerContextCore manages pairs of client UUID and a rawptr to ServiceWorkerContainerHost. ServiceWorkerContainerHost is designed as a source of truth of a service worker client, and is more appropriate than ServiceWorkerProviderHost here. See the design doc for details. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Change-Id: I80fbf281c71670ef9edc12d5468ad27c9bd0b2c3 Bug: 931087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939157Reviewed-by:
-
Anand K. Mistry authored
Bug: 1007832 Change-Id: Icff60c942f7a0c7201f8b166e9b20d5a6d677737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930359Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#719881}
-
Jiewei Qian authored
Use flat_map::at() introduced in https://crrev.com/c/1933849 to replace find()->second, so the code reads easier. Change-Id: I4f4e04da30e6c7bb7b8f2a2f9a7e582755295b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939994 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes {Next,Previous}OnLineInlineNG() for AXLayoutObject to utilize |NGInlineCursor| for preparation of migrating to |NGFragmentItem|. This patch also introduces |NGInlineCursor::CurrentMutableLayoutObject()| to reduce using |const_cast<LayoutObject*>()|. Bug: 982194 Change-Id: I36d5d76b266968824ecd029851737e45c740f839 Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930243 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73beaaa48fcc..f4c5faa87b84 git log 73beaaa48fcc..f4c5faa87b84 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 663dcefa22ea..d6e903bdc9ef (4 commits) Created with: gclient setdep -r src/third_party/skia@f4c5faa87b84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: If976504affe80d43c2bdc75e13ff4f03f3b53e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941081Reviewed-by:
-
Eric Willigers authored
BrowserNonClientFrameViewAsh::UpdateFrameColor() now includes a call to the base class implementation. On ChromeOS only, if a web app set a dark theme using HTML (as opposed to a web app manifest), web app toolbar controls such as the three dot menu did not appear as white - instead they remained dark and unreadable. Now we have consistency between platforms, and between using HTML or the manifest to set the theme color. Bug: 1028484 Change-Id: Ie222e5986cebfbca533a2cd053f9347336e2b724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940324 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#719877}
-
Greg Thompson authored
FakeAutocompleteProviderClient points an InMemoryURLIndex and a HistoryService at a ScopedTempDir that it owns. It must wait for each of them to fully process a Shutdown before it can reap the temp dir. BUG=546640 Change-Id: I4573fd3566bddbb75aec756c2ef57a2eb04e8d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940151 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719876}
-
