GitLab

Revert of Revert "Typecheck JS files for chrome://extensions" (patchset #1 of https://codereview.chromium.org/508283002/)

Reason for revert:
fixed check_licenses issues

Original issue's description:
> Revert "Typecheck JS files for chrome://extensions"
>
> This reverts commit 405253b7.
>
> Caused a liscene failure on android bot:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/87b3206

TBR=vitalyp@chromium.org,eroman@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/512003002

Cr-Commit-Position: refs/heads/master@{#292229}

When the window is not snapped, user resizes should always clear restore
bounds. This allows user initiated resizes to not be unexpectedly
ignored.

BUG=405563
TEST=WorkspaceWindowResizerTest.RestoreClearedOnResize

Review URL: https://codereview.chromium.org/477823003

Cr-Commit-Position: refs/heads/master@{#292228}

The surface aggregator should keep track of the last frame from each surface that was aggregated, and use that to determine what the appropriate damage rect is for the next aggregation.

BUG=
TEST=chrome --use-surfaces --disable-gpu

Review URL: https://codereview.chromium.org/506273002

Cr-Commit-Position: refs/heads/master@{#292227}

Command used: for f in `find ui -name *.grd`; do echo GRD: $f; ./tools/unused-grit-header.py $f android_webview apps ash cc chromecast chromeos content chrome extensions gpu media pdf printing remoting webkit; done

Review URL: https://codereview.chromium.org/515433002

Cr-Commit-Position: refs/heads/master@{#292226}

Having the views observe these notifications is strange -- they don't know when
page actions are updated in any other ways, so they shouldn't need to know for
this. Move the notifications to LocationBarController.

Bonuses:
- Less code! By 50 lines!
- Remove four deprecated notification uses!

This has a very loose dependency on https://codereview.chromium.org/508563003/.

BUG=407672

Review URL: https://codereview.chromium.org/505373002

Cr-Commit-Position: refs/heads/master@{#292225}

BUG=407833

Review URL: https://codereview.chromium.org/512543002

Cr-Commit-Position: refs/heads/master@{#292224}

BUG=400760
NOTRY=True

Review URL: https://codereview.chromium.org/453713002

Cr-Commit-Position: refs/heads/master@{#292223}

If we're going to make mojo a write-once-run-anywhere platform, we'll
have to smooth over platform differences in event handling. Currently,
we have code that tries to emulate this behaviour at different levels
of the chrome stack on Linux. This emulation code lead to the double
character insertion bug on Windows: things looked fine on Linux
because we had another hack to cover up the lack of character events,
which just caused double character insertion on Windows.

In this patch, we declare the Windows style of events (a keydown,
a translated character event, a keyup) as canonical and what
should be targeted going forward.

BUG=403514

Review URL: https://codereview.chromium.org/476283006

Cr-Commit-Position: refs/heads/master@{#292222}

Instead, encode null as NULL (and not just any falsy value) via
a == comparison with null (and use ==, not === to treat undefined
the same way as null).

BUG=407258

Review URL: https://codereview.chromium.org/511443002

Cr-Commit-Position: refs/heads/master@{#292221}

This change attempts to fix a flaky test by changing the KeyPress function to
use SendKeyPressAndWait which will wait for an event. The event that this test
will wait for is the focus change event that should get called when an element
in the web form changes focus.

BUG=405711

Review URL: https://codereview.chromium.org/503863002

Cr-Commit-Position: refs/heads/master@{#292220}

TBR=eroman@chromium.org
BUG=none
TEST=green tree

Review URL: https://codereview.chromium.org/492623005

Cr-Commit-Position: refs/heads/master@{#292219}

Revert of Revert "TestWebServer needs to use a free port." (patchset #1 of https://codereview.chromium.org/514443002/)

Reason for revert:
I will land the following CL to fix the findbugs warning
https://codereview.chromium.org/513583002/

Then I will revert the revert.

Original issue's description:
> Revert "TestWebServer needs to use a free port."
>
> Causing Android Build (dbg) findbugs to fail.
>
> This reverts commit c4a3f88c.
>
> BUG=none
> TBR=hush
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/b055d91

TBR=ajwong@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/512573002

Cr-Commit-Position: refs/heads/master@{#292218}

For the actual changes, see:
https://codereview.chromium.org/506203004/

R=tomfinegan@chromium.org
TBR=tomfinegan@chromium.org
BUG=https://code.google.com/p/webrtc/issues/detail?id=3747

Review URL: https://codereview.chromium.org/513593002

Cr-Commit-Position: refs/heads/master@{#292217}

Note that the LOCATION_CHANGED event isn't explicitly handled, it just gets mapped to a WINDOW_CONTENT_CHANGED event on Android.

BUG=407871

Review URL: https://codereview.chromium.org/510513003

Cr-Commit-Position: refs/heads/master@{#292216}

Due to how the browser plugin is created, it is possible for the
<extensionoptions> element to attempt to attach to the embedder before
the browser plugin has bindings. This occurs when an ExtensionOptions object
gets an extension id and creates a guest, but has not yet been added
to the DOM. Use the deferred attach logic from <webview> so that if this
case occurs, wait until the browser plugin gets its bindings before
trying to attach the guest view.

BUG=386838

Review URL: https://codereview.chromium.org/457653003

Cr-Commit-Position: refs/heads/master@{#292215}

The ReST URL was bad, and somehow it started parsing differently, maybe because I have a newer version of the ReST parser.

TBR= binji@chromium.org, sbc@chromium.org
TEST=none
BUG=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/504343006

Cr-Commit-Position: refs/heads/master@{#292214}

Please let me know if I'm missing anything on the release notes.

Some other files updated, they seem to have been forgotten by previous commits.

R=dmichael@chromium.org, jmedley@chromium.org, binji@chromium.org
BUG= none
TEST= none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/477203002

Cr-Commit-Position: refs/heads/master@{#292213}

BUG=305280
NOTRY=True

Review URL: https://codereview.chromium.org/512453002

Cr-Commit-Position: refs/heads/master@{#292212}

This will make the SDK archive step upload to the correct URL for trunk builds.

No tries because this does not affect the Chrome build.

BUG=none
R=bradnelson@google.com, bradnelson@chromium.org
TEST=ran locally

Review URL: https://codereview.chromium.org/510133002

Cr-Commit-Position: refs/heads/master@{#292211}

If any EC_KEY with EX_DATA is duplicated, whether or not it is one of ours,
ExDataDup may get called. This is unlikely to ever happen (I don't think
we ever dup any EC_KEY on the client, and dup_ex_data has a fast-path if
the EX_DATA has never been touched anyway), but the CHECK is a little
overzealous.

BUG=none

Review URL: https://codereview.chromium.org/506813002

Cr-Commit-Position: refs/heads/master@{#292210}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/499903004

Cr-Commit-Position: refs/heads/master@{#292209}

This reverts commit 405253b7.

Caused a liscene failure on android bot:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio

Review URL: https://codereview.chromium.org/508283002

Cr-Commit-Position: refs/heads/master@{#292208}

Revert of Disable slow BootstrapSandboxTest.DistributedNotifications_SandboxDeny (patchset #1 of https://codereview.chromium.org/498193002/)

Reason for revert:
Unclear reason for disable.

Original issue's description:
> Disable slow BootstrapSandboxTest.DistributedNotifications_SandboxDeny
>
> TBR=rsesek
>
> BUG=407066
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/f1bd7f7

TBR=phajdan.jr@chromium.org
BUG=407066

Review URL: https://codereview.chromium.org/508873003

Cr-Commit-Position: refs/heads/master@{#292207}

Review URL: https://codereview.chromium.org/503293003

Cr-Commit-Position: refs/heads/master@{#292206}

Use OAuth2AccessTokenFetcher implementation on Android.  This cleans up the way that AO2TS overrides functionality from the base class to differentiate the way that access tokens are minted, and makes the overriding mechanism for android the same as for iOS.  Its possible to reimplement OAuth2AccessTokenFetcher now that Mihai extended for use in bling.

BUG=390353

Review URL: https://codereview.chromium.org/345703003

Cr-Commit-Position: refs/heads/master@{#292205}

R=vitalyp@chromium.org,tbreisacher@chromium.org
BUG=393873
TEST=cd third_party/closure_compiler && ./tools/compile_coverage.py
NOTRY=true

Review URL: https://codereview.chromium.org/507953002

Cr-Commit-Position: refs/heads/master@{#292204}

Review URL: https://codereview.chromium.org/508793002

Cr-Commit-Position: refs/heads/master@{#292203}

BUG=371463

Review URL: https://codereview.chromium.org/514473002

Cr-Commit-Position: refs/heads/master@{#292202}

Instead, it causes smoothness metrics to have None values. Additionaly,
the smoothness metric in smoothness.py has been refactored to more
easily support (the newly added) unit tests.

BUG=

Review URL: https://codereview.chromium.org/476363002

Cr-Commit-Position: refs/heads/master@{#292201}

BUG=366408

Review URL: https://codereview.chromium.org/504223005

Cr-Commit-Position: refs/heads/master@{#292200}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/509573002

Cr-Commit-Position: refs/heads/master@{#292199}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/505203003

Cr-Commit-Position: refs/heads/master@{#292198}

This enables 1/n-1 record splitting, which we have done with NSS for a
long time. No compat issues are expected with this.

(This does not appear to be a regression from the OpenSSL -> BoringSSL
switch as I don't see that a record splitting patch was previously
included.)

BUG=none

Review URL: https://codereview.chromium.org/508803003

Cr-Commit-Position: refs/heads/master@{#292197}

Review URL: https://codereview.chromium.org/506143003

Cr-Commit-Position: refs/heads/master@{#292196}

BUG=393873
R=dbeam@chromium.org
TEST=gyp --depth . chrome/browser/resources/extensions/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/475633006

Cr-Commit-Position: refs/heads/master@{#292195}

Picked up changes:
078e633 Add support for outputting debug info in result.
0cc1705 Instrument DomDistiller with timing information.
73e3327 rejiggle 1 table classification heuristic

BUG=368941

Review URL: https://codereview.chromium.org/505183003

Cr-Commit-Position: refs/heads/master@{#292194}

BUG=

Review URL: https://codereview.chromium.org/507723002

Cr-Commit-Position: refs/heads/master@{#292193}

https://skia.googlesource.com/skia/+log/4473be874f70d4a8833180a7aebcc9d8a0b1de9e..6b0d6b43cf662735dc804d8142383452c7f246f9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/509053002

Cr-Commit-Position: refs/heads/master@{#292192}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503353002

Cr-Commit-Position: refs/heads/master@{#292191}

BUG=372607

Review URL: https://codereview.chromium.org/501063002

Cr-Commit-Position: refs/heads/master@{#292190}