GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284091 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/384b0202c040034ba1e8f2e3789a01e4b05a6a2b..19eb3b2f0aa6dce5c0335230a8930e90733e5d5d

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/400543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/400133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284089 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/396023003/)

Reason for revert:
Very speculative revert for current XP bots failures (all 3 bots are failing with obscure errors and this is our last suspect in the list...).

I'll reland if that's not it.

Thanks for your understanding!

Original issue's description:
> Change SPACEPARITY in the Windows serial api implementation to ODDPARITY.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284000

TBR=rockot@chromium.org,sammc@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/399353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379967

Review URL: https://codereview.chromium.org/392333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284086 0039d316-1c4b-4281-b951-d872f2087c98

Add EF_FINAL_MODIFIERS to ui::KeyEventFlags to suppress modifier key
remapping on artifical events. This replaces using the X11 send_event
field.

BUG=380349
TEST=EventRewriterTest.TestRewriteKeyEventSentByXSendEvent
R=sadrul@chromium.org,derat@chromium.org

Review URL: https://codereview.chromium.org/394553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284085 0039d316-1c4b-4281-b951-d872f2087c98

Adds WrenchMenuBadgeController which is responsible for notifying toolbar 
UI implementations (i.e. views and cocoa) about how they should be badged. 

Logic is moved from Cocoa and Views toolbar implementations and from 
wrench_icon_painter.cc to this new class. 

This refactor allows to easily expand the functionality of this class to add 
new sources of badging without needing to make the same changes to 
several platform-specific implementations. 

No functional changes. 

BUG=394855

Review URL: https://codereview.chromium.org/395193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284084 0039d316-1c4b-4281-b951-d872f2087c98

Restrict triggering of enrollment recovery to a smaller subset of
DeviceSettingsService status codes just to be on the safe side.

BUG=389481

Review URL: https://codereview.chromium.org/400623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393611

Review URL: https://codereview.chromium.org/406463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284082 0039d316-1c4b-4281-b951-d872f2087c98

SignAndStore method is moved out from DeviceSettingsService to OwnerSettingsService. It's still called by DeviceSettingsService via delegate, but later it will be invoked by OwnerSettingsService::Set().

BUG=230018
TEST=unit_tests:DeviceSettingsService*

Review URL: https://codereview.chromium.org/399613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284081 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284080 0039d316-1c4b-4281-b951-d872f2087c98

(This is a reland of r283813 which was reverted in r283845 because it broke
WebRTC tests on Android. That, in turn, was a reland of of r283542 which was
reverted in r283591 because it broke the WebView build.)

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

BUG=none

Review URL: https://codereview.chromium.org/401613008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284079 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/384023002/

This CL renames ChromeOS-specific code.

Still missing:
- ChromeOS-specific resource IDs (strings and images)
- JavaScript, HTML, CSS
- The global ENABLE_MANAGED_USERS define

TBR=atwilson@chromium.org (c/b/signin)
TBR=nkostylev@chromium.org (c/b/chromeos)
TBR=noms@chromium.org (c/b/profiles)
TBR=oshima@chromium.org (ash and c/b/ui/ash)
All TBRs are simple renamings.

BUG=385113

Review URL: https://codereview.chromium.org/393343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284078 0039d316-1c4b-4281-b951-d872f2087c98

In a componentized world, ThumbnailManager will stay in Chrome and ImageManager will be the interface on which SuggestionsService will depend on.

BUG=387751
TBR=jam
TEST=Suggestions*,ThumbnailManager*

Review URL: https://codereview.chromium.org/392983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284077 0039d316-1c4b-4281-b951-d872f2087c98

This updates the GPU rasterization whitelist to include
under-development Android versions. As of http://crrev.com/282281, 
these are treated as version 4.4.99 for blacklisting purposes.

BUG=394504

Review URL: https://codereview.chromium.org/397143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393149

Review URL: https://codereview.chromium.org/386023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/403573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394028, 385074
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/405613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284073 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284072 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff titzer@chromium.org in case of problems.

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/400933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284071 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284070 0039d316-1c4b-4281-b951-d872f2087c98

Port UpdateHistoryAndBookmarks and UpdateSearchTerms to use a
base::CancelableTaskTracker instead of a CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/368283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284069 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178418:178426&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/400953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284068 0039d316-1c4b-4281-b951-d872f2087c98

Cleaning code that became redundant.

Review URL: https://codereview.chromium.org/384983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284067 0039d316-1c4b-4281-b951-d872f2087c98

The previous minimum size does not fit the controls and the trach icon was
cropped.

BUG=None
TEST=manually

Review URL: https://codereview.chromium.org/398643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284066 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/407493002/)

Reason for revert:
Reverting the revert. This didn't break the tree; it's still broken without the patch. :(

Sorry for the noise!

Original issue's description:
> Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/)
> 
> Reason for revert:
> Speculative revert to fix XP bots.
> 
> XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677
> 
> This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it.
> 
> Original issue's description:
> > Migrate accessibility from RenderView to RenderFrame and RVH to RFH.
> > 
> > In preparation for out-of-process iframes, move almost all accessibility
> > functionality from RenderView to RenderFrame, and from RVHI and RWHI
> > to RFHI.
> > 
> > In addition, the accessibility mode is moved to WebContents, and changing
> > the mode triggers changing it on all frames.
> > 
> > BUG=368298
> > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994
> 
> TBR=dmazzoni@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284032

TBR=creis@chromium.org,nick@chromium.org,nasko@chromium.org,jam@chromium.org,dtseng@chromium.org,jschuh@chromium.org,tsepez@chromium.org,kenrb@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/407493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284065 0039d316-1c4b-4281-b951-d872f2087c98

This CL modifies the LeakDetector to force immediate crash when an
optional commandline argument is specified to content_shell.

Usage:
$ content_shell --dump-render-tree --enable-leak-detection=crash-on-failure

This enables us to use the ClusterFuzz infrastructure to investigate and
minimize leaks, as the tool currently detects the test case pass/fail by
seeing if the process crashes.

BUG=None

Review URL: https://codereview.chromium.org/405433011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284064 0039d316-1c4b-4281-b951-d872f2087c98

It is difficult to reason about the liftime of ObjC classes, especially
NSViews and CALayers. To simplify verifying their correctness, move the
bulk of the code for the ObjC classes into C++ helper classes (these
classes are already necessary to interface with owning structures).

Make the NSView sub-class BrowserCompositorViewCocoa be owned by
BrowserCompositorViewMacInternal.

Move the bulk of the work in CompositingIOSurfaceLayer to be done by
CompositingIOSurfaceLayerHelper, and mark that the ownership
relationship should be inverted (that isn't feasible at the moment
because we are mid-transition from non-delegated rendering to delegated
rendering).

BUG=392919

Review URL: https://codereview.chromium.org/394883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284063 0039d316-1c4b-4281-b951-d872f2087c98

This is used by https://codereview.chromium.org/373223003/

BUG=390600
R=eseidel@chromium.org, stip@chromium.org, hinoka@chromium.org

Review URL: https://codereview.chromium.org/376653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284062 0039d316-1c4b-4281-b951-d872f2087c98

Adds histograms to record the time since a tab was active when:
 - switching to the tab
 - switching to an evicted tab
 - protecting a tab on memory warning
 - evicting a tab on memory warning

Also adds a histogram to show how often users switch to
an evicted tab that was never active.

BUG=385111
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/340113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391005

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282740

Review URL: https://codereview.chromium.org/372243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284060 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Adding a router class to handle messages that expect responses. (https://codereview.chromium.org/371603003/)

Reason for revert:
This appears to have broken mojotest_instrumentation_tests with the errors like the ones listed below.

http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20270

C   52.086s Main  [FAIL] org.chromium.mojo.bindings.ConnectorTest#testErrors:
C   52.086s Main  java.lang.NoClassDefFoundError: java.util.Objects
C   52.086s Main  	at org.chromium.mojo.bindings.MessageHeader.equals(MessageHeader.java:189)
C   52.086s Main  	at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:29)
C   52.086s Main  	at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:39)
C   52.086s Main  	at org.chromium.mojo.bindings.BindingsTestUtils.newRandomMessageWithHeader(BindingsTestUtils.java:85)
C   52.086s Main  	at org.chromium.mojo.bindings.ConnectorTest.setUp(ConnectorTest.java:53)
C   52.086s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   52.086s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   52.086s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C   52.086s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

C   52.091s Main  [CRASH] org.chromium.mojo.bindings.RouterTest#testReceivingViaRouterWithResponse:
C   52.091s Main  Native crash: Segmentation fault

Original issue's description:
> Adding a router class to handle messages that expect responses.
> 
> This also introduce the notion of message header to allow routing.
> 
> R=rmcilroy@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767

TBR=qsr
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/392223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284059 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a test which checks that the flag introduced in https://codereview.chromium.org/353493002/ is interpreted correctly by the SupervisedUserService's implementation of ManagementPolicy::Provider.

BUG=390520

Review URL: https://codereview.chromium.org/401643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284058 0039d316-1c4b-4281-b951-d872f2087c98

Wrapping them silenty breaks the referenced resources. This was broken in https://codereview.chromium.org/384023002/.

dcommitting to bypass the presubmit hooks which refuse the long lines.

BUG=385113
R=pam@chromium.org

Review URL: https://codereview.chromium.org/400653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284057 0039d316-1c4b-4281-b951-d872f2087c98

The database was only used to import a PKCS#12 file. By changing to separate key (PKCS#8 format) and cert (X509 in PEM encoding), only dependencies on the lower level RSAPrivateKey, X509Certificate and PK11_* NSS functions are required.
Note this removes at the same time a call to the deprecated NSSCertDatabase::GetInstance().

Also
- fixes multi profile cases of the unit test and the CA matching (the latter is now identical to all other platforms).
- fixes a bug in the matching of client certs from software slots, because of reused cert database names
- gets rid of the error output that occurred during the PKCS12 import because the file contained also a CA cert:
  [ERROR:nsPKCS12Blob.cpp(219)] Could not grab a handle to the certificate in the slot from the corresponding PKCS#12 DER certificate.

BUG=210525, 329735,315285

Review URL: https://codereview.chromium.org/394013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284056 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284055 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
- Hook up the default v8::Platform implementation to pdfium

BUG=none
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/399473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394788
TEST=manually tested

Review URL: https://codereview.chromium.org/400703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284053 0039d316-1c4b-4281-b951-d872f2087c98

Previously the gallery checks the sequence number to find out whether the update
for canvas size is needed or not.  The sequence number is incremented when
variables that affect canvas size are updated. But sometimes, the
canvas size goes to be out of sync.

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/399383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284052 0039d316-1c4b-4281-b951-d872f2087c98

After this change, sync tasks are erased only when it completes or SyncClient gives up.
This change is preparation for implementing a mechanism to allow CopyOperation to wait for a specific sync task to complete.

In EntryUpdatePerformer:
Add a new error code FILE_ERROR_PARENT_NEEDS_TO_BE_SYNCED.
Return the new error code when the sync task cannot be completed because of the lack of the parent resource ID.

In SyncClient:
Add a new task state SUSPENDED to allow tasks to be in an inactive state.
Add a new member |context| to SyncTask to make it possible to change the context without erasing the task.
OnTaskComplete() takes almost all responsibilities to handle errors. OnFetchFileComplete() and OnUpdateCompleter() are now almost empty or removed.
Handle the new error code FILE_ERROR_PARENT_NEEDS_TO_BE_SYNCED in OnTaskComplete().

BUG=384213
TEST=unit_tests

Review URL: https://codereview.chromium.org/391343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284051 0039d316-1c4b-4281-b951-d872f2087c98