- 29 Jan, 2018 40 commits
-
-
Kyle Horimoto authored
This CL adds an extra StateChangeDetail parameter to the Observer::OnSecureChannelStatusChanged() function. This parameter is currently unused, but it will be used by a future CL to better handle connection retries. Bug: 805218, 672263 Change-Id: I4dc80f324d74a6df54113b058dec0bb07459ae3f Reviewed-on: https://chromium-review.googlesource.com/888038Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#532510}
-
Hannes Payer authored
This CL brings the following changes to promptly freeing and coalescing: 1) Promptly freed objects on already swept pages are immediately added to the free list. 2) For promptly freed objects on not already swept pages we only clear the mark bit. 3) The promptly_freed_size_ counter is explicitly set to 0 before sweeping because sweeping will take care of coalescing as well. 4) The dead bit is removed. Note that coalescing before sweeping completed can not happen. Future outlook: As a next step we will evaluate if we need coalescing and if we need it we have to make it jank friendly. Bug: chromium:804279, chromium:633030 Change-Id: I35dfae80ae0e7ed6cfbc91877d97d0b5fc26498e Reviewed-on: https://chromium-review.googlesource.com/873974 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#532509}
-
Sean Kau authored
Changing the default mode to AllAccess from BlacklistOnly. Changing the default so that we can show printers if the NativePrintersAccessMode policy is unset. Changes to policy_templates.json will be separate. Bug: 805825 Change-Id: I62ef189749ad2209ba715835e4a1ffda8150573e Reviewed-on: https://chromium-review.googlesource.com/887366Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#532508}
-
Becky Zhou authored
+ Speculative fix for ModalDialogManagerTest#testShow_UrlBarFocused: Wait for url bar focused callback to make sure dialogs are updated. + JavascriptTabModalDialogTest#testAlertModalDialogMessageFocus: Use landscape mode for test to make sure alert message is long enough. Bug: 802254, 800377 Change-Id: Ic7549b81aa1ca8900858260f6311772014c7de37 Reviewed-on: https://chromium-review.googlesource.com/887823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#532507}
-
Adam Langley authored
Bug: 793985 Change-Id: I840f950d7de6e6ac8506ed8937bbe9a3e270d5da Reviewed-on: https://chromium-review.googlesource.com/887820Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#532506}
-
Weidong Guo authored
Background: Upon suspend, DisplayManager::SetSoftwareMirroring(true) will be called to clear current mirroring source and destination displays. But mirror mode is not enabled because DisplayManager::OnNativeDisplaysChanged() will receive empty display info and stop before reconfiguration. Later upon resume, mirror mode will not be restored because the mirror info is cleared. Changes: Prevent DisplayManager::SetSoftwareMirroring(true) from clearing the mirroring source and destination displays as they will be cleared later in DisplayManager::OnNativeDisplaysChanged(). Bug: 797016 Change-Id: I3b987e5bc13a72313f5273262e96ed26b7ca347c Reviewed-on: https://chromium-review.googlesource.com/857548 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#532505}
-
James Cook authored
The "accessibility_autoclick" service is a small mojo app that implements the "automatically click when the mouse stops moving" feature for users with difficulty clicking the mouse. It was missing from ash's manifest file. This fixes browser_tests AccessibilityFeatureaApiTest and ChromeOSInfoPrivateTest.TestGetAndSet under mash. Bug: 678687, 805713 Test: browser_tests --mash Change-Id: I3611b80209809247a64987d339cc513e1caeee06 Reviewed-on: https://chromium-review.googlesource.com/889524 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#532504}
-
Nico Weber authored
`new` never returns nullptr per standard (in Chromium, we crash the process on out-of-memory instead). Also, in the first case, the image in the ImageBitmap is checked for nullness right above, so that check isn't needed either. Bug: 805881 Change-Id: Ieff5bdf15813bfb0f3087ec925f74ecacc77df7c Reviewed-on: https://chromium-review.googlesource.com/887758Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532503}
-
Minh X. Nguyen authored
The current implementation of UpdateService doesn't take into consideration the installation of delayed extensions. This will fix that. Also add flag/feature to prepare running the new update service as an experiment in Finch. Change-Id: If858e74ac2276829de2d2e9b3babc9c7182e49d9 Reviewed-on: https://chromium-review.googlesource.com/872119 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532502}
-
Nico Weber authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=671732#c11 This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 177475,671732 Change-Id: I7b147b9bf9b5ed7853a9a98132812a3557972326 Reviewed-on: https://chromium-review.googlesource.com/890432Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532501}
-
Peter Boström authored
* Separates the title from the promotion content (adds a secondary-style Label for body content). * Removes the "no thanks" button (still present in the Cocoa version). Bug: chromium:654115, chromium:654117 Change-Id: I83274934bfff8eaec6e5065233661ddd91447d39 Reviewed-on: https://chromium-review.googlesource.com/887726Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#532500}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/23c165f3c831..7a4ced2773b2 $ git log 23c165f3c..7a4ced277 --date=short --no-merges --format='%ad %ae %s' 2018-01-26 ehmaldonado Report progress of gclient sync during fetch. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Id0d796613dfb0d102156afbea486aadfa2299482 Reviewed-on: https://chromium-review.googlesource.com/891301 Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532499}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/dbac8ca4f5d7..bc4869293d78 $ git log dbac8ca4f..bc4869293 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 thestig Fix identical if/else blocks. 2018-01-29 thestig Remove duplicate assignments in sycc420_to_rgb(). 2018-01-29 thestig Roll V8 to ee5d9a0c. Created with: roll-dep src/third_party/pdfium BUG=805881,805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id658b85157c1332418f1509c8653ecab8390cfae Reviewed-on: https://chromium-review.googlesource.com/890631 Commit-Queue: <pdfium-deps-roller@chromium.org> Reviewed-by: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532498}
-
Christopher Grant authored
As requested by the test team, this will eliminate a manual test case. BUG=806279 R=ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5e08e7b8e30e65cebf680d3449d15a0b293de7b1 Reviewed-on: https://chromium-review.googlesource.com/890392Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#532497}
-
Luna Lu authored
unsized-media sets a default size for laying out intrinsically sized images / videos. The feature is allowed for all origins by default. When disabled, any intrinsically sized images / videos will be using the default dimension (300 x 150) to prevent relayout. Bug: 623682 Change-Id: I1bd105ded2580349e2a2b177e87b70417403cb59 Reviewed-on: https://chromium-review.googlesource.com/865159Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#532496}
-
Kevin McNee authored
In the OOPIF-based guest implementation of attachment, the contentWindow of the internal iframe element is used to identify the local frame to swap for a remote frame. When the guest is destroyed, we currently don't "reset" the internal iframe element so that it can be used for another attachment. When we try to attach, the frame is still remote, which causes GuestViewInternalCustomBindings::AttachIframeGuest to be unable to find the frame to swap. We now replace our internal iframe element upon guest destruction, so that the frame is local when we reattach. Bug: 800407 Change-Id: I4424793c7c0230d62a424765bc3c288080b2e0b9 Reviewed-on: https://chromium-review.googlesource.com/871292Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#532495}
-
Brian Salomon authored
Bug: 801783 Change-Id: I78455d0a50869e7a81b9bfe8613e53bcb5973c80 Reviewed-on: https://chromium-review.googlesource.com/884441Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#532494}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7cdba1e84b853eeaff281093555e8757dc1616ed Reviewed-on: https://chromium-review.googlesource.com/882396Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532493}
-
danakj authored
But drop them when they become available if we're in the SUSPENDED memory state. Deleting busy resorces doesn't actually free any memory, it just moves the ownership solely into the ResourceProvider until they become available. Instead, we can keep them in the busy list, and when they are available, decide to keep them or not based on the memory state instead. This should also improve things by reducing memory footprint in the SUSPENDED memory state if OnPurgeMemory() isn't being called but new tile resources are being made and released. R=ericrk@chromium.org, vmpstr@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I24e1a6f38c88fa278566849174a315bff71ed375 Reviewed-on: https://chromium-review.googlesource.com/886862 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#532492}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1717655..787ecbb3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I29e1ddf6f049f287169f92091db9ec3c3df9c503 Reviewed-on: https://chromium-review.googlesource.com/889869Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532491}
-
David 'Digit' Turner authored
This CL supports the case where the crazy linker dlsym() or dlclose() functions are passed handles that were opened from the system linker. To do that, a set of valid crazy-linker-created dlopen handles is maintained, and compared against at runtime. + Remove crazy::Set<> template, and introduce crazy::PointerSet that has better lookup performance. BUG=805861 R=agrieve@chromium.org,pasko@chromium.org,rmcilroy@chromium.org,ymalik@chromium.org Change-Id: I6b965c2dabc4ac9f5340ce028444e4195aa2b580 Reviewed-on: https://chromium-review.googlesource.com/885763 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#532490}
-
stkhapugin@chromium.org authored
Moves the _locationBar ivar (it becomes _locationBarController) to LocationBarCoordinator. Moves popup coordinator, too. Bug: 785253, 806028 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4bea5a069fc2caeb76f27d204eeddd8d5b281430 Reviewed-on: https://chromium-review.googlesource.com/883504 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#532489}
-
Alexander Timin authored
s/kFrameLoading_kControl/kFrameLoadingControl/ R=alexclarke@chromium.org Change-Id: I3011117f013c6c257255bc06da38b2d6833e7981 Reviewed-on: https://chromium-review.googlesource.com/891321Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532488}
-
James Forshaw authored
Map any generic access rights during the AC access check. Also fixes a bug in the test code which preventing testing of generic access masks. Bug: 760977 Change-Id: Iec729a40a25c187b758f61e3128930e7f4bfb02d Reviewed-on: https://chromium-review.googlesource.com/890454Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#532487}
-
kylechar authored
There is a timer in SurfaceManager that periodically checks for old temporary reference and deletes them. This timer was always running to drive an UMA stat, even if there are no temporary references to expire. Running the timer unnecessarily caused a regression on Android in the thread_times.key_idle_power_cases benchmark. Stop the timer when there are no temporary references. This won't wake the thread unnecessary and should save power. Also replace the UMA stat, instead of tracking the number of expired temporary references per timer tick, track the reason each temporary reference was removed. This new UMA metric provides more information and isn't coupled to the implementation. Bug: 804696 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5e4385a72ca597de29094b8352ed7908916f4cf0 Reviewed-on: https://chromium-review.googlesource.com/883775 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#532486}
-
Denis Yaroshevskiy authored
Change-Id: Ia0a8721df2c0503ea180cfdeba507173a051c62b Reviewed-on: https://chromium-review.googlesource.com/868510 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#532485}
-
Elly Fong-Jones authored
Bug: None Change-Id: I2338cec9d47330ccf0a76de1d8894d632fea267b Reviewed-on: https://chromium-review.googlesource.com/891280Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#532484}
-
Nico Weber authored
R=mpearson@chromium.org Change-Id: I5508ab909d436112fdf537a7ae9b6828f862fb93 Reviewed-on: https://chromium-review.googlesource.com/889779Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532483}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/82f653f9a44e..e99634797bd6 $ git log 82f653f9a..e99634797 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 perezju [Devil] Use ListProcesses for testRestartAdbd Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibc667a9370472f3b7116a568e7fb5f89301fbd92 Reviewed-on: https://chromium-review.googlesource.com/890390 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532482}
-
Weidong Guo authored
Changes: Assign 0 to the timeout of the notification to make resolution change irreversible in Kiosk mode. BUG=794135 Change-Id: Icb17ba31c15fe25476674142db5ae317f6d4e6af Reviewed-on: https://chromium-review.googlesource.com/887224 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#532481}
-
Mustaq Ahmed authored
Reasons for removal: - UserGestureIndicatorTest.Timeouts asserts the same check. - The removed test seems to have a sloppy time expectation. - This is blocking UserActivationV2 (with extended expiry). Bug: 804903 Change-Id: I8960e670772cb4a0bb306206e86a873e1c226f77 Reviewed-on: https://chromium-review.googlesource.com/881523Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#532480}
-
https://skia.googlesource.com/skia.git/+log/ba3ed69a4ee4..cca86f386cfd $ git log ba3ed69a4..cca86f386 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 fmalita [skottie] Hierarchical animators 2018-01-29 egdaniel Blacklist additional perf skp on win Intel Vulkan 2018-01-29 egdaniel Remove Ops whose lazy proxies fail to instantiate on flush 2018-01-29 kjlubick Disable flaky perf benchmark 2018-01-29 angle-skia-autoroll Roll skia/third_party/externals/angle2/ ffa4cbb6f..d1434c048 (6 commits) 2018-01-29 fmalita Revert "[skottie] Cache attached assets" 2018-01-29 bsalomon Allow printf style var args for messages in REPORTER_ASSERT. 2018-01-29 fmalita [skottie] Reduce parser verbosity 2018-01-29 egdaniel Add createTextureProxy function to ProxyProvider that takes an SkImage 2018-01-29 ethannicholas fixed creating a vector from another vector in SPIR-V output Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I36366d9be68d3c011f892a19dc65a8e8d13e3598 Reviewed-on: https://chromium-review.googlesource.com/890821Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532479}
-
Mirko Raus authored
With tablet style Bookmarks modified in: https://codereview.chromium.org/2837643002 Bookmarks tests need to be modified. Bug: 806217 Change-Id: I761e7fdade7a311d65b4411be2d98b3cffe071d0 Reviewed-on: https://chromium-review.googlesource.com/889338Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532478}
-
Sylvain Defresne authored
os.path.getmtime(path) returns a float value with non-zero fractional timestamp when using APFS+. Truncate the value when comparing to the saved timestamp in remap file. Bug: 324079 Change-Id: I92e100548d96d66df0da2d72258015763a5b6d5c Reviewed-on: https://chromium-review.googlesource.com/891358Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#532477}
-
Michael Wasserman authored
This reverts commit 751cc857. Reason for revert: Incorrect speculative revert. The actual change causing this failure was likely http://crrev.com/c/887282 for Issue 805937 That CL actually touched the failing test, and its revert caused the bot to pass: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25915 I'm reverting this seemingly incorrect speculative revert of my CL. Original change's description: > Revert "mus: Fix event processing for touch events in unified mode" > > This reverts commit 1423331f. > > Reason for revert: speculative attempt due to unhappy MSan ChromiumOS bot. > See also crbug.com/806638. > > Original change's description: > > mus: Fix event processing for touch events in unified mode > > > > This refines my earlier work done in: http://crrev.com/c/842467 > > > > Move event target nulling and root location use to WindowTreeClient, to ensure events reach MusUnifiedEventTargeter. > > Otherwise, WindowEventDispatcher::GetInitialEventTarget will use the touch gesture recognizer's target (returned by GetPriorityTargetInRootWindow) before performing the mirror display transformation on the event's location. > > > > Inline DispatchEventToTarget for additional clarity. > > > > Bug: 805714 > > Test: Mus touch events work in Chrome OS's unified desktop mode. > > Change-Id: Ic4844c85cc24a9f9885e7705ff27cb57b305d245 > > Reviewed-on: https://chromium-review.googlesource.com/887250 > > Commit-Queue: Michael Wasserman <msw@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532030} > > TBR=sky@chromium.org,msw@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 805714 > Change-Id: I02333546f91d0d0f495153c8556aa9820612673d > Reviewed-on: https://chromium-review.googlesource.com/890841 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532328} TBR=sky@chromium.org,msw@chromium.org,shimazu@chromium.org Change-Id: I6c7b91429abdddb4f9db881c40c64f53141bc707 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805714 Reviewed-on: https://chromium-review.googlesource.com/890822Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#532476}
-
Adithya Srinivasan authored
A variant of this was originally generated by clusterfuzz (https://crbug.com/803352), and caught a bug in https://crrev.com/c/829613. This test tests nameditem cache invalidation for form control collections, even after their form owner is disconnected from the document. Change-Id: I2b3389926e2bed9dd9173a9f26649c5aa55526c6 Reviewed-on: https://chromium-review.googlesource.com/878661 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532475}
-
Peter Beverloo authored
The serialization contains the p256dh and auth values of the push subscription encoded per base64url. Normally it's valid to keep the trailing equal-sign padding, but the Push API specifically forbids this. Bug: 801555 Change-Id: I370f01b6aa398ccd407502c967391ea573352381 Reviewed-on: https://chromium-review.googlesource.com/868295 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532474}
-
Jeremy Roman authored
For consistency between the methods, have all converters take v8::Isolate*, as all of the ones that presently take v8::Local<v8::Context> implicitly assume it to be the current context anyhow. Bug: None Change-Id: I565fb54bdc7a1d5ac1796ef5d7c1c69ca83290bb Reviewed-on: https://chromium-review.googlesource.com/876563 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532473}
-
Emily Hanley authored
Bug: 806257 Change-Id: Ia59da0cc8e3f5892aa1d250958bec6619ecc3ab2 Reviewed-on: https://chromium-review.googlesource.com/888097Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#532472}
-
Nico Weber authored
This CL was uploaded by git cl split. R=dmazzoni@chromium.org Bug: 177475 Change-Id: I4d9385c71c2cdb2202a768f547636bb8ecb3d298 Reviewed-on: https://chromium-review.googlesource.com/889949 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#532471}
-