- 17 Nov, 2020 40 commits
-
-
Daniel Cheng authored
These metrics used the legacy Blink helpers to record enumeration histograms; rather than migrating them to the preferred helpers in //base/metrics, just remove them. Bug: 1047547 Fixed: 975724, 975724, 1037132 Change-Id: I8f428f02d06b53aeaa31c5623ea776d630fa8732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524930Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828145}
-
Stepan Khapugin authored
I am removing myself from watchlist, and as I am the only one to use it, I'm removing the rule too. Bug: none Change-Id: I3b83556d0d03de88113142ccd4166d2522d88f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540627 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828144}
-
Nazerke authored
This CL adds the add-new-tab-button, which is not tappable and which is not moving the position according to the number of tabs. Bug: 1134132,1128249 Change-Id: Ia72835684f8d65879c863041a503835dad2a67d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536469 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#828143}
-
Michael Lippautz authored
Quarantined objects do not need to be scanned at all. For larger objects with size >= kLargeScanAreaThreshold, it's beneficial to check the quarantine bit before performing a scan. Locally reduces Speedometer2 regression from ~6% to around ~2.5% with the current partition configuration (renderer + browser). Bug: 11297512 Change-Id: I97627898733f6cdb1fa7b0dc18a39b1b4566f48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540594 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#828142}
-
Jana Grill authored
Change the names of the string placeholders from ENROLLMENT_DOMAIN or DOMAIN to MANAGER in order to make it clearer for the translators that the placeholder can be replaced either by a domain or by an individual managing the users and devices. Additionally adjust several messages that explicitly mention the domain. Bug: b:172676091, b:172676651, b:172676763, b:172676861, b:172678391, b:172678434, b:172678602, b:172678610, b:172679002, b:172680043, b:172680296, b:172682943, b:172683064 Test: None Skip-Translation-Screenshots-Check: True Change-Id: I938f7dc563733e6cdd3c5cbee8c1692c4444cc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537534 Commit-Queue: Jana Grill <janagrill@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#828141}
-
Michael Lippautz authored
The expectation of PartitionAllocMemoryReclaimer::Reclaim() is that all unused memory gets reclaimed, which requires a scan to be run. In general: Purging memory may only be effective when running PCScan before doing so, as otherwise quarantined memory keeps buckets and their PartitionRoot used. Bug: 11297512 Change-Id: I82b39dd8662df3a32dbf21a795de86b160684f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539200 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
No behavior is changed, only test code. - Sign-in before creating the sync service. - Use MANUAL_START, which is more common than AUTO_START these days. Bug: None Change-Id: I739b950b97e01321008b72c984b909ec09bde6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540595 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#828139}
-
Nico Weber authored
This will become even more useful once we roll in https://reviews.llvm.org/rGf2710d4b576053d405af7a0e2a62ea06d5a978e3 Bug: 1149587 Change-Id: Ia6953f31fcbf3dc0e1041112d437fb20e1f6e9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542122Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828138}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b8a27ae001c2..6823afb28ceb 2020-11-17 nigi@chromium.org Enable some Windows-only embedder tests for Skia/SkiaPaths. 2020-11-17 nigi@chromium.org Enable FPDFEditEmbedderTest.RemoveMarkedObjectsPrime for Skia/SkiaPaths. 2020-11-17 nigi@chromium.org Roll third_party/skia/ ae4bb98f1..1ce8964db (756 commits) 2020-11-17 nigi@chromium.org Roll tools/clang/ c5290b5af..c72342ce9 (39 commits) 2020-11-17 nigi@chromium.org Roll third_party/freetype/src/ 007c109b4..32b14552d (13 commits) 2020-11-17 nigi@chromium.org Roll buildtools/ 4be464e05..6302c1175 (8 commits) 2020-11-17 nigi@chromium.org Roll build/ 50f81f245..182e4cef2 (336 commits) 2020-11-17 nigi@chromium.org Roll third_party/skia/ 4c3486e6f..ae4bb98f1 (1 commit) 2020-11-17 nigi@chromium.org Roll third_party/zlib/ 26211a5a8..e84c9a3fd (2 commits) 2020-11-17 nigi@chromium.org Roll tools/memory/ ee1e24481..f685c086b (1 commit) 2020-11-17 nigi@chromium.org Roll third_party/icu/ aba3f0dfe..7db579a73 (12 commits) 2020-11-17 nigi@chromium.org Roll third_party/depot_tools/ 422c039e8..da73999f7 (72 commits; 20 trivial rolls) 2020-11-16 tsepez@chromium.org Remove CFXJSE_Values from CFXJSE_FormCalcContext::Mod() and Round() 2020-11-16 tsepez@chromium.org Remove CFXJSE_Value from CFXJSE_FormCalcContext::ApplyToExpansion(). 2020-11-16 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 89eeef5150cb to ed4fb99735f4 (55 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ib777eacf8c0091b101060c318bcef58d79cfd29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828137}
-
Alexandre Courbot authored
When a dynamic resolution change occurs and a new picture is imported under the same ID as a previously existing one, we need to release the reference to the old frame in picture_at_client_, otherwise the reference counter will never to back to 0 and the picture will never be released. BUG=b:161759267 BUG=b:165035340 BUG=b:172881995 TEST=DRC with Youtube Android app on Trogdor now takes place smoothly. TEST=CTS H264 AdaptivePlaybackTests now pass. Change-Id: I82350fbc9355d22365b7f6432243b3ecb39a22b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540206 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#828136}
-
arthursonzogni authored
This was reset once per navigations, which includes same-document navigations (in-page scroll toward #fragment). This doesn't look right. This has been moved toward DidCommitNewDocument(). Bug: 1113294. Change-Id: Ib8a62f29ab53b11828475b83f2fe7c0df7e360e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536468 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#828135}
-
Alex Rudenko authored
Adds setShowFlexOverlays methods according to: https://docs.google.com/document/d/1MmJtT_KaNYq3iTiDQJHuEVOI0vHaJRVnPdVMAaG6tAE Bug: 1145997 Change-Id: I945252bf625c98ff98043d8feaf620f77075393d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527133 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#828134}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I693ddd491b5d0a96b75b1cf1b78aee767b9c241c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542858Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828133}
-
Per Kjellander authored
This reverts commit 108797c3. Reason for revert: Underlaying problem fixed in webrtc. https://webrtc-review.googlesource.com/c/src/+/193063 Original change's description: > Disable flaky */ConnectionTest.VideoWithSlowSignaling/* > > Bug: 1143311 > Change-Id: I131bb5b58f8f403d2752288c6e2c4a8ec11e15a7 > NoTry: True > Tbr: joedow@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523302 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825119} TBR=xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143311 Change-Id: I0aa89b44e48335b08b0615c6ba9edc6c405218fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544122Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Per Kjellander <perkj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828132}
-
Nico Weber authored
...similar to what we do for Windows. This is to pick up: - include/c++/v1 to pick up libc++ headers for the very few targets that use system libc++ (which on macOS assumes that library headers are bundled with the compiler), like gcapi - libclang_rt.osx.a for __isPlatformVersionAtLeast (needed everywhere) Bug: 1147069 Change-Id: I9da25218686466c29b171ca959bbe5a529cccfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542183 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
chrome://usb-internalsdpapad authored
Bug: 1132403 Change-Id: Ie44b69c074794cbd10a08289e389e502e8e94ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539892Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#828130}
-
Corentin Wallez authored
This was a well-known flag so it wasn't removed immediately but instead printed a deprecation messages when it was used. This was more than three months ago which is enough time for deprecation so this CL removes the flag. Also uses more inclusive language in a comment found with `git grep`. Bug: chromium:1101491 Change-Id: I6dd147ca0e5a7b55175995be4f46dcc11bb7d138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540668 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#828129}
-
Philipp Hancke authored
BUG=webrtc:7061 Change-Id: I4bf6df92f64635880cd3aae35bf4f61881199868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543145 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#828128}
-
Mihai Sardarescu authored
This reverts commit e256a45e. Reason for revert: Seems that this header is used by Drive and Doc offline. Original change's description: > Stop sending X-Chrome-Connected header when Mirror is disabled > > The header X-Chrome-Connected header was sent to Gaia and Drive even > when Mirror is disabled. However it seems that this header is ignored > server-side, so it is better from privacy perspective to stop sending > it. > > Bug: 1149163 > > Change-Id: I361754ed4d74b10a4347975d614efbd29be41d1c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537838 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Auto-Submit: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827813} TBR=droger@chromium.org,msarda@chromium.org Change-Id: Icc095489c0c6762b2eb7dba76c4d7ccfda1ecce6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1149163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543023Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#828127}
-
Findit authored
This reverts commit 93cc91b2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 828123 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzY2M5MWIyZTRlZGU0MTYwNTRlNTVkNGMyNmEzMjAyNjZkZTA3NjYM Sample Failed Build: https://ci.chromium.org/b/8863396302867752096 Sample Failed Step: compile Original change's description: > Mojoify DidCommitProvisionalLoadParams > > Turn the IPC struct: > FrameHostMsg_DidCommitProvisionalLoad_Params > > Into a mojo struct > mojom::DidCommitProvisionalLoadParams > > This is mostly straigforward, except: > > 1. The functions have been updated to correctly specify whether > ownership over this struct is passed or not. Use one of "const T&" / > "T*", "TPtr*". > > 2. Mojo checks the required params are populated. This forced me to > update several unittests to construct the required params. Like the > referrer or the navigation_token. > > 3. blink::mojom::Referrer is used instead of the old content::Referrer > This required adding (temporarily) the conversion between both when > needed. > > Fixed: 1145888 > Bug: 1145888 > Change-Id: Ib94cff3921d0212d8c1556062326d6cb6d0dcba4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529096 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828123} Change-Id: If87cc3dce40bc743138b7225818db9073f4ca474 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542857 Cr-Commit-Position: refs/heads/master@{#828126}
-
Henrik Boström authored
Because of differences in precision when using timestamps from performance.now() and timestamps from RTCStats.timestamp it was possible for the test "RTCStats.timestamp increases with time passing" to fail, e.g: assert_less_than_equal: expected a number less than or equal to 505.65500000084285 but got 506 By flooring t0 and ceiling t1 we get a more broader view of the maximumTimeElapsedBetweenGetStatsCallsMs. This should fix the flake. If it doesn't, the issue may be related to using different clocks or somehting, in which case we'll have to revisit what this test can assert. For now, let's land and see if the flake goes away. TBR=philipp.hancke@googlemail.com Bug: chromium:1093020 Change-Id: Ie8c8e379a244ca53ed207d20c5f4de68606d29d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543923Reviewed-by:
Philipp Hancke <philipp.hancke@googlemail.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#828125}
-
Miyoung Shin authored
This CL injects and removes the objects into all frames in RemoteObjectInjector#addInterface and set an allow of inspection to all frames. Bug: 1105935 Change-Id: Ica6bba74e7f5c5f5eada272979bd15b690d6a254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532141 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828124}
-
arthursonzogni authored
Turn the IPC struct: FrameHostMsg_DidCommitProvisionalLoad_Params Into a mojo struct mojom::DidCommitProvisionalLoadParams This is mostly straigforward, except: 1. The functions have been updated to correctly specify whether ownership over this struct is passed or not. Use one of "const T&" / "T*", "TPtr*". 2. Mojo checks the required params are populated. This forced me to update several unittests to construct the required params. Like the referrer or the navigation_token. 3. blink::mojom::Referrer is used instead of the old content::Referrer This required adding (temporarily) the conversion between both when needed. Fixed: 1145888 Bug: 1145888 Change-Id: Ib94cff3921d0212d8c1556062326d6cb6d0dcba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529096Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828123}
-
Wolfgang Beyer authored
Send a `Page.DocumentOpened` event via CDP when an iframe's content is edited via JS. Writing to an iframe's document via JS is not considered a navigation, therefore no `Page.Navigated` CDP event is emitted. But since writing to an iframe's document can change attributes which DevTools needs to be informed about, the `Page.DocumentOpened` event is emitted instead. Previously only a refresh of DevTools would let DevTools know about changes to an iframe caused by JS manipulation of said iframe. Example (see http://doc/1gczarAME7AATGHwqm_IDqcGFlOM6DLAoX9rqetv4Rx0): There is a 'frameNavigated' event for the initial load of an iframe. If there is a 'document.write' for this iframe right away, there is no 'frameNavigated' event for this iframe at all. Frontend CL: https://crrev.com/c/2507793 (needs to be merged first, this will fix the failing tests, which fail because the frontend cannot handle unknown CDP events) Bug: chromium:1140540, chromium:1140481 Change-Id: I92a659b7ab8b1cb7ae50e28df40b8ca9b0bf8c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498482 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sreeja Kamishetty authored
In order to send different detached notifications, we need to make sure that WebContents is associated with will_delete. This becomes essential with the new ClosedTabCache feature, which changes the assumption that the WebContents will be deleted after detaching. We do the following in this CL to fix this scenario: - Removes ‘will_delete’ from TabStripModel::DetachNotifications struct and Move it to TabStripModel::DetachedWebContents. - Move TabStripModelChange::Remove ‘will_be_deleted’ member to TabStripModelChange::Removed contents with addition of will_be_deleted to ContentsWithIndex. ContentsWithIndexAndWillBeDeleted is added to TabStripModelChange to associate WebContents with will_be_deleted used inside Remove struct. BUG=1146370 Change-Id: Ifa2d1378449e057e8ce297ce6f8f6e31bed90d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522585Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#828121}
-
Antonio Sartori authored
CSPEE (Content-Security-Policy: Embedded Enforcement) is a mechanism for a parent frame to enforce some Content Security Policies on a child frame. This was originally implemented in Blink, and later moved to the Browser. The Blink implementation has been put behind a feature flag and deactivated. Since it seems that the new implementation in the Browser is working correctly, the old Blink code and the feature flag are now safe to remove. Bug: 1094909 Change-Id: If299c5561b9f55330234c6fdf85d3faf2c4462d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410408Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#828120}
-
Maggie Chen authored
GPU.SupportsDX12 GPU.D3D12FeatureLevel Viz.DisplayCompositor.RootDamageRect.Underlay Viz.DisplayCompositor.RootDamageRect.Overlay Bug: 1149513, 1140045 Change-Id: If7abff2968708f2f4c234d87f55d6bb26b25c2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543184 Auto-Submit: Maggie Chen <magchen@chromium.org> Reviewed-by:
-
Leo Lai authored
EULA screen doesn't fetch the password anymore and the removed class doesn't have any other consumers. BUG=b:172748724 BUG=b:168852740 TEST=browser_tests. Change-Id: Ic72312280fd7768b36ebba6aff476eb7aec50f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536658 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828118}
-
Camillo Bruni authored
Remove v8::ScriptCompiler::CompileOptions option that is no longer supported from ScriptStreamer. The V8-side changes have landed in 8.8: https://crrev.com/c/2498698 Bug: 1061857, v8:11165 Change-Id: I06b8c23cfb1ed3b397c0df024366848f8b7c1636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540453Reviewed-by:
-
Pavol Marko authored
This CL contains a few changes to make working with poilcy-recommended (marked as "Recommended" in ONC) IP and Namserver settings possible in the Chrome OS network settings UI. (1) ui/webui/resources/cr_components/chromeos/network/ network_nameservers.js (1.1) When selecting 'custom' in the UI, introduce explicit priority among the nameservers to display: policy-enforced > previously user-entered > recommended > active (getCustomNameServers) (1.2) |savedCustomNameservers_|: Keep track of the most recent manually selected nameservers type, to be able to handle the case of 'google' nameservers coming in from the backend by selecting 'custom' (if the user last selected 'custom') or 'google' if the user never selected anything or something else than 'custom'. (1.3) setNameservers_(): Get rid of async hack. (2) ui/webui/resources/cr_components/chromeos/network/ network_ip_config.js Correctly merge saved/backend-provided IPv4 settings with defaults on changing to "automatic". Bug: 1108922, 1109660, 1109670 Change-Id: I18c2ab5ae69a4922f3d63584975f6f3424dee9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449449 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828116}
-
Leo Lai authored
Making "override"s explicit for future proof. BUG=None TEST=build ok. Change-Id: I4cd0eda8fb5a979e86900579a83dd93d565efca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543723 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605538580-853d8fcb404f37acc68f0179b58be2e881687944.profdata to chrome-win32-master-1605560272-3c812cc827eaf1991f3c05cfa46c3374e2d6a16e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I822b6cde6eabf1214573b4c5627c273e100e2115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542590Reviewed-by:
-
Jérémie Boulic authored
Bug: 1133186 Change-Id: If8ad75ab5b8d70b470deb3821bbe084990c4288e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542939 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#828113}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605571148-8e0456d32b4535b8a26e31eb6f964ebd3417aaef.profdata to chrome-linux-master-1605592392-dc172d915909da26cabde4fc0f34ef46d817ea1e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I29a6f8fdd5e4bd17a07a53cddfdc60d1c4cdf68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543982Reviewed-by:
-
Marc Treib authored
Remove mathp who isn't working on this anymore, and instead add mahmadi and tiborg. Bug: none Change-Id: If79cb03d1fbe3891db3d8df9b54f03bf8b707d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540450Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#828111}
-
Maggie Chen authored
GPU.GPUChannelHostWaitTime2 is used for the gpu watchdog finch and has a histogram range from 1 second to 120 seconds. Now, it's removed at the end of the finch. A new histogram GPU.GPUChannelHostWaitTime3 is added to record the normal time the browser UI thread spends blocked after GpuChannelHost sends IPC message to the GPU process. The histogram range is from 5 microsecond to 1 second. Also restore the original pending_sync.done_event->Wait() in GpuChannelHost::Send() Bug: 1140089 Change-Id: I46c8028fe26ce4cf206a90150f39d135f411ed19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489022Reviewed-by:
-
Liquan (Max) Gu authored
Changes: * PRService takes over the handling of the not-show error. Before the CL, triggerPaymentAppUiSkipIfApplicable(), continueShow() handles the not-show error (e.g., log, disconnect) in CPRService. After the CL, the not show error is handled in PRService; the methods simply returns the error, if any, to PRService. Behaviour changes: * When MINIMAL_UI_SUPPRESSED happens, these two behaviours are added to the error handling: (1) the journey logger logs a not-show event, (2) sObserverForTest.onPaymentRequestServiceShowFailed() is invoked. * When continueShow() fails, this behaviour is added to the error handling: sObserverForTest.onPaymentRequestServiceShowFailed() is invoked. Bug: 1148902 Change-Id: Ib67e630c14c07da29e9821c5d94a44e895bb2106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537118 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828109}
-
Michael Lippautz authored
Scan should know what it needs for book keeping. Bug: 11297512 Change-Id: Ie73d362a9632f5b5eb365c0ce1fba72c62887f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541864Reviewed-by:
-
Melissa Zhang authored
This CL adds animation to Sharesheet appear and disappear. Appear has a opacity fade in from 0 - 100 in 100ms with linear curve and scale fade in 80-100% in 150ms with curve (0.4,0,0.2,1). Disappear is a 100-0 in 80ms linear opacity fade out. In this CL we also disable sharesheet close on deactivate when ShareActions have been selected. Bug: 1148692 Change-Id: Id6a360438271ad62f5911ed97984c3230a448332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537502 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828107}
-
Jiewei Qian authored
This CL adds the necessary logic to ensure system web apps are launched to the active desktop, if the launch is initiated by a profile whose desktop is inactive (e.g. in the background). This scenario can occur on a multi-user ChromeOS logins, where the user logs in multiple accounts and switches the desktop among them. Fixed: 1114939 Change-Id: Ieeb101c196bed5b4533e1f56e72df628ef50c61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532143 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828106}
-
