GitLab

BUG=none

Review-Url: https://codereview.chromium.org/2626403002
Cr-Commit-Position: refs/heads/master@{#443501}

These tests are flaky because there is a delay between infobars being
removed in the native InfobarManager, and this flowing through the the
Java side of things. This change introduces a polling loop whenever
an infobar is removed to account for this.

BUG=678210

Review-Url: https://codereview.chromium.org/2621983003
Cr-Commit-Position: refs/heads/master@{#443500}

This CL implements search by sending a query to the existing backend
search and then updating the ui to reflect the search result. The
bookmarks list will now either display the contents of a folder or the
search results.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614703003
Cr-Commit-Position: refs/heads/master@{#443499}

Presumably this was used in the past, but it isn't used anymore except
in the ScriptContextSet classifier. However, the classifier can use the
world ID to accomplish the same thing, so just remove this and clean up
a bunch of dead code.

BUG=481699
R=haraken@chromium.org,peria@chromium.org,yukishiino@chromium.org
TBR=jochen@chromium.org,rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2628053003
Cr-Commit-Position: refs/heads/master@{#443498}

Data reduction proxy is always allowed with primary and fallback
mechanism.

BUG=654438

Review-Url: https://codereview.chromium.org/2626963003
Cr-Commit-Position: refs/heads/master@{#443497}

Some content embedders (such as WebView) may not have a ContentSubresourceFilterDriverFactory
created. Do not enforce it.

BUG=680791

Review-Url: https://codereview.chromium.org/2633593002
Cr-Commit-Position: refs/heads/master@{#443496}

device::mojom::TimeZoneMonitor has been changed to be hosted by Device Service,
so this CL removes it from content_browser manifest, and also removes
some unnecessary dependencies from content/.

BUG=612341

Review-Url: https://codereview.chromium.org/2630463003
Cr-Commit-Position: refs/heads/master@{#443495}

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector
before ExecutionContextSelector.js is loaded.

I also made runOnWindowLoad async to be consistently async

BUG=none

Review-Url: https://codereview.chromium.org/2624383005
Cr-Commit-Position: refs/heads/master@{#443494}

Uses ICU. This change also enables using it on the Desktop implementation. A followup will enable it on Android.

BUG=679797
TEST=CurrencyFormatterTest, LANGUAGE=fr_CA ./out/Default/chrome

Review-Url: https://codereview.chromium.org/2621033003
Cr-Commit-Position: refs/heads/master@{#443493}

R=dschuyler@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626993003
Cr-Commit-Position: refs/heads/master@{#443492}

Geometry: Common -> UI
CSSShadowModel: Common -> InlineEditor

I namespaced three global variables in Geometry:
'Size', 'Insets', 'Constraints'

BUG=none

Review-Url: https://codereview.chromium.org/2626143004
Cr-Commit-Position: refs/heads/master@{#443491}

In order to be suitable for use from within CertVerifyProc, this CL makes
CertNetFetcher shareable between the network and worker threads. The
worker thread will start and wait for fetch requests, but the network
thread needs to be able to create and shutdown the fetcher. Shutdown is
needed to be able to destroy the URLRequestContext cleanly: since the
CertNetFetcher will have a reference to the URLRequestContext, the network
thread needs to be able to shut down the fetcher and cancel outstanding
requests before destroying the URLRequestContext.

Thus this CL makes CertNetFetcher refcounted (replacing its refcounted
bridge class CertNetFetcherCore) and gives it a Shutdown method to cancel
its outstanding requests and prevent new ones from starting.

Note that there is still a race where a worker thread could issue a fetch
request while the network thread is shutting down. In this case,
the fetch task would never run on the network thread and WaitForResult would
hang indefinitely. I'm not sure what to do about this except give
WaitForResult() a timeout like nss_ocsp does.

BUG=657549

Review-Url: https://codereview.chromium.org/2595723002
Cr-Commit-Position: refs/heads/master@{#443490}

The EarlGrey tests were not using the apps Info.plist file,
which resulted in UIFileSharingEnabled not being set for tests.

BUG=676735

Review-Url: https://codereview.chromium.org/2622403005
Cr-Commit-Position: refs/heads/master@{#443489}

This is part of an effort to remove all business logic from SBHI.

BUG=669967

Review-Url: https://codereview.chromium.org/2624943002
Cr-Commit-Position: refs/heads/master@{#443488}

BUG=none

Review-Url: https://codereview.chromium.org/2609363002
Cr-Commit-Position: refs/heads/master@{#443487}

The previous code had a bug that it would never start observing newly
added windows (Changing is sent for old parent, and Changed for new
parent, so DisconnectedAppHandler really need to override both
Changing and Changed). In fixing that I figured it was easier to
reason about if it's associated with a single top level window.

This bug was causing the shelf to never remove items when the window closed.

BUG=none
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2629523006
Cr-Commit-Position: refs/heads/master@{#443486}

Adds several additional WebVR layout tests.

Refactors the WebVR Mojo mocking to more closely emulate the actual
actual implementation.

Fixes several issues in the WebVR source code that were encountered by these
tests.

BUG=679952,679288

Review-Url: https://codereview.chromium.org/2624263003
Cr-Commit-Position: refs/heads/master@{#443485}

R=dpapad@chromium.org
BUG=680012,680084
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626173004
Cr-Commit-Position: refs/heads/master@{#443484}

Cr-Commit-Position: refs/heads/master@{#443483}

Updated independent-inheritance-fast-path.html to test all keywords
instead of just testing a single keyword. Updated the independent
properties table to include all keywords for the independent properties.

BUG=628043

Review-Url: https://codereview.chromium.org/2620383008
Cr-Commit-Position: refs/heads/master@{#443482}

Previously the host telemetry logger doesn't report these information. This
CL fixes this problem so that we can use host info to filter stats.

BUG=680644

Review-Url: https://codereview.chromium.org/2629593003
Cr-Commit-Position: refs/heads/master@{#443481}

This is a follow-up fix to http://crrev.com/2630493002.

In that CL, I changed the path to the manifest command but
used the wrong path, resulting in the latest import failing:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7868

The manifest script is actually checked into:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest

BUG=678077

Review-Url: https://codereview.chromium.org/2626183004
Cr-Commit-Position: refs/heads/master@{#443480}

The new test harness has been deployed; let's see whether it's more
reliable.

BUG=603329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2629763002
Cr-Commit-Position: refs/heads/master@{#443479}

Gtk3.20 changed the selector for menu separators.  This CL adds a
version check to use the appropriate selector.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2627153003
Cr-Commit-Position: refs/heads/master@{#443478}

BUG=460102,679417

Review-Url: https://codereview.chromium.org/2619863002
Cr-Commit-Position: refs/heads/master@{#443477}

Currently even there is no custom search engine to show (such as clean
start), "Recently visited" header will still be displayed. This
is confusing for users.

To fix this, there is no custom search engine to show, remove the "Recently
visited" header.

BUG=679608

Review-Url: https://codereview.chromium.org/2623113002
Cr-Commit-Position: refs/heads/master@{#443476}

The test quickly finishes usually, but sometimes it doesn't finish.
We guess it's possible to call checkInputs() before loading js-test.js.

This CL doesn't remove a TestExpectations entry. We'll check if the flakiness is
gone later.

BUG=675907

Review-Url: https://codereview.chromium.org/2629033004
Cr-Commit-Position: refs/heads/master@{#443475}

Reason for revert:
Sheriff: Suspect CL for causing net_unittest failures on several bots such as https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder

Original issue's description:
> Add quic_logging.
>
> Merge internal change 143128776
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2611613003
> Cr-Commit-Position: refs/heads/master@{#443413}
> Committed: https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4c3519504ec39

TBR=rch@chromium.org,fayang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2629723003
Cr-Commit-Position: refs/heads/master@{#443474}

Revert of Perform InterfaceProviderSpec intersection in the ServiceManager (patchset #12 id:220001 of https://codereview.chromium.org/2610853013/ )

Reason for revert:
This CL is causing chrome --mash to fail to start up on Chromebook hardware. See https://bugs.chromium.org/p/chromium/issues/detail?id=680700

I'm not sure why our existing test coverage doesn't catch this. Let me know if I can help manually test a future patch.

Original issue's description:
> Perform InterfaceProviderSpec intersection in the ServiceManager.
>
> . Introduces a parallel flow in ServiceManager to Connect called BindInterface which carries (via ConnectParams) interface name and pipe.
> . Introduces an OnBindInterface() method to mojom::Service. In ServiceContext, this just calls through to OnConnect still since updating callsites is a pretty large task for a subsequent change.
>
> Note that policy checking is still happening in the client - there was no easy way to avoid this without adding an unsafe mode to InterfaceRegistry that skips the check that I'd be concerned might be misused. And IR should probably just die once this work is complete anyway.
>
> R=rockot@chromium.org,tsepez@chromium.org
>
> Review-Url: https://codereview.chromium.org/2610853013
> Cr-Commit-Position: refs/heads/master@{#443119}
> Committed: https://chromium.googlesource.com/chromium/src/+/e70e635ab325eede70d564b995130583bb3404ce

TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2634493002
Cr-Commit-Position: refs/heads/master@{#443473}

This change makes wtf::ArrayBuffer::data() require that the underlying
ArrayBuffer be non-shared. The caller must use dataShared() or
dataMaybeShared() to access the underlying data of a SharedArrayBuffer.

BUG=678410

Review-Url: https://codereview.chromium.org/2617073002
Cr-Commit-Position: refs/heads/master@{#443472}

This CL does not fix the linked bug, but was discovered
during its investigation and might be related to it.

BUG=675584

Review-Url: https://codereview.chromium.org/2630583003
Cr-Commit-Position: refs/heads/master@{#443471}

https://skia.googlesource.com/skia.git/+log/b621a35b436b..aeef5610d7a3

$ git log b621a35b4..aeef5610d --date=short --no-merges --format='%ad %ae %s'
2017-01-12 liyuqian Revert "Reland https://skia-review.googlesource.com/c/6091/"
2017-01-12 msarett Use RasterPipeline to support full precision on 16-bit RGBA pngs
2017-01-12 stani Add support for drawImageLattice in SKIA debugger
2017-01-12 liyuqian Reland https://skia-review.googlesource.com/c/6091/
2017-01-12 msarett Revert "Use RasterPipeline to support full precision on 16-bit RGBA pngs"
2017-01-12 reed impl clipping for GDI raster-handle

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2628293002
Cr-Commit-Position: refs/heads/master@{#443470}

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns,
who added update_w3c_test_expectations.py (which is responsible for
updating baselines and TestExpectations during the import process).

This CL also simplifies some example dicts/strings.

Review-Url: https://codereview.chromium.org/2629253002
Cr-Commit-Position: refs/heads/master@{#443469}

Allow there to be multiple suites that run on the flaky bot, since
we have more than one test suite. Use the appendix "_flaky_egtests"
to denote targets. Previously it only ran "ios_chrome_flaky_egtests".

BUG=675613

Review-Url: https://codereview.chromium.org/2629733002
Cr-Commit-Position: refs/heads/master@{#443468}

BUG=none

Review-Url: https://codereview.chromium.org/2626293003
Cr-Commit-Position: refs/heads/master@{#443467}

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627353003
Cr-Commit-Position: refs/heads/master@{#443466}

Adds DeviceDetailsPage to internals page so users can view all the properties
of the DeviceInfo object. No display of service properties is included in this
patch.

Splits action link in Devices table into two separate links: "Inspect"
and "Forget".
Adds functions to add and remove items from the sidebar.
Adds test infrastructure for Device proxy-based tests.
Adds test for DeviceDetailsPage.
Adds unregister function to PageManager.

GIFs: https://goo.gl/photos/zLiv86gyYmQhRn9w8

BUG=651282,663470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576603002
Cr-Commit-Position: refs/heads/master@{#443465}

Add an alternative function for combining resource weight with host
visit frequency. This one is a measure of the probability that there
will be a cache hit for the resource, given that resource_weight is the
probability of a cache hit for a single trial and host_visits is the
number of independent trials.

BUG=

Review-Url: https://codereview.chromium.org/2623553003
Cr-Commit-Position: refs/heads/master@{#443464}

 * Adds EnumTraits for TextInputMode and TextInputType.
 * Adds corresponding unittests.
 * Adds missing enum entries in ime.mojom.

BUG=631527

Review-Url: https://codereview.chromium.org/2626383002
Cr-Commit-Position: refs/heads/master@{#443463}

Reland of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #1 id:1 of https://codereview.chromium.org/2600863002/ )

Reason for revert:
Fixed the root cause of the crash.
https://crrev.com/64efa56e5bb67106cea0eb4033b866d9217d8324

Original issue's description:
> Revert of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #3 id:40001 of https://codereview.chromium.org/2569993002/ )
>
> Reason for revert:
> Causes crashes on canary. See https://crbug.com/676984
>
> 0x5eb4a4fa	(chrome.dll + 0x000fa4fa )	base::Callback<void ,1,1>::Callback<void ,1,1>(base::Callback<void ,1,1> const &)
> 0x6003ec7d	(chrome.dll -service_worker_version.cc:1095 )	content::ServiceWorkerVersion::OnSimpleEventFinished(int,content::ServiceWorkerStatusCode,base::Time)
> 0x5ff64f33	(chrome.dll -bind_internal.h:214 )	base::internal::FunctorTraits<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),void>::Invoke<scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode,base::Time>(void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode &&,base::Time &&)
> 0x5ff50241	(chrome.dll -bind_internal.h:285 )	base::internal::InvokeHelper<0,void>::MakeItSo<void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int,blink::WebServiceWorkerEventResult,base::Time>(void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int &&,blink::WebServiceWorkerEventResult &&,base::Time &&)
> 0x5ff655a6	(chrome.dll -bind_internal.h:339 )	base::internal::Invoker<base::internal::BindState<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion>,int>,void >::Run(base::internal::BindStateBase *,content::ServiceWorkerStatusCode &&,base::Time &&)
> 0x5fbe1b09	(chrome.dll -callback.h:85 )	base::internal::RunMixin<base::Callback<void ,1,1> >::Run(filesystem::mojom::FileError,__int64)
> 0x5fba0984	(chrome.dll -service_worker_event_dispatcher.mojom.cc:225 )	content::mojom::ServiceWorkerEventDispatcher_DispatchPushEvent_ForwardToCallback::Accept(mojo::Message *)
> 0x6037605b	(chrome.dll -interface_endpoint_client.cc:336 )	mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message *)
>
> Original issue's description:
> > [ServiceWorker] Mojofy PushEvent of Service Worker.
> >
> > This CL converts push event IPCs into mojo interface:
> >   ServiceWorkerMsg_PushEvent
> >   ServiceWorkerHostMsg_PushEventFinished
> >
> > BUG=629701
> > TEST=content_unittests
> >
> > Committed: https://crrev.com/35842853527f50a04662a6dfe2c3cd1b10cf5915
> > Cr-Commit-Position: refs/heads/master@{#439739}
>
> TBR=leon.han@intel.com,peter@chromium.org,shimazu@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=629701
>
> Committed: https://crrev.com/024112aedb31806f7c825e3591f6be1ec7474aa9
> Cr-Commit-Position: refs/heads/master@{#440693}

TBR=leon.han@intel.com,peter@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com,falken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629701

Review-Url: https://codereview.chromium.org/2620333003
Cr-Commit-Position: refs/heads/master@{#443462}