- 22 Jun, 2020 40 commits
-
-
Xida Chen authored
These histograms were added to figure out whether there is any difference of performance by comparing the blocking handlers and the non-blocking handlers. These UMAs don't have much value at this moment. So this CL marks them obsolete. Bug: 1088748, 1072663, 1059793, 1055386, 1053244, 1053243, 1053242, 1037588, 1037071, 1034573 Change-Id: I94c9223955ba4483029978c00d323355abe6d527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252616Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780806}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: If7e09c6168c289fc12e602b1ba7738d82b791875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254283 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#780805}
-
Sam Maier authored
This also fixes a mistake I made in a previous CL where I was not keeping any methods annotated by @DoNotInline. Bug: 1094569 Change-Id: Ic6d6c5771764a8faf9d387e677423c0cd43a2091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249723Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#780804}
-
Clemens Backes authored
The test output will change with the next v8 roll, hence skip the tests now and rebaseline after the v8 change rolled in. R=thibaudm@chromium.org, haraken@chromium.org Bug: 1097717 No-Try: true Change-Id: I00bbfa9ada558b87e3e581fe13c2d957963a8a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256183 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#780803}
-
Dave Tapuska authored
Add some additional types so that we can move more input handling into blink from content/renderer. These structures are used by the webview's synchronous compositor. BUG=1073560 Change-Id: I6af4798934fe618229c87e3794489562072e1cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249343 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780802}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a061b4a78240..956ec8a8bcdd 2020-06-22 johnstiles@google.com Update GrCCClipProcessor to support an input FP. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I3c0c65c693241c6b43e7cf6aa68b833f9e36f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780801}
-
Gauthier Ambard authored
The share menu requires JavaScript execution to capture the page's canonical URL, but script execution is halted when JavaScript dialogs are running. This CL adds ToolbarMediator as an OverlayPresenterObserver and disables the button when a overlays are displayed in OverlayModality::kWebContentArea. Fixed: 987247 Change-Id: Ia09b9eb5e9e734e4d25252aee236acf46a6d81c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256230 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#780800}
-
arthursonzogni authored
We have tests with: - (opener <-> openee) with COOP on the openee. This patches adds: - (opener <-> openee) with COOP on the opener. Along the way, reduce the size of the previous set of tests, make them independent of the other reports. Bug: 1090273 Change-Id: I2af9e6f520cec745a875e4b048d02b7c6e6573b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255470 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780799}
-
Ioana Pandele authored
Clicking the toggle changes the tab icon by replacing all tabs. This requires the tab to be re-marked as selected after its replacement. Bug: 1044930 Change-Id: Ife8ef25cf6a7b081fba4dcabd9d81c9fa7dd0f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250111Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#780798}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a57798d. With Chromium commits locally applied on WPT: bca089ad "[LayoutNG] Truncate block-end child margins at fragmentainer boundaries." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I666cb819bacb2a83792d6dcefa264feff0d7304c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255508Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780797}
-
Sylvain Defresne authored
Remove compatibility aliases allowing to load sessions saved with Chrome version pre M-59 (should have been after M-68 was released which happened long ago). Bug: 661633 Change-Id: I617dc4a394f61e0a4a89cd2da40ff73b2650d903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255611 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780796}
-
Hans Wennborg authored
This is a reland of a6e9e966 Original change's description: > Remove/replace unnecessary includes of logging.h (base/) > > If the file just needs the CHECK/CHECK_OP/NOTREACHED > macros, use the appropriate header for that instead. > Or if logging.h is not needed at all, remove it. > > This is both a nice cleanup (logging.h is a big header, > and including it unnecessarily has compile-time costs), > and part of the final step towards making logging.h no > longer include check.h and the others. > > TBR=thakis > > Bug: 1031540 > Change-Id: Ib87efde411a3617fcebad6dae08313c20d63d0bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254284 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780580} TBR=thakis Bug: 1031540 Change-Id: I0ba8608458cf14c3e4bbc86eaef4c7ad136a9263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256179Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780795}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1dccfa608557..dbb8f3185736 2020-06-22 tvanderlippe@chromium.org Reland "Add rollup_entrypoint to rollup entrypoints in front_end" 2020-06-22 alexrudenko@chromium.org Add additional assertions to styles pane tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1061037,chromium:1096473,chromium:946975 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4c76e044980cb5e2096b9428539362ccbb2759a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257439Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I7a96c78d4a93b99956a920d61636ed91cf0e82ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219462 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#780793}
-
Robert Ma authored
to be consistent with the shebang in `run_web_tests.py` Also `chmod +x` because checkperms complained. Note that vpython(.bat) is provided by depot_tools and should be available in PATH after following the Windows build instructions: https://chromium.googlesource.com/chromium/src.git/+/master/docs/windows_build_instructions.md#install Bug: 1095643 Change-Id: I0afaae268022e0a2a368ecae6cd7020c453f5812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249086 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#780792}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f594ffdc357a..a4434747558d 2020-06-20 sebras@gmail.com [cff] Fix handling of `style_name == NULL' (#58630). 2020-06-20 apodtele@gmail.com Simplify unused macro. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I0300ca5bab677272e312581e26f3c05f71c88967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255769Reviewed-by:
-
Fredrik Söderqvist authored
We will not create LayoutObjects for <stop> elements, so when animating stop-color on one of these elements we should access ComputedStyle via Node::GetComputedStyle(). Fixed: 1097762 Change-Id: I9e5996b733cae97f813ab392f62f37a8aaa0e176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255366Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#780790}
-
Theresa Wellington authored
Rename the useDarkColors, which is somewhat ambiguous, to inNightMode instead. Bug: 1057553 Change-Id: I9a64e1105107441330f3c34b521398da562fba97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256150 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#780789}
-
Samuel Huang authored
This reverts commit fc8e613a. Reason for revert: Fixed the issue. Original change's description: > Revert "[SuperSize] Add multiple Container support using .ssargs files." > > This reverts commit 19d7a780. > > Reason for revert: Breaking CQ (see bug) > > Original change's description: > > [SuperSize] Add multiple Container support using .ssargs files. > > > > This CL adds SuperSize support for multiple containers. Details: > > * Introduce .ssargs file, which is a text file to specify multiple > > containers for SuperSize-archive to process into a single .size file. > > * Container file types are auto-detected. > > * Container files are relative to .ssargs file location, unless > > absolute paths are given. > > * Introduce Version 1.1 .size file format: > > * Header fields contain Container specs, now absorbing metadata and > > section_sizes. > > * Per-section data become per-container-per-section. > > * For compatibility: Running SuperSize-archive on one container still > > generates Version 1.0 .size file format. > > * Update SuperSize-console output (including diffs) to accommodate. > > > > After this CL, basic Trichrome support is available. A recommended > > .ssargs file (3 lines) for the official build is as follows: > > > > TrichromeLibraryGoogle.apk --name Library > > TrichromeChromeGoogle.minimal.apks --name Chrome --java-only > > TrichromeWebViewGoogle.apk --name WebView --java-only > > > > Bug: 1040645 > > Change-Id: I67df00731d07660163410b59c57854bf56ea651e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248860 > > Commit-Queue: Samuel Huang <huangs@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780594} > > TBR=huangs@chromium.org,agrieve@chromium.org > > Change-Id: Ic3175ea3e8ede41e3183c12b5a00a4a09be55a75 > No-Try: True > Bug: 1040645, 1097572 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256593 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780639} TBR=huangs@chromium.org,agrieve@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1040645, 1097572 Change-Id: I95a20b271d7522a1aa70cc3247ad9a1fab911dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257279Reviewed-by:
-
Domenic Denicola authored
location.href access is one of the things that is guarded by the "same-origin domain" check, but it goes down a different code path than generic synchronous property access such as we test with window.document. So, it's worth testing it additionally. Bug: 1042415 Change-Id: I92fc222f895bf25fc1767e7ffddd3d7f7f1f1e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255102Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780787}
-
Scott Lee authored
This CL adds 'test_name' tag with the name of the test result. Please find the context in crbug/1097178. BUG=1097178 CC=chanli@chromium.org,nodir@chromium.org R=robertma@chromium.org Change-Id: I68206dc4c59ddedf1770e74288682c5d0bed3915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255215Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#780786}
-
Clemens Arbesser authored
Note: this is an alternative solution for http://crrev/c/2235698 This interaction executes a number of callbacks for the input loop value. This is intended to be used to inflate UI elements for client-only values, i.e., for values that the backend can't specify. Internally, ForEach loops are implemented by introducing the concept of callback contexts, which will change value and view lookup accordingly. In particular, callback contexts are used to automatically replace placeholders of the form ${i} in value and view identifiers (where 'i' is the loop identifier). This allows creating and referencing values and views with templated names, such as "created_view_${i}" and "value[${i}]". Bug: b/145043394 Change-Id: I53089252fe1cc14b2b1fb74cfc56d7314bc4b37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241975 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#780785}
-
sangseok.jang authored
|preferred_height_| isn't no longer used. This CL is for cleaning up. Bug: none Change-Id: I8c82e540c90bed5101fb2fcb07c06c70824177b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257088 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#780784}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I83ad75eb6b42cc959ee299cd1f29229d03f22763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254150 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#780783}
-
Guillaume Jenkins authored
Moves the policy_infoo namespace so it can be reused by iOS CBCM code. Bug: 1091933 Change-Id: Ie7e2a58f2e790ebbe9fa0204ded3af9535efbabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251105Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#780782}
-
Robbie Gibson authored
Bug: 1049559 Change-Id: Iffda7ed060a5e6220efd1d2ab3b322a3c105d08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254279Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#780781}
-
Nektarios Paisios authored
Some events indicate a change that does not affect the data of the accessibility node they are raised on. For example, if a kTextSelectionChange event fires on a non-native text field, the data on and inside the field does not need to be reserialized, since the selection endpoints are stored on the document object, and not on the non-native text field itself. Marking objects as dirty for any event that could be raised on them, especially for objects with a lot of data, e.g. a long name or value attribute that is computed from descendants, has a significant effect on performance: in the range of 100 MS for a long document in Google Docs. AX-Relnotes: Noticeably faster caret navigation in Google Docs and presumably in other online editors. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ie138e516156951949a5f8dc272ba67dd0df1f79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250257Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#780780}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35c62742f96d..fbd2c6337c39 2020-06-22 benmason@chromium.org Revert "Add GCLIENT_DEP_REF env var for recurse command" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:923016 Tbr: agable@chromium.org Change-Id: Ia1ab655bde11d7dc47112f9ae2dadd83dd8cdf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257447Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780779}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a82467d0db0..af0d5bca34b1 2020-06-22 jakobi@webrtc.org Remove ANA FEC control in Opus encoder. 2020-06-22 nisse@webrtc.org Delete SDP x-alt-protocol If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1086942 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If571c1f7ab282ef7ee4353833a24c5cf7ee69a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257057Reviewed-by:
-
Sigurdur Asgeirsson authored
Bug: 1096543 Change-Id: I8d4f3569671487aed5d8e18dbeae683503e71545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254444 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#780777}
-
Nohemi Fernandez authored
We attempt to open a URL in a new tab through two different entry points in the multiwindow use case: - 1 when we populate self.sceneState.URLContextsToOpen per scene - 2 when we populate self.mainController.startupParameters This patch ensures that we only call one of these. Bug: 1096489 Change-Id: I7c5c0fffc1d0f194d041f6ef3c734cb4da7ca385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254599 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780776}
-
Corentin Wallez authored
This reverts commit f204c589. Reason for revert: crbug.com/1097755 Bug: 1097755 Original change's description: > Reuse pixmap across VFPool/MailboxVFConverter. > > In the newly introduced VideoDecoder, we create a native buffer for > video decoding on demand in the PlatformVideoFramePool. This buffer > eventually makes it to the MailboxVideoFrameConverter in order to > produce a SharedImage for the client. > > This CL ensures that the NativePixmap created in the > PlatformVideoFramePool can be re-used in the MailboxVideoFrameConverter. > Before this CL, we would call CreateNativePixmapFromHandle() > unnecessarily when creating the SharedImage for a buffer. That's because > we didn't propagate the GpuMemoryBufferId correctly from the > PlatformVideoFramePool to the MailboxVideoFrameConverter and the check > in [1] would fail. As a result, we would end up creating an additional > DRM framebuffer which is unnecessary because the allocation in the > PlatformVideoFramePool would have already created one. Thus, the > video.MemCheck.h264_hw test would fail because of having created too > many objects. > > To propagate the GpuMemoryBufferId correctly, we create a > GpuMemoryBuffer VideoFrame in the PlatformVideoFramePool (instead of a > dma-buf VideoFrame). That way, when MailboxVideoFrameConverter calls > CreateGpuMemoryBufferHandle(), it gets a GpuMemoryBufferHandle with the > same ID that PlatformVideoFramePool gets. Additionally, we make > MailboxVideoFrameConverter use kPlatformVideoFramePoolClientId since > that identifies the namespace of the GpuMemoryBufferIds in question. > > Note that for SCANOUT_VDA_WRITE buffers (which we use for video > decoding), we end up creating a ClientNativePixmapOpaque when creating a > GpuMemoryBufferImplNativePixmap. This is problematic because a > ClientNativePixmapOpaque doesn't let us query the stride and we need to > know it in order to create a GpuMemoryBuffer VideoFrame. Therefore, > GpuMemoryBufferImplNativePixmap::stride() is changed so that it's not > necessary to have a gfx::ClientNativePixmap to query the stride. > Instead, we query the underlying NativePixmapHandle directly. > > For that same reason, we must introduce a workaround in the > VideoFrameValidator: when we get a GMB VideoFrame, we cannot map it > directly because ClientNativePixmapOpaque doesn't allow us to. > Therefore, we extract the dma-buf FDs and use the regular dma-buf > mapping path. > > [1] https://cs.chromium.org/chromium/src/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc?l=152&rcl=d96e9f16ae852ec9dbd15bf17df3d440402413bb > > Bug: 1091450, 1093644 > Test: video.MemCheck.h264_hw_switch, video.DecodeAccelVD.h264 on eve > Change-Id: I3d60efa362b66bd2f01139296d4ed756c8777ef8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233534 > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780504} TBR=dcheng@chromium.org,akahuang@chromium.org,dcastagna@chromium.org,hiroh@chromium.org,andrescj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1091450, 1093644 Change-Id: Iace25eb12b50b030327568ae75ebef0f7691934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257418Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780775}
-
Philip Rogers authored
This patch replaces the "whitelist" term for touch actions in favor of "allowed" touch actions. Much of this patch is a straightforward rename but touch_action_filter needed some special handling because there is both an allowed_touch_action (set from main) and a compositor_allowed_touch_action (formerly white_listed_touch_action). Bug: 1097346 Change-Id: I69e6bc7669a5fef00a85d63131ae9e473c668de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256149 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780774}
-
Xida Chen authored
There are actually two problems in this test: 1. The expectation file is wrong, when canvas context.fillRect takes int as size, not '50px'. 2. The test file needs parseInt to convert string to it. This CL fixes the test. Bug: 1096078 Change-Id: I01e6a753d3d9772a39dfacfe8b87f80b6f877b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254449Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780773}
-
Anton Bikineev authored
For the fuzzer builds, optimizations are set to -O1, which can break UnsanitizedAtomic. This CL uses GCC builtins to not rely on inliner anymore. Bug: 1082796 Change-Id: I3d5ff6cca61a1a7e0365b9096010d18689cdb4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255579Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#780772}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Additionally, CL also removes the left-over use of WebMediaStream in MockMediaStreamRegistry. BUG=704136 R=guidou@chromium.org Change-Id: I4c033e3460d30df7ad3fd0f2850e5e151fa685a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254087 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#780771}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Ibccc8496d94173e1d51dc3ffe785f9cbbff4669f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254122 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780770}
-
Corentin Wallez authored
This test is likely failing because Skia triggers newly added Dawn validation. TBR=bajones@chromium.org Bug: chromium:1097735 Change-Id: If5e6411edd97e9b279aa0905b60c383b6827e608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255364Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592815711-e36a86e9145f6f12f52b2c83c2feb91a9eebc962.profdata to chrome-win64-master-1592823242-c0a158a98eb51cc1e695f636e9edb128f03ff58d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iad17d8edb79b0a704977fe8cdbc57c2f5ad72351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257055Reviewed-by:
-
Geoff Lang authored
BUG=982292 Change-Id: I5ec7e19d2ab3ddb7ab08e04a8db94e96c1bf1a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225122 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#780767}
-
