- 10 Sep, 2020 40 commits
-
-
Benoit Lize authored
Threadsafe static local variables call into the C runtime on Windows, which may not be safe in the allocation path (see linked bug). Don't use them for code which is on this path. This is using base::LazyInstance. It currently fulfills our needs, though it is not ideal for a couple reasons: - Not guaranteed to stay independent from local statics. - Can allocate in some paths (mostly DCHECK()s) As such, this is temporary, and we should either make sure that LazyInstance is suitable, or have a replacement local to PartitionAlloc. Bug: 1126432 Change-Id: I9cffed6f313c3fb380383a1607f0e6f27397c2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401469Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805698}
-
Benoit Lize authored
This CL adds a thread cache to PartitionAlloc. It is optional, only applies to thread-safe partitions, and uses the same freelist encoding and bucketing as the main allocator. The thread cache is added "in the middle" of the main allocator, that is: - After all the cookie/tag management - Before the "raw" allocator. That is, the general allocation flow is: 1. Adjustment of requested size to make room for tags / cookies 2. Allocation: a. Call to the thread cache, if it succeeds, return. b. Otherwise, call the "raw" allocator <-- Locking 3. Handle cookies/tags, zero allocation if required On the deallocation side, the process is reversed: 1. Check cookies / tags, adjust the pointer 2. Deallocation a. Return to the thread cache of possible. If it succeeds, return. b. Otherwise, call the "raw" allocator <-- Locking The thread cache maintains an array of buckets, the same as the parent allocator. A single thread cache instance is only used by a single partition. Each bucket is a linked list of allocations, capped to a set maximum size. Elements in this "freelist" are encoded the same way they are for the main allocator. Only the smallest buckets are eligible for caching, to reduce the memory impact. There are several limitations: - Only a single partition is allowed to have a thread cache - No periodic purging of thread caches is done - No statistics are collected The last two limitations will be addressed in subsequent CLs. Regarding the first one, it is not possible to use Chrome's native thread local storage support, as it allocates. It is also desirable to use thread_local to improve performance. Bug: 998048 Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805697}
-
Morten Stenshorne authored
This reverts commit 44a2bf3d. Reason for revert: New test times out. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38462 Original change's description: > [lacros] Support mojo connection in testing environment > > This CL supports setting up mojo connection between lacros and ash in > testing and debugging environment, and it is done via a unix domain > socket. > > Unix domain socket is only used in testing, not production because it > allows a random process to connect to ash-chrome as long as it knows > the socket path. > > Currently, only one lacros-chrome is allowed to connect to ash-chrome, > so in the testing environment, test launcher will run tests serially, > and will change to run in parallel once ash-chrome supports multiple > clients. > > Bug: 1120582 > Change-Id: I9736b03218f8fe937a7d642a35d6ee49b7e081f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384543 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805537} TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org Change-Id: I911a4d8bd80e8f0a217243503986a1a6d4a16338 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403460Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805696}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/917a2d741e92..3d41d509a6a9 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5f71fdf34b76 to b24900a1aa39 (2 revisions) 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 41c93c550b07 to 29b1f07f4ab2 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1042393,chromium:819294 Tbr: reed@google.com Change-Id: I2af5cbf40df4253a6757a6e64aab2e8824e03bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805695}
-
Denis Kuznetsov authored
Fix a11y focus-related issues on Marketing opt-in and EULA screens. Bug: 1024092 Change-Id: Ic976091e42ed2c46324445288e2c2b794d87883e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401659 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805694}
-
Olivier Robin authored
Change-Id: I2ca6df4452e375d4f381d4b015f877fa99d16e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400985Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805693}
-
Alex Rudenko authored
Renaming the variable that controls if the overlay will be repainted ignoring the throttling for clarity and reducing the throttling time to 50ms to reduce lags. Change-Id: Ifca6c5e0badf2978fce595604e19082233bac8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401034Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805692}
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: I6930da9f938db2f3bfe4c5062dce30fc4847f3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401037 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805691}
-
Hans Wennborg authored
When using CRC hashing, that assert doesn't hold, but a weaker variant does. Also disallow compiling with FASTEST defined, because I don't think that longest_match variant would be safe with CRC hashing. It doesn't guarantee that the fourth of the hashed bytes will be compared. Bug: 1113596 Change-Id: I20ede29835b9c6b4bdc09fc1836864ffa2b10a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401023 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805690}
-
arthursonzogni authored
Rename the WPT tests so that they now match the new report.body.type: - access-from-coop-page-to-openee_coop-ro.https.html - access-from-coop-page-to-opener_coop-ro.https.html - access-from-coop-page-to-other_coop-ro.https.html - access-to-coop-page-from-openee_coop-ro.https.html - access-to-coop-page-from-opener_coop-ro.https.html - access-to-coop-page-from-other_coop-ro.https.html The report-to API is now working thanks to: https://chromium-review.googlesource.com/c/chromium/src/+/2390748 This patch also updates the expectations accordingly using the latest run: https://wpt.fyi/results/html/cross-origin-opener-policy/reporting?sha=74b5a27a35&label=master&max-count=1 Bug: 1090273 Change-Id: I9f1e4528a5209f81e544247b7857db6cf7fa4ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398720Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805689}
-
Alice Wang authored
This CL refactors AccountManagerTestRule#addAndSignInTestAccount() method so that we can reuse it to refactor SyncTestRule. Bug: 1126814 Change-Id: Ie49ffb174e18f09d28f4253a7b2cdd34ffce9142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401035 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805688}
-
Christian Dullweber authored
Fetch a favicon for the current page and display it in the new PageInfo UI. Use fallback icon when no icon is available. Also fix a failing assert with the long click callback. Screenshot: https://crbug.com/1077766#c30 Bug: 1077766 Change-Id: Ia1a911fe9d06c4c1bc30f9721102253b535294e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390320Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#805687}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/87f25134a8c1..498d5ea20aed 2020-09-10 cwallez@chromium.org Rename BC6HRGBSfloat to BC6HRGBFloat If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia6502fdf833a14f331170b075ddf6d7809691077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402652Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 30a5da05. With Chromium commits locally applied on WPT: 6e8ec7a9 "sensors: Drop tests for Sensor.start()/stop() return types." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Iefdd30404690e7b202854feef83d6de26b381a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401082Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805685}
-
Roberto Moura authored
This CL implements the changes listed in sub section "The View Revealing Vertical Pan Handler" under section "Architecture" of the thumb strip design doc: go/bling-thumb-strip-design . Modify the view revealing vertical pan handler in order to handle both the transition from Hidden to Peeked states and vice-versa, as well as from Peeked to Revealed and vice-versa. -Instead of one boolean property that states whether the view is hidden or revealed, switch to property that can take one of 3 states (Hidden, Peeked, and Revealed). -The animateViewReveal method of the ViewRevealingAnimatee protocol now takes as argument the target state that the animatee should animate to. Bug: 1094335, 1123512, 1123729, 1124380 Change-Id: Ieb7979b19005a3612b7515ac1fc9bfc376c10bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362594 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805684}
-
Wez authored
Bug: 1125623 Change-Id: Ib09d0fe8f694107cf77c9b5172b9f03df015bf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396161Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#805683}
-
Andreas Haas authored
V8 uses a signal handler to implement memory bounds checks for WebAssembly. Therefore signal handler have to be allowed in all V8 fuzzers. R=ochang@chromium.org Bug: chromium:1124755 Change-Id: I3be9fedaf87e78bfd81196e0d847f7b31781a17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401468Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805682}
-
Minoru Chikamune authored
The test was failing on Android L and M bots. This problem was solved with the CL below. https://chromium-review.googlesource.com/c/chromium/src/+/2395195 Bug: 1102041, 1049056 Change-Id: I75b72b3914efb1de1a58c21af778f424c29b6b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398603 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805681}
-
Maksim Sisov authored
It was accidentally disabled for non-ozone. It meant to fail for Ozone/Wayland/X11, but it hasn't been caught because linux-ozone-rel doesn't run interactive_ui_tests. This will be addressed in a follow up. TBR=sky@chromium.org Bug: 1085700 Change-Id: I7d5bf9548aef630cf09839d1bb2c6ad46b9de4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401050Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#805680}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a187dd58a048..2de7d3af0c0e 2020-09-10 paulthomson@users.noreply.github.com spirv-fuzz: Add SPIRV_FUZZ_PROTOC_COMMAND (#3789) 2020-09-10 paulthomson@users.noreply.github.com Add missing include (#3788) 2020-09-09 paulthomson@users.noreply.github.com Improve spirv-fuzz CMake code (#3781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I690a942ac0295b00e418428fe41223a412033fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402644Reviewed-by:
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/930fbec75b..3c8b5d7587 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/930fbec75b..3c8b5d7587 No changes required to .def files. Bug: None Change-Id: I9ec81aafc9986662f47ebd0425d0984fcb95ce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401465Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#805678}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/33792a19b6e2..b6525ec96573 2020-09-10 thestig@chromium.org Fix non-standalone XFA build. 2020-09-10 tsepez@chromium.org Nest CXFA_TextPiece and CXFA_PieceLine in CXFA_TextLayout 2020-09-09 tsepez@chromium.org Better encapsulate CFXA_TextLayout::m_pieceLines. 2020-09-09 tsepez@chromium.org Remove out paramenters from CXFA_TextLayout::GetUnderline() 2020-09-09 tsepez@chromium.org Nest CXFA_LoaderContext inside CXFA_TextLayout 2020-09-09 tsepez@chromium.org Make CXFA_FontMgr a garbage-collected class 2020-09-09 tsepez@chromium.org Make fxjs/gc be its own source_set 2020-09-09 tsepez@chromium.org No need to observe garbage-collected CXFA_FFWidget either. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2b956409d4a4b64d78ce3dd8d3e904510584e403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402645Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5eea6aea02d9..917a2d741e92 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 02f4f19d to b68279c2 (442 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I282dcb9420dbcea74fa652f4e675027aaece25e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402641Reviewed-by:
-
Yutaka Hirano authored
In order to investigate timeout flakiness on the file, add t.step_timeout(t.unreached_func('timeout'), 10 * 1000); for each test case. Bug: 1013596 Change-Id: Ia12c65b8c7afcee2da4499dfb83d1590386111cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402719 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805675}
-
Raphael Kubo da Costa authored
This test has been flaky on the Mac bots for a very long time. Previous efforts such as r770328 ('sensors: Make frequency hint test wait for another slow sensor "tick"') did improve things a bit, but the flakiness has not been fully fixed. The problem is that our mock platform sensor dispatches sensor reading notifications via window.setInterval(), and the actual period of the callback can vary significantly, to the point where we cannot make any assumptions about how precise it will be. The Mac bots in particular seem to have big deviations in the timer's precision. Consequently, we also cannot assume a faster sensor will really receive more "reading" events than a slower one, or how long it will take for it to happen. Make the test deterministic at the expense of testing a less "real" use case: instead of comparing how many times each sensor receives a "reading" event, we just check that MockSensor.getSamplingFrequency() is adjusted accordingly depending on which sensors are active. Bug: 731018 Change-Id: Idc994d7e7d1cfb30d7c4e2f4b285494faff7160c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401139 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805674}
-
Gauthier Ambard authored
This CL makes sure that the WebState callbacks (DidStartNavigation, DidFinishNavigation...) are correctly called with the new Error page workflow. The callbacks are called once per error, with the URL of the page requested. Fixed: 1081484, 991608 Change-Id: I92934ea36c270f6f99fb355011b87083b8592988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398130 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805673}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599674142-9f13839562e8523855d1bff685bbea34c58e94a7.profdata to chrome-mac-master-1599716388-02eae1071f5b6fe6862d29aa135a2ecf5509f01d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2545cfe09df438d8daeab3d6a43d8951f15c7c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402648Reviewed-by:
-
Kent Tamura authored
* Move core_export.h from core:core to core:core_common to avoid a circular dependency between core:core and core/mojo:mojo. * Move v8:bindings_core_v8_generated from 'deps' to 'public_deps' in core:prerequisites. v8:bindings_core_v8_generated is used by a target depending on core:prerequisites. * Move some test helper sources from core:unit_tests to core:unit_test_support, and change core:unit_tests dependency to core:unit_test_support in controller:blink_bindings_test_sources in order to avoid a circular dependency between controller:blink_bindings_test_sources and mojo:unit_tests. This CL has no behavior changes. Bug: 800764 Change-Id: I8d8f78e0eb6f18464d4e270360a62b212cd9da27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402460Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#805671}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/210e1beae78c..bdb38e31199e 2020-09-10 jleconte@google.com Run only WebRTC perf tests relevant to the specified story. 2020-09-10 hidehiko@chromium.org catapult: Expand is_linux to is_linux || is_chromeos. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1110266,chromium:1123318 Tbr: skyostil@google.com Change-Id: Ie9620f35f29e8989834c9740a6ccc404aed3d1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402639Reviewed-by:
-
Sadrul Habib Chowdhury authored
. Zero delay is not used anywhere. So remove support for zero delay. . The notifier is only used in the compositor thread, so there is no need to use base::Lock. So this is removed, and replaced by a thread checker instead. BUG=none Change-Id: I1c998a011b9b28edab6b46ac9d772969bb4bb147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391981 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805669}
-
Roman Sorokin authored
Bug: None Change-Id: Ib1a2649b85bf832c09c0d1c4f164c10e61a3a651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387640Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805668}
-
Tanmoy Mollik authored
This cl updates the PersonalizedSyncPromoView. There are two changes made to this view. 1. The status message "Sync is off" is removed 2. The sync off badge in the profile picture is removed. Since the badge is no longer dynamically updated, all updateBadgeConfig() calls for updating the promos have been removed. Bug: 1124701 Change-Id: Ia3654ade8a0bccfc44a12bb8548cb4ad022fc442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391233 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805667}
-
Saurabh Nijhara authored
As per the current code flow, PENDING_ADD_FAILED failure reason can be reported when: 1) an extension with same extension_id is already installed from a higher priority source (Manifest::Location) but is corrupted. This is then not reported in the metrics as the extension is already installed. 2) extension is already in the pending extension list from a higher priority source (Manifest::Location). Case #2 should not be reported as PENDING_ADD_FAILED failure for the force installed extension. Bug: b:162855924 Change-Id: I1f91a6d5ae97c7f75fc69584d9ba0ed9516e6d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379859Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#805666}
-
My Nguyen authored
Adding click handler for customize spell check in follow-up CL. DisabledView: http://screen/BwJ7YNftynvYNVN EnabledView: http://screen/5kcJNdQhrF8Foq5 Spec: http://go/cros-lang-settings-ux-slide/edit#slide=23 Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ibdc7fb40cb70d3ffd670e9e1a8bff84764a229e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362044 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805665}
-
Yoshifumi Inoue authored
This patch changes |ShapeResult::CountGraphemesInCluster()| not to crash when specified substring is empty by avoiding null reference of |CursorMovementIterator|. Note: This is a speculative patch because I could not reproduce locally. ClusterFuzz will check whether this patch is effective or not. Bug: 1071423 Change-Id: I6807ead3cb05f11d2ff663de8f5675aee524b5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402467 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805664}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbbf9587645f..29b1f07f4ab2 2020-09-10 syoussefi@chromium.org Vulkan: Boilerplate for vkCmdNextSubpass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I97acd800eba999bb448166ad6d378df07e09fad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401831Reviewed-by:
-
Sami Kyöstilä authored
This reverts commit 1047b889. Reason for revert: Build failure on mac-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/220028 Original change's description: > OOR-CORS: Remove BlinkCORS supporting code outside Blink > > As OOR-CORS was fully launched, this patch removes BlinkCORS > supporting code that exists outside Blink. > > We still have some dead code in Blink, and subsequent cleanup > changes will remove them all. > > Bug: 1053866 > Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805644} TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,karandeepb@chromium.org Change-Id: I51b1a274038b33b8db3036fc1a3912c6580c9446 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1053866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401467Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#805662}
-
Victor Hugo Vianna Silva authored
Disabling FastEnableDisableEnable (score of 433 in the flake portal) and DisableOneAtATime (score of 334). Bug: 1111227 Change-Id: Idf399ae2c76d7748c704952d38042e14187508ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401143Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#805661}
-
Omid Tourzan authored
Adds util method and integration test load time data entry to check feature in the Foreground page as well. Bug: 491043 Change-Id: Ia10eb456a982d2f8d8a4ce09d3c80d0b82f5e2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398598Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805660}
-
Peter E Conn authored
This will allow ExternalAuthUtils to be moved to a separate module. Change-Id: I03c3217ca22ad4a0aa6e0dbd33cbe56032aca48d Bug: 1104817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400622Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#805659}
-
