GitLab

Two capabilities have been added to the GetSettledFetches task:
1. Support CacheQueryOptions, while fetching responses for completed
fetches from the Cache Storage.
2. Support for filtering responses corresponding to a specific request from
completed fetches.

Both will be useful to support match() and matchAll() methods on
BackgroundFetchSettledEvent.

Bug: 863016
Change-Id: Icababdd71cd1687644cacc9460550de89bdfc4d5
Reviewed-on: https://chromium-review.googlesource.com/1140324Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577269}

ExtensionThrottleEntryInterface was never strictly necessary.
Now that ExtensionThrottleManager does not expose the
ExtensionThrottleEntry to any caller (excluding tests) it
no longer needs to be a reference counted object.

Also, removed the back reference to the ExtensionThrottleManager
in the ExtensionThrottleEntry as that was not necessary.

Bug: none
Change-Id: I5188f7a024304b9159879a9d0763a075c8bfba3c
Reviewed-on: https://chromium-review.googlesource.com/1132353
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577268}

For actual changes, see

  https://chromium-review.googlesource.com/1145582

TBR=manojgupta@chromium.org
BUG=chromium:865100
TEST=locally built chrome os image works.

Change-Id: Ifeaa0092937977fbb942741b1f348845c1e4596f
Reviewed-on: https://chromium-review.googlesource.com/1147108Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577267}

The V2 schema was introduced in WebKit on 2011-07-15, in
https://bugs.webkit.org/show_bug.cgi?id=58762. Removing support for the
V1 schema allows us to remove the plumbing for a SQLite feature that no
other part of the codebase uses.

This CL does mean that a hypothetical user who hasn't upgraded Chrome
for 7 years and suddenly upgrades will have their DOM storage reset. We
generally support database schemas up to 2 years old, so this
hypothetical user will most likely start with a clean slate anyways.

Change-Id: I8e21c525a114ed1da856af5c393d62a0ad8cfb1c
Reviewed-on: https://chromium-review.googlesource.com/1146280Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577266}

The default value for SQLITE_DEFAULT_FILE_FORMAT has been 4 for a while.
Besides, the option has a typo in our build file, so it wasn't really
used.

SQLITE_ENABLE_FTS3_BACKWARDS defines fts1 and fts2 as aliases for fts3.
They are not actually used in Chrome.

Change-Id: I1bca922862fcff665e614b098cd17e74f908b60d
Reviewed-on: https://chromium-review.googlesource.com/1146158Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577265}

R=ericrk@chromium.org

Bug: 866434
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6c47cf25c2f15c668b50622896170886e23e6658
Reviewed-on: https://chromium-review.googlesource.com/1147253Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577264}

Bug: 860048
Change-Id: Ib8a0daa87d8015f6c13db52484cee59dda22d0cd
Reviewed-on: https://chromium-review.googlesource.com/1145822Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577263}

JsReplace(script, args...) works by replacing $1, $2, $3, etc in |script| with
JS literal values constructed from |args|, similar to
base::ReplaceStringPlaceholders, except that args can be a variadic mix of
strings, ints, base::Values, GURLs and more.

Unlike StringPrintf or manual concatenation, this utility will properly
escape string content, even if it contains slashes or quotation marks.

Example 1:

  GURL page_url("http://example.com");
  EXPECT_TRUE(ExecuteScript(
      shell(), JsReplace("window.open($1, '_blank');", page_url)));

$1 is replaced with a double-quoted JS string literal: "http://example.com".
Note that quotes around $1 are not required.

Example 2:

  bool forced_reload = true;
  EXPECT_TRUE(ExecuteScript(
      shell(), JsReplace("window.location.reload($1);", forced_reload)));

This becomes "window.location.reload(true);" -- because bool values are
supported by base::Value. Numbers, lists, and dicts also work.

Change-Id: I11041b6d2db299949266290b940e2d855522f2ea
Reviewed-on: https://chromium-review.googlesource.com/1125098
Commit-Queue: Nick Carter <nick@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577262}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7605dd087b272397bfc028fd7c2de735033d4ea3
Reviewed-on: https://chromium-review.googlesource.com/1141954
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577261}

The MemoryDumpProvider API uses 64-bit integers. For consistency, use
SQLite's 64-bit API (sqlite_status64) to obtain memory usage statistics
from SQLite.

This CL also documents the SQLite build configuration setting assumed by
the memory usage reporting code. The value needed by the memory
reporting code is (currently) the default. However, the SQLite
docs [1] recommend a different value, so documenting our needs makes it
less likely that we'll accidentally end up with an incorrect
configuration.

Change-Id: I15217e11bce8d167dce65db345ddf78d21148144
Reviewed-on: https://chromium-review.googlesource.com/1146293Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577260}

This CL add a method to SurfaceId that allows for checking if the surfaceId is
Inside some SurfaceRange.

Bug: 857575
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7b083c82f84e47dc08b9dd2f2ddf8179889ba26e
Reviewed-on: https://chromium-review.googlesource.com/1145628
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577259}

This change removes StartListening() and StopListening() methods from
Platform and RendererBlinkPlatformImpl since they are not called
anymore.

Bug: 855308
Change-Id: I8f240737ca7d37abc1eb3267701f76854742d83d
Reviewed-on: https://chromium-review.googlesource.com/1144224Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577258}

Bug: 866359
Change-Id: I5bae80bafd34446eaa35b74d79cb35acb5ba5b6c
Reviewed-on: https://chromium-review.googlesource.com/1146991Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577257}

Set the priority of same-origin loading task to high and the priority of
cross-origin tasks to low depending on the feature enabled.

Bug: 856158
Change-Id: I5bc2e17cf512ccae0cdd7a62d1afc61cc5b53cb7
Reviewed-on: https://chromium-review.googlesource.com/1112252
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577256}

R=amineer@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2f0fc5687196b274b3235773de212ff46fe67d40
Reviewed-on: https://chromium-review.googlesource.com/1147314Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577255}

This patch forces legacy layout for the 'text-combine'
property, for the first phase of LayoutNG.

Also extracted the "if" block to a function because it gets
large enough.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2d67e26c506bc560eaf31c574d8552adb785bfb1
Reviewed-on: https://chromium-review.googlesource.com/1144594Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577254}

Since shutil.copy() fails when it cannot open(2) O_WRONLY the destination,
introduce an additional step: for a destination that is a file with different
contents, delete the destination before copying.

Back story:

I noticed that in my tree quite a few files were not writeable. It was
probably a consequence of a past bug, not sure which one. I was running:

shell> build/android/gradle/generate_gradle.py --output-directory out/Debug

This caused 'permission denied' from shutil.copy() when it attempted to
open the file for writing.

One way to reproduce it right now is:

shell> cd out/Debug
shell> touch obj/third_party/netty4/netty_all_java__process_prebuilt-filtered.jar
shell> chmod u-w lib.java/third_party/netty4/netty-all-4.1.9.Final.jar
shell> build/android/gradle/generate_gradle.py --output-directory out/Debug

BUG=None

Change-Id: Ifaa16d52bb2c0e6af362401fc635a3e21f3d7214
Reviewed-on: https://chromium-review.googlesource.com/1146923Reviewed-by: John Budorick <jbudorick@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577253}

Roll in the most recent version of:
testharness.js, testdriver.js, idlharness.js.

(webidl2.js has not changed in wpt)

Bug: 866467
Change-Id: I5be57429726e2179e0482514158be0e5ec49be04
Reviewed-on: https://chromium-review.googlesource.com/1146804
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577252}

https://android.googlesource.com/platform/external/perfetto.git/+log/89f205cedfcf..ee5a26d974be


git log 89f205cedfcf..ee5a26d974be --date=short --no-merges --format='%ad %ae %s'
2018-07-23 hjd@google.com Merge "perfetto-ui: Prefetch resources required resources"
2018-07-23 michaschwab@google.com Merge "Basic gridlines"
2018-07-23 hjd@google.com perfetto-ui: Prefetch resources required resources
2018-07-20 michaschwab@google.com Basic gridlines


Created with:
  gclient setdep -r src/third_party/perfetto@ee5a26d974be

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:111541116
TBR=perfetto-bugs@google.com

Change-Id: Id3cc224ea587cc19e94c1a09c454e9cac1e47e38
Reviewed-on: https://chromium-review.googlesource.com/1147101
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577251}

Change-Id: I4ca5334941a9f7d83f8a84bbb0f5feffbed2e5ff
Reviewed-on: https://chromium-review.googlesource.com/1145949Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577250}

The metrics have not been used in a while, and have no immediately clear
use case.

Bug: 850539
Change-Id: If11dcadf946bc66071ecb85aa126981a149193b3
Reviewed-on: https://chromium-review.googlesource.com/1146076Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577249}

This constitutes the remainder of the changes required for the
client to show a larger splash screen icon. The server still needs
a few more changes before the larger icons can be shipped but this
gets the client to a point where the larger icons can be used.

Updates will occur automatically when the new Shell APK version is
pushed. Otherwise apps will continue to use the small icons.
Because larger splash icons are just app icons, all that is needed
to trigger an update is changing the icons in the WebappManifest to
update the splash screen icons.

Tested on mdpi, hdpi, xhdpi, and xxhdpi devices running L, N, O, P.

There is a known issue on P Beta builds where xxhdpi devices don't
use the large layout due to Bitmap#getWidth() and Bitmap#getHeight()
returning incorrect values for aliased resources. However, this is
not something we can solve in Chrome and requires Android changes.
See b/111687946

Bug: 819755
Change-Id: I033dba20b766f875b6fc3d7515f24636aa5b0d4a
Reviewed-on: https://chromium-review.googlesource.com/1142475Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577248}

These tests do not appear to be any more flaky with BlinkGenPropertyTrees.

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ife14d0bd87e0ba57e9879ea5cb95d291ce83de3b
Reviewed-on: https://chromium-review.googlesource.com/1146900
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577247}

This CL sets the public interface of //third_party/sqlite to consist of
sqlite3.h (general entry point) and recovery.h (header for our custom
recovery extension).

The CL also adds dependencies on //third_party/sqlite where necessary.
These dependencies weren't caught by GN before because SQLite's BUILD.gn
has missed sqlite3.h completely, so "gn check" completely ignored the
includes pointing to it.

Change-Id: I38f95bd30302a6d62d778476893f0d5a2a939581
Reviewed-on: https://chromium-review.googlesource.com/1146320Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577246}

Because of issue 831568, we may end up trying to generate pseudo
elements for element outside the flat tree if we did a getComputedStyle
for all non-flat-tree ancestors and then triggered style invalidation of
the pseudo element's originating element.

This is not a new issue, but [1] boldly tried to make the if-test for a
layout parent a DCHECK. This CL is effectively reverting that change.

This should ultimately be fixed by fixing 831568 and re-introduce DCHECK
instead of the if-test.

[1] https://crrev.com/86f6eefc70ed2aa46969754e207198bd6917ee33

Bug: 862098, 831568
Change-Id: Id10fdbe28592e492ef6903b82d2fc47bff930ea4
Reviewed-on: https://chromium-review.googlesource.com/1146729Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577245}

Modified FileSystemBrowserTest.CreateTest so that in addition to
simply creating a file entry it also writes to, and reads from
that entry.

Additionally moved error constants (in tests) from FileError to
DOMException because FileError is undefined.

Bug: none
Change-Id: Id0a5072dce0fe089e887e982700b850d74b68623
Reviewed-on: https://chromium-review.googlesource.com/1142460Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577244}

Move the widget creation to the constructor, so GetWidget() becomes
trivial and removes the need for member variables to be mutable.
BubbleFrameViewTest.GetBoundsForClientViewWithClose also no longer needs
to call GetWidget() for its side effect.

Change-Id: Ic904c808c37be8f4a61bf9e0bccdbc281ba16c0f
Reviewed-on: https://chromium-review.googlesource.com/1123774Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577243}

https://chromium.googlesource.com/angle/angle.git/+log/ba365939b90c..0df813c37570


git log ba365939b90c..0df813c37570 --date=short --no-merges --format='%ad %ae %s'
2018-07-23 lfy@google.com GLES1: GL_OES_draw_texture
2018-07-23 oetuaho@nvidia.com Don't allow multiview clear during timer query


Created with:
  gclient setdep -r src/third_party/angle@0df813c37570

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Id25f9bb60ecdedb2d2e20b58e1c5f3d46896a3a8
Reviewed-on: https://chromium-review.googlesource.com/1146940Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577242}

Including <vulkan/vulkan_intel.h> results in compilation errors when building
with the CrOS SDK, because we use vulkan.h from //third_party/vulkan.

This is a temporary issue since we're using a deprecated extension for
dmabuf import. Fix it by inlining the header.

Bug: 866564
Test: Compile chrome with cros chrome-sdk --board=eve
Change-Id: If84ae6b503e7b0af67df72d7092d9467549eaed8
Reviewed-on: https://chromium-review.googlesource.com/1147219Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577241}

Also add test_util add extra setup that uses it to the test harness/

Bug: 830892
Change-Id: Iae1bb4323f6a0b25339d13e702135c2a3625c99d
Reviewed-on: https://chromium-review.googlesource.com/1141146
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577240}

Add a CreateDefaultContext() method to QUIC's ProofVerifier
interface which allows a proof verifier to supply a valid,
but generic context.

Applications, like Chrome, will create per-connection contexts
based on the requests which initiate them. But this method
allows a generic context to be used by the toy client and
reduces code diffs.

Merge internal change: 203811282

Change-Id: I051a87bfded65597fa2bd4a74203f74c84f336d9
Reviewed-on: https://chromium-review.googlesource.com/1130945
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577239}

If the user is redirected to sign-in to Google Photos the
customization dialog should be left open.

If the user signs out while the albums dialog is open clicking
on an album should redirect them to the sign-in page.

Bug: 865740, 865735
Change-Id: Ic6e0c529f7f42f05efff81b868b9a5042c87cac3
Reviewed-on: https://chromium-review.googlesource.com/1145869
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577238}

While waiting for a newer ndk, some constants and types
were locally declared. Since January there is an NDK that contains
those types so the local declarations are not needed anymore

In some jumbo builds the local and ndk declaration clashed so it
is time to drop the local declarations, but keeping some types
still needed by the dynamic lookup of some (to be public) internal
functions.

Bug: 771171
Change-Id: Ie29ad63108b6c7aef857752daf6741902fdd749e
Reviewed-on: https://chromium-review.googlesource.com/1141735Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#577237}

In jumbo experiments build targets using both ui/gl+mesa and khronos
at the same time fail to compile because the two GL libraries
declare the same constants and functions.

This happened in gpu/command_buffer/service because ShaderTranslator
used khronos GL when it should have been using ui/gl. This patch switches
that code over to ui/gl.

Bug: 864986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I522243374eaf0416df58d84e20585c11aef3de32
Reviewed-on: https://chromium-review.googlesource.com/1145306Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#577236}

Currently, extension icons in the toolbar are grayscaled when the
extension action (i.e., the page action or the browser action) is
disabled. However, this can be confusing, because it makes the extension
look disabled when it might be running on that page.

With runtime host permissions enabled, the extension icon should only be
grayscaled in the toolbar only if the action is currently disabled *and*
the extension cannot currently inject on the page. This addresses the
confusing "disabled" look, as well as preventing the strange case of
"clicking on the extension icon and it immediately becoming disabled."

Bug: 866170

Change-Id: I00c239c6b4a35f52398e433d0a6ed357298e08c6
Reviewed-on: https://chromium-review.googlesource.com/1145630
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577235}

This reverts commit 5c7b464c.

Reason for revert: oops, didn't mean to auto-CQ PS1.

Original change's description:
> Reland "[MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread"
> 
> This reverts commit c512937e.
> 
> Reason for revert: change is correct, fixed test flakiness
> 
> Original change's description:
> > Revert "[MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread"
> > 
> > This reverts commit 81626592.
> > 
> > Reason for revert: MetricsOnlyFromUILoops test appears to be flaky (see https://crbug.com/866299).
> > 
> > Original change's description:
> > > [MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread
> > >
> > > Addresses crbug.com/860801 in time for the M69 branch while keeping the
> > > diagnosis signals which will be used to assess future improvements
> > > (MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle that is).
> > >
> > > Removed MessageLoop.DelayedTaskQueue.PostedDelay as we've
> > > learnt everything we needed from this one, that is :
> > > We now know that while 99% of tasks are posted with a delay under 30s,
> > > 95% of users post at least one task in every portion of the 0ms-3hours
> > > range at least once per day:
> > > https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.DelayedTaskQueue.PostedDelay&fixupData=true&uniqueUsers=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > >
> > > Removed MessageLoop.ScheduledSleep.* metrics as we've also
> > > learnt what we wanted from it, that is :
> > > The maximum sleep a MessageLoop ever completes is 1 hour (and
> > > even then 99% of completed sleeps are under 1 second), all
> > > longer delays are reliably always interrupted.
> > > Win : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > > Mac : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > > Android : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > >
> > > Added a test for MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle
> > > but it appears to be broken on MacOSX (prior to this CL). Added a note
> > > to investigate on the metric but it shouldn't block this CL which
> > > doesn't make it worse.
> > >
> > > R=​kylechar@chromium.org, rkaplow@chromium.org
> > >
> > > Bug: 860801, 850450, 786597
> > > Change-Id: I7a693886ab4e1b9c8e9fbe8a64d906a95019a609
> > > Reviewed-on: https://chromium-review.googlesource.com/1142589
> > > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > > Reviewed-by: kylechar <kylechar@chromium.org>
> > > Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#576686}
> > 
> > TBR=gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org
> > 
> > Bug: 860801, 850450, 786597, 866299
> > Change-Id: I848621acf9ddbec69d72649d16a459910ffa937e
> > Reviewed-on: https://chromium-review.googlesource.com/1146300
> > Commit-Queue: Wez <wez@chromium.org>
> > Reviewed-by: Wez <wez@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577133}
> 
> TBR=wez@chromium.org,gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org
> 
> Change-Id: Idb53da9b8b40b407ece6cf6c81b95bcb7072d76c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 860801, 850450, 786597, 866299
> Reviewed-on: https://chromium-review.googlesource.com/1147360
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577228}

TBR=wez@chromium.org,gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org

Change-Id: I29dec465bd2a29c3aa16940664ba5e1d3d005c0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860801, 850450, 786597, 866299
Reviewed-on: https://chromium-review.googlesource.com/1147380Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577234}

I don't (yet) know why this fixes the issue, but it certainly does. This
diff *should* be a no-op, changing an rLineTo to the equivalent lineTo,
but I guess the former runs into a bug in skia.

Stepping through this in the debugger reveals that there is some
floating-point error in the path's point sequence that the rLineTo
propagates and the lineTo obviously does not.  Apparently 0.5000015259
vs. 0.5 or 53.0000038 vs 53 makes a difference to skia when it's
calculating the path intersection.  ¯\_(ツ)_/¯

Bug: 864280
Change-Id: I06ba430f7f62f075102975e1e3db4b8a3292c879
Reviewed-on: https://chromium-review.googlesource.com/1141292Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577233}

There are no order guarantees in the remote updates received from
the server.
However, for hierarchical types such as bookmarks, it's important
to process updates in the correct order.
For example parent node creation should happen before child node
creation.

This CL implements the following reordering rules for bookmark
remote updates in USS.
1. Creations and updates come before deletions.
2. Parent creation/update should come before child creation/update.
3. No need to further order deletions. Parent deletions can
   happen before child deletions. This is safe because all updates
   (e.g. moves) should have been processed already.

Bug: 516866
Change-Id: I059224b897ea51a4a0321124b082e76be824d28f
Reviewed-on: https://chromium-review.googlesource.com/1141870
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577232}

Change-Id: Ic4533523c8d1e335a41c0fe3a46f39feea8257c9
Reviewed-on: https://chromium-review.googlesource.com/1146995Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577231}

If one side of the screen is occupied by a split window, and the other
side of the screen is occupied by overview, select an overview window
should only animate the selected overview window to snap, and the other
windows should not animate.

Bug: 866178
Change-Id: I1cb243ad61791a240227c6395770643603726a33
Reviewed-on: https://chromium-review.googlesource.com/1145836
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577230}