- 07 May, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 10251873. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17128 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0e5a732735fb73f758681cf2e8e78473f8951aa5 Reviewed-on: https://chromium-review.googlesource.com/1046985 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556425}
-
Koji Ishii authored
This class was once used in NGLineBreaker but is no longer used. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic6823fa745b2d3722c434f009b1b56cbf680dd2b Reviewed-on: https://chromium-review.googlesource.com/1046290Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556424}
-
Marc Treib authored
instead of using the ThreadChecker class directly. This way, it'll only be instantiated in DCHECK-enabled builds. Bug: 839823 Change-Id: Ifcbbc4113265fd0067a1df10fc4a26ca844139f1 Reviewed-on: https://chromium-review.googlesource.com/1046845Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556423}
-
Marc Treib authored
instead of talking to ProfileOAuth2TokenService directly. Bug: 825190 Change-Id: I80f1e52857f3fd8effbb6351a22e5bd86062d326 Reviewed-on: https://chromium-review.googlesource.com/1028150 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#556422}
-
Max Morin authored
Actually using it is TODO. No-Try: true Bug: 824019 Change-Id: I9053827dba2504218559be523574b71ef079c72b Reviewed-on: https://chromium-review.googlesource.com/1046646 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#556421}
-
Patrik Höglund authored
enable_webrtc=false has been broken for months and no one has noticed, so let's get rid of this complexity. WebRTC will now be a part of Chromium until the serpent Nidhoggr ascends into the sky and ushers in Ragnarök. Next step: remove #ifdef'd code that depends on defines that were set by enable_webrtc. Bug: chromium:800653 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1661fc56b8005fdae92c3441bb9d7204944bd7c5 Reviewed-on: https://chromium-review.googlesource.com/1044220Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#556420}
-
https://webrtc.googlesource.com/src.git/+log/e6256055e7db..823f9135f858 $ git log e6256055e..823f9135f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:None,chromium:839860,chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief34c2bd69b2feb972c8ffa05f039c8b34c87a25 Reviewed-on: https://chromium-review.googlesource.com/1046925 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556419}
-
Marc Treib authored
As far as I can tell, the current split was a started but abandoned refactoring. As it is, the two classes are very tightly coupled (PSS directly uses many protected members of SSB), and it's entirely unclear what the intended split of responsibilities is. So let's just merge the two back into one. TBRing trivial change in recent_tabs_sub_menu_model.h TBR=ellyjones Bug: 839823 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0dbdf9115c3359dca2cd05bde55ae9d24a081223 Reviewed-on: https://chromium-review.googlesource.com/1044219 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Marina Ciocea authored
Both objects live in browser process. AudioInputStreamBroker maintains and observes state of an input stream. ForwardingAudioStreamFactory forwards stream creation to audio::StreamFactory in audio service process. AudioInputStreamBroker implements media::mojom::AudioInputStreamObserver, replacing media::MojoAISObserver. Bug: 828868 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieabb77c2edfd7e9939e6f7cd43b953d2af1d1c2c Reviewed-on: https://chromium-review.googlesource.com/1030330Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556417}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 84578181. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17127 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ibdc0b3742082309a6e2c53030ffa7b61754d2b90 Reviewed-on: https://chromium-review.googlesource.com/1046390 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Alex Kalugin authored
map is empty. xml_content string has no "<annotations>" substring because XmlWriter wrties annotations element as "<annotations/>", therefore call to xml_content.insert(xml_content.find("<annotations>"), kXmlComment); crashes. TrafficAnnotationExporter: :GenerateSerializedXML() crashes when archive_ Change-Id: I669975e77e34965aeac02f721bc5f5f85dcfbe8c Reviewed-on: https://chromium-review.googlesource.com/1046673Reviewed-by:Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Kalugin Alexander <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#556415}
-
Hayato Ito authored
Support slot's expanded nodes, using slot's assigned nodes, for IncrementalShadowDOM. Inspector can show slot's assigned nodes correctly even in IncrementalShadowDOM. virtual/incremental-shadow-dom/http/tests/devtools/elements/shadow/shadow-distribution.js test is still failing, however, this is not a regression of IncrementalShadowDOM. See crbug.com/840238 for details. This CL adds an expected.txt for the test. Bug: 776656,840238 Change-Id: I037caf9184e9be42525575bf2e027cf000bdbf7a Reviewed-on: https://chromium-review.googlesource.com/1029567 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#556414}
-
Jonas Olsson authored
Not every client cares about observing or logs. This change saves those clients from providing a dummy observer/log. If the log isn't provided, explicitly clear log_. This makes it easier to check if the scoped_refptr<media::mojom::ThreadSafeAudioLogPtr> actually holds a value, and skips some unnecessary message forwarding. Bug: 834702 Change-Id: I4c405a7dd90d241847ee60e4c3b8db58bf0a3fc9 Reviewed-on: https://chromium-review.googlesource.com/1043907Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Marc Treib authored
It's unused. Bug: 839834 Change-Id: Ic354b16a5534aab8ce89c036b8a81a2ceeb3ae60 Reviewed-on: https://chromium-review.googlesource.com/1046672Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556412}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0cb7b82e..19f90f91 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia3ba15f2d9318caf0cdc29fa51c85ce724c26f02 Reviewed-on: https://chromium-review.googlesource.com/1046250Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556411}
-
Guido Urdaneta authored
TBR=eseckler@chromium.org Bug: 839747 Change-Id: Ic98a3b585163f663c983403d34d958460658c884 Reviewed-on: https://chromium-review.googlesource.com/1046597 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556410}
-
Guido Urdaneta authored
TBR=kenrb@chromium.org Bug: 840314 Change-Id: I81f0b9b208ddf1985fca4e30694a2c4416b233dc Reviewed-on: https://chromium-review.googlesource.com/1046825Reviewed-by:
-
Colin Blundell authored
As a first step toward completely eliminating the usage of ProfileIdentityProvider in //components/gcm_driver, this CL threads in SigninManager and replaces direct usage of ProfileIdentityProvider in GCMProfileService::IdentityObserver with equivalent usage of SigninManager. Note that it is easy to verify that the usage is equivalent: The ProfileIdentityProvider method calls are replaced with their implementations in profile_identity_provider.cc. Full design doc here: https://docs.google.com/document/d/1OmNrIiMDkF7eOYVB4RIiDvY7pQz3zUrOf-D4TVwdRQA/edit?ts=5aa6b936# TBR=zea@chromium.org, rockot@chromium.org Bug: 809923 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20515d7431f0e8f5370a47cd04c8b21eb0874d6f Reviewed-on: https://chromium-review.googlesource.com/1004999 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#556408}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I810feee6bd00d881289e12bf9dc328f070a7b125 Reviewed-on: https://chromium-review.googlesource.com/1046727Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556407}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I55754ed89c069499824d66b0737dbde98e0a119d Reviewed-on: https://chromium-review.googlesource.com/1046745Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: Id57af99390197cf17ae5e8feb9820f12cb251620 Reviewed-on: https://chromium-review.googlesource.com/1046705Reviewed-by:
-
Guido Urdaneta authored
TBR=chfremer@chromium.org Bug: 840294 Change-Id: I2919e8b959ec0e6b1a4b9f2d52e382cbfe0c6d3e Reviewed-on: https://chromium-review.googlesource.com/1046670Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: If7850581bd83a1c55f81d05b1c8f030f5e2caf14 Reviewed-on: https://chromium-review.googlesource.com/1046691Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I51df4c72bb8de0faff2922748ed3d0201716f102 Reviewed-on: https://chromium-review.googlesource.com/1046690Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I5db5f4d91fa1cca880d17d8b428598562b487abf Reviewed-on: https://chromium-review.googlesource.com/1046685Reviewed-by:
-
Marc Treib authored
It's used within OnConfigureDone which receives it as a param, but no need to store and expose it. Bug: 839834 Change-Id: I553e7b8f8b4cbab97c3c00d21e609f0e05d8dff9 Reviewed-on: https://chromium-review.googlesource.com/1044223Reviewed-by:
-
stkhapugin@chromium.org authored
Adds a new metric that logs users focusing and immediately defocusing the omnibox without changing it or copying it. This should allow to see the regression when the steady state location bar will be introduced. Bug: 837164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf177b57ca1781930e21c57f9c40dc829aac0982 Reviewed-on: https://chromium-review.googlesource.com/1030190Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556399}
-
Vadym Doroshenko authored
When Password Manager deals with form action it gets it with GetCanonicalActionForForm. But when FormData is created in WebFormElementToFormData another way of receiving action is used (difference is that now in WebFormElementToFormData params and auth is not stripped). It looks that using GetCanonicalActionForForm is more robust and right way. It shouldn't influence autofill in any way: 1.Signature calculation is based on action scheme and host that wouldn't change. 2.Autofill doesn't use action for filling. Bug: 831123 Change-Id: Id8ea5fd80bbfb6a3e9c354fecb2b21ad868283a6 Reviewed-on: https://chromium-review.googlesource.com/1041952Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#556398}
-
Max Morin authored
This reverts commit ef15ddc5. Reason for revert: Crashing on WebRTC bot: https://build.chromium.org/deprecated/chromium.webrtc/builders/Win10%20Tester/builds/28286 Stack trace: base::debug::StackTrace::StackTrace [0x02F08F00+32] base::debug::StackTrace::StackTrace [0x02EDEACD+13] logging::LogMessage::~LogMessage [0x02E9DD40+80] base::ThreadTaskRunnerHandle::Get [0x02EA23ED+189] std::make_unique<media::VideoCaptureDeviceClient,std::unique_ptr<media::VideoFrameReceiverOnTaskRunner,std::default_delete<media::VideoFrameReceiverOnTaskRunner> >,scoped_refptr<media::VideoCaptureBufferPool> &,base::RepeatingCallback<std::unique_ptr<medi [0x024D0D18+178] base::internal::FunctorTraits<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerator>)>,base::Repeatin [0x024D1330+70] base::internal::Invoker<base::internal::BindState<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerat [0x024D12E1+33] media::VideoCaptureDeviceClient::OnIncomingCapturedData [0x03F23016+246] media::VideoCaptureDeviceWin::FrameReceived [0x03F2B124+228] media::SinkInputPin::Receive [0x03F2BF05+181] (No symbol) [0x6EB233FB] (No symbol) [0x6EB232F7] (No symbol) [0x6EB401BA] (No symbol) [0x6EB2420F] (No symbol) [0x6EB37E3B] BaseThreadInitThunk [0x763F8654+36] RtlGetAppContainerNamedObjectPath [0x77254B17+311] RtlGetAppContainerNamedObjectPath [0x77254AE7+263] Original change's description: > [Video Capture Service] Support accelerated jpeg decoding > > * Move/rename class content::VideoCaptureGpuJpegDecoder to > media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order > to make it reusable for the video capture service. (I was unable to convince > Gerrit that this is a move/rename. Sorry for this making it harder to review.) > * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface > ui.mojom.GpuMemoryBufferFactory > * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface > ui.mojom.GpuMemoryBufferFactory. > * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService > from Browser into video capture service when starting up the service. > * Enable the existing-but-disabled test cases for accelerated jpeg decoding in > combination with video capture service > > Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing > > Bug: 820608, 720604 > Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.* > Change-Id: Ic9860e4f846dc0abfc85fec673b1d9c15b99c7d1 > Reviewed-on: https://chromium-review.googlesource.com/971302 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556197} TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 820608, 720604 Change-Id: I518790cfb4eede5fd66d1f2862043285992c8af2 Reviewed-on: https://chromium-review.googlesource.com/1046525Reviewed-by:
-
Vadym Doroshenko authored
It's leftover from https://chromium-review.googlesource.com/c/chromium/src/+/1026111 where these methods where moved to password_form_filling.h but their definition was not removed from password_manager.h. Bug: None Change-Id: I51362bd8874dc89c0db5075cd4fbf403bdbacc49 Reviewed-on: https://chromium-review.googlesource.com/1044222Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#556396}
-
Hans Wennborg authored
Apparently the cv-qualifier of a function type must match, during deduction, see http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#1584 Recent Clang versions error about this so the code must be adjusted. Bug: 840251 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I715da586731ee97a7c5bfc27b522454dac14d316 Reviewed-on: https://chromium-review.googlesource.com/1046588 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
As part of ongoing scheduler architecture refactoring, this patch updates NonMainThreadScheduler so it can be used in place of WebSchedulerImpl. Specifically, this patch does the following: * Let NonMainThreadScheduler inherit from ThreadScheduler (in addition to WebThreadScheduler). * Implement required virtual functions. * Remove WebSchedulerImpl instance from WebThreadImplForWorkerScheduler, and make it work with NonMainThreadScheduler. Now, WebThreadImplForWorkerScheduler works without relying on WebSchedulerImpl. WebSchedulerImpl is still used by RendererWebSchedulerImpl, so the class itself is not removed yet. This patch adds post-constructor initialization to NonMainThreadScheduler in order to initialize a member requiring a virtual function call. The work is done in the Init() function which is now a non-virtual function of the class, and the original virtual Init() function is renamed to InitImpl(), which is called from Init(). Bug: 826203 Change-Id: I7499fb1df197b760e2289414020f7136e3545a46 Reviewed-on: https://chromium-review.googlesource.com/1032452 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556394}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I755155128114101f02a0871a3bcd9bebe93639d5 Reviewed-on: https://chromium-review.googlesource.com/1046380 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556393}
-
Max Morin authored
This facilitates further development until logging stuff is ready. No-Try since last PS only added a comment. No-Try: true Bug: 812557 Change-Id: I2121ea9d485c7db999b8d89d9fa0039ef9ab8136 Reviewed-on: https://chromium-review.googlesource.com/1046206 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Don't emit new lines before/after display:contents elements. Bug: 837452 Change-Id: I9e43f836d569b6435672c36f5c50a13605fbdc21 Reviewed-on: https://chromium-review.googlesource.com/1042285Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#556391}
-
Marina Ciocea authored
Used by AudioInputStreamBroker (introduced in dependent CL) instead of AudioInputDeviceManager::KeyboardMicRegistration implementation, in order to avoid thread jumps and to keep broker interface simple. AudioInputDeviceManager::KeyboardMicRegistration will be removed after switching to audio service input streams. Bug: 828868 Change-Id: I41aac3e01faeb0d4d47f98726bc069640fb346e3 Reviewed-on: https://chromium-review.googlesource.com/1044216 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
I forgot to patch dynamic_annotations following the instructions in README.chromium when I rolled Abseil last time. TBR=phoglund@chromium.org Bug: None Change-Id: Ib295b0b9d59cb50853f552b5c38a5b1d54b50a3f Reviewed-on: https://chromium-review.googlesource.com/1046054Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#556389}
-
rhalavati@chromium.org authored
Socket patterns are no longer required in traffic annotation tests, hence they are removed from traffic_annotation_extractor clang tool. The original plan was to have network traffic annotation as an optional argument of socket create functions, and we needed to check if the argument existed for all calls that originate from Chrome. This is now changed to having annotations as a mandatory argument of the socket write functions, and as it is enforced by the compiler, we do not need to test it. Bug: 690323 Change-Id: I101fb7295662c3488807091cb9a8686cfc87d249 Reviewed-on: https://chromium-review.googlesource.com/1046087 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556388}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3059fd7dba63..b9ff578f32e7 $ git log 3059fd7db..b9ff578f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 wangqing-hf Add name to AUTHORS. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I396ab1a4ba46207261e7bee84c02dca6f9d697e7 Reviewed-on: https://chromium-review.googlesource.com/1046160Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556387}
-
Yuta Kitamura authored
This patch moves source files that only serve the main thread scheduler from renderer/ to main_thread/, which is the new home for those files after the ongoing scheduler architecture refactoring. All moved headers are only included from main_thread/, with the exception of auto_advancing_virtual_time_domain.h which is used by a test in common/, which should be OK. Bug: 826203 Change-Id: I7ea7594cca5c2ebf66805db0dfacd0183cc7a6d4 Reviewed-on: https://chromium-review.googlesource.com/1038944 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
