- 08 Aug, 2011 17 commits
-
-
timurrrr@chromium.org authored
Fix a typo in the prev patch Increase the number of stacktrace frames to 40 TBR=bruening Review URL: http://codereview.chromium.org/7585035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95810 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
Remove redundant header and center the confirmation message. BUG=chromium-os:18798 TEST=Check enterprise enrollment confirmation page on WebUI OOBE. Review URL: http://codereview.chromium.org/7584017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95809 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
If the gaia login frame is loaded right away when the main OOBE UI loads, there's no chance for the enrollment handler to set up chrome.dialogArguments, which gaia_login.js however requires to initialize correctly. So, defer loading of the gaia login frame to the point the enterprise enrollment screen actually gets shown. BUG=chromium-os:18736 TEST=Enrollment triggered through the accelerator finally works. Review URL: http://codereview.chromium.org/7550048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95808 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
Previously, the code would only change the CSS classes for the current and the next step. This resulted in any steps between these two to incorrectly remain at their old state, which results in the next transition not working. BUG=chromium-os:18736 TEST=Enterprise enrollment screen is actually visible when triggered through accelarator. Review URL: http://codereview.chromium.org/7541047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95807 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
This way, we'll not miss keyboard events due to the focus being in an embedded iframe, as used e.g. on the gaia signin page. BUG=chromium-os:18736 TEST=Accelerators still work, even from within the gaia signin page. Review URL: http://codereview.chromium.org/7550043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95805 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7585029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95804 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Also: * improve readability and completeness of the drmemory_analyze script * add BROWSER_WRAPPER support to the Dr. Memory runner (for ui_tests, browser_tests, etc) TBR=bruening BUG=http://code.google.com/p/drmemory/issues/detail?id=546 Review URL: http://codereview.chromium.org/7491093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95803 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=92026 TBR=bruening Review URL: http://codereview.chromium.org/7595003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95801 0039d316-1c4b-4281-b951-d872f2087c98
-
avayvod@chromium.org authored
- removed i-beam cursor for labels - lowercases labels tet - changed buttons height to 29 pixels - 1px border around EULA texts - checkbox label font smaller - Learn More link color changed BUG=chromium-os:17335 TEST=Go through WebUI OOBE manually and verify the changes in description. Review URL: http://codereview.chromium.org/7582008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95799 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
BUG=66458 TEST=DevToolsManagerTest.NoUnresponsiveDialogInInspectedTab Review URL: http://codereview.chromium.org/7565008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95798 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=chromium-os:14807 TEST=manual testing Review URL: http://codereview.chromium.org/7569004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95783 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=chromium-os:14807 TEST=manual testing Review URL: http://codereview.chromium.org/7550027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95782 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
scale of these parameters in the TTS API, the conversion to Chrome OS values was done incorrectly and this fixes it. BUG=91883 TEST=manual testing Review URL: http://codereview.chromium.org/7550049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95781 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/7563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95780 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://settings/cookiestzik@chromium.org authored
BUG=88644 TEST='BrowsingDataQuotaHelperTest.*' Review URL: http://codereview.chromium.org/7387007 TBR=tzik@chromium.org Review URL: http://codereview.chromium.org/7491085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95779 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/7583030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95777 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/7572015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95774 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Aug, 2011 9 commits
-
-
thakis@chromium.org authored
The previous increase made almost all interactive_ui_tests pass in Debug, but DevToolsSanityTest.TestShowScriptsTab DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh are still failing. They used to take 23.3s and 24s with gcc, and the DevToolsSanityTests got about 5s slower in Debug on 10.5 (less on 10.6). BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7583029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95771 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
This is to test if the browser_test and interactive_ui_test failures on the mac dbg builds after the switch to clang are due to tests narrowly missing their timeout -- that's what it looks like locally. BUG=91371 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/7569033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95770 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=None TEST=None TBR=achuith@chromium.org Review URL: http://codereview.chromium.org/7541067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95768 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Cycle bots BUG=none TEST=none Review URL: http://codereview.chromium.org/7569032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95766 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
Clean up macros which do one-time initialization of static pointer to histograms to use subtle atomic operators. r=willchan, dvyukov BUG=7535006 Review URL: http://codereview.chromium.org/7535006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95762 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Suppresses leaks introduced with r95607 related to BrowsingDataQuotaHelper. Generalizing suppressions. BUG=91836 TEST=Valgrind and HeapCheck bots turn green. TBR=tzik@chromium.org Review URL: http://codereview.chromium.org/7584025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95761 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Suppresses leaks introduced with r95572 related to BrowserAccessibilityManager. Another suppression. BUG=91845 TEST=Valgrind and HeapCheck bots turn green. TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/7541066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95760 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Suppresses leaks in WebIntentsRegistry introduced in r95710. BUG=91950 TEST=Tests go green on Valgrind and HeapCheck bots. TBR=groby@chromium.org Review URL: http://codereview.chromium.org/7491082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95756 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/7491081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95755 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Aug, 2011 14 commits
-
-
thakis@chromium.org authored
displayName is set to initialName in -[BookmarkEditorBaseController awakeFromNib], and initialName is [@"" retain]. This seems to return a new object with clang but the same object with gcc. Not relying on internalized strings seems cleaner in general. BUG=none TEST=tree goes green TBR=mrossetti Review URL: http://codereview.chromium.org/7569030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95753 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95752 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=7229 TEST=1- Launch Chrome Task Manager and select any process/puglin in the window. 2- Hit Alt E(/e) to kill that process. R=evan@chromium.org Review URL: http://codereview.chromium.org/7582025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95751 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
Based on a patch by altimofeev http://codereview.chromium.org/7461117/ BUG=chromium-os:17892 TEST=manual Review URL: http://codereview.chromium.org/7520037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95750 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/7491080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95747 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/7583027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95746 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/7584023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95744 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95739 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
To get my trivial fixes of base/md5.h BUG=None TEST=None R=thestig@chromium.org Review URL: http://codereview.chromium.org/7584022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95738 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95734 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=browser_tests --gtest_filter=FormManagerTest.MultipleLabelsPerElement Review URL: http://codereview.chromium.org/7541059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95732 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
BUG=72492 Review URL: http://codereview.chromium.org/7572046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95731 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
R=rvargas@chromium.org Review URL: http://codereview.chromium.org/7569005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95730 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
TBR=vrk@chromium.org Review URL: http://codereview.chromium.org/7541061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95729 0039d316-1c4b-4281-b951-d872f2087c98
-