- 27 Mar, 2020 40 commits
-
-
Nate Fischer authored
If no flags are toggled, flags are shown in the same order (the order hardcoded in ProductionSupportedFlagList). If the user has already toggled some flags (enabled/disabled), these flags float to the top of the list when the user revisits the UI. The flag order only moves when we recreate the flag UI. So flags will stay in the same place as the user interacts with the UI, and only move as a convenience if they return to the UI and need to go back to default. This is mostly consistent with chrome://flags (the difference is that we won't reset the order when the user clicks "reset all to default," for simplicity and convenience if the user changes their mind to re-enable some of those flags). Fixed: 1059478 Test: Manual - verify flags float to the top when I revisit the flag UI Change-Id: I01cac5e7c38b35be765c3e111f4b0d5ea4e3941f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124532Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754165}
-
Sergey Ulanov authored
Currnetly runner always redirects AudioCapturer to the agent and the AudioCapturer implementation provided by the agent supports echo cancellation, noise suppression and automatic gain control. Also, in the future the default AudioCapturer will implement these effects as well. Updated AudioManagerFuchsia::GetInputStreamParameters() to report these effects as supported. This ensures that WebRTC will not try to use built-in versions of these effects. Bug: 1065207 Change-Id: I9997dc603544441c0e1bc96516915943e08d7a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124305 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754164}
-
Jiawei Li authored
Adds a ExecuteJavaScript method for CastWebContents to run script on the main frame's context. The method would accept string script and a OnceCallback that is used to receive a result later. Bug: Internal b/150822089 Test: cast_web_contents_browsertest Change-Id: I15e43f62036907e667278f954d06b0bb035c59cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123639 Commit-Queue: Jiawei Li <lijiawei@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754163}
-
dpapad authored
Bug: 1026426 Change-Id: I1016b954c98bad62d1c121f590beffbbbb9610fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123187 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#754162}
-
Matt Jones authored
Bug: 952703 Change-Id: I70e46da08c593b4f94d6225cc7cff2f152010da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121265Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#754161}
-
Nico Weber authored
We only ship 64-bit asan runtimes on Windows, so we shouldn't try to build 32-bit binaries in 64-bit asan builds. Also improve an existing assert so that it catches problems like this at `gn gen` time in the future, by using current_cpu instead of target_cpu. Bug: 1065287 Change-Id: I511e50b9578650f85c0beb236ee1de9af6166fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125029 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#754160}
-
Andrew Grieve authored
Adds a 'print-certs' command that prints certificate info. * --full-cert: show the full Base64-encoded signature of the cert (useful for config_webview_packages.xml) * --sha256: show the SHA-256 digest of the signature (useful for trichrome/static shared libraries) E.g.: out/Default/bin/trichrome_library_apk print-certs --sha256 out/Default/bin/monochrome_bundle print-certs --full-cert Bug: 889704 Change-Id: I510baacbb39e98b86f8b19bf8e4dd0217eeffb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119200 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754159}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/41820cd74f31..c3051401526b git log 41820cd74f31..c3051401526b --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jbudorick@chromium.org infra: stop overriding boto credentials. Created with: gclient setdep -r src/native_client@c3051401526b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1059443 Tbr: mseaborn@chromium.org Change-Id: Ie47017b5e7479d67ce85ce4427f2c56a07da13f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754158}
-
Ken Rockot authored
This also does a minor refactor of the target structure. Blink and non-Blink bindings share typemap traits for GpuMemoryBufferHandle, and those traits in turn depend on the non-Blink variant of bindings for GpuMemoryBufferPlatformHandle. Prior to this CL, that unconventional dependency was present but not obvious. The native buffer handle mojom types are separated out from the rest of buffer_types.mojom so that both (Blink and non-Blink) variants of the latter can depend on the non-Blink variant of the former. Finally, as recommended for all typemaps shared between Blink and non-Blink variants, the corresponding traits are also moved into their own component targets. Bug: 1059389 Change-Id: I86e9806bc3c0f5059ed99398c6e46065aaa02272 Tbr: sadrul@chromium.org Tbr: dtapuska@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111834 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#754157}
-
Brandon Wylie authored
Bug: 1053251 Change-Id: Ic258955a7cd1466e3afe54cfa5205d083afe28cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117937Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754156}
-
Emily Andrews authored
Before this change, if the min_version was set on a nested enum then it would not compile. This change updates that if statement and adds a new test case to validate the scenario. Test: Run mojo_unittest.exe Bug: 896777 Change-Id: I68fe3878d89d114b5601a00770d9653dc764ebd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119660 Commit-Queue: Emily Andrews <emiled@microsoft.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#754155}
-
Robert Ogden authored
Bug: 1023486 Change-Id: I6d343f49e9ad120ba4f88afc968f5cbd01b6d176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121348 Auto-Submit: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#754154}
-
Aaron Leventhal authored
Use more accurate scrollability check that matches the scrollable state with the presence of a scrollbar. Use the same technique to determine scrollability as blink/renderer/core/page/spatial_navigation.cc Also improves the AccessibilityScrollableOverflow dump tree test: - Class name matches scrollable state for easy debugging - Loading test page reveals green dashed line around expected scrollable elems, red solid line around any elements expected to not be scrollable. - Test more cases of odd x-hidden and y-hidden cases. In the x-hidden case, the renderer makes this content vertically scrollable if there content. Bug: None Change-Id: I10f266e65ad5442ad20caf25a7b94c9dfd2192ef Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120105Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#754153}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/058444fabc78..2e33129995df git log 058444fabc78..2e33129995df --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jophba@chromium.org Add discovery to standalone receiver Created with: gclient setdep -r src/third_party/openscreen/src@2e33129995df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ie6939fd9f161d9292041972e765097a478bd09a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124822Reviewed-by:
-
Antonio Gomes authored
Relevant notes: - The test named was changed to flexbox-overflow-auto-001.html. - the 'background: -webkit-radial-gradient(...)' was changed to the cross-browser accepted variant, 'background: radial-gradient()'. Its gradiend value was also made simpler. - The descriptive <p> in the test body was intentionally left, so that manual testing is clear. - Test seem to produce in Firefox a result that does not match the expectation html file. BUG=1063749 R=dgrogan@chromium.org Change-Id: Ic49f28aca13cfa11d6e187a1801654384436e5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124598Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#754151}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c8974b38bff1..3ca41df3d3ba git log c8974b38bff1..3ca41df3d3ba --date=short --first-parent --format='%ad %ae %s' 2020-03-27 bclayton@google.com Regres: Add llvm.Version.Download() to download and verify a LLVM toolchain Created with: gclient setdep -r src/third_party/swiftshader@3ca41df3d3ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I15bacf96bca30f5f711ea1acc00648483ddc3bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124816Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0dd5482c5254..d94f8ea2b545 git log 0dd5482c5254..d94f8ea2b545 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jbudorick@chromium.org gclient: update logging.warn to logging.warning. Created with: gclient setdep -r src/third_party/depot_tools@d94f8ea2b545 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idd70dc23d833c0b1db5817ac517297df3e968151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123885Reviewed-by:
-
Peng Huang authored
Bug: 1065499 Change-Id: Ib0dde0f46f73d73dbb580a6cc03288b6c0337c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124687Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754148}
-
Sammie Quon authored
In CrOS, using overview can allow us to close the transient parent of a file dialog. This will cause a crash while closing a browser windows with the certificates file dialog open. So let the dialog know not to send CertificatesHandler any notifications after CertificatesHandler has been destroyed. Test: manual Bug: 1012658 Change-Id: I0315dfa33f21108be67d36019d8e17d7587d0e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125030Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#754147}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2cae3b05ea2b..f95a35fb706f git log 2cae3b05ea2b..f95a35fb706f --date=short --first-parent --format='%ad %ae %s' 2020-03-27 egdaniel@google.com Remove some unused 3 byte vertex attrib types. 2020-03-27 robertphillips@google.com Make the distanceFieldAdjustTable a static singleton 2020-03-27 jvanverth@google.com Minor fixes for D3D build. 2020-03-27 bungeman@google.com Fix gcc9 warning around size of memset. 2020-03-27 csmartdalton@google.com Rename GrGpuTessellationPathRenderer to GrTessellationPathRenderer 2020-03-27 nifong@google.com Remove deprecated functions 2020-03-27 reed@google.com onProgram for overdraw-colorfilter 2020-03-27 bsalomon@google.com Remove texture swizzle from GrSurfaceProxy. Created with: gclient setdep -r src/third_party/skia@f95a35fb706f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056730 Tbr: robertphillips@google.com Change-Id: Ie1d8434047cfe876f8de31c293727023194b55ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124821Reviewed-by:
-
Reilly Grant authored
To investigate issue 1045372 some crash keys were added to log the old and new frame tokens however this doesn't work for the flaky browser tests I am investigating in issue 1022321. This change adds log messages which should show up when the test flakes. Bug: 1022321 Change-Id: If1c88d1cea3dc771c96a4d636b6797a8686b6315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123030 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#754145}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If9d344b84e58ecd730c26be997a7bacf8990dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125011Reviewed-by:
-
Varun Khaneja authored
R=xinghuilu Change-Id: Ib12238898aae23f4c60ee5d26701026e15d3cfd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119755 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#754143}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, rename its filename to something more descriptive and less Chromium-specific (it currently references crbug.com/527039). Bug: 1063749 Change-Id: I55e9eb8b1943f1c9f71861b53437cd0e1908889b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124257 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754142}
-
Lei Zhang authored
Move some message sending code into SendDocumentMetadata() and SendLoadingProgress(). Change-Id: Ic9881444f1af57531dc49ee2527ded092d7ffec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122924 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#754141}
-
Adam Langley authored
With M82 canceled, the original plan to leave this on M82 beta for a while is sunk. With M83 picking up two releases worth of changes, it's a poor choice for a potentially disruptive feature like this. It can still be enabled via chrome://flags for testing, but this change disables it by default for M83 to branch off. BUG=1028602 Change-Id: I746a3c7d89199b0521a68c6231a1dbef82027dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124599 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#754140}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a0519c673493..395a627b8ad8 git log a0519c673493..395a627b8ad8 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 rmhasan@google.com [Typ] Add getters for raw tags and raw results to Expectation Created with: gclient setdep -r src/third_party/catapult@395a627b8ad8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050754 Tbr: wenbinzhang@google.com Change-Id: Iaa8f1206b7599b8924d45ebe7c279e49de043a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124670Reviewed-by:
-
Evan Stade authored
This relands commit ce01fae5 but instead of including dialog_strings.grdp from two different grd targets, it uses the WebLayer components string whitelist. A small amount of extra work had to be done to package the strings tagged formatter_data="android_java" in components_strings.grd into a java string target. TBR=tedchoc@chromium.org Bug: 1058495 Change-Id: I94aae6e9f75f5252123fb83b6ade28cbf5c1f3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124699Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#754138}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7f8640cc02c10a929fe536ae31073b4a72849019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124873Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#754137}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/276eb74c..761afa07 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ff7a17671a6fcadc4d7b14b5f075e70b8bc0382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754136}
-
Xiaohan Wang authored
Historically media_service_unittests needs a different test runner and involves a standalone binary with it's main() function and mojo manifest file. So we had put the tests in its own test target. After several redesign and refactoring, now these tests are just normal unit tests. There's no reason to treat them separately anymore. This CL folds media_service_unittests into media_unittests to simplify our test code. Bug: 1062194 Change-Id: I62ae08706b755622fd348189ecc87192e5e4b797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118582Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754135}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fd3480d22624..7e0699a25089 git log fd3480d22624..7e0699a25089 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 timvp@google.com Create the ProgramExecutable Class Created with: gclient setdep -r src/third_party/angle@7e0699a25089 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Ic026deeb835b8a18d51023cab71b85e37180de58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124808Reviewed-by:
-
Tibor Goldschwendt authored
An interactive doodle can request to be resized via a postMessage. Resize doodle as requested when such a message is received. Bug: 1039910 Change-Id: Icd4563cabf1edc28eb22268c5e7969194cada2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117299 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754133}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4243010e6c8d..4502a6360996 git log 4243010e6c8d..4502a6360996 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 treehugger-gerrit@google.com Merge "Use random session name in HeapprofdJavaCtsTest." Created with: gclient setdep -r src/third_party/perfetto@4502a6360996 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id49f5627d4ca1d481befcf4f3f2879bf04b94988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124820Reviewed-by:
-
Justin Donnelly authored
I couldn't check out the branch during my branch sheriff shift yesterday until I figured out that I needed to run git fetch. This CL basically copies the similar note from: https://www.chromium.org/developers/how-tos/get-the-code/working-with-release-branches Change-Id: I00a09a995ccedf49ea535f6ab3ed56d8c32eed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124306Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#754131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60f529d224f9..a35ca2b5e91d git log 60f529d224f9..a35ca2b5e91d --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jacktfranklin@chromium.org E2E test for element breadcrumbs 2020-03-27 tvanderlippe@chromium.org Remove unused global references from sdk-legacy.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@a35ca2b5e91d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032561,chromium:1064958 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie4fef47e92ca38c9aad0e9b566c336e40f4d93a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124812Reviewed-by:
-
rbpotter authored
Bug: 1026426 Change-Id: I3f20bae0e8fe0c22d401efb633ffaec80d93a12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123769Reviewed-by:
-
David Bokan authored
This is a small cleanup. The code here was added way back in https://crrev.com/ba35627328434 as part of https://bugs.webkit.org/show_bug.cgi?id=11985. Today, scrollbar enabled state is computed explicitly in UpdateScrollbarEnabledState. I believe this is no longer needed, to see why: - This will only make a difference if the scrollbars were disabled prior to reaching this method. - If the scrollbars were disabled and were overflow:scroll, this means they didn't have overflow - If overflow was added at the same time as the style changed, we'll do a layout and update enabled state in UpdateAfterLayout or UpdateAfterOverflowRecalc - Otherwise, the scrollbars will be removed as there's no overflow and we're in overflow:auto|visible|hidden. Bug: None Change-Id: Iabc37c6933f43726529fb7fb19436393c53a5014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123635Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754128}
-
Tommy Martino authored
TBR=pkasting@chromium.org Change-Id: I304210aac096854f666cafa2103ee9aed9f0df96 Bug: 1065474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125007Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#754127}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7aacaca. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" a1caf42e "[css-flexbox] Move flex-item-contains-strict.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I63a5abde01fbfe26cf3884495fb590a651135b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124730Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754126}
-
