- 26 Mar, 2020 40 commits
-
-
Rune Lillesveen authored
A FirstLetterPseudoElement is marked for style recalc when the text node the first letter belongs to is removed from the DOM tree. On the next style recalc, if the first-letter's originating element is inside a subtree marked for layout tree re-attachment, or one of its descendants are marked for re-attachment, we delay the first-letter style update until UpdateFirstLetterPseudoElement is called for the kRebuildLayoutTree or kAttachLayoutTree phases. For the former, we call RecalcStyle which will ClearNeedsStyleRecalc, but ofr the kAttachLayoutTree phase, we called StyleForLayoutObject without clearing the dirty flag. Bug: 1064595 Change-Id: Ibebb9c358b473f61b1cff49a7c5ec43bf6894408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122347Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753806}
-
Yuri Wiitala authored
miu@ will be going on a personal leave for 2020Q2. This adds mfoltz@ to relevant Screen Capture, Mirroring UX, and Cast Streaming OWNERS files to ensure a stakeholder with long-term background knowledge is available for code review. Change-Id: I62b9ae7cfd278f320b566c919408a3456f2a67a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122915 Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753805}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dca61aa30a9..97094993b251 Created with: gclient setdep -r src-internal@97094993b251 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053589,chromium:1056962,chromium:896775 Tbr: jbudorick@google.com Change-Id: Iaff14c7e85a8b632e2eb4dc4ad32467afd06e4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122868Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753804}
-
Tommy Nyquist authored
Disable on Android since the test is very flaky, particularly on android-marshmallow-arm64-rel bot. Bug: 1016118 Change-Id: Ie8f1a90a1c26fdc008746a19ef6337ee62661188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122866 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#753803}
-
Brian Sheedy authored
Adds a --bypass-skia-gold-functionality flag to //build/android/test_runner.py which causes all tests that use Skia Gold to skip any actual interactions with Gold. This is meant to be used in the unlikely event that there's a Gold outage that can't be fixed quickly so that the outage does not block CLs, etc. Bug: 1057848 Change-Id: If34b2b8a86fd8a5020d2f5fbc8fc823e66186ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122859Reviewed-by:
-
Ben Pastene authored
Bug: 812428 Change-Id: If8f5473d965ad4cbe07c4bdf46f80458d9473918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110513Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#753801}
-
Javier Ernesto Flores Robles authored
Bug: 1045456 Change-Id: Ibf91aff0fef477255751a689692be281d098ceba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119530 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753800}
-
Xianzhu Wang authored
In CompositeAfterPaint, though backface-visibility:hidden doesn't directly cause compositing, it's very likely that we'll composite the element (when we find its backface-visibility is different from the previous paint chunk), and it indicates preference of compositing, so it's mostly beneficial to prepare for compositing in paint properties: - by creating PaintOffsetTranslation to avoid raster invalidation on paint offset change; - by preferring composited scrolling. Change-Id: I57a59d17a3e864416c479d788291f3a201644c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121355Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753799}
-
Vladislav Kuzkokov authored
Bug: 1060700 Change-Id: Icb823ccdb4cac17e4a6ee7a5885d59e4722a7b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098662 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#753798}
-
Devlin Cronin authored
Extensions used to be able to override the bookmark star view in order to provide a custom bookmark manager (this was used for the Stars extension). The extension has been deprecated and removed, and the API never launched. Clean up the remnants. Remove the logic for the StarView being hidden if there's an overriding extension installed. Bug: 894447 Change-Id: I57381c688ddacac747391a9af432e8375e16ca83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119387Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753797}
-
Thiemo Nagel authored
Bug: none Change-Id: I016a3d1f1c16778c82e026953a34d140f712966f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122530 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753796}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4085.6-1584959535-benchmark-82.0.4085.16-r1 to 83-4085.6-1584959535-benchmark-83.0.4091.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9021f73f7f8596ef3daf3123b28240d9a0d90a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753795}
-
Devlin Cronin authored
Extensions used to be able to override the bookmark star view in order to provide a custom bookmark manager (this was used for the Stars extension). The extension has been deprecated and removed, and the API never launched. Cleaning up the remnants. Remove the logic to hide the default bookmarks commands conditionally if an overriding extension is installed. Bug: 894447 Change-Id: Iddbdb96171fb567ee9adf06390cfa4668996d58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119805 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753794}
-
Ahmed Mehfooz authored
Bug: 1065079 Change-Id: I0646096217a8cdef1715061cb0b60f440c4a6240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122862Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753793}
-
Tommy Nyquist authored
The test has recently been very flaky across many Android bots. TBR=sahel@chromium.org Bug: 825629 Change-Id: I64bac3833f92da55bae524af11ac1ce39b10c594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122748 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d25ae4048565..ba15ec2dc8ee git log d25ae4048565..ba15ec2dc8ee --date=short --first-parent --format='%ad %ae %s' 2020-03-26 tmathmeyer@chromium.org Clean up stale code 2020-03-26 aerotwist@chromium.org [e2e] drop to one job Created with: gclient setdep -r src/third_party/devtools-frontend/src@ba15ec2dc8ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4f4988ffd60859ce4515e92251da768efbe1e705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122731Reviewed-by:
-
Peter Kasting authored
Running |done_callback_| may delete |this|; it's not safe to continue execution after that point. Bug: 1064898 Change-Id: Iffcb4ac54d928c90c207f3455521dac08de0a469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122865 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#753790}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idc78ccc972665f768dbc39b4b11c0a8379e438ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122872Reviewed-by:
-
yilkal authored
This cl ensures that www.website.com matches website.com in SupervisedUserUrlFilter. Bug: 1032811 Change-Id: Ic76ffde2457d029fbb25acaf6f41e048cbca17b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092125 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753788}
-
Xianzhu Wang authored
The result has no effect in pre-CompositeAfterPaint. Disable it to avoid performance impact and reduce risk. Bug: 1064712 Change-Id: I4f826c719c581b86b6ff2508b710508ef291e788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122618Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753787}
-
Regan Hsu authored
NOTE: There are still unresolved A11y issues. The current A11y follows the same rules for the chrome browser search input. See https://drive.google.com/file/d/1aXwE_2OJb6uMqhiyKLFOCyQ_c0sqrLxM/view * Hides old search UI and shows new search UI when flag is on. * Produces a list of random results when user inputs into search bar. * Basic stylization to account for when screen is narrow mode. * JS handling for keyboard and mouse events, highlighting correct row. * Temporary stylizations and functions for testing. * Rows are not actionable yet but are forced to via tabindex. * Modified os settings ui and os toolbar so that the old search UI is not impacted but provides permissive environment for new UI. * Tests. Screenshots: * Regular (wide) mode: https://screenshot.googleplex.com/9zZVYXoOzzQ * Narrow mode: https://screenshot.googleplex.com/tpR1jMg0Cjv * Narrow mode (not showing search): https://screenshot.googleplex.com/Labxcscu47U Bug: 1056909 Change-Id: I5d8ae7313cfb799ead69dad6ffb06f4c4bcc4f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099468Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#753786}
-
Peng Huang authored
Bug: 1064853 Change-Id: I01e2762b292147e655701af61a647206f0a88576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122849Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753785}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/37457d5e1826..9f2dd0d07c99 git log 37457d5e1826..9f2dd0d07c99 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 capn@google.com Fix taking aspect into account for image view identifiers 2020-03-26 bclayton@google.com Kokoro: Move llvm configs into 7.0 subdirectory, create 10.0 copies. Created with: gclient setdep -r src/third_party/swiftshader@9f2dd0d07c99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I36f8d33f7dca127a9711d4e7a06639c9cc261187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122466Reviewed-by:
-
Joel Hockey authored
Move background-color lookup into crostini_terminal since we are also adding pass-ctrl-w and it is better to colocate them. Bug: 1060861 Change-Id: Id55c9672007cabcb635fce7022d64544b1158f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121115 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#753783}
-
Hongbo Song authored
The current values of NumInputEvents are too high. The reason is sending the actual value of num_input_events from render to browser will cause recounting input events. Instead, we need to send the delta of the values. The function DidChangePerformanceTiming() on line 277 will call functions that send page load timing metrics from render side to browser. When the browser receives the updated page load timing metrics, it will merge timing values received from different frames together. For NumInputEvents, TotalInputDelay and TotalAdjustedInputDelay, we sum up all values(PageLoadTimingMerger::MergeInteractiveTiming()), which means we should send the deltas of them. So we need to reset the values after sending them to the browser. Basically, this CL is for two things. 1) Resetting the values when interactive_detector sends metrics to metrics_render_frame_observe. 2) Resetting the values when page_timing_metrics_sender sends the metrics to browser side. Code flow Sending metrics from render side: DocumentLoader::DidChangePerformanceTiming() => ... => PageTimingMetricsSender::SendNow() => MojoPageTimingSender::SendTiming() => PageLoadMetrics::UpdateTiming() Receiving metrics on browser side: PageLoadMetrics::UpdateTiming() => ... => PageLoadMetricsUpdateDispatcher::UpdateMetrics() => PageLoadMetricsUpdateDispatcher::UpdateMainFrameTiming()/UpdateSubFrameTiming() =>PageLoadTimingMerger::Merge() => PageLoadTimingMerger::MergeInteractiveTiming() This CL is just a temporary fix. There will be another CL for plumbing all input delays to browser and doing calculation on browser side. Bug: 1051042 Change-Id: Ia58243295cdc90974ce1cb3bf53e3b6bee3c482e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084100 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#753782}
-
Chisoon Jeong authored
Depending on compilation environment, trace_event_memory_overhead.h|cc is not compilable, owing to missing <string> header. Change-Id: I8e52e7bae33e68d5dc3cc08b1d38fcd3c87303a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117932Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#753781}
-
Sujie Zhu authored
Change hardcoded year to NextYear. Also update NextYear implementation with suggested AutofillClock. Bug: 1059087 Change-Id: Iaf5bc8c74775c2e1bcab06b0c0b7e87a74281aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103654 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#753780}
-
Etienne Bergeron authored
This CL is adding a sampling profiler track for the compositor thread to slow-reports. The TracingSamplerProfiler is responsible to take CPU sampling profiler and put them into tracing iff slow-reports is activated. The class destructor is responsible to stop CPU sampling if needed. The sampling profiler will be working for the whole tracing session. The TracingSamplerProfiler is able to manage turning on and off tracing at any point in time. For users not part of the control population, this should not affect the performance at all. Bug: 1064662 Change-Id: I658e97fcc6585918b6762878ade3a1ddb31f3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119220Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753779}
-
Ahmed Mehfooz authored
This was added previously to make sure focus navigation worked if notifications were cleared. We only need to activate the quick settings widget and not focus an element in it. Bug: 1062219 Change-Id: I7a4ae2ebb007872306e712dcc91a269f990ebbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117151Reviewed-by:
-
Jon Mann authored
Wi-Fi sync needs to know the ssid and security type of a network in order to remove it from sync. Once a network has been removed this information is no longer available. This observer method allows us to cache the required metadata for use once we know that the removal was successful. Bug: 966270 Change-Id: Ic850ae8fc75fe600ce70ca2a161bb4281be4119e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110392 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#753777}
-
Etienne Bergeron authored
This CL is removing the old tracing system in net::disk_cache. The tracing is only active in debug build, or if manually toggle an ifdef in trace.cc (see #define ENABLE_TRACING 0) R=gab@chromium.org, morlovich@chromium.org Bug: 1065004 Change-Id: I8d0b85975b15896078d9275fd9ab6ac6174338e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122449Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753776}
-
Adam Ettenberger authored
With the Narrator setting "Sync the Narrator cursor and system focus" enabled, and the user navigates from the browser UI into the document frame, the root Document should be focused. If IFrame content had focus before it was moved to the browser UI, when returning to the document frame the last focused item within the IFrame regains focus. This happens either when using the Tab key or Narrator Item Navigation. With Narrator Item Navigation however, the focus should be moved to the root Document upon entering the document frame. This is because Narrator explicitly requests focus on the item via IRawElementProviderFragment::SetFocus (AXPlatformNodeWin::SetFocus). This ends up calling BrowserAccessibilityManager::SetFocus which attempts to do 2 things in this scenario : (1) Return focus to the Accessibility View (AccessibilityViewSetFocus) (2) Focus the target Element (AccessibilityPerformAction) AccessibilityViewSetFocus ends up focusing the IFrame content with this approximate stack : AccessibilityViewSetFocus BrowserAccessibilityManager::OnWindowFocused BrowserAccessibilityManager::FireFocusEventsIfNeeded BrowserAccessibilityManager::GetFocus BrowserAccessibilityManager::GetFocusFromThisOrDescendantFrame BrowserAccessibilityManager::FireFocusEvent After focus has been returned to the IFrame content, the call to AccessibilityPerformAction should now focus the targeted element. However this does not happen because it ends up calling AXNodeObject::OnNativeFocusAction which only calls ClearFocusedElement for the root document. This call does not affect the nested Frame, and focus remains within the IFrame. This change aims to fix this corner case, and allow focus to be set on the requested Document. Bug: 1064339 Change-Id: I5648483a4463ecd8e4105624c84293e0be68f8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116541Reviewed-by:Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753775}
-
Julie Jeongeun Kim authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I6bbe8dfdf8a20049114b498e2bc4c0695526cd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120998 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#753774}
-
Matt Jones authored
The usages in this class were in an unused method. Bug: 952703 Change-Id: Icb36d4205dee45374323d2b4d009caed1cae8ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122612Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#753773}
-
Justin Miron authored
This re-lands the blink/content renderer changes of https://crrev.com/c/2108343 fixed for the chromeos build with --thintlo. The fix adds a clang annotation to the FrameView class which crashed due to a compiler customization of the vtables. Annotating the class with clang::lto_visibility_public prevents this automatic optimization. Change-Id: I849f07fb2cd3a5afde861589ca0a55a13ca84e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112233 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753772}
-
David Tseng authored
TBR=dtseng@chromium.org Fixed: 1064947 Change-Id: Ica62f840395880fce96bc73cb1e7eb8e948d23cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122464Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753771}
-
Wenjie Shi authored
There is a rare access violation bug in the Windows sensor WinRT API that causes the client code crash on Windows RS5. The Chromium sensor backend on Windows is using these WinRT APIs if the build is on Windows 10 (RS5 is a build of Win10) so Chromium is crashing due to this issue. The WinRT bug was fixed in Windows 19H1. This CL updates the Chromium sensor backend to only use the WinRT APIs if the system is on build 19H1 or above to avoid the AV. Bug: 1063124 Change-Id: I6c9eb02170e5d62a75ea6ee511369254e27a9652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122616 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753770}
-
Sammie Quon authored
According to [1], a sequence of gesture events is generated by the gesture recognizer. These events currently all share the same event target so if the target gets invalidated by the first event, the next event would crash when we try coordinate conversion using the dangling pointer. This can happen if the backdrop is visible with a non-resizable app. On swipe/fling we'll get a sequence of SCROLL_END -> GESTURE_END. The SCROLL_END event will get processed and Hide the non-resizable app, which will trigger the backdrop to destroy. Then the GESTURE_END will crash when it tries to do coordinate conversion. To fix this, move coordinate conversion outside the loop as the results should be the same. [1] https://docs.google.com/document/d/1mQFx99xz5jVUHQk2jZTjHPgMjRQd4EUDfdLG0XKOlWI/edit Test: added test Bug: 1064618 Change-Id: I91c9e0955d01a651a779a800149a73f6c545a767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119632Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753769}
-
rbpotter authored
Migrate these 3 smaller elements in site_settings/ to Polymer 3. These elements don't have corresponding unit tests. Bug: 1026426 Change-Id: I8fde01cfc2cf94b5710c5fe70df7ad91fc393927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121501 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Avi Drissman authored
This reverts commit e334b16e. Reason for revert: Breaks win-asan https://ci.chromium.org/p/chromium/builders/ci/win-asan/11193 ../../sandbox/win/src/process_mitigations_dyncode_unittest.cc(414,31): error: code will never be executed [-Werror,-Wunreachable-code] std::wstring test_command = L"CheckPolicy "; ^~~~~~~~~~~~~~~ ../../sandbox/win/src/process_mitigations_dyncode_unittest.cc(490,31): error: code will never be executed [-Werror,-Wunreachable-code] std::wstring test_command = L"CheckPolicy "; ^~~~~~~~~~~~~~~ Original change's description: > Enable -Wunreachable-code on Windows. > > TBR=reillyg > > Bug: 346399 > Change-Id: I7f52d34dd3be08485c1aace38f2f61d1d4f14176 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122428 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753741} TBR=thakis@chromium.org,reillyg@chromium.org,rsesek@chromium.org Change-Id: I289e69d3147aa774a5637fffa850f55015ea5d67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 346399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122434Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753767}
-
