GitLab

Bug: 794289
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If1ed00732e07bd0f9b3bdf2cf97cd257d8054f8e
Reviewed-on: https://chromium-review.googlesource.com/1069793Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562027}

This is a new User Policy that is used to determine if Sync Consent
should be displayed for the user during login.

TBR=atwilson@chroumium.org

Bug: 841156
Change-Id: Ibf5e0bdbe7a1037b6c2760032901e3cbe1924146
Reviewed-on: https://chromium-review.googlesource.com/1073623
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562026}

This adds the missing override of viz::OutputSurface::UpdateGpuFence
to content::VulkanBrowserCompositorOutputSurface.

Bug: none
Test: compile

Change-Id: I8dc0c40d98c16f4bb85c404b51f654f90bce47ca
Reviewed-on: https://chromium-review.googlesource.com/1073063Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562025}

This optional method is not implemented by native content classes.

Bug: 725239
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I70bb3e0e308762bd90c354769eccd1cc2616ed73
Reviewed-on: https://chromium-review.googlesource.com/1073676Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562024}

With these gn args:
is_clang = false
target_cpu = "x64"

the file fails to compile due to uint64 -> uint32_t conversion.

Change-Id: I76126e6d170f01eedcccfd3a17f6aa4184753fe9
Reviewed-on: https://chromium-review.googlesource.com/1071287Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562023}

This CL:
1. Stops null-checking the WebContents when considering to block popups.
   All callers pass in a valid contents already.

2. Tests the case when a caller calls ShowBlockedPopup with an invalid
   id. This seemed like a more reasonable API to be defensive with, but
   it wasn't tested.

Bug: None
Change-Id: I3913ed540b06f57e7fd31cae1f7da7de4da37dab
Reviewed-on: https://chromium-review.googlesource.com/1073847Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562022}

Bug: 823365
Change-Id: I847384bf51dfe78dcb772afde72d7d19c876b44b
Reviewed-on: https://chromium-review.googlesource.com/1073659Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562021}

Remove FrameTokenAllocator since it is no longer needed or used.

BUG=811961

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I760a1dcaf220dd13d8b4ac448de911ec46acf593
Reviewed-on: https://chromium-review.googlesource.com/1073081Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562020}

https://chromium.googlesource.com/catapult.git/+log/0ceb1eccef76..393b0fd9c739

$ git log 0ceb1ecce..393b0fd9c --date=short --no-merges --format='%ad %ae %s'
2018-05-23 wangxianzhu [Tracing UI] Use ResizeObserver for picture chart resizing

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:842238


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1a64cd37f4324f1a7e07e206129016c8dca424c0
Reviewed-on: https://chromium-review.googlesource.com/1073644
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562019}

This cl adds the support to toggle the shortcut view by the same
shortcut: Ctrl + Alt + /:
1. If the KSH window is active, close it.
2. Otherwise, open it (if it's not open already) or activate it (if it's
   open but not active).

Bug: 819815
Test: New unit test KeyboardShortcutViewTest.ToggleWindow
Change-Id: Icbc9fba5644208750d1632b7473c66f53b923a80
Reviewed-on: https://chromium-review.googlesource.com/1073101Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562018}

This CL is a refactor with no intended behavior change.

This CL:
  * Removes the mojom interface ClientProcesss::EnableHeapProfiling.
  * Removes the implementation, primarily hosted in MemoryDumpManager.

Change-Id: Id55835da60d86520f692385930208a31206f7dce
Bug: 822843
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1069000Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562017}

We removed ash::Config::MUS as part of the switch to //services/ui/ws2.
ShellPortMus isn't used independently anymore.

Bug: 841941
Test: ash_unittests --enable-features=Mash
Change-Id: I506a0526aebd8b90f07d654ceaad8f90891106cb
Reviewed-on: https://chromium-review.googlesource.com/1072454
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562016}

When elements don't have scope, setting the model value throws an
undefined element exceptions, causing autofill to fail.
Test existence of scope before updating model.

Bug: 846730
Change-Id: Ia1119604252829d2012bfc728de297607aa92883
Reviewed-on: https://chromium-review.googlesource.com/1072473Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562015}

https://pdfium.googlesource.com/pdfium.git/+log/710fa99b0bd2..d4d645abecec

$ git log 710fa99b0..d4d645abe --date=short --no-merges --format='%ad %ae %s'
2018-05-25 rharrison Reserve space for code words when creating encoder context

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:846027


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I26d090f4a72bd512979b45a7799106a90ad1cc68
Reviewed-on: https://chromium-review.googlesource.com/1073680
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562014}

The W3C Gamepad spec says that gamepad timestamps should be returned
as DOMHighResTimeStamps relative to the navigationStart attribute of
the PerformanceTiming interface.

This CL modifies the internal Gamepad buffer to store the timestamp
as a 64-bit signed integer count of milliseconds since the base::TimeTicks
origin. When returning the value to the page, the value is converted to
a DOMHighResTimeStamp relative to navigationStart.

Additionally, all gamepad data fetchers are modified to set the
last-update timestamp using the base::TimeTicks clock.

This is a reland of commit: 2464a382
The first attempt broke OculusGamepadDataFetcher and was reverted:
https://chromium.googlesource.com/chromium/src/+/fb0674220c41322d99ba8a08347356af20061bbd

BUG=398642

Change-Id: I1a77881be388d91131443d93e22395e3f5a78363
Reviewed-on: https://chromium-review.googlesource.com/1070996Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562013}

Background:
New specs require that an item can be dragged to next page without
having to fill up the current page. However, all items in launcher
currently are laid out linearly and no gap is allowed between items. And
the item's visual index (e.g. (i, j) means ith page and jth slot.) can
be calculated by it’s model index (index of the item view in
|view_model_|) via formula:

visual_index.page = model_index / max_items_per_page
visual_index.slot = model_index % max_items_per_page

However, this formula does not work for new specs, so we need a new view
structure to map from model index to visual index.

Changes:
1. Add a view structure to represent the item view's structure we show
   to users.
2. Add functions to operate on the view structure: load, save, sanitize,
   move, remove, add, etc.
3. Create a new page if the user drag an item to the end of last page.
4. Put everything behind a home launcher flag because it is part of home
   launcher feature.

Design doc: go/applist-gap

BUG=837871

Change-Id: I9718bfca0ebf31da5a5d63aa73c4a6f1fb20459a
Reviewed-on: https://chromium-review.googlesource.com/1058715
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562012}

Restructure new download home code to pull out the list specific
information from the DownloadManagerCoordinator.  This will make it
easier to separate the rest of the code (things like undo snackbars,
etc.) from the list specifics, and allows us to just expose the list
coordinator to keep the interfaces clean.

Bug: 842345
Change-Id: Id2bf042f3e2af865ee741dfce18cd6427aea5b66
Reviewed-on: https://chromium-review.googlesource.com/1072152Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562011}

The tab switch button wasn't quite vertically centered in the GM2
style result view, and the icon was being clipped. This CL makes
provisional size changes to make them fit.

Bug: 780835
Change-Id: Ia72cb406088f50c2e22c0929e9e0acdb8d0db31e
Reviewed-on: https://chromium-review.googlesource.com/1069569Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562010}

Currently, resizing sometimes doesn't always adhere to the aspect
ratio when the window also moves (origin point updates) alongside it.

OnNativeWidgetMove() is called in these cases. With this change, if the
sizes of the previous and new bounds are the same, the window was only
moved rather than resized. This change will make
OnNativeWidgetSizeChanged() handle the updates for |current_bounds_|.

BUG: 829677
Change-Id: Id7df25c0a888efa4b2a7cad39cf83105aa03a759
Reviewed-on: https://chromium-review.googlesource.com/1071125Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562009}

Omitting kNoClockless allowed the renderer to pull frames quickly rather
than trying to ratelimit them at the video fps. This was causing the
video to finish playback in the short timespan between being resumed and
suspended, causing the 'WaitUntilOnEnded' call to incorrectly return
early, as the 'ended_' attribute on the PipelineIntegrationTest had been
set to true. This ended_ boolean is only reset on a seek or a resume,
none of which had come after the suspend. This was flaking because
sometimes the video _wouldn't_ finish before the Suspend call, leaving
the pipeline test in an unended state.

Bug: 836785
Change-Id: I89d4382354e4cfcd6593b69f6cc02d6821492e41
Reviewed-on: https://chromium-review.googlesource.com/1072955
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562008}

Since the InputChanged_ observer was tracking both validity and the
input string, it generated intermediate states in which validity was
true and the setting value was set to an invalid value, as the input
value had not been updated. Fix this issue.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibb35e8e825c3d4177d4c99a59dc6dcd5275969a6
Reviewed-on: https://chromium-review.googlesource.com/1072697Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562007}

DevToolsEmulator::HandleInputEvent handles the case of a gesture pinch
being handled on the main thread. Since touchscreen gesture pinch
events are all handled on the compositor thread, this workaround is no
longer needed.

Bug: 787924, 734201
Change-Id: I3499c1129b0ee529a8d218a652c69e258fa93fc0
Reviewed-on: https://chromium-review.googlesource.com/1073401Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562006}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8933c795ce0eb05ab54ef5bf92342cd21c2299c8
Reviewed-on: https://chromium-review.googlesource.com/1073678Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562005}

Per UX feedback, add some space between the close button and the edge
of the window.

BUG: 836389
Change-Id: Id527c868b6beef25e7278e737faa2e0aff4ea469
Reviewed-on: https://chromium-review.googlesource.com/1071233
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562004}

This CL is exactly the revert of the diff between patch 6 and 7 of
CL 1013211:
https://chromium-review.googlesource.com/c/chromium/src/+/1013211/6..7

It was assumed that GURL and std::string are equivalent for this use
case. However GURL converts spaces in urls to "%20", therefore
wallpaper_manager.js fails to use the url to find the currently set
wallpaper. It's observed that this issue is only reproducible for
wallpapers whose urls have space.

Think it makes sense to use std::string since the url is not used for
downloading purpose. (Using url as wallpaper id is not the best
solution IMO, but changing it is a separate task.)

Bug: 846264
Change-Id: Ie83b6d9e95dccbe44dd8fca8c0843a85fcfd9758
Reviewed-on: https://chromium-review.googlesource.com/1072700Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562003}

Bug: 644851
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I759a98701d50bad4347ae5f44e49a11a3b9cdd45
Reviewed-on: https://chromium-review.googlesource.com/1054526
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562002}

Change-Id: Iac5d986f51b86b5c43b20d9cbf1f742684aa610b
Reviewed-on: https://chromium-review.googlesource.com/1072790
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562001}

CanEngineStart specified the required conditions for creating the
SyncEngine object: CanSyncStart() plus a refresh token being available.
The refresh token condition was there because creating the engine will
trigger a request for an access token. Previously, that request would
fail in unhelpful ways if the refresh token wasn't loaded yet.
Now however, PrimaryAccountAccessTokenFetcher handles that situation
just fine, it'll simply wait for the refresh token.

So this CL removes the refresh token condition from ProfileSyncService.

Bug: 825190, 842697
Change-Id: Ica57945f93efcdf8597c1bdfdbda19a0b879e6d9
Reviewed-on: https://chromium-review.googlesource.com/997796
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562000}

Bug: 846405
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I83be26f39db7175b2726052a98311e120bd3a2ee
TBR: jochen@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1073398
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561999}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/13f43437558c..faaf41e886aa

$ git log 13f434375..faaf41e88 --date=short --no-merges --format='%ad %ae %s'
2018-05-23 agable Remove PatchChrome command

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:770408


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I12953870db5d4be3b20d54bbbd523559e053ea40
Reviewed-on: https://chromium-review.googlesource.com/1073661Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561998}

Includes "null check for encryption info", reviewed here:

https://chromium-review.googlesource.com/1072163

This CL does not roll to origin/master, since that is currently in
a broken state (merge from upstream fails on the bots).  Instead,
1da9c3346d8 has origin/merge-m68 as a parent.

Created with:
  roll-dep src/third_party/ffmpeg
BUG=832852, 846009

Change-Id: I09714fed74c90c6173a9fc8c33db7458fc26b38f
Reviewed-on: https://chromium-review.googlesource.com/1072520
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561997}

BUG=846623
TBR=tapted@chromium.org

Change-Id: Iafb9b3b179e35f4847d87c887a58b143524d0ce0
Reviewed-on: https://chromium-review.googlesource.com/1073372Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561996}

The implementation was wrapped with a DCHECK_IS_ON() condition by
https://codereview.chromium.org/2653073002/ but the DCHECK_IS_ON() check
inside the implementation was not removed. Remove it to make the macro
a little easier to read.

Bug: 684105
Change-Id: Ia0e923f89432b31fc2ec32b7438e5e6c416433bf
Reviewed-on: https://chromium-review.googlesource.com/1072455
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561995}

Instead of having a 'frame token' for communicating with the embedder,
and a separate 'presentation token' for getting presentation token, use
a single 'frame token', with explicit 'send_frame_token_to_embedder' and
'request_presentation_feedback' flags.

BUG=811961
TBR=reveman@ for trivial changes in fast_ink and exo

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I40765f62d27908f3f999487333113bbb096ae7cc
Reviewed-on: https://chromium-review.googlesource.com/1072702
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561994}

This CL renames DelegatedFrameHost::SynchronizeVisualProperties =>
DelegatedFrameHost::EmbedSurface. RenderWidgetHostImpl::SynchronizeVisualProperties
makes sense because it sends across a set of VisualProperties and a
viz::LocalSurfaceId to the child whereas the DelegatedFrameHost method actually
embeds that viz::LocalSurfaceId that's being sent to the renderer.

This CL renames that method to something more appropriate and less confusing.

Bug: 672962
Change-Id: Icc9b5a1438c9efaab9ddb5f4f37f0ff62e1d5df1
Reviewed-on: https://chromium-review.googlesource.com/1073654Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561993}

Change most of arguments of type CompletionCallback by constant reference to
CompletionOnceCallback by value, and change most const or non-const
CompletionCallback type members to non-const CompletionOnceCallback in
//net/proxy_resolution, and in some other places as necessary.  This is part of
//the larger transition effort described on the bug.

In addition to changing type, also:
* avoid move to local variable when unnecessary;
* remove unused MockAsyncProxyResolver::callback() method;
* inline ProxyResolutionService::InitProxyResolver::DoCallback() and
  PacFileDecider::DoCallback(), both only called once;
* include completion_callback.h in //chromeos where
  CompletionCallback is used but was only transitively included.

Bug: 807724
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib9e08f54988abb6655f2efd68fc6169ff12e9b20
Reviewed-on: https://chromium-review.googlesource.com/1066291Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561992}

This will use the canonical URL specified in the <link rel="canonical">
element when it exists instead of the actual URL. Most notably this gets the
canonical URL for AMP pages. Since this means there are potentially two separate
URLs per page, we add a canonical URL to the readiness state object.

Bug: 844123
Change-Id: Ib5e99fdd284006a7402136d78ea89cca31181f32
Reviewed-on: https://chromium-review.googlesource.com/1067679
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561991}

This cl adds the handling of OnSpeechLevelUpdated and sends the level to
ActionView. It is a preparation work in order to make LogoView update
the dots amplitudes based on the speech level in kUserSpeaks mode.

Bug: b/80259367, b/78191547
Test: manual.
Change-Id: I9547437fd129d0cb2056fcdd2ba5d37e580e9b8c
Reviewed-on: https://chromium-review.googlesource.com/1072421
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561990}

In https://crrev.com/c/924027, we blocked copy command if selection is
hidden, but also incidentally broke copying on image documents because:
- We don't have visible selection on image document
- Copying on image document is done via a fast path that doesn't check
  selection at all, but the CL blocked the fast path

This patch moves the fast path before checking selection visibility,
so that the original copy behavior on image documents is recovered.

Bug: 845957
Change-Id: I920198d13ab3aa387f550c5c213fcbadc42fd43e
Reviewed-on: https://chromium-review.googlesource.com/1072730
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561989}

Implement a new video decode path using Android Image
Reader API which is available from OREO+. Using android
image reader, both GL and Vulkan textures can be created
from video frames which is the main motivation behind this
new path. Existing SurfaceTexture based path will be the
used for android versions < OREO.

Bug : 838725

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib44ac6128340b1419c2bdcc786e3d9d59614e462
Reviewed-on: https://chromium-review.googlesource.com/963506Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561988}