- 05 Feb, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4460b2d2..6a299ca2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4f90b81c6dfc1e8c4aa59e1c07af50878ac781ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738445}
-
Xiaoqian Dai authored
Modified based on the new spec: A window has to be dragged toward the direction of the edge of the screen for a minimum of 96dp to a point within 48dp of the edge of the screen, or dragged inside 8dp from edge to be snapped. Bug: 1021294 Change-Id: I2d79854b37bfdf36bcd5319a856b874233159982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037825Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#738444}
-
Mitsuru Oshima authored
Add DCHECK to make sure that panel rotation returns the correct value when a display is updated on Android. Bug: 1048294 Change-Id: Iad2747325ea724a23a66ce340c3c3984ace54a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037640Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738443}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/30f6fc14e50c..bdd9db2010fa git log 30f6fc14e50c..bdd9db2010fa --date=short --first-parent --format='%ad %ae %s' 2020-02-04 oysteine@google.com Fixed category used for JSON exported StackCpuSampling events 2020-02-04 treehugger-gerrit@google.com Merge "tp: add support for non-Perfetto root relative proto imports in metrics" 2020-02-04 treehugger-gerrit@google.com Merge "gn: Make enable_perfetto_trace_processor overrideable" 2020-02-04 treehugger-gerrit@google.com Merge "UI: fix mm_event path" 2020-02-04 treehugger-gerrit@google.com Merge "processor: Translate streaming profile packet timestamps to boottime" 2020-02-04 treehugger-gerrit@google.com Merge "traced_perf: use address-specific loads/stores for ring buffer pointers" 2020-02-04 fmayer@google.com Merge "Mention enabling Perfetto in heapprofd quickstart." 2020-02-04 taylori@google.com Merge "perfetto-ui: Stop accidental area selections" 2020-02-04 treehugger-gerrit@google.com Merge "remove off64_t wrappers + minor unwind class renaming" 2020-02-04 treehugger-gerrit@google.com Merge changes I1686fefc,Ic59c153c Created with: gclient setdep -r src/third_party/perfetto@bdd9db2010fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1046918 Tbr: perfetto-bugs@google.com Change-Id: If09d813a926b9b96efd602c7eae63a14869920a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738442}
-
Eriko Kurimoto authored
This CL adds shared-worker-options-credentials.html for web-platform-test. Bug: 1048966, 824646 Change-Id: Ib35daf5ba96ddd03bb1881757e86e8251c1a3456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037294 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#738441}
-
Julian Watson authored
Bug: 1048962 Change-Id: I7db787ea4d42457507962d6e7b359405117015a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035479 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738440}
-
Ken Rockot authored
Removes the last usage of Mojo associated interfaces from DOM Storage code. Prior to this change, associated interfaces are used to synchronize Clone() operations on a StorageNamespace interface with arbitrary mutations on any StorageArea bound through that StorageNamespace. With the introduction of the Mojo async flushing API in r730829 we can enforce such synchronization without associated interfaces. This CL does that with a simple two-phase flush at clone time: - Flush all related StorageArea pipes immediately prior to Clone - Tell the StorageNamespace pipe to pause until said flushes complete - Call StorageNamespace.Clone() - Flush the StorageNamespace pipe immediately after Clone - Tell all related StorageArea pipes to pause until that flush completes This achieves the necessary ordering constraints for Session Storage cloning without requiring strict ordering among all StorageNamespace and StorageArea messages, consequently allowing StorageNamespace and StorageArea to use independent pipes connected to potentially different processes from each other. This satisfies a key requirement for migrating Session Storage to the Storage Service. Bug: 1000959 Change-Id: Ic1ccc2d6cbfa462733c53d2052d616655b49ed53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036885 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#738439}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e4a40aa1bf4..0165beed0829 git log 2e4a40aa1bf4..0165beed0829 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 fancl@chromium.org Removing requirement of notification_email from subscription Created with: gclient setdep -r src/third_party/catapult@0165beed0829 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1048033 Tbr: rmhasan@google.com Change-Id: I83bade8ad8ceb04a5383eda55d01b5a338e6e638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738438}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e93101895e74..44ea3ffa40fe git log e93101895e74..44ea3ffa40fe --date=short --first-parent --format='%ad %ae %s' 2020-02-05 ehmaldonado@chromium.org Revert "presubmit_support: Add --all-files options." 2020-02-04 ehmaldonado@google.com presubmit_support: Pass a gerrit object instead of a cl object to PostUploadHook. 2020-02-04 ehmaldonado@google.com presubmit_support: Add --all-files options. 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@44ea3ffa40fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324,chromium:1048885 Tbr: agable@chromium.org Change-Id: Icded7207eee771f694ae4555e93c29deaec79018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738437}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I382b2f7eef3897248263a7c7dda8849f58ca1536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035630Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#738436}
-
Christopher Thompson authored
This exposes the control config for legacy TLS errors to the network stack. This is loosely based on the same design that the CRLSet component installer uses: 1. Installer passes to network service via Mojo 2. Network service keeps a LegacyTLSConfigDistributor which tracks observers that care about the config 3. SSLConfigServiceMojo registers an observer to get the latest config 4. SSLConfigService exposes an interface to check ShouldSuppressLegacyTLSWarning() This change also moves the tls_deprecation_config.proto into the network service, and adds a ref counted wrapper around it (so that the LegacyTLSConfigDistributor can pass them to the observers without lifetime issues). This currently duplicates the control config set (there is a copy in the browser and a copy in the network service). A followup CL will address this. The new cert error is introduced in https://crrev.com/c/1894616. The new interstitial is introduced in https://crrev.com/c/1940707. Bug: 896013, 1039756 Change-Id: I31fee71c292ffe8b592d3c6f47c3352ed4475892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906779Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#738435}
-
Mei Liang authored
This CL cleans all existing message cards if GTS can be shown quickly, then re-appends them to the end of GTS. These steps are required, since the internal model resets only when the GTS can't be shown quickly. Change-Id: I30fce1a2eda27e38a42bf05fd6090be769e40427 Bug: 1043202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007344 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738434}
-
Jiawei Shao authored
This patch moves the creation of WireServerCommandSerializer from the constructor of WebGPUDecoderImpl to the call of HandleRequestDevice as the preparation of supporting multiple Dawn devices in the server side. This patch also moves SendRequestedDeviceInfo and SendAdapterProperties from WireServerCommandSerializer to WebGPUDecoderImpl as they are independent of Dawn devices and not related to any wire commands. This patch also passes the device_descriptor in adapter.CreateDevice() which was missed unexpectedly. BUG=chromium:996713 Change-Id: Id12367f077cd89ecd032414c00d9172c7b66756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037089Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#738433}
-
Dana Fried authored
See comment in source code linked to this bug for an explanation. Attached bug contains crash report link. Bug: 1048363 Change-Id: I9b6e3cd10bd8fe1ea5466e950a3a47b61659b191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037648 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738432}
-
Yoshifumi Inoue authored
This patch marks "external/wpt/selection/idlharness.window.html" slow. TBR=yosin@chromium.org Bug: 1048204 No-Tree-Checks: true No-Try: true Change-Id: Ibce06c7bb63790ff7c97d060e64c99e16e14755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038294Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738431}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia9bbb3db69735738eee7e3495911673f5c0ed90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038350Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738430}
-
gogerald authored
This CL also fixes the issues that 1, MobileStartup.UserEnteredTabSwitcher is not recorded when onStartWithNative is called earlier than createInitialTab Bug: 1048318 Change-Id: I3549ad1fb250046fe293dd2437375abced1254e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036253 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738429}
-
Ben Pastene authored
These tests have started failing after fec354dc. Tbr: guidou@chromium.org Bug: 1048934 Change-Id: Id54e609d286cea6c4b2506edc11c3bc1433d46c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038253 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#738428}
-
Anand K. Mistry authored
Also rename to MountPreconfiguredShare() to avoid the confusion between mount/remount/premount. Bug: 939235 Change-Id: If9df3a55b4aea6852468078b2188974adf35af24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035504 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#738427}
-
Ben Joyce authored
See https://chromium-review.googlesource.com/c/chromium/src/+/1830506 -Update build.gn dependencies for androidx update. -Change an import for androidx annotations that should have been when all other annotation imports were migrated to androidx. Bug: 896775 Change-Id: Ie22118da7841fac029aee37a5c1d10b78325b87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036407Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#738426}
-
Daniele Castagna authored
Originally RemoveOverdrawQuads looped trough all the renderpasses and did some computation for the non-root ones, and then executed occlusion logic on the root one. A CL that removed the computation for non-root renderpasses landed, making the loop always skip his body for all the renderpasses but the root one. This CL removes the loop and executes the occlusion logic only for the root renderpass. Test: RemoveOverdrawQuadPerfTest.* Change-Id: Ie92deae2b5fb65e1f5be605f79bc47bfc9de36bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033368Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#738425}
-
Ken Rockot authored
CachedStorageArea is ref-counted and was retaining an unsafe reference to a GCed object which it may outlive. This changes that reference to a WeakPersistent and ensures that we don't dereference it once it's no longer valid. Fixed: 1048234 Change-Id: I9971b35b9aa7db790236f92c353a2320740f7729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036383 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#738424}
-
Ken Rockot authored
The refactoring in r715377 failed to expose general-purpose child process interfaces to the browser from plugin processes. As a result, histogram collection and tracing don't function as expected in plugin processes. This fixes that. Fixed: 1043019 Change-Id: I7d32e0d4de091cd3e6a343d7cf1604ff65a2ff8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037345 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738423}
-
Nicholas Verne authored
We restart vm when upgrading, if it wasn't running already. Bug: 1024693 Change-Id: I00e093f7bbf83eb04a6adb4029a4612e99950ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026559Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738422}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: I8a45a90fe282c1c25f893bf4ce2c42b2543d196f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032554Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#738421}
-
Lei Zhang authored
The removed method is only used in PrintPreviewMessageHandler, and PrintPreviewMessageHandler already has ShouldUseCompositor(), which does exactly the same thing. Once all the calls to ShouldCompositeDocumentUsingIndividualPages() has been replaced, PrintPreviewMessageHandler::OnMetafileReadyForPrinting() now has: if (ShouldUseCompositor(ptr)) { if (ShouldUseCompositor(ptr)) { ... } else { // Dead code. } } Remove the dead code and simplify the surrounding code. With the cleanup, OnMetafileReadyForPrinting() can also make its IPC parameter check more strict. Change-Id: I137f0ceb82f40ede6b61ac3c29fd43d99c12851a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037088 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#738420}
-
Lei Zhang authored
In the |kFeatureEntries| struct, each FeatureEntry has a name and a description. As is, for "message-center-redesign", |kMessageCenterRedesignName| is used in both fields and |kMessageCenterRedesignDescription| goes unused. Fix the typo so the description is set to |kMessageCenterRedesignDescription|. Change-Id: I130b795b656fdb27c4474e785ab83db230176d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037082Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#738419}
-
Xida Chen authored
This CL adds a few perf tests for the on-screen no damage cases. To be more specific, we create animations that causes no damage, for example animation from translateX(0) to translateX(0). At this moment, the on-screen no damage cases should not report any histogram, because the frames_expected would be 0. Bug: 1048163 Change-Id: Id315e98b32d5a9e55b85a96d1ed2d5d59003a983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035858Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738418}
-
Minggang Wang authored
The current mojom struct ResourceLoadInfo defined in //content is used to notify the status of a resource loading, which is unavailable inside Blink. Along with the implementation of OnionSoup of loaders, we are going to notify the loading status from Blink directly. So we have to move this mojom struct into Blink in order to leverage it there. This CL makes the changes below: - Remove the ResourceType in //content and its typemap and replace with the mojom one. - Move the resource_load_info.mojom into Blink. Change-Id: I11ab3b7107bd4e06ee3ec737f825202c533a466c Bug: 860403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986640 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#738417}
-
Kent Tamura authored
Enable rendering of the shadow element of <select>, and remove anonymous block in LayoutMenuList. * HTMLOptionElement::ParseAttribute(): Update the shadow element content on option[label] change. * HTMLSelectElement::UpdateFromElement(): Fold LayoutMenuList::UpdateFromElement() into here. If option_style_ and InnerElemnet's style are inconsistent, update InnerElement's style. * HTMLSelectElement::UpdateMenuListLabel() Move the code in LayoutMenuList::UpdateInnerStyle() here. Also, kick TextChanged ax notification which LayoutText::ForceSetText did. * MenuListInnerElement::CustomStyleForLayoutObject(): Set "display: block" Add custom style which the anonymous block used. * layout_menu_list.{h,cc}: Remove a lot of code. * ax_layout_object_test.cc: Add tests to check if AXLayoutObject::StringValue() respects to text-transform and -webkit-text-security. * web_tests/accessibility/notification-listeners.html: Remove TextChanged notification expectation. After this CL, <select> won't notify TextChanged in this test scenario. The text is changed before creating LayoutObject and AXLayoutObject. Bug: 1040828 Change-Id: Ia0c19f0897ab2d1461e457c83adceda2c0739f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024250Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738416}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I7728ca5b5bfda31be35c10609a2602e6efd6adfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035518Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738415}
-
Md. Hasanur Rashid authored
This CL update the function GetOriginUsageOnFileTaskRunner to use url::Origin instead of GURL. Bug: 598424 Change-Id: Id88ee97f35f68dbc557c86e07f4431fb95271676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032556Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#738414}
-
Rachel Sugrono authored
When an item in a check-select is deleted, onFileSelectionChanged_ must ensure that the current index wraps to stay in bounds of the new selection. When we wrap, favor the bottom entry. Tests coming. Tbr: alex Bug: 803259 Change-Id: I0a6c1f4a22770ad48040695f2b170dcd0db50459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035474Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#738413}
-
Kenneth Russell authored
conformance/extensions/webgl-compressed-texture-astc.html conformance/extensions/webgl-compressed-texture-s3tc-srgb.html are failing on webgl2_conformance_gl_passthrough_tests on Intel GPUs after recent ANGLE changes. Tbr: jdarpinian@chromium.org Bug: 1048861 No-Try: True Change-Id: Iffa429a14ba13a19ef8d3b32cd34c343d7ef9e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037829 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#738412}
-
Darren Shen authored
Change-Id: I51f0c14c738ba2a6592ddd8ae73726fe2802d926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035816 Commit-Queue: dstockwell <dstockwell@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#738411}
-
Kenneth Russell authored
This reverts commit 5019665f. Reason for revert: broke capture_unittests on chromeos-amd64-generic-rel per http://crbug.com/1048934 Original change's description: > Reland "Call MFShutdown in places where MFStartup is called" > > This reverts commit 5be12bf8. > > Reason for revert: Fixing the issue, and running on more trybots > > Original change's description: > > Revert "Call MFShutdown in places where MFStartup is called" > > > > This reverts commit abf9a1f5. > > > > Reason for revert: Broke tests on Win7 dbg, see linked bug > > > > Original change's description: > > > Call MFShutdown in places where MFStartup is called > > > > > > Bug: 1012527 > > > Fixed: 1012527 > > > Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332 > > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#738063} > > > > TBR=xhwang@chromium.org,tmathmeyer@chromium.org > > > > Change-Id: I267213cc06b42769736c7eb337432ade7953de20 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1012527 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036057 > > Reviewed-by: Marc Treib <treib@chromium.org> > > Commit-Queue: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738130} > > TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org > > Change-Id: I8f87e933e133d0dcbf9904c002af7738af450f41 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1012527 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037811 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738344} TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org Change-Id: Ieba1f172a5a2bed58e338f15c638c6deae8b0685 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012527, 1048934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037855Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738410}
-
Kenneth Russell authored
This configuration's been forced to use only the integrated GPU due to graphics driver bug workarounds, so these tests don't pass on this configuration. Tbr: enga@chromium.org Bug: 1047573 No-Try: True Change-Id: Id6e436ae118a1fbb552cfebd995f689b274f893e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037826 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738409}
-
Regan Hsu authored
This CL copies over the final strings that are missing from browser settings to OS settings, and removes the browser string provider from OS settings. Bug: 967888 Change-Id: Iebf0880fb3ef94df67e9bc4fea14ad286b0c18ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036263 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738408}
-
Anand K. Mistry authored
Constants defined in the mojom are re-exported as part of the public API. Adding the mojom as a public dep ensures the header files are generated before trying to compile any dependent target. Bug: 939235 Change-Id: I80b72bcf2ab7a722ebdd3c6c2703fbb546affad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037298Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738407}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ae44760. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I85a7219e516a2ae566bca595883c26e13f359ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037935Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738406}
-