GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb219a0..71085d0

TBR=

Review URL: https://codereview.chromium.org/806523002

Cr-Commit-Position: refs/heads/master@{#308271}

Add OAuth2 authentication for speech recognition requests from the launcher, when audio-history is opted-into.

Audio history allows a user to see the speech recognition result at https://history.google.com/history/audio. This change will attach an auth (OAuth2) token to the recognition request, which is used to associate the request with the user. This only happens when the user opts-in to audio history, and only on speech recognition from the app launcher.

This change adds a helper class that handles retrieving and refreshing the auth token, and plumbs that token into the speech recognition request.

BUG=397019

Review URL: https://codereview.chromium.org/778393002

Cr-Commit-Position: refs/heads/master@{#308270}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/502e869..cb219a0

TBR=

Review URL: https://codereview.chromium.org/797183003

Cr-Commit-Position: refs/heads/master@{#308269}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2e542d..502e869

TBR=

Review URL: https://codereview.chromium.org/805573005

Cr-Commit-Position: refs/heads/master@{#308268}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b676431..f2e542d

TBR=

Review URL: https://codereview.chromium.org/787923003

Cr-Commit-Position: refs/heads/master@{#308267}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d8c8e9e..b676431

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/789103005

Cr-Commit-Position: refs/heads/master@{#308266}

Review URL: https://codereview.chromium.org/800783003

Cr-Commit-Position: refs/heads/master@{#308265}

Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally using run_tests script).
Fix a failing test from this file.

Found this while fixing unit test for max_failures patch
(https://codereview.chromium.org/790673005/).

BUG=440101

Review URL: https://codereview.chromium.org/805593002

Cr-Commit-Position: refs/heads/master@{#308264}

Pipeline generates OnPipelineSeeked and OnPipelineBufferingStateChanged
events in response to seek operations. There is an event generated already
for OnPipelineBufferingStateChanged but missing one for OnPipelineSeeked.

Follow up fix for https://codereview.chromium.org/740663002/
Required for landing https://codereview.chromium.org/456343002/

Review URL: https://codereview.chromium.org/791233003

Cr-Commit-Position: refs/heads/master@{#308263}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1607156..fbaace0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/804463004

Cr-Commit-Position: refs/heads/master@{#308262}

Editable HTML content is very laggy when it is relatively large. Lag
is caused by creation of WebRange object with given location and offset.
Bigger the editable content and farther the location, the more the lag.

Currently we create WebRange object twice - once for checking presence
of text (plain) and again for fetching actual plain text. It causes the
lag to double the actual value. This patch removes unneccessary double
creation of WebRange.

Sample page and traces showing the lag and improvement with this patch
are attached with the bug.

BUG=396051

R=avi,jochen,yosin

TBR=jochen

TESTS=None

Review URL: https://codereview.chromium.org/795493003

Cr-Commit-Position: refs/heads/master@{#308261}

Cr-Commit-Position: refs/heads/master@{#308260}

Updates cryptotoken to 0.9.10:
 - Implement eTLD+1 checking of appIds
 - Smaller bugfixes

BUG=426358
R=juanlang,xiyuan

Review URL: https://codereview.chromium.org/799923007

Cr-Commit-Position: refs/heads/master@{#308259}

We "white list" some exceptions which user story runner can continue running
the rest of user stories even if they are raised during the test run.

Those exceptions are:
page_test.Failure
util.TimeoutException
exceptions.LoginException
exceptions.ProfilingException
page_action.PageActionNotSupported
exceptions.AppCrashException (except if this is thrown inside
shared_user_story_state.state.TearDownState(), which indicates a failure of
recovering the test state)

BUG=437735

Review URL: https://codereview.chromium.org/755323012

Cr-Commit-Position: refs/heads/master@{#308258}

Revert of Generalize V4L2 HW video codec device names (patchset #3 id:40001 of https://codereview.chromium.org/786993002/)

Reason for revert:
Still hitting crbug.com/439175 on Pit.

Original issue's description:
> Generalize V4L2 HW video codec device names
>
> Switch to more generalized V4L2 video accelerator device names and update
> sandbox rules to reflect that.
>
> After video_ChromeHWDecodeUsed autotest is fixed, this cl is submitted again
> due to crrev.com/730693005 reverted in crrev.com/784553004.
>
> BUG=405861, 437598, 439175
> TEST=passed video_ChromeHWDecodeUsed with h264 and vp8 on peach_pit.
> Media.GpuVideoDecoderInitializeStatus value is 0 when playing a video
> from youtube. DUT only has /dev/video-enc and /dev/video-dec device nodes.
>
> Committed: https://crrev.com/b777ad3f16655a3493a0ecd9975c58a7b84c740d
> Cr-Commit-Position: refs/heads/master@{#307674}

TBR=jorgelo@chromium.org,wuchengli@chromium.org,scherkus@chromium.org,henryhsu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405861, 437598, 439175

Review URL: https://codereview.chromium.org/792123006

Cr-Commit-Position: refs/heads/master@{#308257}

Revert of Omnibox Watcher: Don't Flag Incidents that are Paste+Enter (patchset #5 id:80001 of https://codereview.chromium.org/795343002/)

Reason for revert:
causes crashes in official builders.
../../chrome/browser/rlz/rlz_unittest.cc:240:14:error: no matching constructor for initialization of 'OmniboxLog'
  OmniboxLog dummy(base::string16(), false, metrics::OmniboxInputType::INVALID,
             ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../chrome/browser/omnibox/omnibox_log.h:22:3: note: candidate constructor not viable: requires 13 arguments, but 12 were provided
  OmniboxLog(
  ^
../../chrome/browser/omnibox/omnibox_log.h:21:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 12 were provided
struct OmniboxLog {
       ^
1 error generated.

Original issue's description:
> Omnibox Watcher: Don't Flag Incidents that are Paste+Enter
>
> The code currently excludes paste-and-go operations.  It should probably
> also exclude paste+enter operations; these are effectively equivalent.
>
> TODO before submitting: test interactively
>
> BUG=
> TBR=bauerb@chromium.org
>
> Committed: https://crrev.com/c281fb257d2acdd247b0692380d084863e2dd462
> Cr-Commit-Position: refs/heads/master@{#308233}

TBR=pkasting@chromium.org,grt@chromium.org,bauerb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/800983005

Cr-Commit-Position: refs/heads/master@{#308256}

Keep track of the display configuration callbacks and trigger them when the
GPU process responds.

BUG=429746
NOTRY=true
TBR=kenrb@chromium.org

Review URL: https://codereview.chromium.org/800743002

Cr-Commit-Position: refs/heads/master@{#308255}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1fdbfa4..d8c8e9e

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/797833004

Cr-Commit-Position: refs/heads/master@{#308254}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1629118..1607156

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/801963002

Cr-Commit-Position: refs/heads/master@{#308253}

woops, when I was testing this, I hadn't noticed the mistake because
I was testing over a white background, and the shadow looks exactly
like the bubble in that case.

I had used the wrong color for the shadow color, and as a result I
didn't notice that the shadow was in the wrong spot.

I did a bit more extensive testing, if you have chrome fullscreen on the
left side, and you show the bubble on the right, it does extend to right
screen by 1 pixel.  This happened before and after my change.

BUG=435910

Review URL: https://codereview.chromium.org/792243002

Cr-Commit-Position: refs/heads/master@{#308252}

Use this for platforms with no control over input devices.

BUG=441856
TEST=build

Review URL: https://codereview.chromium.org/802813002

Cr-Commit-Position: refs/heads/master@{#308251}

Cleaning up since the entry points should not be used/needed anymore.
Also removing the Configure() calls from TakeControl() and replace them
with a call to probe and configure displays.

BUG=429746

Review URL: https://codereview.chromium.org/796263002

Cr-Commit-Position: refs/heads/master@{#308250}

Frankly I'm tired of all the inconsistencies and <!DOCTYPE> looks odd being the
only tag-like thing on the page that's UPPERCASE.

It Officially Doesn't Matter according to the HTML5 spec:
http://www.w3.org/TR/html5/syntax.html#the-doctype

R=estade@chromium.org
BUG=none
TEST=less annoyance

Review URL: https://codereview.chromium.org/802863002

Cr-Commit-Position: refs/heads/master@{#308249}

Not only does this do less work in the browser process, but it also
sidesteps issues with SkBitmap pickling for IPC, resolving a crash
when the user attempts to search for an invalid image.

BUG=431418

Review URL: https://codereview.chromium.org/792903002

Cr-Commit-Position: refs/heads/master@{#308248}

Depends on blink side change in https://codereview.chromium.org/782463002/
and on the blink side change in https://codereview.chromium.org/799703003/

BUG=426458

Review URL: https://codereview.chromium.org/781723002

Cr-Commit-Position: refs/heads/master@{#308247}

BUG=302704

Review URL: https://codereview.chromium.org/798173002

Cr-Commit-Position: refs/heads/master@{#308246}

DXVAVideoDecodeAccelerator::GetState uses InterlockedAdd(0) to get the recent state.

BUG=441000

Review URL: https://codereview.chromium.org/793993002

Cr-Commit-Position: refs/heads/master@{#308245}

In case actions.xml is included in the changelist the chrome/browser/resources/PRESUBMIT.py shouldn't run because the presubmit for actions.xml will do more complete job.

Fixing the bug to look into all changed files in the CL where previously it was only looking at subdirectories of current presubmit script to find actions.xml

BUG=439978

Review URL: https://codereview.chromium.org/760163004

Cr-Commit-Position: refs/heads/master@{#308244}

The proxy config service for android does not allow
one to configure an exception for localhost be made.
The implementation for Linux did allow this in:
   proxy_config_service_linux.cc
it just seems it was overlooked for android.

Instead of adding in the ability to configure
localhost as an exclusion, it makes more sense
to just force the exception; it seems silly to
send traffic for localhost through a proxy.

This patch addresses the following bug in android:
   https://code.google.com/p/android/issues/detail?id=37031

BUG=

Review URL: https://codereview.chromium.org/796003002

Cr-Commit-Position: refs/heads/master@{#308243}

Now since clank supports Enhanced Bookmark feature on tablet, this flag
should be turned on.

BUG=NONE

Review URL: https://codereview.chromium.org/803703002

Cr-Commit-Position: refs/heads/master@{#308242}

The problematic sequence of events is as follows:
1. ShouldRequestOnNonUiThread, which posts a closure
(request_draw_gl_closure_) to UI thread
2. That closure gets run on UI thread, and it schedules the invokeFunctor
with Android framework
3. Before the corresponding invokeFunctor actually happens on RT (which
is DrawGL process mode),  ShouldRequestOnUiTdread is called on the UI
thread. At this point, pending_non_ui_ is not null, we cancel the
callback, which does nothing, because WebView has already scheduled an
invokeFunctor with the Android framework in Step 2. Then we schedule
another invokeFunctor immediately on the UI thread. So there are 2
invokeFunctors queued in Android framework in this case.

This CL tries keep track of whether or not we've
queued an invokeFunctor in Android framework already.

BUG=442013

Review URL: https://codereview.chromium.org/801923003

Cr-Commit-Position: refs/heads/master@{#308241}

Review URL: https://codereview.chromium.org/804663002

Cr-Commit-Position: refs/heads/master@{#308240}

Part of change to collect, upload and expose histogram data
for Cronet.

BUG=441466

Review URL: https://codereview.chromium.org/794493002

Cr-Commit-Position: refs/heads/master@{#308239}

BUG=441966
TEST=Upload a previously selected file from subframe form after restore.

Review URL: https://codereview.chromium.org/805563003

Cr-Commit-Position: refs/heads/master@{#308238}

Add a method to EventDeviceInfo to determine if the device has a
keyboard on it based on the key bitmap. We'll require the first 31 keys
to be considered a keyboard; this is compatible with udev.

TEST=chrome on link_freon & rush_ryu
BUG=437539

Review URL: https://codereview.chromium.org/797483002

Cr-Commit-Position: refs/heads/master@{#308237}

The SurfaceAggregator will never need the resources for a frame after a new frame has been submitted for that Surface, so return the resources early.

BUG=441698,441751,440213

Review URL: https://codereview.chromium.org/800133002

Cr-Commit-Position: refs/heads/master@{#308236}

BUG=437700
TEST=everything builds as before

Review URL: https://codereview.chromium.org/790603006

Cr-Commit-Position: refs/heads/master@{#308235}

BUG=406439
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/802823002

Cr-Commit-Position: refs/heads/master@{#308234}

The code currently excludes paste-and-go operations.  It should probably
also exclude paste+enter operations; these are effectively equivalent.

TODO before submitting: test interactively

BUG=
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/795343002

Cr-Commit-Position: refs/heads/master@{#308233}

We previously were not properly expanding the free list when
dup2 results in growing the descriptor range.

Added of test of this.

BUG=None
TEST=Dup2Allocate
R=binji@chromium.org

Review URL: https://codereview.chromium.org/795213003

Cr-Commit-Position: refs/heads/master@{#308232}