- 27 Jul, 2018 40 commits
-
-
Martin Kreichgauer authored
This changes IsUserVerifyingPlatformAuthenticatorAvailable to return false in incognito mode, and disable platform authenticator instantiation for MakeCredential/GetAssertion in incognito. Also change IsUVPAA to not return true on platforms where Touch ID is enabled but the embedder does not not provide a configuration. Bug: 678128 Change-Id: I2fc6b0182fcb9ae718acd842f1247baee81c5281 Reviewed-on: https://chromium-review.googlesource.com/1149115 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#578535}
-
Koji Ishii authored
Following bot results are included. 8340 8342 8347 8355 8360 8368 8379 8387 8389 0 lines were removed and 4 lines were deflaked by consecutive results since 8322. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iba47345c85b9ae81c4229ac137f0757b1393c219 Reviewed-on: https://chromium-review.googlesource.com/1150956 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578534}
-
chrome://conflictsPatrick Monette authored
Now prefer to show that the group policy is disabled instead of saying that the feature is disabled Change-Id: Ibcfa4a72bce47ad6a98ea6c1fb120117b6705aa8 Reviewed-on: https://chromium-review.googlesource.com/1151544Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#578533}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/203b26f27d00..dbd1612782f5 git log 203b26f27d00..dbd1612782f5 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 geofflang@chromium.org EGL: Implement EGL Image extensions. Created with: gclient setdep -r src/third_party/angle@dbd1612782f5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie36028e0842e1ee560ece98ece793c7b9458577a Reviewed-on: https://chromium-review.googlesource.com/1151209Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578532}
-
Sahel Sharify authored
This is a follow up path for https://chromium-review.googlesource.com/615144 The original patch adds scrollbar flashing logic in the first two cases but skips the last case: 1- All scroll updates other than the first one in a seuqence (the case that scroll node exists). 2- The first GSU while scrolling viewport. 3- The first GSU while scrolling on anything but viewport. This cl covers the third case. Bug: 746342 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I62aafdc68df361fee56b3513a2a09250e3092b32 Reviewed-on: https://chromium-review.googlesource.com/1150436Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578531}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/933672b6cfa1..ac8c0c3138b7 git log 933672b6cfa1..ac8c0c3138b7 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 nednguyen@google.com Log browser state iniside Browser.__init__ upon startup failure Created with: gclient setdep -r src/third_party/catapult@ac8c0c3138b7 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865895 TBR=sullivan@chromium.org Change-Id: I6874a9352991d535b83b4fa8047762a3b3583f83 Reviewed-on: https://chromium-review.googlesource.com/1152271Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578530}
-
edchin authored
This CL adds metrics for snapshotting at the moment when the user enters the tab switcher. The following are possible results of snapshotting: - A snapshot is not attempted if the page is still loading, since the snapshot would be stale. - A snapshot may be attempted but fail. Some known failure cases include when certain videos and video ads are shown on the page. (crbug.com/711455). - A snapshot is successfully taken. Bug: 853569 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iec3fdb87fe6f3008879a24507558fef1757813f9 Reviewed-on: https://chromium-review.googlesource.com/1150769Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578529}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e83d89c060cd..1d201c0289f2 Created with: gclient setdep -r src-internal@1d201c0289f2 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852038 TBR=mmoss@chromium.org Change-Id: Ibbf899b982866bb65858f197a284d1afcb8e1e85 Reviewed-on: https://chromium-review.googlesource.com/1152272Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578528}
-
Stuart Langley authored
SearchMetadata is used to query for recents and file system searches. There are a number of folders under <drive> that are hidden by default, and to be searched needed to be whitelisted. This adds team_drives to the whitelist and adds unit tests to verify that team drives results are returned in searches. Bug: 866575 Change-Id: I583ba06672f3d6a8112680ff22124b65048b74a7 Reviewed-on: https://chromium-review.googlesource.com/1149669Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#578527}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I74b59be8df653f27f4cfb38a24194329067df379 Reviewed-on: https://chromium-review.googlesource.com/1152479Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578526}
-
Koji Ishii authored
This patch changes OffsetForPosition and PositionForOffset functions to accept its source string, and let callers to pass them. The given strings are not used yet in this patch, other than DCHECK with the number of characters in the ShapeResult. Computing grapheme cluster list for all ShapeResult turned out to be not cheap enough for LayoutNG that this patch is the preparation to compute them when needed. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6dc22fda781f63219fba74381da87f1f0b33e85f Reviewed-on: https://chromium-review.googlesource.com/1118062 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578525}
-
Jeffrey Kardatzke authored
This adds support for sending a D-Bus message to Chrome so it launches a terminal connected to a Crostini container. Arguments to be executed in that terminal can also be passed as well. Bug: chromium:853560 Test: Verified with manual testing Change-Id: Ib0126e6fba94e210d9376d57c0f6edb85e667484 Reviewed-on: https://chromium-review.googlesource.com/1149188 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#578524}
-
John Abd-El-Malek authored
Move google_util from components/google/browser to components/google/common so that it can be called in the renderer. Bug: 841313 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I751bf47bf452e6dc365939131fd1e95ceee64d50 Reviewed-on: https://chromium-review.googlesource.com/1152502Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#578523}
-
Christopher Cameron authored
We've previously disabled this, but now try reverting all of the code back to the way it was prior to compositor recycling being possible. TBR=lgrey (revert of files from https://crrev.com/574738) Bug: 863817 Change-Id: I1b933e17c523fb14860284f06631cb2af0c4bf98 Reviewed-on: https://chromium-review.googlesource.com/1152548Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#578522}
-
Yuki Awano authored
- Update kAccessibilityFocusFallsbackToWidgetKey depending on whether ChromeVox or TalkBack is used for the window. - This CL fixes the logic to update window properties. AxTree can arrive to the helper bridge after a window is activated. This CL adds a logic to fix it. confirm that it works. Bug: 866793 Test: Navigate Android window with TalkBack by using keyboard and Change-Id: I911c77229c9a6f338fcdadd81ea5642aaefae084 Reviewed-on: https://chromium-review.googlesource.com/1148099Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#578521}
-
Adam Rice authored
Create watch lists for Blink Streams, net/server and net/websockets. Add ricea@chromium.org to these watch lists, along with blink_websockets. Change-Id: I3f6e9da15b9710a30686597e5d8212f3ada93ac8 Reviewed-on: https://chromium-review.googlesource.com/1151180Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#578520}
-
Adam Rice authored
It is a static method which returns a constant ", " string, and which is only used inside the implementation of DOMWebSocket. Replace it with a compile-time constant. Change-Id: I1bb9ab48421394e6b3f759536d53a56888a3af8f Reviewed-on: https://chromium-review.googlesource.com/1151170Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#578519}
-
Yeol authored
So it replaced AddHeadersFromString with SetHeader in the unit tests. Bug: 862175 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia29ed00a158d1dd37fd0aea28cb71b50320daa8e Reviewed-on: https://chromium-review.googlesource.com/1146411Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#578518}
-
Ross McIlroy authored
This is the default, and doing so prevents passing --no-opt via other means. BUG=chromium:865913 Change-Id: I017d940809020d4015e245e9cb4ac3b166ad67b8 Reviewed-on: https://chromium-review.googlesource.com/1148730Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578517}
-
Jeffrey Kardatzke authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/e0781f23b9e8..2e6185093997 $ git log e0781f23b..2e6185093 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 jkardatzke Add owner/vm/container fields for TerminalParams proto 2018-07-20 smbarber vm_cicerone: add cid to NotifyVmStarted 2018-07-18 smbarber vm_concierge: add more keys to ContainerSshKeysResponse 2018-07-13 xiaochu dlcservice: add service constants 2018-07-13 reillyg system_api: Remove permission_broker RequestPathAccess method 2018-07-18 ljusten authpolicy: Add ERROR_OU_CONSTRAINT_VIOLATION 2018-07-09 ljusten dbus/login_manager: Add "ListStoredComponentPolicies" 2018-07-02 chirantan vm_concierge: Add field for seneschal server handle 2018-06-08 chirantan seneschal: Steward of the user's /home Created with: roll-dep src/third_party/cros_system_api Change-Id: I4d869302f28c1ae0736789973f76b98c8252f9a9 Reviewed-on: https://chromium-review.googlesource.com/1151710Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#578516}
-
Darren Shen authored
We previously added a setHitTestBounds API that allows IME to indicate what area on the keyboard is clickable. However, if IME forgets to set it when the UI changes (e.g. when the container type changes), then the UI may be unusable because it is using another container type's hit test bounds. This patch resets the hit test bounds when we change the container type. Bug: 866380 Change-Id: Ia02d958e8aa8505c82a82121e00647702da4df69 Reviewed-on: https://chromium-review.googlesource.com/1152327 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#578515}
-
Johannes Henkel authored
Add the following abstractions: - A mojom struct, DevToolsSessionState, which is used to send the state to the inspector session in the renderer, and to receive incremental updates from it (see agent_state.mojom). - InspectorSessionState, which interprets the session state received from the browser so that individual properties in the agents (modeled as fields, see below) can be initialized. This object also collects the updates incurred during field mutations. - InspectorAgentState, which connects the fields in the agents to the session state. - Fields in the inspector agent classes. These fields are Boolean, Integer, Double, String, and 1 level maps from String to any of these. For now I've only modified InspectorPageAgent, so the old session state is still there in parallel. Will work on editing the remaining agents. This is a variant of https://chromium-review.googlesource.com/c/chromium/src/+/1147929 which uses protocol::Value to encode the fundamental values stored in the session state. Change-Id: I2c2aa1354884ab6420bac764fbca8497f4785ad1 Reviewed-on: https://chromium-review.googlesource.com/1149201 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578514}
-
Noel Gordon authored
Call it getUnzippedFileListRowEntries, ie. add the FileList part to be consistent with zip helper getZipSelectionFileListRowEntries. Minor: more consistency, use !!result everywhere. Test: browser_tests --gtest_filter="ZipFiles/FilesApp*" Bug: 867738 Change-Id: I448442ac959e44da162fca0c6c15f230fa4bc1dd Reviewed-on: https://chromium-review.googlesource.com/1151587Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a0d5f35..7399ae5d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic0bbb135b76415e58f73b9ee1cc3e2e1f7ee1d8f Reviewed-on: https://chromium-review.googlesource.com/1152421Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578512}
-
Antoine Labour authored
http://crrev.com/c/1105466 changed the precondition for CommandBuffer::DestroyTransferBuffer to only require an OrderingBarrier rather than a full flush, but the implementation in PpapiCommandBufferProxy wasn't fixed to handle that. This change ensures we issue the flush before the DestroyTransferBuffer IPC if one is pending. Bug: 866644 Change-Id: I6d6a3b6a752c4bfcd32f66153c84829140ed2b5f Reviewed-on: https://chromium-review.googlesource.com/1152149Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578511}
-
Oksana Zhuravlova authored
Bug: 861923 Change-Id: If70fbe3e56d9e6e11841bf694fb45041fdcc7a38 Reviewed-on: https://chromium-review.googlesource.com/1150624Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#578510}
-
Wenzhao Zang authored
1) |getLaunchableApps| should only return launchable apps, but not all of the apps would necessarily be ready. (Non-ready apps becomes ready normally after ~10s after user session starts.) 2) |launchApp| can be used to launch non-ready apps. A spinner will be shown on the shelf and the app will launch after it becomes ready. Bug: 819404 Change-Id: I6569043226f38b6905687defb4be95554a5e5511 Reviewed-on: https://chromium-review.googlesource.com/1141349 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578509}
-
Donna Wu authored
This is a preparing CL for USB servicification which introduced WebUsbDeviceManager and its unit test. As designed, all permission management for USB devices will be consolidated within //chrome. Permission checking code in //device/usb will be moved out to this new class WebUsbDeviceManager. BUG=699790 Change-Id: I60580152ec31d1962dfdce616bd5b3729a3e60cc Reviewed-on: https://chromium-review.googlesource.com/1121971Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#578508}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/52660b68f115..17f184f10975 git log 52660b68f115..17f184f10975 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 bhthompson@google.com Add additional comments around paladins running HW tests Created with: gclient setdep -r src/third_party/chromite@17f184f10975 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If821a833572a7a5b66eb1dc39cc64cab99aae604 Reviewed-on: https://chromium-review.googlesource.com/1151971Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578507}
-
Nigel Tao authored
This commit is a rename. No features were added or removed. Prior to this commit, the only user of //chrome/browser/extensions/FaviconDownloader was //c/b/e/BookmarkAppHelper. Future commits will add code to //chrome/browser/web_applications so that, when installing web applications, a shared code path will download icons and re-scale if necessary. The class was renamed from FaviconEtc to WebAppIconEtc because such icons might not be favicons, in the sense of the `served on /favicon.ico` or `<link rel="icon" etc>` conventions. For example, https://events.google.com/io2016/manifest.json lists multiple app icons that aren't favicon icons. The class was moved because code in the newer //c/b/wa directory aims to not explicitly depend on code in //c/b/e, although dependencies from //c/b/e to //c/b/wa/components is OK. Change-Id: Id2808965c41b497eee92585c62374734db20ef42 Reviewed-on: https://chromium-review.googlesource.com/1149666 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578506}
-
Nate Chapin authored
* Don't take a timeout in ThreadableLoader constructor * Rename OverrideTimeout() to SetTimeout(), use it as the only way to set a timeout. * Stop using base::Optional for the timeout. The more I look at it, the less it adds, especially when the timeout isn't passed in the constructor. TBR=peter@chromium.org,yhirano@chromium.org Change-Id: I8d2e7f1099110399e0fe187432b04760fbc79cac Reviewed-on: https://chromium-review.googlesource.com/1150865 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#578505}
-
Nicholas Verne authored
Bug: 866752 Change-Id: I34056730480bb7ad52b01f6ec045ee936b5f016b Reviewed-on: https://chromium-review.googlesource.com/1151041Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578504}
-
Jiajia Qin authored
With this patch, we can compile and run a basic compute shader. Bug: 859249 Change-Id: I4b0c3fe35b70f9daa82a7783521e0aea9c57fdc9 Reviewed-on: https://chromium-review.googlesource.com/1151050Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#578503}
-
Shakti Sahu authored
Bug: 867693 Change-Id: I0d3795b4c456d89fa16c38984ddf6a89a21f8f1b Reviewed-on: https://chromium-review.googlesource.com/1150924 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578502}
-
Anand K. Mistry authored
This is dead code. A follow-up CL will remove this dbus method from cros-disks. BUG=None Change-Id: Iec688692f112a267b5aa8ec428bd067ff0e80119 Reviewed-on: https://chromium-review.googlesource.com/1151037 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#578501}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/254538b955bd..079812cefdd9 git log 254538b955bd..079812cefdd9 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-26 vadimsh@chromium.org [cipd] Bump client (+vpython) v2.1.0 (521b9b6477) => v2.2.2 (03693197fe). 2018-07-26 vadimsh@chromium.org [cipd] Try to bootstrap CIPD from scratch if selfupdate fails. 2018-07-26 ehmaldonado@chromium.org metrics_utils: Print notice to stderr. 2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@079812cefdd9 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:821194,chromium:867729,chromium:821194,chromium:832386 TBR=agable@chromium.org Change-Id: I0eb1d5d4e51b7559bee1647b84f8c420459b831b Reviewed-on: https://chromium-review.googlesource.com/1152248Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578500}
-
David Black authored
See bug for additional details. Bug: b:110416447 Change-Id: Id5323c5040e1b32326a8caa8d06a41749f0d92fa Reviewed-on: https://chromium-review.googlesource.com/1151714 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#578499}
-
tzik authored
Some WebRTC's ref-counted objects are implicitly stored into base::scoped_refptr instead of rtc::scoped_refptr through base::Bind. And an upcoming base::Bind update disables this case of auto wrapping. This CL replaces it to rtc::scoped_refptr by wrapping the pointer with rtc::scoped_refptr explicitly. Bug: 866456 Change-Id: Id8a9dd622f5aa5b9c843ec7ec43e0d390a0777db Reviewed-on: https://chromium-review.googlesource.com/1145147Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578498}
-
Amy Qiu authored
Create new recordings for pages in key_desktop_move_cases to ensure current websites are used. Bug: 852530 Change-Id: Ia216e388edf269a0462f014f90bbe22be0a68916 Reviewed-on: https://chromium-review.googlesource.com/1150691Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#578497}
-
Ryan Sturm authored
RenderFrameHost could be deleted while there is a message round trip occuring if shut down happens at the perfect time. Keeping BrowserContext is much safer. Bug: 868112 Change-Id: Ia9da7c64378f90a00e2c0bb07b1d3b24bf882ee1 Reviewed-on: https://chromium-review.googlesource.com/1152362Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#578496}
-