- 10 May, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e959bcf..fb60ce92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9796f1cb99bcd2a0f08d311b272ba1ea021422d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605301Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658517}
-
Martin Robinson authored
When grabbing focus or setting the sequential focus navigation starting point for AtkText nodes, we should use the character offset to set it on the proper child node. This ensures that tab navigation works as expected after calling AtkText APIs on a parent node. Bug: 955349 Change-Id: Idf8677f7d4fb205fee46905c80fb1bf5bc9baf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599616 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#658516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be6aa332df1b..995da00b992c Created with: gclient setdep -r src-internal@995da00b992c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I1a5f8243a13aa6051416b66befb6ca6e918bb66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658515}
-
Rune Lillesveen authored
Introduced in: https://crrev.com/bf7739c4947015b9ddfd245f28ea35de58fe45f8 Caused various fuzzer crashes. R=andruud@chromium.org Bug: 961535, 961520 Change-Id: I84fc226afb690fab5cbf07d7ca6aa9b79b4e2f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605406Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#658514}
-
alanlxl authored
Add an internal page (chrome://machine-learning-internals) to debug ML Service models and test connectivity/performance. Currently it supports a built-in TEST model which add two floats. What is planned for this page: * Each built-in model can add a tab here, if it's worthwhile to help debugging of on-device issues. * Plan to add performance metrics (i.e. latency) of different operations. * Plan to add control operations like Disconnect/Connect from ML Service. Bug: 924738 Change-Id: I23ff4ad93c532b7c1fc951a7ede1cb376b551f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1411959 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#658513}
-
Javier Ernesto Flores Robles authored
When the return key in the keyboard is pressed, the following text field will become first responder. If there is none, the current text field resigns first responder to hide the keyboard. Bug: 960420, 951300 Change-Id: I6497bc9e1930b06054ab2946665e4836de94d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602497 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#658512}
-
Finnur Thorarinsson authored
The new permission they added in earlier betas has been removed and a new RELATIVE_PATH column has been added, which replaces the DATA column (being deprecated). Bug: 905257, 656015 Change-Id: Ie30d234a031920fdb6487732c8d5a719267d9e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602719 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#658511}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72316111. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" 9d5bc5ec "Portals: Add support for frame-src CSP directive." d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I650f0f468b4d2936a4d3809ef7ba086d26658761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605302Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658510}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c59e4b6dba6..f3794c6f3ef5 git log 8c59e4b6dba6..f3794c6f3ef5 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 fmayer@google.com Merge "Turn --pid and --name into comma separated lists." Created with: gclient setdep -r src/third_party/perfetto@f3794c6f3ef5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia93909d03b7a5772a2ee91b8523301dcdf9e6fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658509}
-
Elly Fong-Jones authored
Bug: None Change-Id: I162bdbdb5de4a5f094cf631f769878cc90c46b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602096 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#658508}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/09537e93fddd..4c03bf558364 git log 09537e93fddd..4c03bf558364 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 perezju@chromium.org [Telemetry] Remove old code for ClockSync as AsyncEvent Created with: gclient setdep -r src/third_party/catapult@4c03bf558364 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947675 TBR=skyostil@google.com Change-Id: I022f1c0e6a187b9fecdb1d532c2bc043d293e29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605209Reviewed-by:
-
Dominic Battre authored
TBR=alph@chromium.org Bug: 959129 Change-Id: I90a383f3ee617f58614b14f0d54675ffc612b703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604266Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#658506}
-
Oleg Davydov authored
For further investigation of issues with forceinstalled extensions we need to know what happens with extensions in downloading stage in a more detailed way. We already collect data for this (in InstallationReporter via ExtensionDownloaderDelegate), so this commit introduces an UMA histogram. Change-Id: Id4d13b9e9678d0f7ef5bd30fbfbfebd7e57291bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587032 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658505}
-
Alex Clarke authored
Origional patch: https://crrev.com/c/1539981 This is the internal promise representation. It implements the machinery needed to marshal and dispatch promises as they become ready for execution. Care has been taken to try and minimize the size of the AbstractPromise class and to keep down the number of heap allocations. The promise result and the executor are both stored in the base::unique_any since they are never needed at the same time. The size of AbstractPromise on x64 is 96 bytes in builds without DCHECKS. In builds with DCHECKS it's larger because there's additional storage used to diagnose and prevent various usage hazards: * Unhandled rejection * Double move of promise results to callbacks * Mixed move and non-move semantics of promise results to callbacks The base::any_internal type has been adjusted so it can store the SmallUniqueObject<> inline, which is used to store the promise executor. The largest anticipated promise executor base::All is the size of 3x sizeof(void*) to hold a vtable and a std::vector. Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit TBR=fdoray@chromium.org, etiennep@chromium.org Bug: 906125 Change-Id: I15dbb78d4aecb6ae60f5dfaca8f73aba3fdd0963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605683Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#658504}
-
Dominic Battré authored
This reverts commit 8964034e. Reason for revert: see crbug.com/961620 Original change's description: > [SpatNav] Navigation of stacked focusables > > Background: > SpatNav compares activeElement's bounding rect > with all other focusables' bounding rects. > > Example (snav-fragmented-link.html): > A multi-line ("fragmented") link has focus. > > xxxxxxLINK L > INKLINKxx #A > > Here LINK's bounding box's area is bigger than the > the combined area of its two fragments. The box, > returned by NodeRectInRootFrame(), even overlaps > another focusable, #A. We can say that LINK's > bounding box "contains" #A. > > Problem: > Spatial navigation searches _from_ the focused > element's bounding box (but not inside of it). > Here LINK's rect completely contains A's rect so > #A will never be considered as a focus candidate. > > Solution: > Give priority to focusables inside the current focus rect. > > This also solves the generic case, crbug.com/798102, > where one focusable lays "under" another one, i.e > where a focus rect "contains" (or is positioned > behind) another focusable. I test this case in > snav-focus-rect-contains-links.html. > > Previously, such containers where unreachable because > of 86d40f3d's (anno 2010): > > "... if there are 2 overlapping focusable nodes, we do > a hit test and only the node on top can get focus." > > Now, when two focusables overlap, SpatNav first goes > go the outer box. From there, focus can go to the > "on-top", or "inner" (thinking in 2D) focusables. > > Related CLs: > Search scrollers from their edges: crrev.com/589502. > This CL uses the same approach as crrev.com/589502; > when a "container" is focused, we first search inside of > it, from one of its edges. > > Distance calculation fixup: > OppositeEdge()'s returned slice will now be "just outside" > the box it is slicing. This change helps us avoid if-logic > to cover cases when focusables sit at the very top of their > container. > > Bonus cleanup: > AreElementsOnSameLine() can now be removed. It was > introduced back in 2011 at 3568f132 to support > [some] line-broken links but it didn't fix 956900. > > Bug: 798102, 956900 > Change-Id: I00aaba88a7846b36275f9913034145679576e410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587559 > Commit-Queue: Hugo Holgersson <hholgersson@fb.com> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658484} TBR=bokan@chromium.org,fs@opera.com,junho0924.seo@lge.com,hholgersson@fb.com Change-Id: If908a9fe49b9a653018ae7f9fdbf9120b130cc6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798102, 956900, 961620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605410Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bf102206a6c..be6aa332df1b Created with: gclient setdep -r src-internal@be6aa332df1b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: Ifde234608f6bcc05a1882f383897c016b94060fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605210Reviewed-by:
-
Dominic Battre authored
TBR=mcnee@chromium.org Bug: 961607 Change-Id: I26c5b72817e69b9835ce309602bac64efcb21d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605407Reviewed-by:
-
Andy Paicu authored
Spec change in progress: https://github.com/whatwg/html/issues/4510 Bug: 920531 Change-Id: Idef348de028acbb400ae39ed5e9d058a2fc0173d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545067 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#658500}
-
Javier Ernesto Flores Robles authored
This way the alert will adjust itself to acommodate for it. BUG=959737 Change-Id: Ia0a4945f8d18079ca698af6ecd74423fe7bec459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602511 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds a toolbar to the implementation to showcase, which helps demostrating how the alert respects the safe areas. The toolbar contains a dummy button to demostrate how the presentation is done not modally. R=edchin Bug: 951301, 951300 Change-Id: I31297cfc73a0e59b854404685cdb1d4851f12bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594584 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658498}
-
Rune Lillesveen authored
The IsNull() check for the content attribute when processing referrer- policy got lost in [1] which caused a DCHECK to happen. Re-introduce the IsNull() check. [1] https://crrev.com/bf7739c4947015b9ddfd245f28ea35de58fe45f8 Bug: 961304 Change-Id: I5cb755d47725f56e84b372b5cc6175d92dca1b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602729Reviewed-by:
-
Javier Ernesto Flores Robles authored
Tests to follow in another CL. Bug: 951300 Change-Id: I1e622285758b22c84986242bd39e5f4c99b0496c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590135 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
The affected test would count the number of selection changed notifications and succeed if 4 notifications had been received. This is brittle because the test was counting both the notifications that resulted from the setup method in addition to the test itself. To exclude the selection changed notificationsfired from the setup method, the test is mmodified so that it runs after layout and paint. R=aboxhall@chromium.org Bug: 639340 Change-Id: I766138415f6d36042214eeba3ada02645f54dc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601994Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#658495}
-
Tanmoy Mollik authored
Bug: None Change-Id: I0d56179e339c4c361823f438b7d70072de80ee59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602712Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#658494}
-
Tanmoy Mollik authored
This CL replaces the deprecated base::SharedMemoryHandle used to hold the crash information in nacl:: classes with new shared memory api. The plugin side writes to the shared memory region using base::WritableSharedMemoryRegion and sends a read only version of the region to the renderer process through the browser. The renderer side reads the crash info using base::ReadOnlySharedMemoryRegion. Change-Id: I335040a9884d6dc79f107070c954a3ff250458a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565974Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
Most of the code uses "loading" but there were a few samples of code using "loader". Unifying both under the "loading" umbrella. Bug: 954854 Change-Id: I9fa3c7ecb6f342a30614ea3485bcb7eb0eea2475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594587Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#658492}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d622d6e5c42..952b571a4ac7 git log 3d622d6e5c42..952b571a4ac7 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 nisse@webrtc.org Delete unused class InsecureCryptStringImpl 2019-05-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a91b44f5..5f38b3b2 (658232:658382) Created with: gclient setdep -r src/third_party/webrtc@952b571a4ac7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c96569ea6adc8e64f5ff6f089a19e27618a0ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605208Reviewed-by:
-
Javier Ernesto Flores Robles authored
Creates a consumer to set up an alert. This effectively isolates the view from the business logic and is to be used with the new alert view controller. Bug: 951300, 951710, 951303 Change-Id: I8516de2eca6016a30ed5b6d6f0435981c12c5562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583796 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7b08d381fd67..5dc689c12028 git log 7b08d381fd67..5dc689c12028 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 89fe836fe22c..f6d9a1784313 (1 commits) Created with: gclient setdep -r src/third_party/angle@5dc689c12028 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I655de39be1c839fbdc8f80747a359fada5ee1e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605207Reviewed-by:
-
Dominic Battre authored
See bug for details. TBR=kristipark@chromium.org Bug: 960622 Change-Id: I95db78214255faf9f41623c65856458c199413c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605681Reviewed-by:
-
Dominic Battre authored
TBR=ricea@chromium.org Bug: 960623 Change-Id: I6bcd438d73dc1a795290f1c4541bb8c52989e6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604265Reviewed-by:
-
Dominik Röttsches authored
Replace manual memory management of FontConfig options with unique_ptr's and address a container-overflow issue in the unit test. Bug: 961018 Change-Id: Ief6a44abb98a4d48372440bc62cb801bfddabeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604263 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#658486}
-
Roman Aleksandrov authored
Reuse existing in ash warning message. Bug: 927331 Change-Id: I7632787964b124c3dcce649a504634c6182698ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572352Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Hugo Holgersson authored
Background: SpatNav compares activeElement's bounding rect with all other focusables' bounding rects. Example (snav-fragmented-link.html): A multi-line ("fragmented") link has focus. xxxxxxLINK L INKLINKxx #A Here LINK's bounding box's area is bigger than the the combined area of its two fragments. The box, returned by NodeRectInRootFrame(), even overlaps another focusable, #A. We can say that LINK's bounding box "contains" #A. Problem: Spatial navigation searches _from_ the focused element's bounding box (but not inside of it). Here LINK's rect completely contains A's rect so #A will never be considered as a focus candidate. Solution: Give priority to focusables inside the current focus rect. This also solves the generic case, crbug.com/798102, where one focusable lays "under" another one, i.e where a focus rect "contains" (or is positioned behind) another focusable. I test this case in snav-focus-rect-contains-links.html. Previously, such containers where unreachable because of 86d40f3d's (anno 2010): "... if there are 2 overlapping focusable nodes, we do a hit test and only the node on top can get focus." Now, when two focusables overlap, SpatNav first goes go the outer box. From there, focus can go to the "on-top", or "inner" (thinking in 2D) focusables. Related CLs: Search scrollers from their edges: crrev.com/589502. This CL uses the same approach as crrev.com/589502; when a "container" is focused, we first search inside of it, from one of its edges. Distance calculation fixup: OppositeEdge()'s returned slice will now be "just outside" the box it is slicing. This change helps us avoid if-logic to cover cases when focusables sit at the very top of their container. Bonus cleanup: AreElementsOnSameLine() can now be removed. It was introduced back in 2011 at 3568f132 to support [some] line-broken links but it didn't fix 956900. Bug: 798102, 956900 Change-Id: I00aaba88a7846b36275f9913034145679576e410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587559 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658484}
-
Martin Robinson authored
These are typically caused by ATK GObjects that are reffed, but then never unreffed. Bug: 961578 Change-Id: I6455044685f7253b6088ddaf32e611eaa97971f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605402Reviewed-by:
-
Evan Shrubsole authored
Bug: 952831 Change-Id: I12800e6db741632617af859a7852565e6da99d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599624Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#658482}
-
Julie Jeongeun Kim authored
This CL uses DocumentInterfaceBroker to stop passing frame ID over mojo from WebApplicationCacheHostImpl for the render frame path and moves AppCacheHost registration and |host_| from AppCacheBackendImpl to AppCacheServiceImpl. Now AppCacheBackend is only used for workers and it registers AppCacheHost through AppCacheServiceImpl. Bug: 950159 Change-Id: Ic1ba441a6a4bb7f430cf8fce8267ba69a7a4c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589478 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658481}
-
Alex Danilo authored
CL:1593885 adds scrolling of the tree to support tabbing around selections so the focused item comes into view. A side-effect of that CL is that if focus is taken away from the tree by clicking in the file list area, followed by clicking on a folder in the tree, the tree view will scroll as focus returns and in turn, can select the wrong folder due to delivery order of the 'focus' and 'click' events. This CL removes the scrolling behavior to match what other file managers do. Bug: 955172 Change-Id: I209eb4ba61964928c064f711be3c2e0fca9b51e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605660Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658480}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4135885cfde9..6bf102206a6c Created with: gclient setdep -r src-internal@6bf102206a6c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I6327247c66e1ae7f5bbfd2f3debe05eca6bb7b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604106Reviewed-by:
-
Christos Froussios authored
The long tail of clients is still migrating. We are keeping the migration on and will continue to monitor adoption. Change-Id: I0d48a87d3022fd1828b159078420cec062f261c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598810Reviewed-by:
-
