- 16 Jul, 2020 40 commits
-
-
Sahel Sharify authored
Flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyawsSBUZsYWtlImBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFRyYW5zbGF0ZU1hbmFnZXJXaXRoTWFpbkZyYW1lTGFuZ3VhZ2VEZXRlY3Rpb25Ccm93c2VyVGVzdC5UcmFuc2xhdGVJZnJhbWUM TBR=dougarnett@chromium.org Bug: 1106446 Change-Id: I6008f48820b05353fcef9fe23fa8d9b68d1b44a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303051Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789211}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e7945d6e..72a5712e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c6f6149da71531e4b40b3b82847b0b7a97ff94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303489Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789210}
-
rbpotter authored
Add new rotate counterclockwise label, and hook up the button for the new toolbar. Bug: 1105965 Change-Id: I9e665a4f3f547fd574c0f797cfd4a46046f42f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300230Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789209}
-
Will Harris authored
Before this CL, only EXE files had CFG bitmap generated and PE DLL Characteristics "Control Flow Guard" enabled. This CL enables these for DLLs as well. It is a no-op for Chrome code as the dispatch guards are not being generated but will protect indirect calls from e.g. system libraries from being able to call into arbitrary Chrome code. This CL also updates checkbins.py to ensure that shipped binaries always have /guard:CF enabled, and also enables longjmp support as compiler issues were isolated to MSVC which we no longer use. See Comment 30 on bug for size impact analysis. TEST=Verify by running dumpbin.exe on Chrome DLLs and checking for "Control Flow Guard" in the "DLL characteristics" header field, or run tools/checkbins/checkbins.py on output directory. BUG=584575 Cq-Include-Trybots: luci.chromium.try:win7-rel,win_archive,win_x64_archive Change-Id: I4b78b97e93cd81dee70d0b3d1edd3d8e522a5495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298284 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789208}
-
Yuke Liao authored
The owner file should end with a 's'. Bug: 1104318 Change-Id: I3910a8c99cccba42e46a17671bf179fda25a86ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302744 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#789207}
-
Dirk Pranke authored
I accidentally introduced some unused code paths in the test() GN template when adding the first pass of the bin/run_ GN wrappers for desktop in 956c4dcc (#784653). This CL removes them. Bug: 816629 Change-Id: If84195eec47d93c1260a063ca6cbb81f74e7c2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303039Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#789206}
-
Nicolás Peña Moreno authored
* Add prototype of Frame Timing as a stretch goal. * Fix a typo with a link. Change-Id: Ic1cbdb7d2a0a83d18ded0f00bb67df9a44e2d93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303557 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789205}
-
Greg Thompson authored
- add a const get() - add a nofail assign() from a same-sized string - add an empty() BUG=None Change-Id: Iaea64cccd408deedb5d5b605815e98a6c943096c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302849 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789204}
-
Garrett Beaty authored
Change-Id: If1026afabd6da9f61bb0f6371d7d521271b6eefe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303038 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789203}
-
Ana Salazar authored
While repareting an app from a folder into the main grid, we could drag it to create a new blank page. If the repareting is cancelled, the app will snap back to the folder but the blank page will remain, causing the system to crash eventually. We need to update the apps grid paging in this case, so that the blank pages are discarded. Bug: 1100011 Change-Id: I5e28ed61bb50f3bde85cceaca9c5c7d0be1693b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300836 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789202}
-
Jia Li authored
This will enable implementation of the ML Service with complete service features. Summary of changes: - Implemented deserialization and validation of the model. - Added tests for |DecisionTreePredictor| and |DecisionTreeModel|. Bug: 1102428 Change-Id: Ib1328f69dca76c5f47b361259e181a8ab12e45e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290330Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#789201}
-
Ayu Ishii authored
Fix - SyncWebsocketFactory - MessageCallback - ConditionalWaitCallback Change-Id: I9bf3e90df4a4217e158857dc90d4d7356dabcfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298264Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#789200}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/11bfeb307c4e..820021d24600 2020-07-16 danilchap@webrtc.org Ignore fragmentation header when packetizing H264 2020-07-16 handellm@webrtc.org Remove unused critical section includes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I877271f709b77c2aae5c9defff83b46784a2eef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302681Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789199}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/ad56e3f17dd1..4de168715fa1 $ git log ad56e3f17..4de168715 --date=short --no-merges --format='%ad %ae %s' 2020-07-16 nharper Fix use-after-free in QuicConnectionTest 2020-07-16 fayang In quic, coalesce packet of higher encryption level with initial or handshake retransmission. protected by gfe2_reloadable_flag_quic_coalesced_packet_of_higher_space. 2020-07-15 haoyuewang Support sender control of ack frequency step2: (1) add min_ack_delay transport parameters. (2) client send min_ack_delay by default. protected by gfe2_reloadable_flag_quic_record_received_min_ack_delay. 2020-07-15 renjietang Make QuicControlFrameManager talk to QuicSession via a delegate. 2020-07-15 wub Internal QUICHE change 2020-07-14 nharper Add flag count macro for quic_enable_zero_rtt_for_tls Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I548d3d96b85a08bc9ee81c76090352f992685df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302729 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789198}
-
dpapad authored
Bug: 1098124 Change-Id: I4f49f48a4698c4cf10caff2e2a3801c6231cedcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302810Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#789197}
-
cfredric authored
Bug: 1085645 Change-Id: I43410df0b7b38ab1b06ecb1a9e41fde7aef8b49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299182 Auto-Submit: Chris Fredrickson <cfredric@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789196}
-
Kevin Babbitt authored
This gets us one step closer to using the streaming tokenizer for declarations, which will allow us to preserve raw text for CSS variable values. The existing logic made heavy use of sub-ranges to track block boundaries and restart parsing to find the correct branch of a production. To support the new logic, the streaming tokenizer's BlockGuard gained the ability to tell its caller whether the end of the block it was created for has been reached. Since the streaming parser cannot be rewound to a previous position, the supports parser had to be restructured to peek ahead more than one token for the supports-in-parens grammar, and to decide based on lead token whether to parse supports-feature or general-enclosed. Finally, to maintain support for the CSSConditionRule.conditionText property, the streaming tokenizer gained the ability to return raw text for an underlying range. Bug: 661854 Change-Id: I7fcf244e5f360e3715c8543ac7283e351d6b2baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238512Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789195}
-
Jordan Bayles authored
This patch adds a new check to the media router views UI that, on Mac OS X 10.15+ (Catalina), checks if the screen capture permission has been granted, and shows a warning message and fails to cast if so. Bug: 1087236 Change-Id: I3afdfdb06a011fee3e6fd5f199d375d0ab6eef88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298479 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#789194}
-
Greg Thompson authored
The debugging bit that controls whether or not the extracted files are left behind rather than cleaned up is a kind of configuration, so it's natural that it reside in the Configuration class. This is a refactor with no behavior change with one exception: this CL fixes a regression introduced in r282032. BUG=None Change-Id: I6dd594d220b9b75a507f4482af49f083b697b3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302152 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789193}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia4f6eeaba314a0ebee6dba887ca3cb41d7417d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789192}
-
Evan Stade authored
Bug: none Change-Id: I7ef47e17d4c534161abab20cc8fe0718af442465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295809Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789191}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Change-Id: I23d0dce539e573e373009a85c715268e74b83872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303048Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789190}
-
behdad authored
Use cpu_wall_time_ratio in representative perf tests logic to invalidate failures which had lower than usual cpu_wall_time_ratio in order to reduce flaky failures. As a result only stories which have higher frame_times than the limit and acceptable cpu_wall_time_ratio would be failing. Bug: chromium:1052361 Change-Id: I294361375f91096a32e226f57dc61450926fab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292811 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789189}
-
Ken Rockot authored
Service manifests are not particularly useful in production anymore. Content uses a subset of the manifests (and their overlays) to filter interface requests coming from renderers. This filtering is redundant given the completion of BrowserInterfaceBroker migration and the fact that *_receiver_bindings.cc files have SECURITY_OWNERS coverage too. Hence the redundant filtering is removed here. Minimal infrastructure supporting manifests is left in place for now, as cast_shell still internally depends on the Service Manager and manifest overlays. Bug: 977637 Change-Id: I360aadeecaeed859996b3671ed6646babd831a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296482Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#789188}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e28cc55cac22..c15c6eb9d8c3 2020-07-16 cwallez@chromium.org dawn_wire/server: Use MapAsync to do Map[Read/Write]Async 2020-07-16 cwallez@chromium.org DawnTest: Use MapAsync for expectations. 2020-07-16 cwallez@chromium.org Roll third_party/swiftshader/ ad65826a2..e8dd233c7 (10 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I920cff96b98bffd9c8d794a653f037556c3ce5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789187}
-
Sophie Chang authored
Bug: 1092329 Change-Id: I65f6cc0f5534859a4b55cf86c916015030e01af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295780Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789186}
-
Hesen Zhang authored
- Add full unit test for the service. - Add SetClockForTesting for the service, and use clock object inside. - Using scheduler to check throttle(tooManyNotifications). Bug: 1047037 Change-Id: I3354e5190c70e1e7eeb64437fb293c1d342eb7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293579Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789185}
-
Adam Langley authored
Fido2CredentialRequestTest in chrome_public_test_apk is failing. Commit f55cd37e was reverted[1] but I suspect that the cause might actually be the Mojo change in c296f39e. Trying to run the tests fails for me because the tests timeout trying to do setup as I'm remote, but I think this is worth a shot at greening the bots. TBR=martinkr [1] https://chromium-review.googlesource.com/c/chromium/src/+/2303030 Change-Id: Ida3e66df0c5bd9e98ffc2b84032d857236aaf6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303354Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#789184}
-
Robert Sesek authored
This target was missed in 2585915c. The CL also adds additional locking annotations to MachPortRendezvousServer. Bug: 1106353, 1013082 Change-Id: Id2fe4f707dc90efd79c0354de73e5066b8715713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302942Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#789183}
-
Garrett Beaty authored
There was some confusion about file naming where someone thought they could run lucicfg generate against //subprojects/findit/main.star. Only the top-level files main.star and dev.star can be passed to lucicfg generate, so this change should hopefully make such confusion less likely. The main.star in the subproject subdirectories have been renamed to subproject.star so that the subprojects have a consistent entry-point. //dev/main.star and //subprojects/chromium/master-only/main.star are both one-offs that have been renamed to match the containing directory. Change-Id: I99d8f7887d087070bd89f14e74c225447ebe1805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303451 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#789182}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 09f7f50d. With Chromium commits locally applied on WPT: 1adfdd4d "[COOP] Fix typo in test name" f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests"" f90faeee "Remove old comments from web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing mek@chromium.org: external/wpt/webmessaging mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ie4af4bb93871fe71efa273f2eb3ba02d27524571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303011Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789181}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1040826 Change-Id: Id9bd44baa60ff39650f924eec0d39236e3d5765a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301559 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789180}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id1d6aa93d0b49e8ca068b64f76a8f21a4864a230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302719Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#789179}
-
Peter Wen authored
Remove //{chromecast,content,mojo,services,testing}* from allowlist. Bug: 1082904 Change-Id: Ia47b46e70edb64962279c3b8619f37278e15da7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303171 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789178}
-
Alison Maher authored
fast/css/css2-system-color.html was marked as flaky in TestExpectations in the following change: https://chromium-review.googlesource.com/c/chromium/src/+/2295405 It appears that the following change fixes the flakiness issue for fast/css/css2-system-color.html on Windows: https://chromium-review.googlesource.com/c/chromium/src/+/2295695 There were also failures for this test on Mac due to existing expectation files. Removing these did the trick, allowing us to remove fast/css/css2-system-color.html from TestExpectations altogether. Bug: 1104697 Change-Id: I1cb843ada8023f9ab4f803b69469a662b35ab588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300347Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789177}
-
Dominic Farolino authored
R=sclittle@chromium.org Bug: 1047909 Change-Id: I71ca1728a4cc148587e12fce98841488591e869a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299475 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#789176}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c139b630a30b..b15083559691 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hesen@google.com,sahel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106045 Tbr: hesen@google.com,sahel@google.com Change-Id: I9c12f2bdb629de94965cd3a16a2d08fbc024cbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789175}
-
Torne (Richard Coles) authored
Implement an alternative option for the handling of extra headers in loadUrl, which only allows them to be sent to redirects to the same domain (eTLD+1). This is less restrictive than the existing feature flag requiring that they be the same origin (and if that flag is enabled, this one has no effect). Implement a new histogram that just records whether redirects are same-origin, same-domain, or cross-domain, and obsolete the current one, which doesn't make sense with the new option. Bug: 1038002 Change-Id: I121de069d7a87fb4718ad9131ca427a5c017a7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264609 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789174}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: If06e8db5a31067f53e5dfb770dadf8f30f97681a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293374Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#789173}
-
Tina Wang authored
Test the conditions for showing the enterprise info in the menu. Change-Id: I8c2dd7ec18c76c7f58c434a9cea88890225e2cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297721 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789172}
-