GitLab

Render frames can use this service to verify platform on ChromeOS.

BUG=479836

Review URL: https://codereview.chromium.org/1053773007

Cr-Commit-Position: refs/heads/master@{#329247}

BUG=485656,477137

Review URL: https://codereview.chromium.org/1132473003

Cr-Commit-Position: refs/heads/master@{#329246}

BUG=

Review URL: https://codereview.chromium.org/1137033004

Cr-Commit-Position: refs/heads/master@{#329245}

Renaming sync_state to username.

BUG=None

Review URL: https://codereview.chromium.org/1117453002

Cr-Commit-Position: refs/heads/master@{#329244}

Known issues:
-Cancel confirmation dialog and backdrop style should be according to crbug/482962
-Cancel confirmation dialog doesn't cover "account creation" case
-Fatal error does not use 'notification-card' element.

BUG=467119,469428
TEST=Manual
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/1115993002

Cr-Commit-Position: refs/heads/master@{#329243}

When an application is linked against an OSX 10.9+ SDK, a blit will fail if the
source and destination color formats do not match.

BUG=484203

Review URL: https://codereview.chromium.org/1133163003

Cr-Commit-Position: refs/heads/master@{#329242}

The only change in ICU since the last roll is:
  Brings defines for the GN build in line with GYP.

TBR=jungshik@chromium.org

Review URL: https://codereview.chromium.org/1139783004

Cr-Commit-Position: refs/heads/master@{#329241}

Revert of bluetooth: Android adapter can be created with and without Bluetooth permission. (patchset #2 id:110001 of https://codereview.chromium.org/1129683002/)

Reason for revert:
Failing on the main waterfall: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27824

Original issue's description:
> bluetooth: Android adapter can be created with and without Bluetooth permission.
>
> This enables unit tests to run with Bluetooth permission,
> by adding the Bluetooth permission to native_test.
>
> Non-test applications will not have the Bluetooth permission,
> and unit tests should also verify behavior
> when the permission is not given. To enable this
> createWithoutPermissionForTesting is added and
> results in a state equivalent to when the permission
> is not available.
>
> Unit tests will be built in parallel for both when Bluetooth
> permission exists and doesn't.
>
> BUG=471536
>
> Committed: https://crrev.com/30e81472dc168ea1c331a8779b3f6a14f684c54b
> Cr-Commit-Position: refs/heads/master@{#329212}

TBR=tedchoc@chromium.org,armansito@chromium.org,scheib@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471536

Review URL: https://codereview.chromium.org/1137083002

Cr-Commit-Position: refs/heads/master@{#329240}

BUG=483288

Review URL: https://codereview.chromium.org/1130253003

Cr-Commit-Position: refs/heads/master@{#329239}

Another fix for https://codereview.chromium.org/1127153004/. Hooray for
non-recipe bots.

BUG=
TBR=perezju@chromium.org

Review URL: https://codereview.chromium.org/1131143003

Cr-Commit-Position: refs/heads/master@{#329238}

BUG=441392

Review URL: https://codereview.chromium.org/1089903003

Cr-Commit-Position: refs/heads/master@{#329237}

BUG=369661
TEST=All tests remain green.

Review URL: https://codereview.chromium.org/1129893005

Cr-Commit-Position: refs/heads/master@{#329236}

This puts all heap allocated values into scoped_ptrs in
value_unittest.cc and json_writer_unittest.cc. This way
ownership is explicit in the code and we don't use raw
pointers to change owners of an object.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1138103002

Cr-Commit-Position: refs/heads/master@{#329235}

Refactor the API for CertVerifier::Verify() and the implementation of MultiThreadedCertVerifier::Verify().

* CertVerifier::Verify() fills a |scoped_pointer<Request>*| rather than a |void*|

* CertVerifier::CancelRequest(void*) has been removed. Requests are instead cancelled by resetting the scoped_ptr<Request>.

* Refactored memory ownership in MultiThreadedCertVerifier so there are no manual calls to "delete".

* Removed locking and the CertVerifierWorker in favor of using WorkerPool::PostTaskAndReply()

BUG=475153,479336
TBR=pneubeck@chromium.org,zea@chromium.org,sergeyu@chromium.org

Review URL: https://codereview.chromium.org/1115903002

Cr-Commit-Position: refs/heads/master@{#329234}

BUG=477084
TEST=new tests
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1126233004

Cr-Commit-Position: refs/heads/master@{#329233}

This patch ensures that the pending layer is informed of scroll
updates that happen on the active tree. That way the information
can propagate down to wherever it is used (such as tilings)

BUG=483638
R=aelias, enne

Review URL: https://codereview.chromium.org/1135833002

Cr-Commit-Position: refs/heads/master@{#329232}

We always draw window contents using a compositor, so we can remove the windows desktop aura code that handles GDI painting.

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1125193004

Cr-Commit-Position: refs/heads/master@{#329231}

Found by Scythe.

Review URL: https://codereview.chromium.org/1127163004

Cr-Commit-Position: refs/heads/master@{#329230}

- remove cancel utterance logic which incorrectly calls endCallback causing unexpected continuation of speech on stop().
- adds mapping for continuous read in compat mode.
- fixes continuous read test which is still prefixed manual.

TEST=verify continuous read works in ChromeVox Next and compat. Passes BackgroundTest.MANUAL_ContinuousRead

Review URL: https://codereview.chromium.org/1138813002

Cr-Commit-Position: refs/heads/master@{#329229}

Revert of [Chromoting] Add GN build support for ar_sample_app target. (patchset #1 id:1 of https://codereview.chromium.org/1135933002/)

Reason for revert:
Broke GN bots, eg.:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28281

Original issue's description:
> [Chromoting] Add GN build support for ar_sample_app target.
>
> This adds GN build rules for the AppRemoting sample app.
> Some DesktopRemoting build rules were prettified as part of this
> process (to make the App- and Desktop- remoting build rules more
> similar).
>
> This re-lands crrev.com/1126393002 without any additional changes
> required. The issues with the GN clobber builds are fixed in
> crrev.com/1137753002.
>
> BUG=471916
>
> Committed: https://crrev.com/581797d8f76d5855b7f0bed1fe912a038d1d7d25
> Cr-Commit-Position: refs/heads/master@{#329206}

TBR=jamiewalch@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471916

Review URL: https://codereview.chromium.org/1136673003

Cr-Commit-Position: refs/heads/master@{#329228}

This is a reland of https://codereview.chromium.org/1106103003/ with fixes to
ensure callers never pass in a null slot.

Currently some NSS platform integration logic transits private keys through
RSAPrivateKey on CrOS. This prevents incrementally switching RSAPrivateKey to
BoringSSL while keeping platform integrations on NSS.

The intent of this change is to clarify RSAPrivateKey as a BoringSSL vs NSS
internal crypto library (use_openssl=0 vs use_openssl=1) abstraction. It's
primarily to be used with SignatureCreator. Code which uses NSS based on
use_nss_certs rather than use_openssl because the underlying platform is NSS
should call NSS routines directly, or introduce different abstractions.

Remove the problematic RSAPrivateKey methods and instead add
crypto/nss_key_util.h which contains some helper functions for manipulating NSS
keys. This is sufficient to allow consumers of the removed methods to use NSS
directly with about as much code. (This should not set back migrating that
logic to NSS as that code was already very NSS-specific; those APIs assumed
PK11SlotInfo.)

nss_key_util.h, like nss_util.h, is built whenever NSS is used either
internally or for platform integrations. This is so rsa_private_key_nss.cc can
continue to use the helper functions to implement the NSS-agnostic interface.

With this, the chimera CrOS configuration should build. The RSAPrivateKey logic
is functional with the exception of some logic in components/ownership. That
will be resolved in a future CL.

BUG=478777,483606

Review URL: https://codereview.chromium.org/1128153003

Cr-Commit-Position: refs/heads/master@{#329227}

Review URL: https://codereview.chromium.org/1133163002

Cr-Commit-Position: refs/heads/master@{#329226}

Shared timers are explicitly suppressed when sending a sync IPC that
runs a nested message loop. Historically, there was an affordance for
avoiding this suppression, but it appears that is no longer necessary.
Remove RenderThreadImpl::DoNotSuspendWebKitSharedTimer accordingly.

BUG=none

Review URL: https://codereview.chromium.org/1132913002

Cr-Commit-Position: refs/heads/master@{#329225}

BUG=473837

Review URL: https://codereview.chromium.org/1127133004

Cr-Commit-Position: refs/heads/master@{#329224}

If another save prefs request comes, the current timer is cancelled and a new timer is started to persist after 1 minute.

BUG=485314, 451256, 431476
R=rch@chromium.org, mmenke@chromium.org

Review URL: https://codereview.chromium.org/1134523003

Cr-Commit-Position: refs/heads/master@{#329223}

- share dialog
- (photo) gallery
- video player
- file manager
- kiosk apps page

BUG=485779

Review URL: https://codereview.chromium.org/1134603002

Cr-Commit-Position: refs/heads/master@{#329222}

If the alternate Job fails but the Job to the origin succeeds, the request
should succeed.  This CL adds an HttpNetworkTransaction unittest to document
this.

BUG=474217

Review URL: https://codereview.chromium.org/1136753002

Cr-Commit-Position: refs/heads/master@{#329221}

Fixes https://codereview.chromium.org/1127153004/

BUG=

Review URL: https://codereview.chromium.org/1135053003

Cr-Commit-Position: refs/heads/master@{#329220}

Originally landed in crrev.com/1104703003
Reverted in crrev.com/1129103002 due to breaking GN APKs with no
resouces. This now handles the case where aapt doesn't generate an
R.txt (no resources) by creating an empty R.txt.

Generate extra packages' R.java files only containing the resources
listed in their R.txt files. This significantly reduces the number of
DEX field IDs taken up by resources.

BUG=480036
R=cjhopman,yfriedman

Review URL: https://codereview.chromium.org/1136653002

Cr-Commit-Position: refs/heads/master@{#329219}

These will need to be shared between browser and gpu code since we'll
need to read the initial display configuration synchronously on the
browser side.

BUG=484294

Review URL: https://codereview.chromium.org/1133053003

Cr-Commit-Position: refs/heads/master@{#329218}

Some of the loading window splash graphics are narrower than the initial MessageWindow width, which is not handled correctly by resizeWindowToContent.

Review URL: https://codereview.chromium.org/1133103004

Cr-Commit-Position: refs/heads/master@{#329217}

This fixes the FormStructureBrowserTest for
01_autocomplete_attribute_invalid.html

BUG=427614

Review URL: https://codereview.chromium.org/1113263002

Cr-Commit-Position: refs/heads/master@{#329216}

The moveTo and resizeTo methods are deprecated; setting outerBounds is the
recommended replacement.

BUG=485707

Review URL: https://codereview.chromium.org/1130013003

Cr-Commit-Position: refs/heads/master@{#329215}

BUG=481604

Review URL: https://codereview.chromium.org/1124113003

Cr-Commit-Position: refs/heads/master@{#329214}

BUG=

Review URL: https://codereview.chromium.org/1129053004

Cr-Commit-Position: refs/heads/master@{#329213}

This enables unit tests to run with Bluetooth permission,
by adding the Bluetooth permission to native_test.

Non-test applications will not have the Bluetooth permission,
and unit tests should also verify behavior
when the permission is not given. To enable this
createWithoutPermissionForTesting is added and
results in a state equivalent to when the permission
is not available.

Unit tests will be built in parallel for both when Bluetooth
permission exists and doesn't.

BUG=471536

Review URL: https://codereview.chromium.org/1129683002

Cr-Commit-Position: refs/heads/master@{#329212}

Added as part of a recent CL, the form name is not required for the improvements to the Autofill server that are upcoming.

BUG=484229
TEST=FormStructure*,AutofillServer*

Review URL: https://codereview.chromium.org/1138033002

Cr-Commit-Position: refs/heads/master@{#329211}

This change: https://codereview.chromium.org/1110813002/ was missing a
key step - after an ozone platform validator has rounded display_rect
to integer coordinates, that data needs passing back through to the
compositor overlay candidate data - otherwise the assert is still fired.

BUG=

Review URL: https://codereview.chromium.org/1133953002

Cr-Commit-Position: refs/heads/master@{#329210}

This reverts commit 187bc57e.

TBR=dharani@chromium.org,enne@chromium.org
BUG=486214

Review URL: https://codereview.chromium.org/1135073002

Cr-Commit-Position: refs/heads/master@{#329209}

This is like https://codereview.chromium.org/1129093002 , but for move
constructors instead of copy constructors.

Also add a test for https://codereview.chromium.org/1129093002 (and this).
Since testing dllexport on non-win requires a -target and can't depend on
system headers (windows system headers aren't installed where we run tests),
convert the test the new test was based on to be standalone (we should do
this for all tests, http://crbug.com/486559)

BUG=483986,486559

Review URL: https://codereview.chromium.org/1137973002

Cr-Commit-Position: refs/heads/master@{#329208}