- 14 May, 2018 40 commits
-
-
Sunny Sachanandani authored
Initialize create_surface_handle_function_ only once, and handle errors. Handle error when retreiving direct composition device. R=zmo BUG=837378 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibbd8d041e7111ea13936b467c4630b45c9caadcf Reviewed-on: https://chromium-review.googlesource.com/1058173 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#558535}
-
Devlin Cronin authored
Move the ExtensionApiTest class into the extensions namespace, and updated affected sites. This CL should have no functional change. Bug: 117261 TBR=thestig@chromium.org (/chrome) TBR=dmazzoni@chromium.org (/third_party/liblouis) Change-Id: Ibd8820f47ebe53140fd725fb00b1d75c9872808c Reviewed-on: https://chromium-review.googlesource.com/1050580 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#558534}
-
Ryan Landay authored
IncognitoToggleButtonTablet implements a button we have in the Android tablet toolbar that lets a user switch between normal and incognito modes. The button only shows if there's at least one incognito tab currently open. I want to add a similar button to the toolbar on Android phones as part of the horizontal tab switcher experiment. The button won't need as much functionality on phones (we want to always show it, not only when an incognito tab is open, and the click handler will get passed from StackLayout through ToolbarPhone to the incognito button, so we can have StackLayout disable it during animations). This CL refactors the basic functionality into a new base class IncognitoToggleButton, which we can use on phones. IncognitoToggleButtonTablet will now extend this class so as to maintain the current functionality. Bug: 828224 Change-Id: I453be95f42d7baef0d5e237c61bc14f7af7faba2 Reviewed-on: https://chromium-review.googlesource.com/1058433Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#558533}
-
Scott Violet authored
In hopes of simplifying the code I want to have ws2 operate in DIPs. This means a bunch of code assuming pixels in WindowTreeClient needs to be behind a conditional. BUG=837692 TEST=none Change-Id: I13b88eb676eb79247cdf4a435ac673470c359f91 Reviewed-on: https://chromium-review.googlesource.com/1055267 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#558532}
-
https://chromium.googlesource.com/angle/angle.git/+log/5d2ccc534d26..5730c0bf431e $ git log 5d2ccc534..5730c0bf4 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android. 2018-05-14 cwallez DisplayGLX: Close the X display if we own it. 2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android. 2018-05-14 geofflang DEQP: Print not supported messages from tests. 2018-05-14 geofflang Add dEQP EGL test expectations for Linux and Android. 2018-05-10 jmadill Vulkan: Implement masked color clear with depth. 2018-05-14 jmadill Fix libGLESv2 wrong .def file. 2018-05-14 jmadill Fix warnings from size_t conversions. 2018-04-23 lfy GLES1: Renderer (minimal) Created with: roll-dep src/third_party/angle BUG=chromium:834269,chromium:842028 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I1ac4625bc1c520a30186f260160dffbdf5787693 Reviewed-on: https://chromium-review.googlesource.com/1058172 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558531}
-
erikchen authored
Previously, the notifications were sent during the tab-close-loop [if multiple tabs were being closed]. This made reentrancy particularly dangerous. The logic in Browser::TabDetachedAt and Browser::TabInsertedAt relied on the |index| parameter to determine whether the index of the active tab has changed [for which there is no notification]. This CL changes those methods to always call SessionService::SetSelectedTabInWindow, and modifies SessionService::SetSelectedTabInWindow to be idempotent. Bug: 842194 Change-Id: I2fc54749e495ab9c925bdba89ef857c4ea3537d9 Reviewed-on: https://chromium-review.googlesource.com/1055732Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558530}
-
Xianzhu Wang authored
We still omit OverflowClip when there is no visual overflow, but we need to apply the inner border radius clip when clipping a box. Bug: 842463 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I19937a58b99cc91f70591041782cf9dc26f1a55b Reviewed-on: https://chromium-review.googlesource.com/1057838Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558529}
-
Daniel Erat authored
Make Chrome stop providing an org.chromium.LibCrosService D-Bus service. All of the method calls formerly exported on this service have been moved into their own services now, and callers have been updated to use those instead. Bug: 692246 Change-Id: I30ec76570a18d669f37609d662275ed2da7c2012 Reviewed-on: https://chromium-review.googlesource.com/1056051Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#558528}
-
Joel Einbinder authored
Change-Id: Ia0e9f3c98735d64a1188b4373c90b7ef2684ea48 Reviewed-on: https://chromium-review.googlesource.com/1054582 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#558527}
-
Tommy Li authored
This reverts commit a6de7e84. Reason for revert: Makes extension popups blurry with non-integral scale factors. Bug: 824963 Original change's description: > Views: Turn on InkDropMasks for Windows. > > It seems to "just work". > > Tested on: > - Windows 10 > - Windows 10 with --disable-gpu > - Windows 7 > - Windows 7 Classic mode (Aero disabled) > > Bug: 713359 > Change-Id: I04466aab7e978ad51e5e579488e29789cda9ab72 > Reviewed-on: https://chromium-review.googlesource.com/961552 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543785} TBR=tapted@chromium.org,mohsen@chromium.org,tommycli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 713359 Change-Id: I854e2315e5cd73c7aca67f0d7d226cb67102ff32 Reviewed-on: https://chromium-review.googlesource.com/1058289 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#558526}
-
Qiang Xu authored
Changes: This CL mainly addressed two issues: - On stylus selection complete, do not dismiss assistant bubble. - provide AssistantController api to exit metalayer mode. Introduce HighlighterEnabledState, which contains - kEnabled - kDisabledByUser - kDisabledBySessionEnd When AssistantController calls this api, it could specify kDisabledByMetalayerSessionEnd state to indicate metalayer session aborted so that (1) it doesn't dismiss assistant bubble, (2) metalayer mode is exited. (1)(2) are done by observers. Bug: b/78193960 Test: manual test and test coverage Change-Id: Iba81d6827aa7f45bb2195a865e6684148319ac7b Reviewed-on: https://chromium-review.googlesource.com/1053213 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558525}
-
edchin authored
Number conversions can suffer from overflow and other conversion issues so checked_cast should be used instead of static_cast. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7dc9b7e089fef95fd992912d29169bb6ceb461d4 Reviewed-on: https://chromium-review.googlesource.com/1058179Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558524}
-
edchin authored
Numeric/integral conversions can suffer from overflow so checked_cast should be used instead of static_cast. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib5c646f1ae599cf95f594a4d317745407f4a6f17 Reviewed-on: https://chromium-review.googlesource.com/1058333Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558523}
-
Michael Lippautz authored
- Use ThreadHeapStatsCollector scopes instead of manual scopes - Allow adding parameters - Allow enabling by default - Fix telemetry unit tests Bug: chromium:840789, chromium:757440 Change-Id: If291b08d989d11233a31a4fbfc28db0b2f594e2b Reviewed-on: https://chromium-review.googlesource.com/1057626 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558522}
-
Christian Biesinger authored
In certain situations (e.g. involving continuations in combination with changing position:relative to static) we may not be marked as needing layout but still need paint invalidation so that our fragment_.paint_offset_ gets updated correctly; this patch does that. Fixes these tests when fragment caching is enabled: fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html R=eae@chromium.org, mstensho@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9a8b732fffa93b9d03bcaf6c31c2c69785faaa7e Reviewed-on: https://chromium-review.googlesource.com/1058227 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#558521}
-
Scott Chen authored
Bug: 842818 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I291bc06e83d0976bb604e7707ae36b2264ebfd51 Reviewed-on: https://chromium-review.googlesource.com/1058069Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558520}
-
Patrick Monette authored
This is because shell extensions don't specifically target Chrome, they just get automatically loaded by the OS. These will get blocked in phase 2 of third-party software blocking. For IMEs, they are allowed because there is no viable alternative for their implementation. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/996586 that got lost when I renamed the class here: https://chromium-review.googlesource.com/c/chromium/src/+/993699 Tbr: grt@chromium.org Bug: 829490 Change-Id: I96a9382e0dd745023ea71ddcdbb2f31fac7abfa5 Reviewed-on: https://chromium-review.googlesource.com/1058552Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#558519}
-
Bailey Berro authored
Clicking 'SMB Shares' in the 'Add New Services' pane of the Files app opens the Network File Shares settings page in a new window. BUG=chromium:757625 TEST=verified on test device. Change-Id: I579b2ac34b269104118de478f521596af32fd7bb Reviewed-on: https://chromium-review.googlesource.com/1052613Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#558518}
-
Joe Downing authored
Now that KeyboardLock has been implemented, we no longer need the flag used to force the press and hold esc behavior to exit fullscreen. In fact this flag has actually been causing problems as several people have enabled this flag in addition to the KeyboardLockApi flag and reported UI issues (these have all been due to the UI flag). This CL removes the un-necessary flag to prevent further confusion and problems. BUG=680809 Change-Id: Ib2ef9d8cb28125fb19bcbd31d96823217a97f283 Reviewed-on: https://chromium-review.googlesource.com/1058044Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#558517}
-
Takayoshi Kochi authored
Now V0 UA shadow root are already gone and to avoid accidental misuses for creating UA shadow root via CreateShadowRootInternal(), rename it to CreateV0ShadowRootForTesting() and move the original CreateShadowRootInternal() to private. Bug: 787717 Change-Id: Idb3eae11f928d371fe102f766e54e6519f37d5db Reviewed-on: https://chromium-review.googlesource.com/1057047 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#558516}
-
Eric Lawrence authored
Preload classroom.google.com with the Google policy. Change-Id: I4841cecd9f9b06f955cbf754dcff00e0142b35fd Reviewed-on: https://chromium-review.googlesource.com/1058326Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#558515}
-
Dan Sanders authored
Bug: 842276 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibbbca8f7714b644034aa4b95fa444c9c51f973c7 Reviewed-on: https://chromium-review.googlesource.com/1056364Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#558514}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d58b7e0b..d527ddce Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4d4e49988b7291a9c15dc9edc6f5ff55141689cd Reviewed-on: https://chromium-review.googlesource.com/1057872Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558513}
-
Kyle Horimoto authored
Previously, it referenced PendingConnectionRequest::GetRequestId(), but the function is actually named PendingConnectionRequest::request_id(). Bug: 824568, 752273 Change-Id: I60fcd2dfe5863e6361c9820f1a2720c30f36be1a Reviewed-on: https://chromium-review.googlesource.com/1058435 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#558512}
-
Eric Roman authored
This was documentation relating to the internally available crash frontends and mailinglists. Change-Id: Ie4a89bb9cc663eaf9222f5dded29137dc39e2df8 Reviewed-on: https://chromium-review.googlesource.com/1055932 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558511}
-
Hiroshige Hayashizaki authored
This CL removes |num_sources| arguments of WebLocalFrame::ExecuteScriptInIsolatedWorld() methods, because |num_sources| is always 1. This CL also renames WebLocalFrame::ExecuteScriptInIsolatedWorld() with |results| argument to WebLocalFrame::ExecuteScriptInIsolatedWorldAndReturnValue(). This CL shouldn't change the behavior. This is preparation for https://chromium-review.googlesource.com/721862. Bug: 841466 Change-Id: I4a6b2d9da9bfd052cabe9147dac8c9f7818367c4 Reviewed-on: https://chromium-review.googlesource.com/1048323Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#558510}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iab0de9202356fb5105b93aade17ac4dd4dfeb19c Reviewed-on: https://chromium-review.googlesource.com/1058377 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558509}
-
Philip Rogers authored
CompositedLayerMapping::UpdateInternalHierarchy will orphan the main graphics layer if there are no special ancestor layers (for clips or squashing). PaintLayerCompositor::UpdateIfNeeded was responsible for re-parenting the main graphics layer using ParentForContentLayers, but this had a bug and would not re-parent in test configurations, leaving the graphics layer orphaned. Bug: 841423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id5c9fe5b87e9a5c2d47cff4a105c13a885d82d48 Reviewed-on: https://chromium-review.googlesource.com/1056056 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558508}
-
Peter Boström authored
Adds a top-chrome-md entry for Touchable Material Refresh under chrome://flags which is Refresh with a looser Touchable layout. This change adds MATERIAL_TOUCH_REFRESH to MaterialDesignController which enables both IsTouchOptimizedUiEnabled() and IsNewerMaterialUi(). All calls to GetMode() have been audited to make sure MATERIAL_TOUCH_REFRESH doesn't go out of bounds for kValue[mode] indexes. Most of these values have been filled in with the same values as Touchable (except for NTB size and tab insets) but they are subject to change as this mode gets audited further. A new method IsRefreshUi() is added to the MaterialDesignController which is true for MATERIAL_REFRESH and MATERIAL_TOUCH_REFRESH. All explicit MATERIAL_REFRESH checks have been updated to use IsRefreshUi() instead of MATERIAL_REFRESH directly. Where this is incorrect and Touchable should take precedence the code will have to be updated to look at IsTouchOptimizedUiEnabled() first (in separate future changes). Bug: chromium:839972 Change-Id: If0c8bfbd3ce0b33c578260b9e4c8af9e7edc93e9 Reviewed-on: https://chromium-review.googlesource.com/1055875Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#558507}
-
Tom Sepez authored
Change-Id: Ib72f8206079d69805205fcd26591f7606ff6f9fa Reviewed-on: https://chromium-review.googlesource.com/1054143 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558506}
-
Sigurdur Asgeirsson authored
The previous implementation read /proc/pid/task/tid/stat for each thread in the process. This had two issues: 1. When threads die, their CPU cost dies with them and so cumulative CPU cost for a process can go backwards. Reading /proc/pid/stat accounts for the cost due to dead threads. 2. It incurs a extra overhead to open all the individual task files that can be avoided by having the kernel do the tally in a single system call, and grabbing the relevant locks only once. For back story see e.g. https://crbug.com/546565. Bug: 841355 Change-Id: I82582e69187e4cd4069cf9dd02a4b62c326897e6 Reviewed-on: https://chromium-review.googlesource.com/1052811Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558505}
-
John Abd-El-Malek authored
I should have done this initially, but they're now past the point where they're large enough to be in their own file. TBR=nasko@chromium.org Change-Id: I328e03aea5f5a43407c5adb57f265cb64f300b82 Reviewed-on: https://chromium-review.googlesource.com/1057841 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558504}
-
Johannes Henkel authored
This takes care of a mechanical part of https://chromium-review.googlesource.com/c/chromium/src/+/1035091. web_url_error.h is a public header file, so it's possible to then depend on this. Bug: 838291 Change-Id: Ib7dfb28094466661e0aa5e28a94926b923dbbf1f Reviewed-on: https://chromium-review.googlesource.com/1057950Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#558503}
-
Lukasz Anforowicz authored
Bug: 841549 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I259234712ef9dbef570bca26ce3e5028da6a83a3 Reviewed-on: https://chromium-review.googlesource.com/1053243 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558502}
-
Bailey Berro authored
This change adds username and password as arguments that are passed from the Add Smb Share Dialog to Smb Browser Proxy to Smb Handler. This enables users to mount shares that require authentication. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1cbc94e45a85cb6fe048a7456a8ff340c6fcd220 Reviewed-on: https://chromium-review.googlesource.com/1054694 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558501}
-
Tibor Goldschwendt authored
If going to DD home and back to Chrome we won't always recreate VrShell. This could result in no assets being loaded. Load the assets in OnResume instead. This will also apply assets that may have been updated during a VR session. Bug: 812411 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I2fc6cf2d38a71f7483f5f818e46e48e3cc9bdb0e Reviewed-on: https://chromium-review.googlesource.com/1057870Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558500}
-
Peng Huang authored
Bug: 842162 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9b99d9230b59f5962399be14ace79215c0d4988e Reviewed-on: https://chromium-review.googlesource.com/1054163Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558499}
-
Michael Spang authored
This fixes a validation error in vulkan_tests: [160937:160937:0511/145413.931833:81810095976:WARNING:vulkan_implementation.cc(39)] Object: 0x0 | vkCreateRenderPass: pCreateInfo->pAtta chments[0].format is VK_FORMAT_UNDEFINED. The spec valid usage text states 'format must be a valid VkFormat value' (https://www.khronos. org/registry/vulkan/specs/1.0/html/vkspec.html#VUID-VkAttachmentDescription-format-parameter) Bug: 840470 Test: vulkan_tests Change-Id: I71e978d93077a3bddfe3e454ceab55929494e4c8 Reviewed-on: https://chromium-review.googlesource.com/1055786 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558498}
-
Owen Min authored
The dialog will be displayed during Chrome launch if it's blocked by network request. screenshot: https://drive.google.com/open?id=1v4nbbCyY5mo6yTffelxjGhhg-vwYJOrv https://drive.google.com/open?id=1qigP2YSjQNhuzbWtLDfIZZO5Jyoxy91u Bug: 840018 Change-Id: I95f07bc68ef0837d071004598d0473719e2cb528 Reviewed-on: https://chromium-review.googlesource.com/1045548Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558497}
-
Fady Samuel authored
This CL reduces IPC traffic if nnothing has changed on the parent side. We will only consider the LocalSurfaceId dirty if the parent sequence number or embed token has changed. Otherwise, we will not consider the LocalSurfaceId dirty and we will not send an unnecessary IPC that contains information that the child is already aware of. Bug: 672962 Change-Id: I35da312e74166d21d95ff5b24157f3cc20163160 Reviewed-on: https://chromium-review.googlesource.com/1057893 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558496}
-