GitLab

With iOS11 there is API to access WKHTTPCookieStore and through
WKHTTPSystemCookieStore, URLFetcher can use this api to set and get
cookies from WKHTTPCookieStore

This should fix PDF download problems, it also should allow suggestions
queries to send cookies and will use cookies for NTP tiles.

Bug: 779106, 831678
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I59637ebde557fae09cfd39105d84675724ac0140
Reviewed-on: https://chromium-review.googlesource.com/1050404
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558824}

This file will be used by layout tests in http/, so it needs to be visible to them. I was told to
move the file to http/tests/resources, but it looks like another option would be to expose
sensor/resources to http tests via the apache_http.py script, which might be cleaner. Thoughts?

Bug: 802815
Change-Id: I3a8e37e0d41915d8cd5c5983d50d0f4dcc69ebcb
Reviewed-on: https://chromium-review.googlesource.com/1058549Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558823}

Bug: 841475
Change-Id: I55e6008c29008fea3ca24bdca430fa3daa66a0d8
Tbr: chengx@chromium.org
Tbr: peter@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1060165Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558822}

These network quality estimator histograms were deprecated earlier,
but they were not correctly marked as deprecated.

Change-Id: Ib1081681cda243e7cd1c27f81ff453899242860f
Bug: 843210
Reviewed-on: https://chromium-review.googlesource.com/1058843Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558821}

Being added to buildbucket cfg in https://crrev.com/c/1058180

Bug: 790531,731983
Change-Id: Icdfaad8cb64db6d62f620e729e776232fc7ec564
Reviewed-on: https://chromium-review.googlesource.com/1058279Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558820}

BrowserStartupController.StartupCallback.onSuccess() has 'alreadyStarted'
argument, which is not used anywhere.

Bug: 841403
Change-Id: I8faf23c3b1d61d217460c0e3943dadeb6111ee05
Reviewed-on: https://chromium-review.googlesource.com/1055796Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558819}

Tests initialization by checking getters return the right values. Also
checks updating by checking setters properly modify the properties.

Bug: 778764
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I01ae81f5a7475b5e1bb5548707b7d9ab1b592701
Reviewed-on: https://chromium-review.googlesource.com/1058556
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558818}

This adds a presubmit check in the support library that all references
to InvocationHandlers should be annotated with the type they represent.

Annotations take the form of comments:

/* RetType */ InvocationHandler m(/* ParamType */ InvocationHandler p);

This intentionally skips import statements. The presubmit check is only
a warning, in case of false-positive.

Bug: 842022
Test: git cl presubmit -f --upload
Change-Id: I298d488d14f4fe828b02f4ac062bba6d4b1e9ae8
Reviewed-on: https://chromium-review.googlesource.com/1059009Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558817}

Previously we were timing out 'null' favicon results after 60 seconds.

This has turned out to be too simple of a heuristic now that we are
using the FaviconCache to back the default search provider icon in the
location bar.

Users would expect that the favicon appear immediately after loading a
matching search results page, and would be confused by a 60 second
delay.

Bug: 88243, 823535
Change-Id: I062361ffad0e0bdaa45f44ad67a7071efa086f2c
Reviewed-on: https://chromium-review.googlesource.com/1055787
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558816}

R=cmasso@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iae0bcff5ffab587114e0b1257981257115d27a15
Reviewed-on: https://chromium-review.googlesource.com/1060252Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558815}

This patch removes a check that causes the scrim to remain visable
after the bottom sheet is closed. The check in question blocked offset
change events if the bottom sheet is closed, but in certain cases like
when the sheet doesn't animate, the sheets state is closed before any
offset events occur.

This patch also adds a BottomSheetObserver when the sheet is opened
that controls the opacity of the scrim and removes it when the sheet
is closed.

Bug: 842902,842765
Change-Id: Ic70532cefa0ddcafc06d0a2b3a5b6e28639ff24e
Reviewed-on: https://chromium-review.googlesource.com/1058437
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558814}

Bug: 843024
Change-Id: I559a2d65f5112724112a0a57b38e4da4ef375bc4
Reviewed-on: https://chromium-review.googlesource.com/1060116Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558813}

r558579 changed the backing store of NTLM writes from being a
std::basic_string<uint8_t> to a std::vector<uint8_t>, to better align
with its purpose. This change had the effect of causing .data() to now
return nullptr when .size() == 0, rather than the previous behaviour,
in which .data() would return a 1-byte buffer that was a NUL ('\0')
terminator - the consequence of using std::basic_string<>.

This had the effect on writes which expected zero-byte writes (aka
no-ops) to succeed, in that GetBufferPtr() now returned nullptr, rather
than a valid pointer. Since zero-byte memcpys immediately follow, this
needs to be explicitly handled, as memcpy() requires both pointers be
valid, even for zero-byte writes.

BUG=843066

Change-Id: I9ff8f825469142da31abc866c81f0418ae25f93f
Reviewed-on: https://chromium-review.googlesource.com/1059449
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558812}

It was possible for the user to focus the inner <button> element via click
(otherwise button has tabindex -1). After that, pressing 'Space' once would
trigger both 'click' and 'keypress' toggling the state twice.

Bug: 841693,840723
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If1200b6d39ac3eb4d6dc44e5622b75ed7f8beab8
Reviewed-on: https://chromium-review.googlesource.com/1058249
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558811}

I got bitten by this in https://chromium-review.googlesource.com/c/chromium/src/+/1052854

Change-Id: I9a9321cf9b11fc80df12da7b04ab8118ed5dc3d2
Reviewed-on: https://chromium-review.googlesource.com/1055755Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558810}

Previously landed in crrev.com/c/1052860 and reverted in
crrev.com/c/1057308.

This should be safe to land, due to the internal change
http://crrev.com/i/625646, which stops official Android builds
from setting enable_resource_whitelist_generation in args.gn.

Original description:
This allows telemetry to have access to an indexed ruleset, without
having to specify one in the source tree (which would need to be
updated every time the format version changes).

Follow-ups will copy this into telemetry's user-data-dir.

Bug: 823982
Change-Id: I8c9208f1148820340d1dc587e28fb0dfbaa354ee
Reviewed-on: https://chromium-review.googlesource.com/1057422Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558809}

https://chromium.googlesource.com/catapult.git/+log/35cefb8d8a2f..0273fdc65acb

$ git log 35cefb8d8..0273fdc65 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 sullivan Move auto_triage to mark_recovered_alerts and correct logic.
2018-05-14 simonhatch Dashboard - Remove TestMetadata.monitored
2018-05-14 maxlg [CSMMerging] Refactor breakdown_tree_helper with findEmptyRangesBetweenRanges

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I335c37e39c62372c30aac7bf4d9076e18812fc61
Reviewed-on: https://chromium-review.googlesource.com/1060103Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558808}

This reverts commit c2b04a4c.

Reason for revert: Caused Cast build break

Original change's description:
> Access UpdateManager via getInstance().
> 
> This API changes in AT O.
> 
> Bug: internal b/77915277
> Test: Compile
> Change-Id: Id3c651378d9ac12319cd5aa437e9c56d48ea3096
> Reviewed-on: https://chromium-review.googlesource.com/1033472
> Commit-Queue: Doug Horn <doughorn@google.com>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558312}

TBR=halliwell@chromium.org,doughorn@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: internal b/77915277
Change-Id: I9bdb2c5c4a7c841fe26b2b5d212ebb32c6a544a2
Reviewed-on: https://chromium-review.googlesource.com/1059952Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558807}

This CL turns AFDO on for official builds of Linux. This appears to be a
<0.5% binary size regression, and should grant a pretty solid
performance gain.

This CL is also expected to increase build times of official builds by
around 12% (wall and CPU time). A memory usage increase of around
210-225MB per TU is also expected.

Depends on install-build-deps.sh change in r557698; it was re-run on
bots in crbug.com/841983, and devs were asked to update in "FYI: Linux
builds of Chromium need to run install-build-deps.sh after #557698".

Bug: 805098, 821595, 837025
Test: See issue 821595 for perf reports.
Change-Id: I9eafad1d20b897e77566de423f29c11cc8c13e83
Reviewed-on: https://chromium-review.googlesource.com/1025132
Commit-Queue: George Burgess <gbiv@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558806}

This is an attempt to fix the random crashes that happen in
the crazy::RDebug::WriteLinkMapField() function on some devices
(for more context, see related bug below).

It is very hard to understand why these crashes happen, the
best candidate hypothesis so far is that both the crazy linker
and the system linker try to modify the same area of memory
at the same time (the global _r_debug link-map list, see
technical note in crazy_linker_rdebug.h for all details).

This CL tries to reduce the occurence of such events by
better synchronizing modifications performed by the system
linker, and the crazy one.

This is done by the following steps:

- Create a new global mutex, and associated convenience class,
  used to synchronize modifications to the global _r_debug link
  map list. See Globals::ScopedLinkMapLocker.

  Before the CL, only *explicit* modifications to the list were
  synchronized through the global crazy lock, but this did not
  protect against other threads from native code that call the
  wrapped dlopen(), which end up calling the system ::dlopen()
  which may also modify the list.

  These explicit modifications would typically happen after
  the library was loaded, due to the fact that they are
  applied by a delayed callback running on the UI thread,
  not the thread that loaded the library.

  Ironically, this delayed callback scheme was introduced
  to try to reduce these kind of random crashes. We may
  consider removing it entirely if this patch doesn't
  fix the situation.

- To solve this, wrap all calls to the system linker through
  a new convenience class: crazy::SystemLinker. And ensure
  that each call that may change the global list will
  properly lock/unlock the link map mutex.

- Incidentally, this allows making the global crazy mutex
  non-recursive.

+ Initialize the RDebug instance properly when its
  GetAddress() method is called. Otherwise, it could return
  a nullptr value in certain cases.

  This was not an issue in practice, since it was only used
  to update the DT_DEBUG entry of a crazy-loaded library,
  which technically isn't used by anything at runtime
  (e.g. GDB would find the value from the executable
  image instead, not from one of the shared libraries
  already in the list).

BUG=831403
R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org, lizeb@chromium.org

Change-Id: I6aa5f622908fc56deb37825ffed4a816ec6e4cc2
Reviewed-on: https://chromium-review.googlesource.com/1059516
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558805}

Bug: 842232
Change-Id: I6c00da413a8e1138f62ff578224aa0d1a2e2f599
Reviewed-on: https://chromium-review.googlesource.com/1060122
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558804}

If the server doesn't support partial responses, Chrome should cancel
parallel download requests.
These requests result in the wrong write offset and makes the file larger
than the original

This is a Reland of the original CL. That CL fails because the BrowserTests
need to wait for the 2 cancelled requests, or tsan bots will complain.
There is no good way for ParallelDownloadJob to report cancelled requests.
So this CL uses the histogram to check if 2 failed AddStream attempt was
conducted.

BUG=838627

Change-Id: I856f31c23f2f08ed63e761656b0ed7fc6d6addc4
Reviewed-on: https://chromium-review.googlesource.com/1055852
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558803}

Bug: 836362
Change-Id: I677cffed597ce6dc50247916055bd3182d4a206e
Reviewed-on: https://chromium-review.googlesource.com/1041567
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558802}

Clients of //ios/web_view may wish to show a little icon to represent
the network of the credit card.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8d35f18187f352529e8f47c33ddfe94b13ff7e81
Reviewed-on: https://chromium-review.googlesource.com/1058368Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558801}

Per UX feedback, we should not show [esc] in the context menu when we know that
press and hold is required to exit fullscreen.  This change updates the context
menu to query the current keyboard lock state to handle that scenario.

BUG=680809

Change-Id: Iea80d64b0c3f905521f9bf07473b6b26791fa042
Reviewed-on: https://chromium-review.googlesource.com/1055659Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558800}

https://webrtc.googlesource.com/src.git/+log/28a325b52314..ef75ebef5520

$ git log 28a325b52..ef75ebef5 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I25d85077e5e71a907aa4468888a5e6d1bc9e745b
Reviewed-on: https://chromium-review.googlesource.com/1060099Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558799}

change highlight tab color to GB 600 in Clear Browsing Data, Manage
certificates.
and also drop the uppercase from Certificate manager's tabs
to keep consistent.

Bug: 842010
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I060112a47e9feac1ccba6b9dc20b48d4ca6843d0
Reviewed-on: https://chromium-review.googlesource.com/1055229
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558798}

If FRE is not performed, and initial enrollment is enabled according to
command line flags and device state, performs initial enrollment check.
Specifically, the initial enrollment check is done if all of the
following conditions are true:
- the device was not enterprise enrolled or in consumer mode before
  (according to the check_enrollment VPD variable)
- the RLZ embargo date has passed
  (to ensure not to do initial enrollment exchanges on the factory floor)
- Initial enrollment is enabled usinga  command-line switch
- serial number and RLZ brand code are available.

Bug: 839353
Change-Id: I259c06a5e5274f3bdef54ccc0161e6f642f9499f
Reviewed-on: https://chromium-review.googlesource.com/1052707Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558797}

This also eliminates a few unnecessary includes.

Bug: 798569
For c/b/chromeos/policy DEPS changes:
TBR=emaxx@chromium.org

Change-Id: I80a73a68819f0295f9c81b910467c6e38dd2571e
Reviewed-on: https://chromium-review.googlesource.com/1041568
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558796}

  In order to roll GN 0fbf0789..ccbeab67 (r555198:r558753) and pick up
  the following changes:

  443b70db Fix GN doc formatting.
  e8a3ce91 GN: do not make indirect dependency to direct dependency
  ea15ea06 Fully move PathService into the base namespace.
  ae62ba99 GN: Make the linker output file depend on the inputs.
  629ba73c [MessageLoop] Fix message_loop.h includes

TBR=brettw@chromium.org

Change-Id: I982bbe01bad86a66e7aed379ee1155bdfaa76ff8
Reviewed-on: https://chromium-review.googlesource.com/1060095
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558795}

When we do async hit-testing for OOPIF, we can be trying to do
hit-testing when the local main frame is not valid anymore. Add null
check for that and return empty hit-test result in that case; it would
then be handled in RenderWidgetInputHandler::GetFrameSinkIdAtPoint [1].

[1] https://cs.chromium.org/chromium/src/content/renderer/input/render_widget_input_handler.cc?type=cs&g=0&l=194

Bug: 842458
Change-Id: Ic6a90de54840973a8262ea88472ae9d295c6f773
Reviewed-on: https://chromium-review.googlesource.com/1058343Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558794}

BUG=762641
TBR=satorux@chromium.org

Change-Id: I98e6da904435d11a232ccc554c1005df11cd2b7f
Reviewed-on: https://chromium-review.googlesource.com/1059458
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558793}

These resources were only bundled but not yet loaded.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2bf6ed5d04a12bc5a03dfc001061eb032941d8f3
Reviewed-on: https://chromium-review.googlesource.com/1058346Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558792}

Background:
Folder item's metadata (including position) is retrieved via syncable
service and is set to the folder item. But the item's index in item list
is not updated based on the metadata.

Change:
Update the index in item list if position in the metadata changes.

BUG=842420

Change-Id: I27f67bf37a451f90c4d7654dac9152ea500bfd8d
Reviewed-on: https://chromium-review.googlesource.com/1056064Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558791}

Bug: 842999
Change-Id: I97a64b1aa77c2991e0b20e80e985cbd4f7012e02
Tbr: tedchoc@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1060108
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558790}

Previous attempt: https://chromium-review.googlesource.com/c/chromium/src/+/1054675
This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually.
The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding. They are interactive UI tests because actual typing is involved.

Bug: 842643
Change-Id: I81e8f444374012272433e514d12d398d850a15b9
Reviewed-on: https://chromium-review.googlesource.com/1059627
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558789}

Refactor code and share most of it by moving into FrameHeader
superclass (which is no longer just an interface).

Reduce code duplication and improve the chances the
implementations will stay in sync.

Bug: none
Change-Id: I09d3ba209e9351c0c1980c35660212f7c1b7a96f
Reviewed-on: https://chromium-review.googlesource.com/1053116Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558788}

Fix inconsistent variable names and pass missing paramaters to
functions.

Change-Id: I6eb4bed6a9fd77b820594b4ac1d5719207cd38b8
Reviewed-on: https://chromium-review.googlesource.com/1057906Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558787}

To share a temporary page, we use a content: URI instead of a file URI
so that we don't need to publish the page to the download directory.

Bug: 758733
Change-Id: I873756591fc29537fa1290a0153980f1135db04b
Reviewed-on: https://chromium-review.googlesource.com/1056214
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558786}

Scrim visibility in the location bar is now completely controlled by
a single function. The scrim observer is now added and removed based
on the scrim visibility to avoid conflict with other observers (like
the bottom sheet).

Bug: 834927
Change-Id: I172ca637dde5bc026b1b7f629bc34c6d939dff2d
Reviewed-on: https://chromium-review.googlesource.com/1026168
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558785}