- 01 Mar, 2019 40 commits
-
-
W. James MacLean authored
At present TouchSelectionController uses |show_touch_handles_| to decide when handles are shown by touch events. It is set to 'true' in TouchSelectionController::WillHandleTouchEventImpl(). But if this value is defaulted to true, then PDFs may show the handles on the first selection, even if initiated by non-touch means. This doesn't show up in non-PDF pages, as there seems to be a mechanism in RenderWidgetHostViewAura that prevents the TouchSelectionController from ever being told about selection changes from non-Touch events. Some tests were fixed, since they relied on the old default value to avoid having to send actual touch events. The CL changes the default to avoid handles showing up for the first mouse selection in PDFs. Bug: 933631 Change-Id: I1d66df070c22481141f68f6085f04878842c9f2b Reviewed-on: https://chromium-review.googlesource.com/c/1491794 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636809}
-
Marc Treib authored
TBR=pwnall@chromium.org No-Try: true Bug: 937170 Change-Id: I6fdb63366939b9a027d327491da61cbda90e7205 Reviewed-on: https://chromium-review.googlesource.com/c/1496880Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#636808}
-
Yi Gu authored
See linked bug for details. TBR=einbinder@chromium.org NOTRY=true Bug: 937171 Change-Id: If82006056e04ee829668ad79a22bd1e2ec69e8b1 Reviewed-on: https://chromium-review.googlesource.com/c/1496766Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636807}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2dfb3f01e77d..1c92c159adf9 git log 2dfb3f01e77d..1c92c159adf9 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 cwallez@chromium.org Fix overflow in CommandAllocator 2019-03-01 cwallez@chromium.org Implement wrapping IOSurfaces in dawn::Texture. Created with: gclient setdep -r src/third_party/dawn@1c92c159adf9 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I08022b2ef038872100a4a65ee964f7eedf52126a Reviewed-on: https://chromium-review.googlesource.com/c/1496893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636806}
-
Yi Gu authored
TBR=pkotwicz@chromium.org NOTRY=true Bug: 937242 Change-Id: Ic705e4dcfa5abb1dcd0ff5baa32b51f7f84c6b42 Reviewed-on: https://chromium-review.googlesource.com/c/1496765Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d85235292c2c..07a259de1240 Created with: gclient setdep -r src-internal@07a259de1240 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibefa7c9ab56301099ac47b8981d61da215f69280 Reviewed-on: https://chromium-review.googlesource.com/c/1496891Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636804}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warning this this avoids is: third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1762:40: error: declaration shadows a local variable [-Werror,-Wshadow] EffectPaintPropertyNode::State state; ^ third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1711:38: note: previous declaration is here ScrollPaintPropertyNode::State state; ^ third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1776:40: error: declaration shadows a local variable [-Werror,-Wshadow] EffectPaintPropertyNode::State state; ^ third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1711:38: note: previous declaration is here ScrollPaintPropertyNode::State state; ^ Bug: 923510 Change-Id: Ia64158f91a8f07cd238e01b1e1e31b35a6b5ac06 Reviewed-on: https://chromium-review.googlesource.com/c/1496874 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#636803}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/328027b6c434..859abef68cb5 git log 328027b6c434..859abef68cb5 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 titovartem@google.com Use DefaultVideoQualityAnalyzer as default, cleanup headers. 2019-03-01 titovartem@google.com Fix namespace for PeerConnectionE2EQualityTestFixture 2019-03-01 mbonadei@webrtc.org Implicitly suppress //build/config/clang:find_bad_constructs. 2019-03-01 mbonadei@webrtc.org Fix peerconnection_quality_test #includes and deps. Created with: gclient setdep -r src/third_party/webrtc@859abef68cb5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1c4888d1f4a39666ee3e69355042183df578605b Reviewed-on: https://chromium-review.googlesource.com/c/1495793Reviewed-by:
-
Yi Gu authored
See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=worklet-animation-with-scroll-timeline TBR=treib@chromium.org NOTRY=true Bug: 915352 Change-Id: I7b1a586a9352fcb8b3a4a7d8ab838f199c0858b4 Reviewed-on: https://chromium-review.googlesource.com/c/1496763Reviewed-by:
-
Lucas Tenório authored
This is only the first step of renaming this feature, the next steps are: - Rename the Contained Shell references in chrome://settings and the rest of the browser. - Rename all occurrences of Contained Home to KioskNextHome. For this change, I'm mostly focusing on code living in ash. We are changing the name of this feature to reflect the refactoring work and ultimate goal. Also considered calling it MojoKiosk, but Mojo team prefers to keep the Mojo name referring specifically to the Mojo library, not uses of the library. Bug: 933530 Change-Id: I717cee439da14d6bbd575c26b9f55805ad4d5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/1489272Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#636800}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ea32aab..d01c24e5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I06969b7e5e00125907609c0324545976283366e4 Reviewed-on: https://chromium-review.googlesource.com/c/1496761Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636799}
-
Yi Gu authored
See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=worklet-animation-with-scroll-timeline-and-display-none TBR=treib@chromium.org NOTRY=true Bug: 915352 Change-Id: Ie287d2af0cd7fff9e2393e2918837867dcf4125d Reviewed-on: https://chromium-review.googlesource.com/c/1496762Reviewed-by:
-
Nicolas authored
After both the 'external' and 'IEEM' sitelists have been downloaded, LBS will now write the 'sitelistcache.dat' file with the combined sitelists' contents. Bug: 909878 Change-Id: I789f1e4b59f69af78c3c14a4330d48a50cac94d5 Reviewed-on: https://chromium-review.googlesource.com/c/1468121 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636797}
-
Yuki Shiino authored
Fix the bindings generator so that it won't use variable length arrays with zero sizes, which are forbidden by C++ standard. Bug: 932489 Change-Id: Ife08fe8be4e6b9907c3c97c8047c0432cdddd4bc Reviewed-on: https://chromium-review.googlesource.com/c/1490985 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#636796}
-
Robert Sesek authored
BufferIterator is a bounds-checked container utility to access variable- length, heterogeneous structures contained within a buffer. Bug: 932175 Change-Id: I41f81fca3671bc35fbe65d0dc71c8fd4742453c5 Reviewed-on: https://chromium-review.googlesource.com/c/1481654Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636795}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/88ac583e6668..ab0bd92ed40d git log 88ac583e6668..ab0bd92ed40d --date=short --no-merges --format='%ad %ae %s' 2019-03-01 lalitm@google.com Merge "base: add hasher class for hashing data using FNV-1a" Created with: gclient setdep -r src/third_party/perfetto@ab0bd92ed40d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I24e518269fd7c5592bb82d54fb735a83296b9792 Reviewed-on: https://chromium-review.googlesource.com/c/1495791Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 28586cfa. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" a6d9cfda "[WPT] Changes to generated files by CL 1476144" 4665f96b "RestrictDeviceSensorEventsToSecureContexts by default." 03505df6 "[Origin Policy] Implement error reporting via Reporting API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic6cdce3016510a3e93830ce3f1980f0e41e7a839 Reviewed-on: https://chromium-review.googlesource.com/c/1496760Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636793}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fb02ade1a0b9..727c16174db3 git log fb02ade1a0b9..727c16174db3 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 perezju@chromium.org [Telemetry] Move tracing of agent method calls to TracingAgent Created with: gclient setdep -r src/third_party/catapult@727c16174db3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931236 TBR=sullivan@chromium.org Change-Id: I2793bbe5ada9e7d4601f02d3cb9ce8338f253a1b Reviewed-on: https://chromium-review.googlesource.com/c/1495792Reviewed-by:
-
Anna Malova authored
Add metric to trace how CCT translate feature is used. The usage of the feature is guarded by cct-target-translate-language flag. Bug: 922969 Bug: 931682 Change-Id: Ide16e218ab8f88aa5b7dd0208a0067d5ef1543d3 Reviewed-on: https://chromium-review.googlesource.com/c/1451895 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#636791}
-
Zinovy Nis authored
1) MachineLevelUserCloudPolicyManager::Init calls grand-parent Init() instead of parent'. 2) Minor std::move-related optimizations. Bug: <None> Change-Id: If252493c579690f7fe550c7fc2bb0f0188a314f4 Reviewed-on: https://chromium-review.googlesource.com/c/1340801Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#636790}
-
Martin Robinson authored
We calculate text offsets for the AtkText APIs using UTF-16 code units offsets, yet the values that touch the API surface are in Unicode character offsets. This is only an issue when the text contains UTF-16 characters with multiple code units. Use the Adjustments data structure to move between these two offset types. Bug: 866337 Change-Id: I09f81d0934ea1effe597c4c969d20135bbc1937c Reviewed-on: https://chromium-review.googlesource.com/c/1478798 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636789}
-
Kirill Kosarev authored
Now in load_tests we change benchmarks base classes that could unexepectadly affect others tests. So set pageset_repeat=1 only for SinglePageBenchmark. Change-Id: Ib0a06ed927d7eb9304856c45f51028d051fb1fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1489192Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#636788}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I34e943d86e3f6c3381bbfc83ca6c43e476310696 Reviewed-on: https://chromium-review.googlesource.com/c/1495789Reviewed-by:
-
Sergio Villar Senin authored
There were several mistakes in the list of wpt marked as [ Slow ]: 1) duplicate entries not detected because of misspellings 2) non existing files 3) files that were renamed Bug: 765026, 626703, 874695, 878995 Change-Id: I3456dc508ab98426a9cc842eb42a3500faab467b Reviewed-on: https://chromium-review.googlesource.com/c/1493908 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636786}
-
Yutaka Hirano authored
Also, - Put the name of the result policy, not the integer representing the policy, to the events. - Gather RESOURCE_LOADING_DVLOG to reduce code duplication. Bug: 937173 Change-Id: Ibf19e2b853fbbe6b100f847c3ed3cc63e21e02e7 Reviewed-on: https://chromium-review.googlesource.com/c/1496265Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#636785}
-
Miyoung Shin authored
Refactor: unsigned short -> uint8_t/uint16_t in third_party/blink/renderer/platform/wtf/text/utf8.cc - unsigned short -> uint8_t/uint16_t. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I497af04207c19c5d390b42c6874001844f023363 Reviewed-on: https://chromium-review.googlesource.com/c/1496121 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I420583fd54e02d301839363aee97bcf1efa9097a Reviewed-on: https://chromium-review.googlesource.com/c/1496403Reviewed-by:
-
Boris Sazonov authored
Open system account management page from openAccountManagementScreen if MOBILE_IDENTITY_CONSISTENCY is enabled. Bug: 936953 Change-Id: I97a432da92448afc46724e555d872ef3a4f57795 Reviewed-on: https://chromium-review.googlesource.com/c/1495515Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#636782}
-
Nigel Tao authored
Instead, put the AppType into the IconKey field. A future commit will remove the now-mostly-redundant IconType enum and field. An upcoming commit will introduce icon caching, for which the cache key contains an IconKey. Interposing a caching layer means separating the AppServiceProxy::LoadIcon method (which currently takes an app_id) into two: one that looks up the AppRegistryCache to convert an app_id into an (AppType + IconKey) pair, and one that passes that pair on to the underlying Mojo service. The icon cache intercepts the second method but not the first. In terms of C++ machinery, that intermediate is easier to deal with as a single variable (an IconKey) instead of a pair (AppType + IconKey). Thus, we move the AppType into the IconKey. BUG=826982 Change-Id: I3832daca0a8e11a0f9afc197679d46ee2b5035c0 Reviewed-on: https://chromium-review.googlesource.com/c/1496256 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Change-Id: I06b3adf9661acce35c6aa27ae45c68426a762ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1495530Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#636780}
-
Boris Sazonov authored
This CL exposes MobileIdentityConsistency to Java. It will be used in subsequent CLs. Bug: 936953 Change-Id: Iee987b29581109bd223795a507ae3ce7042f009e Reviewed-on: https://chromium-review.googlesource.com/c/1495514Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9539a2ce1044..d85235292c2c Created with: gclient setdep -r src-internal@d85235292c2c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I43341f477ae62c40b7abeed71107cde6528e42b4 Reviewed-on: https://chromium-review.googlesource.com/c/1495788Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e98c60f8483..328027b6c434 git log 8e98c60f8483..328027b6c434 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 danilchap@webrtc.org Replace fatal error with error log 2019-03-01 hta@webrtc.org Add GetSctpTransport to proxy map 2019-03-01 kwiberg@webrtc.org sdk/android:native_api_stacktrace: Declare a more narrow set of dependencies 2019-03-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d1e2a1cf..24eaf090 (636518:636660) Created with: gclient setdep -r src/third_party/webrtc@328027b6c434 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:818643,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I056c4eacdeacbf877d0c419e6ae4af29625e6f38 Reviewed-on: https://chromium-review.googlesource.com/c/1495783Reviewed-by:
-
Michael Lippautz authored
HasPendingActivity() is called during garbage collection which may happen during constructing an AudioNode. Since the handler has not been set at this point we need to guard against derefencing null. Bug: 937208 Change-Id: I4ee92d08c97f044aca8043443f04d751428e8455 Reviewed-on: https://chromium-review.googlesource.com/c/1495977Reviewed-by:
-
Arthur Hemery authored
Currently, browser initiated navigations are never interrupted after binding the remote NavigationClient. This does not handle cases where the failure happens after ReadyToCommit. For example a download to a source url would be flagged as illegal in the blink frame and the DocumentLoader destructed, which should notify the browser. Bug: 784904 Change-Id: Idd39bbf702ad2cb53b1b0eb1c01ca1df7b58124c Reviewed-on: https://chromium-review.googlesource.com/c/1494888Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#636775}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/65cf8a9b9775..88ac583e6668 git log 65cf8a9b9775..88ac583e6668 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 taylori@google.com Merge "Add config protos to perfetto_trace.proto" Created with: gclient setdep -r src/third_party/perfetto@88ac583e6668 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If14a02128da4f757c1e6be76aa397c1a5a588ce8 Reviewed-on: https://chromium-review.googlesource.com/c/1495787Reviewed-by:
-
Sami Kyostila authored
If the target object of a Looper message gets garbage collected after the message is handled but before Looper logs the 'finished' line, the signature of the object may not match the original 'dispatching' log line. To work around this, store a reference to the original target signature to ensure a matching end event. This patch also adds some extra debug logging when duplicate early trace events are started simultaneously. Bug: 935869 Change-Id: I4bafba4a5469ca5743d9cd6d64cb043e82387b8c Reviewed-on: https://chromium-review.googlesource.com/c/1491612 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#636773}
-
Lutz Justen authored
Helps to track down issue with block_devmode for Chromad devices. BUG=chromium:889893 TEST=None Change-Id: Iad22f7b86ba5c2a69c31f23ec0fd221288eed767 Reviewed-on: https://chromium-review.googlesource.com/c/1477267Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636772}
-
Arthur Hemery authored
After running a callback in the renderer we destroy the NavigationClient interface that was used to commit, since by design, it is an interface that lives only during the navigation. This is not an issue, except with the introduction of mechanisms intercepting DidCommit* callbacks and messages execution. In this case, the callback is intercepted, but the destruction still is interpreted by the NavigationRequest to be an abort. To counteract this, we introduce a new helper function that we use to ignore interface disconnects when receiving the DidCommit* messages, and before processing it. This way we are guaranteed (because we receive the messages in order DidCommit -> Disconnect) that the disconnect coming from this source is always ignored. Bug: 784904 Change-Id: If169c3f9fb76a20200dbb1466e9bc48d736140bf Reviewed-on: https://chromium-review.googlesource.com/c/1491434Reviewed-by:
-
Jérôme Lebel authored
SyncSetupService::CommitChanges() should not be called when the user taps on the "Settings" link in the sign-in screen. Bug introduced with crrev.com/c/1010346 -[ChromeSigninViewController signinCompletedWithUnity] is created to get the correct behavior for Unity. This method is only called with Unity. -[ChromeSigninViewController acceptSignInAndCommitSyncChanges] has now the same implementation than before Unity. This method is only called without Unity. Bug: 936461 Change-Id: I23353fe199d5e31b66feefe9fc5416f452ab35aa Reviewed-on: https://chromium-review.googlesource.com/c/1495519Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636770}
-
