- 24 May, 2019 40 commits
-
-
Steven Bennetts authored
When NetworkList and NetworkListView got merged after the system tray UI was moved back from src/ui to src/ash, nework_list.cc never got renamed to reflect the name of its class which is very confusing. This fixes that. Bug: 862420 Change-Id: I07a48a135259af2ac9d6028590f7a4206570acdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627945 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#663108}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0dee19bacc00..8207b641f56e git log 0dee19bacc00..8207b641f56e --date=short --no-merges --format='%ad %ae %s' 2019-05-24 herb@google.com Remove SkPackedID 2019-05-24 bsalomon@google.com Revert "Allow swapping out of GrBackendTexture used by SkSurface" 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 bsalomon@google.com Blacklist ReplaceSurfaceBackendTexture on all Nexus5x Vulkan bots 2019-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8224a58b4749..e794ddc8a662 (5 commits) 2019-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a410b698..778c5dab (458 commits) 2019-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cae8cde7fa65..8a2441d37d80 (26 commits) 2019-05-24 brianosman@google.com Revert "Active layer excludes outPoint" 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-23 bsalomon@google.com Disable two new tests on two bots while errors investigated 2019-05-23 brianosman@google.com Interpreter: Disassemble during execution when TRACE is enabled 2019-05-23 brianosman@google.com Support larger compound types in the interpreter 2019-05-23 jvanverth@google.com Remove Metal Perf bot from MacBook Air 2019-05-23 bungeman@google.com Add test of char to glyph round tripping. 2019-05-23 reed@google.com split RGB into YUV planes 2019-05-23 fmalita@chromium.org [skottie] Clamp seek() to the valid frame range 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-23 isabelren@google.com Active layer excludes outPoint 2019-05-23 khushalsagar@chromium.org remote fonts: Also send empty paths so they don't count in cache misses. 2019-05-23 michaelludwig@google.com Reland "Track quad type on GrQuad directly" 2019-05-23 bsalomon@google.com Allow swapping out of GrBackendTexture used by SkSurface 2019-05-23 herb@google.com Get bulk advances for SkPDFDevice::internalDrawGlyphRun 2019-05-23 bsalomon@google.com Add GPU implementation of rescaling for SkSurface::asyncRescaleAndRead. Created with: gclient setdep -r src/third_party/skia@8207b641f56e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960981 TBR=csmartdalton@google.com Change-Id: Ica591b9c1f7bc14703bbe115930d692aaabb5322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628461Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663107}
-
Allen Bauer authored
Bug: 966519 Change-Id: I9473da0496cfa56151773e1a218f55f8769a1419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627751 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#663106}
-
John Williams authored
Bug: 965229 Change-Id: I1a35fe6af6a1878b409c7543901ba78bbe7ab2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623140 Auto-Submit: John Williams <jrw@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#663105}
-
James Cook authored
This ports a browser settings CL to do the same: https://chromium-review.googlesource.com/c/chromium/src/+/1583120 It also ports a fix for focus ring padding on the settings menu button: https://chromium-review.googlesource.com/c/chromium/src/+/1611139 The tests are not ported yet because we're still setting up our test scaffolding for the OS settings pages: crbug.com/955731 Bug: 628247,950007 Change-Id: I9941ae06532bc1088beaffa1f8dcc82a7d81e800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627241 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#663104}
-
Edin Kadric authored
Bug: 966767 Change-Id: Iefc519e383b765c9cfc5058e73be0cdfa570fced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628830Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#663103}
-
Mason Freed authored
This reverts commit 09a1f53e. Sheriff: I suspect this is causing the LEAK failures here: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34655 https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_Leak/34655/webkit_layout_tests/layout-test-results/results.html Original change's description: > Keep scroll by keyboard after child focused node is removed > > So far, scroll stops if focused child node is removed > while scrolling parent node. > This is because the event handler passes the |MousePressNode|. > If focused child node(|MousePressNode|) is removed, > it will be null and scrollable area changed to document. > > |LogicalScroll| finds scrollable area from |MousePressNode|. > If we save this scrollable area node, > we can get one more chance to find proper node to scroll. > > > Bug: 493078 > Change-Id: I6e81ca0a0d15e0def66c8457840ca9e1343e8dba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611620 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Lan Wei <lanwei@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663040} TBR=bokan@chromium.org,lanwei@chromium.org,bluewhale.marc@gmail.com Change-Id: I4b8ea440dc16022077746d7924506e7f03ac1673 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 493078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628880Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#663102}
-
Bailey Berro authored
- Flips the feature flag for the streamlined usb printer setup flow launching in M76. Bug: 935135 Change-Id: I34271b9c77cf58f4d736ed1032e354e55f437d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626532 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#663101}
-
Scott Violet authored
Specifically window_tree and window_manager. BUG=964460 TEST=none TBR=tsepez@chromium.org Change-Id: I5f0fae5bd832b72d2a7d82331effa085d22741fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628002Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#663100}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ce723234bacf..a0e9943ca69a git log ce723234bacf..a0e9943ca69a --date=short --no-merges --format='%ad %ae %s' 2019-05-24 eladalon@webrtc.org Negotiation of LNTF controls instantiation of RTPSenderVideo::rtp_sequence_number_map_ 2019-05-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8ae1a64b..e1ec78e2 (662926:663034) 2019-05-24 mbonadei@webrtc.org Ensure CpuInfo::DetectNumberOfCores is > 0 and thread safe. 2019-05-24 eladalon@webrtc.org Negotiate use of RTCP loss notification feedback (LNTF) 2019-05-24 mbonadei@webrtc.org Use preprocessor to strip H264 implementation. 2019-05-24 ilnik@webrtc.org Reland "VP9 screenshare: Don't base layers frame-rate on input frame-rate" 2019-05-24 nisse@webrtc.org Let RtpVideoStreamReceiver implement KeyFrameRequestSender 2019-05-24 nisse@webrtc.org Reland "Delete STACK_ARRAY macro, and use of alloca" Created with: gclient setdep -r src/third_party/webrtc@a0e9943ca69a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I62b7ef9630946c10cdc03485c3b0cbe0d2aab434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628460Reviewed-by:
-
Robert Ma authored
Manually importing because of incorrect Fuschia baselines Using wpt-import in Chromium d334146a. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/visual-viewport meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/css-contain NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I34c7188521125bc61ed460007fba9cc883fba51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628867Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#663098}
-
Alex Clarke authored
Added a destructor to ManualPromiseResolver which cancels the promise if unsettled. Bug: 906125 Change-Id: I4fe26178c53322e8818e98c015121831bdf1e6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626855 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#663097}
-
Vladislav Kaznacheev authored
This undoes the effect of http://crrev.com/c/1530962 on Chrome OS. That CL has introduced a high frequency crash on Chrome OS in M75 (~1.5% of all browser process crashes). Its original intent was to change behavior on Linux. Said behavior (ability to activate notification views for inline replies) worked on Chrome OS before, and continues working with that CL reverted. Bug: 957110, 940924 Test: notification with inline reply works (see steps in bug 940924) Change-Id: I971e46a7c22e942f5a8e54b0f64c5a08f922968d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627964Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#663096}
-
behdad authored
18 pages are added for mobile representatives under the tag of "REPRESENTATIVE_MOBILE". These pages are chosen using the data recorder in chromeperf dashbaord in past 100 days. of platforms below: - ChromiumPerf:Android Nexus5 Perf - ChromiumPerf:Android Nexus5X WebView Perf - ChromiumPerf:Android Nexus6 WebView Perf https://goto.google.com/chrome-benchmark-clustering The clusters are visualized here: https://behdadb.users.x20web.corp.google.com/clusterDashboard/charts.html Bug: chromium:963573 Change-Id: I5644b169ad074824a840f48ffb2d693b87fe951c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613885 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#663095}
-
Steven Bennetts authored
This also converts NetworkListView and VPNListView to use TrayNetworkStateModel. Bug: 862420 Change-Id: I54efc6823a59331c3d011f7af40d1fb05d27a20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626256 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Yi Su authored
This CL creates //ios/web/public/security/BUILD.gn and removes the temporary header //ios/web/public/certificate_policy_cache.h Bug: 956511,942244 Change-Id: I7f70539cb2ce2d504e058a94a585124d265e12a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624809Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663093}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/441284b3fb3e..a948316f5ffd git log 441284b3fb3e..a948316f5ffd --date=short --no-merges --format='%ad %ae %s' 2019-05-24 lalitm@google.com systrace: bump trace to text version Created with: gclient setdep -r src/third_party/catapult@a948316f5ffd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Change-Id: I8c779f8c5c8baff687a382ba30728966e6b0a9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628123Reviewed-by:
-
Aaron Gable authored
This is a follow-up to https://crrev.com/c/1299776. That change made 'minimal_symbols' a default for all debug bots, but it left many configs which still explicitly (and redundantly) specified 'minimal_symbols'. This change cleans those up and consolidates configs for easier reading. Change-Id: I3642e230f24ab7284d127597dc4b50ba2750a7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625846Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#663091}
-
Mohammad Refaat authored
TabStripController used didChangeTab TabModelObserver's method to monitor favicon changes. This was done through TabModelFaviconDriverObserver which used to forward to Favicon driver notification through didChangeTab. So to remove the connection between didChangeTab and favicon notification i changed TabModelFaviconDriverObserver to be WebStateListFaviconDriverObserver and it will have a bridge to be used to monitor the favicon driver observer. Also instead of going through TabModel, WebStateListFaviconObserver will be monitoring the webStateList given at its constructor and Observing each of its' webstates favicon drivers. TabStripController conform to the bridge protocol and creates a WebStateListFaviconObserver giving it the webStateList to monitor its drivers. Bug: 911350 Change-Id: I19a8523c368aa06dabc80005ffcf65d78c00e07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626544 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#663090}
-
Jan Wilken Dörrie authored
This change adds a PopupType parameter to both AutofillClient's ShowAutofillPopup() and AutofillPopupControllerImpl's Show(). This will be needed for the ManualFillingController on Android to determine whether to show the TouchToFill Sheet for Passwords or not. Bug: 957532 Change-Id: I31cd1ecee7d403adea8dfee894b0271b19c35213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619946Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Francois Doray authored
ThreadPoolImpl tests currently run for each combination of: - thread pool type - traits - execution mode In preparation for a CL that adds new traits, this CL extracts tests that don't query the traits and execution mode to a separate test class that only runs for each thread pool type. Change-Id: Ic8406101eeb10288dd5e797747ec2be3fc8f654a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626872Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#663088}
-
Kush Sinha authored
Error badges should not participate in the reading from screen readers like ChromeVox. This is similar to the other error icon: |IDR_WEBUI_IMAGES_ERROR|, which is always set as a background image and never with an |img| tag. Bug: 966770 Change-Id: I798edae34aca18c0f2e7be927bc452cf90c05b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628735 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Maks Orlovich authored
This is needed for a few operations that can bypass prefs, like users clearing all the cookies. Bug: 958923 Change-Id: Id5551698f5664f8f4356827ed0f4456c813c2e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625045 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c308a3de9628..21e35ed8258b Created with: gclient setdep -r src-internal@21e35ed8258b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: I42d229dec70e62433b1d04802115b43b50386150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628459Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663085}
-
Avery Musbach authored
Code from this CL is now unnecessarily complicated (and might have been so all along): https://chromium-review.googlesource.com/c/chromium/src/+/1560298 There is no need for OverviewSession::GetGridWithOverviewItem() when we have OverviewItem::overview_grid(). Then there is also no need for OverviewSession::AddDropTargetForDraggingFromOverview() or OverviewSession::RemoveDropTargetForDraggingFromOverview(), as the whole purpose of putting them in OverviewSession was so that they could call OverviewSession::GetGridWithOverviewItem(). In fact, currently, OverviewWindowDragController::CompleteNormalDrag() uses item_->overview_grid()->RemoveDropTarget() whereas OverviewWindowDragController::ResetGesture() uses overview_session_->RemoveDropTargetForDraggingFromOverview(item_), and there is no reason why they should use different code to remove the drop target. Test: manual Change-Id: Ic973e90d08c9b81b00566306e6b3e3e655939ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628233Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#663084}
-
Robbie Gibson authored
Currently, this doesn't do much because showcase has no way to fetch the image, but the URL is there just in case. Bug: 966429 Change-Id: I34f7bf7a329e60774c7ca314994e86123dae451d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627374 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Chris Harrelson authored
TBR=nasko@chromium.org Bug: 947715,966488 Change-Id: Ic2a11f998a315ee5dc111168db20423b5a6f17d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620365Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Roman Sorokin [CET] authored
Revert "Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string" This reverts commit 2669b5b5. Reason for revert: I believe this one is responsible for compile failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8912567103159431936/+/steps/compile/0/stdout Original change's description: > Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string > > This cl is part of the effort to use CoreAccountId instead of std::string > to denote account_id. > > Bug: 959157 > Change-Id: I6b95b6adf7d73228c399162daf2867c532acd7cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626599 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@google.com> > Cr-Commit-Position: refs/heads/master@{#663069} TBR=droger@chromium.org,sdefresne@chromium.org,triploblastic@google.com Change-Id: I716aa951acef794062444f73954083e5b0981c29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 959157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628724Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#663081}
-
David Benjamin authored
webrtc::acm1::AudioCodingModuleImpl::PlayoutData10Ms can no longer be found in code search, so remove the style suppression. Bug: 348511 Change-Id: Id723f1ca2bb0927be198f1b4166f8fd786fc2893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620590 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663080}
-
Scott Violet authored
And specifically set it when processing windows messages. As almost everything starts from a windows message setting the id when processing a windows message should help us better attribute which code is at fault. BUG=966526 TEST=covered by test Change-Id: I48851150fa55523cffb936d0f2f199ade04cac0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626640Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#663079}
-
Peter Kotwicz authored
This CL merges ProvidedByWebApkSplashDelegate and SameActivityWebappSplashDelegate. As a benefit of the merging, new-style WebAPKs get: - offline error dialog - splash screen hiding functionality BUG=817263 R=dominickn TBR=yfriedman (for renaming SameActivityWebappSplashDelegate->WebappSplashDelegate) Change-Id: I930817d457c51b45156cecf06ce23a94432fa613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608728 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#663078}
-
Tobias Sargeant authored
change to Accept-Encoding requested headers, and www.google.com returns a brotli-compressed response that is correctly rendered. Test: Local inspection shows enabling the feature causes the correct Bug: 961735 Change-Id: I1afe26e9c539e639b07ab70fdbccb36c908e7cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628614Reviewed-by:Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#663077}
-
Mark Mentovai authored
This reverts commit 6a008993. Reason for revert: https://crbug.com/966766, more information at https://crbug.com/955936 beginning at comment 13 Original change's description: > [Mac] Preserve symbolic link in the copy_bundle_data tool. > > The copy_bundle_data tool is implemented in terms of pax for directories > and ln hard links for files. The pax command does preserve symbolic > links within the tree that is being copied. But with the way that pax is > invoked by the tool, cd-ing into the source, if the source is itself > a symbolic link to a directory, the tree will be logically copied rather > than just as a symbolic link. > > A similar issue exists with the non-directory symbolic link source case, > where a hard link will be produced instead of a symbolic link. > > Fix both of these cases by specifically testing if the source is a > symbolic link and then re-creating it if so. > > Bug: 955936 > Change-Id: I69cf96878e59b0b7b121ae46cba5bc1e81f261ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626269 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662575} TBR=sdefresne@chromium.org,rsesek@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 955936 Change-Id: Ia1489278b62d0cdb33ed8980bbd6a6bcab0bb199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628045Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#663076}
-
Ehsan Karamad authored
This is a reland of 4ded38ed The original CL was reverted due to timeouts on ChromeOS debug for the enabled test. It turns out that the underlying issue is most probably due to a race condition which exists in loading and MHV creation process in the absence of NetworkService. Since this has nothing to do with the underlying fix, relanding the same CL but disabling the test on ChromeOS when the MVH flag is on but NetworkService is not. Also adding comment to link to the current outstanding bug for similar timeout failures in some MHV tests on debug ChromeOS bots. Original change's description: > [ MimeHandlerView ] Block PluginStatus != kAllowed/kPlayImportantContent > > Currently, a MimeHandlerView is created as long as there is a plugin > for it. This behavior undermines issues such as <webview> permissions > API. > > This CL will avoid creating MimeHandlerView if the plugin is not > allowed. This change will also make the test > WebViewPluginTest.TestLoadPluginInternalResource pass with the flag > MimeHandlerViewInCrossProcessFrame. > > Note that when the plugin is not allowed, no (frame-based) > MimeHandlerView will be created and the code will follow the ordinary > CreatePlugin code path. > > Bug: 963694 > Change-Id: I91b88956480139ffdb0df06077d099746b713751 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622890 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662641} TBR=tommycli@chromium.org, thestig@chromium.org, wjmaclean@chromium.org Bug: 963694, 949565 Change-Id: If3c2f33b4722f28e7ad35b91139cc73118e923dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626335Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#663075}
-
Friedrich Horschig authored
This CL moves the enum that is needed for every action out of the metrics helper and uses it to disambiguate footer commands more reliably than the currently used title string. It uses the enum wherever we know it's needed and extends it with the missing options. Bug: 902425, 905669, 962548 Change-Id: I6ae9ed561e3a85a483c7d7d3ffdd07a4cb125689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626421 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#663074}
-
Jonathan Backer authored
We previously created a SkSurface for the sole purpose of allocating a GrBackendTexture and keeping it alive. This was a minor misuse of the Skia API. This CL uses a proper API that Skia just added. It allows us to remove a workaround for Nexus 5X. Change-Id: Icbd6c7a86914eab080b7673a87201ca4e0c55345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627631 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#663073}
-
Peter E Conn authored
Bug: 966336 Change-Id: I586a9f43fe2ef3956ba43af2197d634c1de189d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626595 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#663072}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aabc54e8..5d3500a1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I929c7fdf099c7634f39699d08eddfc3c1389f562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626336Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663071}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie4a1dd9c47e3d4371a603eb6752de67b6851c024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628119Reviewed-by:
-
Tanmoy Mollik authored
Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: I6b95b6adf7d73228c399162daf2867c532acd7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626599Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
![Roman Sorokin [CET]'s avatar](https://secure.gravatar.com/avatar/7b28a287700b8b8659a03c33a38be1a8?s=80&d=identicon "Roman Sorokin [CET]")
