- 26 Sep, 2019 40 commits
-
-
Chong Gu authored
Adding an aemu_target.py that supports running headless AEMU with swiftshader. Adds AEMU checkout to the build (with aemu_checkout set to True). Add support for AEMU in layout tests. R=marshallk@google.com Bug: 1000906 Change-Id: Ie4a9e7957c5a33822dd44e8892c0820307ea5b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789849Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#700484}
-
Peter Boström authored
This lets us make sure that the View (but not necessarily subclasses) outlive their properties. Without this change accessing View in the property destructor would be a use after free. Bug: None Change-Id: I8e783fbf46ed046bd2ac7e77ed2373c1da5758e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828217Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#700483}
-
Jimmy Gong authored
- Refactor the tests to be able to verify visible and filtered printers separately. - CupsPrinterEntryList's tests are now easier to follow with their actual vs expected printer list comparisons. Bug: 965721 Test: browsertests Change-Id: Iffdda03fa5e2f5b6ecb6aa309bf91657db27a807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820028 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#700482}
-
David Benjamin authored
In non-NaCl builds, we've since replaced that file with a call to BoringSSL's SHA-1, which we ship regardless. Bug: 47218 Change-Id: Ie61f21378fe00566a218f42a8a3ecd7832eb46f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827385 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700481}
-
Chris Harrelson authored
This reverts commit 202162c2. Patchset 2 has the fix - removing the sorting_context_id field which is unused. This was a mistake in the original CL. TBR=vmpstr@chromium.org Change-Id: Ie13872cb53de33538800b3ff1e7d281625e4e6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827184Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700480}
-
Christopher Grant authored
DFMs that include both Java and native code will probably use JNI. This change introduces a reusable mechanism to load the native library and register its JNI methods. Originally landed in: 7ca339e3 Reverted in: 1cb1d038 Key points: - There are 3 build variants supported: 1. Production builds with lld-generated partitions. 2. Component build (with feature code in a component). 3. Fallback release build (feature code in the main library) - For consistency, explicit JNI registration is done in both ChromeModern and Monochrome. - The Test Dummy module is moved over to use this new system. VR will join the fun in a follow-on change. - Currently, modules must supply an explicit JNI registration method. Common code will locate this method and call it, at the appropriate time, on behalf of the module. TBR=agrieve@chromium.org Bug: 870055 Change-Id: I322c8e80d88e3ac0335f8c2785b90da04ff09d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827249 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#700479}
-
Pavel Yatsuk authored
This CL adds implementation for TemplateUrlServiceAndroid::SetPlayAPISearchEngine. The function: - Checks if Play API search engine already exists. - Adds new search engine marking it with created_from_play_api flag. - Sets the search engine as DSE if enterprise policy allows. The logic for merging new search engine with existing prepopulated or autogenerated is still not implemented. BUG=1002271 R=pkasting@chromium.org,wylieb@chromium.org Change-Id: I3065df7218f90fb74cabbd338b37b8286d2450ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826001Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#700478}
-
Luke Sorenson authored
In order to have a better understanding why the component sometimes fails to install on devices in production, we want to propagate error codes to clients of the setAnalyticsComponent API. Bug: 1003037 Change-Id: Ie57417a81d7556dd51f9b2f7e8db96e8fc695516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797467 Commit-Queue: Luke Sorenson <lasoren@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#700477}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4174f483ee5..e656e9883179 git log e4174f483ee5..e656e9883179 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 ehmaldonado@chromium.org gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3. Created with: gclient setdep -r src/third_party/depot_tools@e656e9883179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1008202 Change-Id: Ic1f06e76ff942a2fa1293a6999fe24dc8a0b2909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700476}
-
Lei Zhang authored
Change-Id: If523c4b07a1f19a47ccdd3b241b7ff2db6c8cfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828079Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700475}
-
jonross authored
CrossSiteSubframe/DragAndDropBrowserTest.DropValidUrlFromOutside/0 has begun flaking on Linux with SkiaRenderer becoming enabled by default. This test has previously flaked on Windows. I'm disabling it until the root cause of the flaking can be fixed TBR=lukasza@chromium.org TEST=CrossSiteSubframe/DragAndDropBrowserTest.DropValidUrlFromOutside/0 Bug: 1008567 Change-Id: I3d18c0b8a2f2fddfe6e383175f53638c78cf985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828119Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#700474}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be4787124940..3375a8848278 git log be4787124940..3375a8848278 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 mtklein@google.com roll GN 2019-09-26 mtklein@google.com Revert "hsw::S32_alpha_D32_filter_DX" 2019-09-26 kjlubick@google.com [canvaskit] remove debugging code 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 egdaniel@google.com Fix vulkan caps checks for external formats. 2019-09-26 robertphillips@google.com Add mipmap support to SkPixmap flavor of createBackendTexture 2019-09-26 csmartdalton@google.com Revert "Remove the resolve rect and resolve types from GrRenderTarget" 2019-09-26 kjlubick@google.com [canvaskit] Create SkFontMgr from passed in data Created with: gclient setdep -r src/third_party/skia@3375a8848278 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I691107a9b12666aa86e4c52728430af2ebcd7271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827828Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700473}
-
Zhenyao Mo authored
BUG=1006960 TEST=crash reports R=sunnyps@chromium.org Change-Id: Ia86f3505589786191eaaa74f5adb47d9245979e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828077Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700472}
-
Alex Newcomer authored
A few changes: - Hotseat background should always exist in tablet mode. - Update some paddings/sizes so it shows in the correct place. - Remove the transparent background (it was interfering with the scrollable shelf gradient). Bug: 973482 Change-Id: I0bc1e30ecdd4fac83cfeae5a8775b0abe03b1a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815615 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#700471}
-
Jared Saul authored
Fixes an issue where declining/ignoring the local card migration promo bubble would only log strikes the first time for a given tab, but not for subsequent times on that same tab. Change-Id: If75c52a4315369820339fc8909b0881ca92adbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827510Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#700470}
-
Yuly Novikov authored
conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html on Pixel 2 passthrough CB. TBR=kbr Bug: 1008535 Change-Id: Ic790be8a83b1f66fe20798cfdc3a7a755f22288f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827466Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700469}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/62960ae89911..15152b52a721 git log 62960ae89911..15152b52a721 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 bsheedy@chromium.org Fix Android non-browser crash symbolization Created with: gclient setdep -r src/third_party/catapult@15152b52a721 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:949321 Change-Id: I4ed2fe476ca3934567148d71ed2a6b5145150d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700468}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e4371bf3..4c650007 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie07b0ff7eb4dff5999948a57cc0828803657a4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700467}
-
James Cook authored
It's testing the os-settings-page element, so rename it to match. This is a prelude to trying to de-flake it, then adding more tests to it. TBR=hsuregan@chromium.org Bug: 967896 Change-Id: I240124bd18169bb7126241416ce7e1a5cce03361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828107Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#700466}
-
Peter Kasting authored
No functional change intended, ideally just more maintainable code. Bug: 1005568 Change-Id: I94bec353c48114e79546e38474d4f55edb04442f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812317 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700465}
-
chromium-autoroll authored
Roll airmont AFDO profile from 79-3900.0-1568629889-benchmark-78.0.3902.0-r1 to 79-3903.0-1569234053-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: If5ef30749a2c573b33ba6f6173064b46580ac287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700464}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 79-3865.63-1568626808-benchmark-78.0.3902.0-r1 to 79-3903.0-1569232734-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ie17ffbcda052c963b780e1916bf4907ea2fbc325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700463}
-
Jeroen Dhollander authored
This reverts commit de88f517. Reason for revert: Breaks internal builder Original change's description: > Introduce AssistantServiceManager::State::STARTING state. > > Until now the |AssistantServiceManager::State| enum did not distinguish > between the state in which libassistant was started (but not ready yet) > and in which it is ready. > That distinction is needed to be able to add tests using libassistant, > as they have to wait until it is ready. > > So now there are 4 states: > - STOPPED: It has not started/it has been stopped (this is the same > as the old STOPPED state). > - STARTING: |AssistantServiceManager::Start| has been called and the > libassistant |AssistantManager::Start| call has not finished yet (this > is the same as the old STARTED state). > - STARTED: the libassistant |AssistantManager::Start| call has > finished, but libassistant has not signalled it is ready yet (this > is the same as the old RUNNING state). > - RUNNING: libassistant signalled it is ready (this state is new). > > As this CL also introduces the first unittests for > |AssistantServiceManagerImpl|, it also contains a bunch of fake/dummy > classes used for the unittests. > > This CL increases test coverage in //chromeos/services/assistant from 28% > to 41%. > > Change-Id: If38a6b70e22e6392537b6658e5f39eebf6dd9099 > BUG: b/141264108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810019 > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700410} TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,jeroendh@google.com Change-Id: Ia0a876aa4ccd1043d54f10dc42a0930ade00fb6f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828221Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#700462}
-
Christopher Thompson authored
This will be used to control our UI treatments for sites using legacy TLS versions (TLS 1.0/1.1). Bug: 989607 Change-Id: I4bc9e21248a83bdd566bdaec31e6fa8a11b9bda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827775Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#700461}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 79-3903.0-1568628088-benchmark-78.0.3902.0-r1 to 79-3904.12-1569231291-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I9d6e24dd8f330faf135b5be2e659af289e3e67bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700460}
-
Gavin Mak authored
Bug: 1008539 Change-Id: I91f499029b9aebea6163cf62429d84d0ee550040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827549Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#700459}
-
Scott Violet authored
Ian was of the opinion the horizontal version should be the same as the vertical position. BUG=993813 Change-Id: I6238b5fdff67701335e778d2dca6fd5b40c0ea9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826871Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#700458}
-
Sanket Joshi authored
After this change, users of the color picker can submit their color selection via the enter key. They can also cancel their selection via the escape key. Additionally, to support tests for this scenario, a custom delay parameter is being added to waitUntilClosing. When a value is submitted in the color picker, a callback to set the input type color's value and close the popup is issued, with a 100ms delay. So, in order to validate behavior after the value change and popup closure, the callback delay needs to be at least 100ms. So the enter and escape keyboard input tests pass a 100ms custom delay to waitUntilClosing. The reason for using an optional custom delay parameter rather than just increasing the delay for all tests is to avoid breaking existing tests (specifically "datetimelocal-change-type-on-input-crash.html") that rely on a shorter delay. Bug: 1007426 Change-Id: I9596bd4cc5955f02124d6c820a7b60444a1e1fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822843Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#700457}
-
Willie Koomson authored
ConciergeHelperService starts Concierge, and provides methods for throttling VMs through Concierge. Test: Run unittests Bug: 997397 Change-Id: I76f6aba67d0f8f702789ff406a803c7c52db8bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809806Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#700456}
-
Dominic Mazzoni authored
Bug: 1006402 Change-Id: I2ad9f834dd69ce149528d749d7b9c4e7dfa9d988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826599 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#700455}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f57843cb20ee..0f4ac587a4ae git log f57843cb20ee..0f4ac587a4ae --date=short --no-merges --format='%ad %ae %s' 2019-09-26 iapres@microsoft.com New API to retrieve a character's loose bounds 2019-09-26 thestig@chromium.org Roll third_party/freetype/src/ 99f23d6ff..432efa25b (5 commits) 2019-09-26 thestig@chromium.org Move a function into the anonymous namespace in fpdf_transformpage.cpp. 2019-09-25 awscreen@chromium.org [lcms] Clusterfuzz - avoid integer overflow Created with: gclient setdep -r src/third_party/pdfium@0f4ac587a4ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:985604,chromium:997463 Change-Id: Ic35c3206caa8f7e27cd81ecdf05ef0f47bfac258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827494Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700454}
-
Avery Musbach authored
As a starting point for test coverage of multi-display overview and split view, the most important existing test suites involving split view mode shall be endowed with a parameter that determines whether to enable the feature flag, to test that old split view functionality still works. Bug: 970013 Change-Id: I971382e68cac7e423442db401e078b85c85f1953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825730 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#700453}
-
Miyoung Shin authored
This change converts MediaControlsMenuHost mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Iefe4ce64adfd4b67d6a12b18a400cf503d97369f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824917 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#700452}
-
James Cook authored
When the user selects a JPG file from disk to use as their profile image we send the image to the renderer as a base64 encoded PNG. The PNG encoding can be slow, so post a task to move encoding off the UI thread. Test: Open OS settings > Personalization > Change device account image, and select a large JPEG. Select file window closing animation plays smoothly. Bug: 812180 Change-Id: Ied7cebe1e85be580b5cd49e5ffb077815e73ebba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826002 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700451}
-
Andrew Xu authored
This CL adds the left gradient zone during gesture drag and scrolling animation. Bug: 1004134 Change-Id: I134b0ea33ae06cbfe0974113ed08203d2b8c63cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818118 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700450}
-
Connie Wan authored
The attached bug contains details on where the previous logic in GetTabGroupForTargetIndex was causing different behavior based on group size. This CL updates the logic to focus more on current position than previous group membership. As noted in the inline comments: (If the tab is between two tabs with the same group membership, match that group.) // If the tabs on the left and right have different group memberships, // including if one is ungrouped or nonexistent, change the group of the // dragged tab based on whether it is "leaning" toward the left or the // right of the gap. If the tab is centered in the gap, make the tab // ungrouped. ("Leaning" is defined by being 1/4 the tab width toward either side of the gap.) // Extra polish: Prefer staying in an existing group, if any. This prevents // tabs at the edge of the group from flickering between grouped and // ungrouped. It also gives groups a slightly "sticky" feel while dragging. (There is also some special handling for the far left and far right of the tab strip.) A screencast of this interaction is attached to the bug. Bug: 1004946 Change-Id: Id3cf631354a47ffa5c3f1aeacdc82bd2af13ea24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823729 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#700449}
-
Amr Aboelkher authored
A device policy which controls the cursor highlight accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_cursor_highlight_enabled policy to True, open System Tray => "Accessibility", check that "Highlight mouse cursor" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Highlight mouse cursor" is not displayed in the login screen. Bug: 552439 Change-Id: I49b3547c78c657b01aa80c025ded6d461e9bc200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816543 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700448}
-
dpapad authored
These are the same checks with chrome/test/data/webui/. Also fixing existing violations. Bug: 720034,1005029 Change-Id: Ic3db4eab01ce109da7f24c9b6f2480d522b3dfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826010 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#700447}
-
Emre Kanlikilicer authored
LogonUI uses fixed buffer size to pass the json object to rundll32. To fix the issue, first write/read the buffer size to/from the pipe. Bug: 902911 https://bugs.chromium.org/p/chromium/issues/detail?id=902911 Change-Id: Ibfc23a098c53c4b6c58a979ee38fb46dc38d55bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825909 Commit-Queue: Emre Kanlikilicer <emreknlk@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#700446}
-
Dana Fried authored
Exactly what it says on the tin. Compressed JPEG data is now available. Expected to be used for Mohnstrudel tabstrip. Change-Id: I523ad8a65a38b7a6c66bc462c8f78ca7d5012318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817583Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#700445}
-