- 25 Jan, 2011 21 commits
-
-
suzhe@google.com authored
This CL assumes keyword query is always synchronous. BUG=70527 TEST=See bug report. Review URL: http://codereview.chromium.org/6281011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72457 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
[linux] When the user has the notification options menu, delay system-initiated closing of the notification. BUG=51177 TEST=open the notification options menu on a notification which will be auto-closed by the page. Review URL: http://codereview.chromium.org/6273010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72456 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
BUG=chromium-os:10180, chromium:70450, chromium:70451 TEST=Verified strings and link were changed. Review URL: http://codereview.chromium.org/6314014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72455 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
Cached forms might not match submitted forms, but the logging code had been assuming that they always do. BUG=70374 TEST=unit_tests --gtest_filter=AutoFillMetricsTest.SaneMetricsWithCacheMismatch Review URL: http://codereview.chromium.org/6259017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72453 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
Disable IndexedDBBrowserTest.TransactionTest and IndexedDBBrowserTest.DoesntHangTest on all platforms because they're now causing crash and/or hang on Mac. TBR=jorlow, japhet, andreip BUG=70665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72452 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none TEST=green tree TBR=tfarina Review URL: http://codereview.chromium.org/6264014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72449 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@google.com authored
(A second try after being reverted.) Review URL: http://codereview.chromium.org/6279009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72445 0039d316-1c4b-4281-b951-d872f2087c98
-
ddorwin@chromium.org authored
time_slice_hrs is being used uninitialized at line 459, and this was causing a Run-Time Check failure and crash in Debug versions on Windows. I don't know whether 0 is the the correct value in this case, but this fixes the crash. mirandac@ will need to review the behavior. BUG=None TEST=Run debug version of Chrome on Windows and wait a few seconds. Review URL: http://codereview.chromium.org/6385004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72444 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@google.com authored
UI Layout tests are not flaky, so delete the FLAKY label from linux and windows. BUG=56364 TEST=test no longer marked flaky TBR=scherkus Review URL: http://codereview.chromium.org/6324010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72442 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
Page title can leak privacy information hence we don't really want it. BUG=66716 TEST=Sent a report to confirm page title is no longer being sent. Review URL: http://codereview.chromium.org/6366007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72441 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
Pritchard for suggesting these mappings. Review URL: http://codereview.chromium.org/6372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72440 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
Windows-native implementation of the TTS API. BUG=none TEST=manual testing Review URL: http://codereview.chromium.org/6249014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72439 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
BUG=70631 TEST=none TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/6317013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72438 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
which would cause crashes if multiple instances were loaded. Fixes bug http://code.google.com/p/chromium/issues/detail?id=70602 BUG=70602 TEST=As described in the bug report. Review URL: http://codereview.chromium.org/6373010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72434 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
BUG=65547, chromium-os:9559 TEST=none Review URL: http://codereview.chromium.org/6269016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72433 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
It seems this file was left when all the other animation files were moved to ui/base/animation/. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6376010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72432 0039d316-1c4b-4281-b951-d872f2087c98
-
dmichael@google.com authored
BUG=None TEST=NaCl SDK pi_generator example encounters this Review URL: http://codereview.chromium.org/6384009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72430 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Dropped the DCHECk since it seems some Windows version don't initialize the unused variable. BUG=27400 TEST=none Review URL: http://codereview.chromium.org/6242011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72429 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
The other layout files under views directory will be moved later. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6360014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72428 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
because they seem to be causing the entire browser test to hang or crash. BUG=70665 Review URL: http://codereview.chromium.org/6339010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72427 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
45s until first TCP Keep-Alive and 45s in between keep alives. BUG=27400 TEST=Run Wireshark, make sure TCP Keep-Alive packets are sent. Review URL: http://codereview.chromium.org/6300013 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6371010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72426 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Jan, 2011 19 commits
-
-
thakis@chromium.org authored
This is to pick clang warning / miscompile fix in r760. r756, 757, 758 were edits to the breakpad wiki, not code changes. r759 added a new file to libreakpad.a on linux BUG=none TEST=none Review URL: http://codereview.chromium.org/6357016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72424 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@chromium.org authored
flag in https://bugs.webkit.org/show_bug.cgi?id=53041 . ENABLE_3D_CANVAS will be removed once we roll WebKit past the landing of the upstream patch. BUG=none TEST=none Review URL: http://codereview.chromium.org/6256013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72423 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
BUG=None TEST=Test Cloud Print Proxy. Review URL: http://codereview.chromium.org/6356007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72422 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
45s until first TCP Keep-Alive and 45s in between keep alives. BUG=27400 TEST=Run Wireshark, make sure TCP Keep-Alive packets are sent. Review URL: http://codereview.chromium.org/6300013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72421 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Make new chrome UI security model the default. allows us to update URL in chrome://settings when the user navigates within it. BUG=57485 TEST=manual Review URL: http://codereview.chromium.org/6277018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72420 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Moved bodies of test functions into .cc files. Remove sync_service() accessors from various model associators. Renamed GetUserShareHandle to GetUserShare() and removed typedefs for its return types. Added plenty of TODOs for future improvements. BUG=None TEST=unit_tests Review URL: http://codereview.chromium.org/6375007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72419 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Avoids throwing an exception when git isn't installed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72418 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@google.com authored
BUG=70344 TEST=See bug report. Review URL: http://codereview.chromium.org/6380012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72417 0039d316-1c4b-4281-b951-d872f2087c98
-
rjkroege@google.com authored
This patch adds a basic TouchTabStrip for touch_ui builds. It is intended to be a placeholder for further work towards a more refined TouchTabStrip. It is modeled after the existing TabStrip and tries to make use of BaseTabStrip and BaseTab where appropriate. BUG=none TEST=none Review URL: http://codereview.chromium.org/5572007 Patch from Chad Faragher <wyck@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72416 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=70576 TEST=none Review URL: http://codereview.chromium.org/6247020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72414 0039d316-1c4b-4281-b951-d872f2087c98
-
skerner@chromium.org authored
BUG=70636 TEST=Manual Review URL: http://codereview.chromium.org/6299016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72413 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Only eat the event in subPageClosingClickHandler_ if it happens on the narrow strip part. BUG=chromium-os:11202 TEST=Verify the radio/checkbox on overlay page works again per chromium-os:11202. Review URL: http://codereview.chromium.org/6371009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72412 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=70576 TEST=none Review URL: http://codereview.chromium.org/6282012 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/6340015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72411 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=70576 TEST=none Review URL: http://codereview.chromium.org/6282012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72408 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
allows us to update URL in chrome://settings when the user navigates within it. BUG=57485 TEST=manual Review URL: http://codereview.chromium.org/6266017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72405 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@google.com authored
This patch moves the experiments settings from the user profile to the browser's local state, since these settings correspond to command line switches. It restores 6267009 http://codereview.chromium.org/6267009/ which got reverted because it broke ChromeOS tests. The patch also removes some migration code for ChromeOS experiments. Users' settings should be migrated by now. This is a release blocker for NaCl, so we are pushing this through. TEST=manual BUG= http://code.google.com/p/nativeclient/issues/detail?id=1322 Review URL: http://codereview.chromium.org/6389002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72404 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=none TEST=visual Review URL: http://codereview.chromium.org/6354011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72403 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Currently, about: links all go to about:blank. This fixes that for left clicks and middle clicks, although context menu navigations (e.g. open in new tab) still won't work. This also "fixes" file: links in the same way. Currently, file links already work as is, but after we make --new-chrome-ui-security-model the default, they will cease to work without this fix. Context menu navigations will, however, continue to work. The fix is currently applied to the history page and one link in settings. BUG=69140 TEST=manual Review URL: http://codereview.chromium.org/6269015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72401 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
BUG=70665 Review URL: http://codereview.chromium.org/6258019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72399 0039d316-1c4b-4281-b951-d872f2087c98
-