GitLab

Revert of cheets: implement cros side of WallpaperManagerService. (patchset #16 id:300001 of https://codereview.chromium.org/2264743002/ )

Reason for revert:
Broke the build. Not sure how this made it past the CQ:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/45818

Original issue's description:
> cheets: implement cros side of WallpaperManagerService.
>
> Rename ArcWallpaperHandler to ArcWallpaperService and implement it as an ArcService, which handles WallpaperManager API from Android.
>
> Test=Manually open PickMyWallpaper app and set wallpaper
> Test=run cts android.content.cts.ContextWrapperTest
>
> Bug=642465
>
> Committed: https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd
> Cr-Commit-Position: refs/heads/master@{#417428}

TBR=xiaohuic@chromium.org,xiyuan@chromium.org,nya@chromium.org,lhchavez@chromium.org,hidehiko@chromium.org,dcheng@chromium.org,yusukes@chromium.org,muyuanli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug=642465

Review-Url: https://codereview.chromium.org/2320323002
Cr-Commit-Position: refs/heads/master@{#417431}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/7c769c9d30f4b0983c9dbbf4e244bfb14b33d032 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/0c2dfcb7cec689007c9963312522d778ad0609d6 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/227f56ba6353986a7fe6d56fb283ad73c84e94d9 Track step nesting in StreamEngine (Reland). (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2322963003
Cr-Commit-Position: refs/heads/master@{#417430}

TBR=kkhorimoto@chromium.org
BUG=635399

Review-Url: https://codereview.chromium.org/2326823002
Cr-Commit-Position: refs/heads/master@{#417429}

Rename ArcWallpaperHandler to ArcWallpaperService and implement it as an ArcService, which handles WallpaperManager API from Android.

Test=Manually open PickMyWallpaper app and set wallpaper
Test=run cts android.content.cts.ContextWrapperTest

Bug=642465

Review-Url: https://codereview.chromium.org/2264743002
Cr-Commit-Position: refs/heads/master@{#417428}

https://codereview.chromium.org/2154593003 added
availableLogicalHeightForPercentageComputation, shared with the regular
percentage computation code, so this is definitely correct.

R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2323953002
Cr-Commit-Position: refs/heads/master@{#417427}

BUG=639691
TEST=tests in upstream distribution

Review-Url: https://codereview.chromium.org/2328693002
Cr-Commit-Position: refs/heads/master@{#417426}

A child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together.

http://imgur.com/a/5PyYl

BUG=644836

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2323813002
Cr-Commit-Position: refs/heads/master@{#417425}

This render path isn't used for WebVR just yet because VrShell has not been
added to the main browser activity.

BUG=389343

Review-Url: https://codereview.chromium.org/2308683004
Cr-Commit-Position: refs/heads/master@{#417424}

https://pdfium.googlesource.com/pdfium.git/+log/c29fc707b24b..0ca160fbf31a

$ git log c29fc707b..0ca160fbf --date=short --no-merges --format='%ad %ae %s'
2016-09-08 npm Delete unused methods in CPDF_Document
2016-09-08 dsinclair Fix CPDFSDK_PageView cleanup.
2016-09-08 jaepark Check whether the annotation content is empty using CFX_WideString.

BUG=645122

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2319773004
Cr-Commit-Position: refs/heads/master@{#417423}

On Mac, desktop capture picker window's title is using sentence case, but by convention, it should be in title case.

This CL Fixes the bug.

BUG=644905

Review-Url: https://codereview.chromium.org/2319303002
Cr-Commit-Position: refs/heads/master@{#417422}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2c67e5988500..fe40502b6dd4

$ git log 2c67e5988..fe40502b6 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 ccraik Support ANDROID_SERIAL env var as default serial
2016-09-08 alexandermont Add metric for power consumption between navigation start and TTI.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321203002
Cr-Commit-Position: refs/heads/master@{#417421}

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG=629605
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org

Review-Url: https://codereview.chromium.org/2318223003
Cr-Commit-Position: refs/heads/master@{#417420}

BUG=644759

Review-Url: https://codereview.chromium.org/2313393003
Cr-Commit-Position: refs/heads/master@{#417419}

BUG=581462

Review-Url: https://codereview.chromium.org/2325473002
Cr-Commit-Position: refs/heads/master@{#417418}

Because of timing delays, and because cancelling a Runnable doesn't
guarantee that it won't run, the LoadingView can get into a state
where it posts a task to animate itself showing up on screen but it
doesn't re-check if it still needs to be visible.

BUG=641262

Review-Url: https://codereview.chromium.org/2319213004
Cr-Commit-Position: refs/heads/master@{#417417}

BUG=589168

Review-Url: https://codereview.chromium.org/2318813002
Cr-Commit-Position: refs/heads/master@{#417416}

Reason for revert:
This is probably not the root cause of crbug.com/643320

Original issue's description:
> Revert of Roll typ to v0.9.7. (patchset #1 id:1 of https://codereview.chromium.org/2289303002/ )
>
> Reason for revert:
> Let's see if reverting this helps w/ crbug.com/643320.
>
> Original issue's description:
> > Roll typ to v0.9.7.
> >
> > This picks up a change that will help address flaky telemetry failures.
> >
> > This includes the following changes (v0.9.5..v0.9.7):
> >
> >   79fe79db Change typ's interpretation of a test that first fails
> >            and is then skipped.
> >   101acd31 Bump version to 0.9.6, clean up Python 3 failures
> >   2f8787b8 rework run script to remove python3 log
> >   d5023636 rework sharding tests
> >
> > TBR=rnephew@chromium.org, nednguyen@google.com
> > BUG=618330
> >
> > Committed: https://crrev.com/71c9ade4e91e16846779311f1ae800ed550c8b69
> > Cr-Commit-Position: refs/heads/master@{#415392}
>
> TBR=nednguyen@google.com,rnephew@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=618330, 643320
>
> Committed: https://crrev.com/1023620c13385de9fcea55ec35f66dc22b454ff8
> Cr-Commit-Position: refs/heads/master@{#416573}

TBR=rnephew@chromium.org,nednguyen@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=618330, 643320

Review-Url: https://codereview.chromium.org/2328753002
Cr-Commit-Position: refs/heads/master@{#417415}

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855,629071

Review-Url: https://codereview.chromium.org/2320063003
Cr-Commit-Position: refs/heads/master@{#417414}

Revert of Move collectGarbage* methods to ThreadState (patchset #3 id:40001 of https://codereview.chromium.org/2307003002/ )

Reason for revert:
Causing weird MSAN and other issues:
BUG=645227,645253

Reverting.

Original issue's description:
> Move collectGarbage* methods to ThreadState
>
> Move collectGarbage* methods to ThreadState to indicate that these run GC for the current thread heap.
>
> BUG=
>
> Committed: https://crrev.com/89d83a49a6c126d91e25e2d3520cb398e8e1f7d5
> Cr-Commit-Position: refs/heads/master@{#417269}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,keishi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2321223003
Cr-Commit-Position: refs/heads/master@{#417413}

BUG=571155

Review-Url: https://codereview.chromium.org/2324483002
Cr-Commit-Position: refs/heads/master@{#417412}

When Chrome is started, enable foreground scanning for Physical Web
URLs. The scanner will remain enabled until Chrome is closed or the
Physical Web preference is disabled, but scanning will only occur when
the Chrome app is in the foreground.

BUG=630769

Review-Url: https://codereview.chromium.org/2317183002
Cr-Commit-Position: refs/heads/master@{#417411}

In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.  This change
actually performs the subscription.

BUG=623638,645182

Review-Url: https://codereview.chromium.org/2316413002
Cr-Commit-Position: refs/heads/master@{#417410}

BUG=

Review-Url: https://codereview.chromium.org/2298363003
Cr-Commit-Position: refs/heads/master@{#417409}

BUG=619055

Review-Url: https://codereview.chromium.org/2326743002
Cr-Commit-Position: refs/heads/master@{#417408}

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.

TBR=tsepez@chromium.org
BUG=563858

Review-Url: https://codereview.chromium.org/2318383002
Cr-Commit-Position: refs/heads/master@{#417407}

BUG=626101

Review-Url: https://codereview.chromium.org/2322073002
Cr-Commit-Position: refs/heads/master@{#417406}

Make dbus::ObjectManager automatically fetch managed objects
after the remote service becomes available. Also remove
Bus::GetManagedObjects(), which produces a large amount of
log spam due to some services not yet being ready. (It was
called by chromeos::DBusThreadManager and
bluez::BluezDBusManager at startup.)

BUG=636554

Review-Url: https://codereview.chromium.org/2239123002
Cr-Commit-Position: refs/heads/master@{#417405}

build:
  https://crrev.com/8eaa27680015cf0fdd5349a568229350f83a0c9f Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/1332f33d42e1a08f4acfb69f4707001ffeaf8ea9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/990ab1b42c1f347686a509aade4303289f779902 Remove force parameter from bot_update.ensure_checkout. (iannucci@chromium.org)
  https://crrev.com/16e7f097a7ab958c843fcc989856a47b842eb3d9 Remove bogus master/builder/slave parameters from bot_update. (iannucci@chromium.org)
  https://crrev.com/92ded3f29204ce9c900f9227be4f713dc18e251c Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/0abcd2640ae3c36165fbbc7531571a0a22294243 Fix typobug in bot_update.py. (iannucci@chromium.org)
recipe_engine:
  https://crrev.com/4b3ff6014bcb018aff9ae2755faf47cc304f47af Track step nesting in StreamEngine. (dnj@chromium.org)
  https://crrev.com/339eace18cba35868b8bbb039100448fbfc58d15 Revert of Track step nesting in StreamEngine. (patchset #5 id:80001 of https://codereview.chromium.org/2245113002/ ) (dnj@chromium.org)

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2327603002
Cr-Commit-Position: refs/heads/master@{#417404}

Pass required flags "-rpath @executable/Frameworks" when linking
executable to point to the location where the custom frameworks
are located in iOS builds.

Pass flags "-objc_abi_version 2" to linker flag for execuable and
dynamic libraries as is done by Xcode and remove one intermediate
config object (unnecessary).

BUG=None

Review-Url: https://codereview.chromium.org/2326543003
Cr-Commit-Position: refs/heads/master@{#417403}

BUG=626786

Review-Url: https://codereview.chromium.org/2316183003
Cr-Commit-Position: refs/heads/master@{#417402}

https://pdfium.googlesource.com/pdfium.git/+log/a31da74cffa8..c29fc707b24b

$ git log a31da74cf..c29fc707b --date=short --no-merges --format='%ad %ae %s'
2016-09-08 weili Fix memory management errors for font loading and copying

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2324933002
Cr-Commit-Position: refs/heads/master@{#417401}

SVGImageForContainer is confusing and needs better documentation. This
patch adds a class-level comment in SVGImageForContainer.h that
describes the dimension and fragment url quirks that require this class.

BUG=644913
NOTRY=true

Review-Url: https://codereview.chromium.org/2322803002
Cr-Commit-Position: refs/heads/master@{#417400}

The previous solution at https://codereview.chromium.org/2316113003/ does not check
all the frames for nullptr. This patch solves the problem in a more clean and
thorough way.

BUG=361036

Review-Url: https://codereview.chromium.org/2322013002
Cr-Commit-Position: refs/heads/master@{#417399}

There are two types of EventListeners: those with web_view_instance_id and those
without. EventListeners with a web_view_instance_id need to always consider
embedder_process_id for equality comparisons. EventListeners without a
web_view_instance_id should sometimes ignore embedder_process_id (when being
removed) for equality comparisons.

The previous code had two major issues:
  1) EventListeners were stored in a std::set. std:set requires a stable sort
  operator. There is no way to create a stable sort operator that sometimes
  ignores embedder_process_id.

  Aside: std::set is almost never the right container to use from a performance
  perspective. In this case, the code frequently needs to iterate through the
  entire container away, so I've changed the container to be a std::vector (we
  expect the total number of elements to be small). If we find performance
  issues, we should switch to std::unordered_set.

  2) EventListeners need to be messaged asynchronously, but it's possible that
  the EventListener is no longer registered by the time the callback comes
  around. The previous code would make a copy of the EventListener, and then try
  to "find" the original copy in the callback. Once again, this requires clear
  semantics for equality.

The new code makes several changes:
  1) Create the class EventListener::ID. As its name implies, this uniquely
  identifies an EventListener.

  2) Disallow copy and assignment of EventListeners. The only use case is async
  identity checking, which should use EventListener::ID instead.

  3) This cleanup means EventListener::blocked_requests no longer has to be
  mutable. (A clear sign that something was wrong with the previous scheme).

The most important result is that it is no longer possible to have identity
confusion between EventListeners, as all comparisons use EventListener::ID. This
was the root cause of the leak from Issue 643025.

BUG=643025, 641958

Review-Url: https://codereview.chromium.org/2303113002
Cr-Commit-Position: refs/heads/master@{#417398}

The origins of this workaround go waaaaay in the past and seem to
contradict themselves (only OSX, vs. not OSX)

BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2326713002
Cr-Commit-Position: refs/heads/master@{#417397}

This overload is deprecated: prefer the std::unique_ptr<Value> version,
which helps the compiler enforce that ownership transfer occurs.

BUG=581865
R=danakj@chromium.org
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2285933003
Cr-Commit-Position: refs/heads/master@{#417396}

This patch re-enables js/mozilla/strict/13.1.html and fixes lexical
redeclaration of arguments.

BUG=v8:4577

Review-Url: https://codereview.chromium.org/2318933007
Cr-Commit-Position: refs/heads/master@{#417395}

This patch sets the device scale factor on cc's root transform node,
fixing several layout tests. This approach is different from how
cc builds property trees (see post_local_scale_factor in
property_tree_builder's AddTransformNodeIfNeeded) where a post_local
transform is used, but aligns closer to blink's approach of using a
single transform per transform node.

This approach is temporary and will need to be refactored when we
begin supporting viewport transforms such as pinch-zoom.

BUG=642240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2318933006
Cr-Commit-Position: refs/heads/master@{#417394}

This reverts commit 9cdba144.
https://codereview.chromium.org/2308153002/

BUG=645177,645181
TBR=qyearsley

Previous commit message:
Import wpt@65954a35b4e0a5cee1f4839271ba0e44f187c0a6

Using update-w3c-deps in Chromium c7eb73ac.

Review URL: https://codereview.chromium.org/2323113002 .

Committed: https://crrev.com/9cdba1441437ab946977a224cc45971cfadd8abb
Cr-Original-Commit-Position: refs/heads/master@{#417302}
Cr-Commit-Position: refs/heads/master@{#417393}

This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but
also includes the 10.11 SDK.

BUG=474373, 626093

Review-Url: https://codereview.chromium.org/2323523003
Cr-Commit-Position: refs/heads/master@{#417392}