GitLab

The non-testing code in src/mojo/public should be buildable without
depending on anything outside of that directory. It's fine for test
code to depend on base/ and gtest/, though. Due to the way GYP works,
having targets for both production and test code in the same .gypi
file winds up trying to resolve the dependencies for both kinds of
targets, breaking the ability to build the public mojo code
hermetically.

Splitting the targets out will enable consumers of the mojo code to
build the public code standalone using GYP.

BUG=chromium:388412
TEST=build and run all mojo unittests

Review URL: https://codereview.chromium.org/385603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392745
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/385983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282698 0039d316-1c4b-4281-b951-d872f2087c98

There were two issues with clang:

- Clang emits .data.rel.ro.local for local struct values with
  an initializer, which lets the linker to emit a few
  relocation info.
- In debug build, clang uses memcpy to copy a structure with
  five members. Neither -fno-builtin nor -ffreestanding did
  not prevent this issue.
- In release build, clang translates for-loop based zero copy
  to memset.

This patch initializes all structures without initializers
or copy. This patch works with GYP_DEFINES=clang=0.

To make sure we will not add memcpy or something in future,
we will build libc_free.nexe with -Wl,--no-undefined.

This also reverts

https://codereview.chromium.org/386543002

to enable the disabled tests.

BUG=392768
TEST=./out/Debug/browser_tests --gtest_filter='*NonSfi*Messaging*'

Review URL: https://codereview.chromium.org/381883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282697 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282696 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177948:177973&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/387783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282695 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nednguyen@chromium.org,nduca@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/387093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282693 0039d316-1c4b-4281-b951-d872f2087c98

Change PPB_ImageData_Proxy and PPB_Instance_Proxy to always initialize
'out' params, to avoid sending uninitialized memory from renderer to
plugin.

BUG=391023

Review URL: https://codereview.chromium.org/383143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282692 0039d316-1c4b-4281-b951-d872f2087c98

It hangs on reliably audio_playback.html?id=mixed_audio on a Nexus 7 v2.

BUG=389362
NOTRY=True
TBR=shadi@chromium.org

Review URL: https://codereview.chromium.org/388883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282691 0039d316-1c4b-4281-b951-d872f2087c98

Blink closes it when a page is disposed. However, Blink can do nothing
when the renderer process is terminated. Chromium needs to close it in
such case.

BUG=355564

Review URL: https://codereview.chromium.org/385043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282690 0039d316-1c4b-4281-b951-d872f2087c98

SetViewportSize previously relied on UpdateInnerViewportContainerSize to
resize the inner viewport container layer; however, as of r253909, this
method is a no-op if the container layer has masks_to_bounds set (i.e.
non-Android platforms).

This fix explicitly resizes the inner viewport container layer to be the
same size as the newly resized device viewport before calling
UpdateInnerViewportContainerSize. This fixes the situation in the bug
where the viewport size is changed but nothing in the layer tree changes
so no new frame is committed.

BUG=387678

Review URL: https://codereview.chromium.org/381703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282687 0039d316-1c4b-4281-b951-d872f2087c98

This is a preparation of crbug.com/387227.

BUG=387227
R=oshima@chromium.org
TEST=manually check for no regression

Review URL: https://codereview.chromium.org/388703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282686 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that the toolchain definitions had an is_clang block in them, but this is only evaluated in the context of the default toolchain (so false for and Android build). But then when we were re-evaluating the build config for the host compile, it was forcing clang to true which was causing the clang flags to be set.

This changes the way we default the is_clang value. Forcing it to true prevents it from being overridden manually. In some cases, like mac, this is pointless. In other cases like Linux, we may want to turn it on and off. Changing this definition allows us to toggle it on and off for different toolchains as we desire.

Ideally I think the way of defining toolchains would be different to make this a bit more flexible, I'll think about this. But this will work for now.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/385823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/388683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282684 0039d316-1c4b-4281-b951-d872f2087c98

1. Defers command buffer destruction until after the native viewport client has had a chance to cleanup.
2. Destroy the compositor before quitting the view manager message loop.
3. Make various NodeObservers properly unhook themselves as node/view observers during destruction and view swapping.
4. Adds a "ViewManagerDisconnected" method to ViewManagerDelegate to allow the application to exit when the connection to the view manager is closed. This is necessary in addition to root monitoring because for some connections (e.g. the root node->window manager) the root node is not destroyed. I'm not entirely happy with imposing this burden on application developers but I will try and tidy this up later.
5. Instantiate nested AtExitManagers only in a static build. In the component build we can use the shell's.
6. Adds a callback to notify the ViewManagerInitServiceImpl when the NativeViewport is destroyed. The VMISI uses this callback to close its connection to the view manager, which triggers the view manager to shut down.

Since this still crashes, I can't test this yet.

R=sky@chromium.org
http://crbug.com/325901

Review URL: https://codereview.chromium.org/372273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282683 0039d316-1c4b-4281-b951-d872f2087c98

Fix the black patch which would appear at the top of app windows in Chrome desktop windows with HiDPI

The bug occurs because the non client insets which account for the window frame are retrieved via the
GetSystemMetrics API which returns values in pixels.

Changes as below:-
1. Renamed the GlassAppWindowFrameViewWin::GetGlassInsets function to GetGlassInsetsInDIP.
2. Replaced calls to the GetSystemMetrics API in the GetGlassInsetsInDIP function with the dpi helper
   GetSystemMetricsInDIP.
3. Added code to convert the insets to pixels in the AppWindowDesktopWindowTreeHostWin::UpdateDWMFrame
   function.

BUG=392603
TBR=benwells

Review URL: https://codereview.chromium.org/382013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282682 0039d316-1c4b-4281-b951-d872f2087c98

The switch will force use auxiliary bitmap path for all
rendering. This path is known to be slow.

This switch is temporary until Android L is released to AOSP.

BUG=

Review URL: https://codereview.chromium.org/388633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282681 0039d316-1c4b-4281-b951-d872f2087c98

This can happen when an iframe is opened, then popualted via a document.write()
from its parent. This will cause the url to change to the parent's url, but the
browser process will not be notified of this url change. If the iframe then
attempts a fragment navigation, it looks like a cross-origin navigation from
about:blank.

BUG=390798
TEST=Added case to NavigationControllerTest.IsInPageNavigation

Review URL: https://codereview.chromium.org/372403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282679 0039d316-1c4b-4281-b951-d872f2087c98

I meant to revert r281866, not this ...

> Revert 281692 "Mac: Enable delegated renderer by default"
> 
> This is causing tabs to get stuck white. Removing before today's
> Canary gets cut. The fix for the stuck white issue is being worked
> on at
> https://codereview.chromium.org/388793003/
> 
> > Mac: Enable delegated renderer by default
> > 
> > Delegated renderer disabled for layout tests (as on other platforms).
> > 
> > BUG=314190
> > TBR=piman
> > 
> > Review URL: https://codereview.chromium.org/374643002
> 
> TBR=ccameron@chromium.org
> 
> Review URL: https://codereview.chromium.org/386943008

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/388973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282678 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/389433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/387003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282676 0039d316-1c4b-4281-b951-d872f2087c98

This is causing tabs to get stuck white. Removing before today's
Canary gets cut. The fix for the stuck white issue is being worked
on at
https://codereview.chromium.org/388793003/

> Mac ÜC: Make resize smooth
> 
> Add helpers to RenderWidgetHelper to associate a NSView with
> a given RenderWidgetHelper (process and widget routing id), so
> that browser compositor swaps can be received while pausing
> waiting for correctly sized frames.
> 
> BUG=388005
> TBR=cevans
> 
> Review URL: https://codereview.chromium.org/370513002

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/387863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282675 0039d316-1c4b-4281-b951-d872f2087c98

GL_TEXTURE_2D is used by x86 non-OSX platforms and by software fallback.
GL_TEXTURE_RECTANGLE_ARB will be used on OSX hardware.
GL_TEXTURE_EXTERNAL_OES is used on ARM ChromeOS.

BUG=281689

Review URL: https://codereview.chromium.org/354763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393231
R=frankf@chromium.org
TEST=Dr.Memory

Review URL: https://codereview.chromium.org/388863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282673 0039d316-1c4b-4281-b951-d872f2087c98

This is causing tabs to get stuck white. Removing before today's
Canary gets cut. The fix for the stuck white issue is being worked
on at
https://codereview.chromium.org/388793003/

> Mac: Enable delegated renderer by default
> 
> Delegated renderer disabled for layout tests (as on other platforms).
> 
> BUG=314190
> TBR=piman
> 
> Review URL: https://codereview.chromium.org/374643002

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/386943008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282672 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/366933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/382193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282670 0039d316-1c4b-4281-b951-d872f2087c98

The two linked bugs both describe situations where the user types
a URL but that URL does not appear first because the top-scoring
provider that returned the URL set it incorrectly as not allowed to
be the default match.

This changes fixes those issues by making providers (namely
HistoryQuick, Search, and Shortcuts) mark a match as
allowed_to_be_default_match if it is UWYT match for this input, or (even
if not identical) it would be dedupped against the UWYT match.
The changes to HistoryQuick and Search fix the attached
bugs.  Shortcuts does the identical part of the test, not the de-dupping part
of the test.  The Shortcuts change to handle dedupping is not to fix a
known bug; rather it's simply to make Shortcuts behave as it should
and in parallel with the other providers.

I don't think changes in other providers beyond these three are
necessary.

This change necessitated some changes to AutocompleteMatch to make a
statically-available version of ComputeStrippedDestinationURL() so we
can strip URLs (such as the UWYT URL) that isn't going to be a
AutocompleteMatch in the relevant provider.

Also removes the IsInlineable() function in BaseSearchProvider::Result,
which is only used in one place and not actually necessary in that place.
(It's computing the same thing that code there is already computing.)

BUG=383065,388397

Review URL: https://codereview.chromium.org/353223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282669 0039d316-1c4b-4281-b951-d872f2087c98

This updates Chromium to use the one-at-a-time SkPicture
clone interface since Skia is moving towards removing 
SkPicture's default and copy constructors.

Review URL: https://codereview.chromium.org/380323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282668 0039d316-1c4b-4281-b951-d872f2087c98

kContextualSearchEnabled should be a string instead of an integer, to be consistent with the calling code.

This pref was never set (ever!) on people's profiles, only registered in profile.cc. I verified with gab@ that moving to String at this point will not mess things up.

BUG=341761
R=noms@chromium.org

Review URL: https://codereview.chromium.org/386893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/385083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282666 0039d316-1c4b-4281-b951-d872f2087c98

R=beaudoin@chromium.org, beaudoin@google.com
TBR=jered
BUG=374932

Review URL: https://codereview.chromium.org/389663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282665 0039d316-1c4b-4281-b951-d872f2087c98

This is the first working CL of <appview>. This CL implements the basic permission API with the onAppEmbeddingRequest event.

BUG=364141

Review URL: https://codereview.chromium.org/354483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282664 0039d316-1c4b-4281-b951-d872f2087c98

This moves the intermediate grit files:
ui/ui_resources -> ui/resources
ui/ui_strings -> ui/strings
in the GYP build to put it in line with the GN one (and also what one would expect).

R=ajwong@chromium.org
BUG=

Review URL: https://codereview.chromium.org/381113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282663 0039d316-1c4b-4281-b951-d872f2087c98

The surface builds up a list of overlays as they come in and HDC
is modified to do the page flip + present all overlays in one go.

BUG=380861
NOTRY=true

Review URL: https://codereview.chromium.org/371813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943

Review URL: https://codereview.chromium.org/385213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282661 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/385133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282659 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282658 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177921:177947&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/389643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282657 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Android] Add heap_profiler_unittests to Android bots. (https://codereview.chromium.org/351183003/)

Reason for revert:
It seems to be breaking some internal bots. :-/


Original issue's description:
> [Android] Add heap_profiler_unittests to Android bots.
> 
> Add proper coverage to heap_profiler.
> 
> BUG=382489
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282626

TBR=aurimas@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/386073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282656 0039d316-1c4b-4281-b951-d872f2087c98

Removes the "ShouldRunMigrationTest()" check from the migration tests.
This check was preventing the tests from being run, but did not cause
them to emit any errors.

Sets these tests to use the legacy python server, since the in-process
server does not yet support migration.

Removes a DCHECK in StatusChangeChecker, since the MigrationChecker
won't work when that condition is enforced.  We can look into
re-enabling it at some later point.

Disables many of the migration tests.  They've been broken by changes
made to the code since they were disabled.

BUG=392989

Review URL: https://codereview.chromium.org/387763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282654 0039d316-1c4b-4281-b951-d872f2087c98