- 28 Feb, 2018 40 commits
-
-
Vaclav Brozek authored
Chrome passwords settings on Android allow the user to export passwords. The Java settings code asks the C++ code to serialise and send over the passwords. The serialised result is in UTF-8 within C++ but gets converted into UTF-16 for Java and then back to UTF-8 on writing to a cache file. This CL changes the data type from String to byte array on Java side. This eliminates the converstion to UTF-16 and back. Note 1: This was pointed out in https://chromium-review.googlesource.com/c/chromium/src/+/926527/2/chrome/browser/android/password_ui_view_android.cc#222. Note 2: This might get further simplified if https://crbug.com/817293 gets implemented, but that's not happening in M66. Bug: 788701 Change-Id: I0799b2c5f6d7e43e9b7449322d300fb9e9d82c54 Reviewed-on: https://chromium-review.googlesource.com/940226Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539832}
-
Michael Hablich authored
Benchmarks are executed as part of ChOps's smoke tests. These smoke tests are also run on debug build, which is much slower. This results in the smoke test framework's perception that Speedometer2 is hanging and thus crashes with a timeout. Now there is the option to do something different in a benchmark in case it is run as a smoke test. R=nednguyen@google.com Bug=792495 Change-Id: I338c39ba3377738e4e52f1869702d444bb266221 Reviewed-on: https://chromium-review.googlesource.com/941227 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#539831}
-
Yi Gu authored
This patch fixed the missing part from the previous patch https://crrev.com/c/939585 to completely disable the feature. Bug: 814673 Change-Id: Id14a32351d6153221aabf36dec506533ad07b437 Reviewed-on: https://chromium-review.googlesource.com/941262 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539830}
-
Sylvain Defresne authored
The testing::Test fixture (used by TEST macro) does not drain the autorelease pool after a test. PlatformTest should be used. Add a PRESUBMIT check that neither TEST nor testing::Test is used in iOS Objective-C++ test files. Files are assumed to be iOS if either their base name match '\bios\b' or one of the component in the path is 'ios'. Expand MockInputApi to filter files in mocks of AffectedFiles and AffectedSourceFiles function, adding missing mocked functions too. Fix unit tests that were failing after the filtering is correctly implemented. Bug: none Change-Id: I0af99b6658b8e15888dfcfb94345eb879ab9fd37 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/937204Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539829}
-
https://chromium.googlesource.com/catapult.git/+log/371be98a6bf6..c0485e380759 $ git log 371be98a6..c0485e380 --date=short --no-merges --format='%ad %ae %s' 2018-02-28 nednguyen Remove [page_set] argument in help string message of benchmark run command Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6b24cf58cacee3faaab8b47cda35dbfa57720ee4 Reviewed-on: https://chromium-review.googlesource.com/941263Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539828}
-
Alexandr Ilin authored
The ResourcePrefetchPredictor isn't going to be used in the near future. Bug: 816545 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3e15bef529e5f0b13a09275b8fe7b385ec8215ba Reviewed-on: https://chromium-review.googlesource.com/939171Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539827}
-
Thomas Tangl authored
This CL makes the sync illustration in the user menu non accessible so it is not read by VoiceOver. Bug: 814995 Change-Id: I280cd359fc389afdeed03bf914b1e8a5cc741bee Reviewed-on: https://chromium-review.googlesource.com/934507 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#539826}
-
Ioana Pandele authored
This adds the remaining metric: - PasswordManager.ExportedPasswordsPerUserInCSV Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I913bedb9f3e716db6f7ac78975344f994ae02016 Reviewed-on: https://chromium-review.googlesource.com/939166 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539825}
-
Tommi authored
Bug: none Change-Id: Ie3adc12610b37a5021038664ab691c100e3fb652 Reviewed-on: https://chromium-review.googlesource.com/940224Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539824}
-
Gabriel Charette authored
Bug: 817330 Change-Id: Ifb402ed997f4c2b4d96e1b4124ee518b8700f69a Reviewed-on: https://chromium-review.googlesource.com/940140Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#539823}
-
Thomas Tangl authored
This CL adds an accessible name to the "Sync with another account" dropdown arrow in the contextual promos. Bug: 814986 Change-Id: Icb43e48a398178d30cd7517b1aba2c1efa697492 Reviewed-on: https://chromium-review.googlesource.com/939397Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#539822}
-
Alexander Timin authored
- Added TODO to move PageVisibilityState into core/. - Pass weakptr in OnWorkerSchedulerCreated instead of adding a method to get a weakptr. - Remove some leftover code. R=haraken@chromium.org,dcheng@chromium.org BUG=776416 Change-Id: I1d6705fe59d878f316809cf73ce6f61c8bfe77b6 Reviewed-on: https://chromium-review.googlesource.com/939469Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539821}
-
Gauthier Ambard authored
This CL doesn't show the progress bar during the loading of the page on iPad. Bug: 813073 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I94c2ca6b28906220aeaf7affca702bd36e49b0d8 Reviewed-on: https://chromium-review.googlesource.com/941223Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#539820}
-
https://chromium.googlesource.com/catapult.git/+log/7a160b6bb44a..371be98a6bf6 $ git log 7a160b6bb..371be98a6 --date=short --no-merges --format='%ad %ae %s' 2018-02-28 nednguyen Remove perf profilers in Telemetry Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6aa5eade1047c6e079c448a7041b41171929b88f Reviewed-on: https://chromium-review.googlesource.com/941181Reviewed-by:
-
Colin Blundell authored
This reverts commit d20c0123. Reason for revert: The SubframeUnavailableBeforePrint test added in this CL is flaky (see crbug.com/817068). Original change's description: > Print with dead subframes for pdf composition > > Handle two cases with dead subframes for pdf composition: > -- When a web page has a dead subframe prior to printing, we need to > detect the liveness of the subframe, and avoid requesting printing for > such frame; > -- If after we request printing a subframe, the subframe dies, we add > monitoring for render frame's closed event to check whether it is one > of our pending ones. If so, notify pdf compositor service about that. > > We add an interface in pdf compositor service to be notified about > the frame's unavailability for either of the above cases. > > In this CL, we also add a map to record the subframes that are already > printed and use it to avoid printing the same ones repeatedly. > > BUG=814086 > > Change-Id: Ibd69dd21a6498a5c2784dfe892bc5803e84fa6f0 > Reviewed-on: https://chromium-review.googlesource.com/932018 > Commit-Queue: Wei Li <weili@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539291} TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=dcheng@chromium.org Bug: 814086 Change-Id: I2062517c3f955523618be23a52ad507c4da3de90 Reviewed-on: https://chromium-review.googlesource.com/941201 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539818}
-
Min Qin authored
The implementation is currently in content/ and used by download and pepper. Download code is being moved to components/. This CL moves the quarantine implemetation to components/ so it can be shared between content/ and components/ BUG=803135 Change-Id: Id68afca113891abb8475b6b64f5854be28b0ca3e Reviewed-on: https://chromium-review.googlesource.com/933287Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539817}
-
Jochen Eisinger authored
R=thakis@chromium.org Change-Id: I53c11336429d7c0f3b42c3bb16b3906dfa54ad40 Reviewed-on: https://chromium-review.googlesource.com/939786Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539816}
-
Paul Jensen authored
Rename the android_library target so it doesn't overlap the similarly named library in the cronet/ output directory. This is an attempt to avoid some weird compile flakes where a class file from one cronet_impl_common_java.jar somehow ended up in the other cronet_impl_common_java.jar. Bug: 816981 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia2f431dd7c2793ca5498fd5696cb2f613ef9f6af Reviewed-on: https://chromium-review.googlesource.com/940586Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539815}
-
Benoit Lize authored
This CL adds the "fractional average distance" to examine ordering stability. Also makes it compatible with orderfiles with symbols. For instance, for a regular roll: $ tools/cygprofile/compare_orderfiles.py --from-commit f9062ad5c6383ae959f1c80d20099375a2be745e [...] Symbols count: first: 417918 second: 418657 New symbols = 1004 Removed symbols = 265 Average fractional distance = 0.15% And a significant one: $ ./tools/cygprofile/compare_orderfiles.py --from-commit 4c1e7a85c8bac01731203990fd4b66a7b5b19dd9 [...] Symbols count: first: 428730 second: 190074 New symbols = 16952 Removed symbols = 255608 Average fractional distance = 26.53% Note that the distance is insensitive to the relative sizes of the orderfiles, only to the relative ordering of the intersection. Change-Id: I188684ef7a0bb545e6a55bc335d432dd6690a203 Reviewed-on: https://chromium-review.googlesource.com/876088 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#539814}
-
Justin Cohen authored
Adds new tile background image and reading list circle. Bug: 805636 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I46dfca56ea4ebdb682ee688aa5b1b8aa88bf4f73 Reviewed-on: https://chromium-review.googlesource.com/936084Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539813}
-
Max Morin authored
How did this ever work ¯\_(ツ)_/¯. Bug: 816348 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2fc1767e6c9cf910241938ca85c03bc503039d07 Reviewed-on: https://chromium-review.googlesource.com/937515Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539812}
-
Koji Ishii authored
Following bot results are included. 3967 3969 3971 3973 3974 3975 3976 3980 3985 3989 3992 3993 3987 1 lines were removed and 21 lines were deflaked by consecutive results since 3926. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I955aedc83f4d71f5ac4b9f52decde6b7508a7766 Reviewed-on: https://chromium-review.googlesource.com/938689 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#539811}
-
Gauthier Ambard authored
This CL merges the LegacyToolbarCoordinator in the ToolbarCoordinator. Bug: 809785 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I444edfa36c23986323fb3ec686c29d4e3c25ba87 Reviewed-on: https://chromium-review.googlesource.com/931441 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL updates the size of the toolbars to match the requirements. The requirements are described in: crbug.com/807778. Bug: 807284 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icabb8adc10d9b6e4828e83e0b94260612ca334b9 Reviewed-on: https://chromium-review.googlesource.com/939480 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539809}
-
Keishi Hattori authored
When incremental marking is enabled, new pages are allocated while marking. By moving the MarkAsUnswept from before marking to after, this simplifies swept flag management. This is because pre sweep all pages become unswept. This CL also adjusts ObjectPayloadSizeForTesting for this change. Change-Id: Ic5ea315a2cfd2c65e8d8f08e55b1d202fbeb5915 Reviewed-on: https://chromium-review.googlesource.com/938887 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539808}
-
Mounir Lamouri authored
These changes are sent over with UKM data and wiped when local data are wiped. Bug: 814351 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I189a430e46fb2a68af34aa7d4b237adad45d781a Reviewed-on: https://chromium-review.googlesource.com/931471 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#539807}
-
Yuri Wiitala authored
Adds a browser test to confirm that tab capture grabs all content and content updates when cross-site render process isolation is turned on. The addition of this test revealed a pre-existing bug where the consumer would not get a video frame for updated content. This happened whenever OnFrameDamaged() was being called before OnBeginFrame() (which can happen when Surfaces are changed). Bug: 808718 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo Change-Id: Ic965ece20d4c40eb65cdb78452148283935e5184 Reviewed-on: https://chromium-review.googlesource.com/936661Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539806}
-
Scott Chen authored
Bug: 815018 Change-Id: I4acef1831cee5f32b6f2b307c5d695e7f3177cb9 Reviewed-on: https://chromium-review.googlesource.com/939180 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#539805}
-
Chandan Padhi authored
This CL adds support for audio and video properties in MediaStreamTrack.getCapabilities() for audio and video sources other than getUserMedia(). Bug: 293292 Change-Id: I14569ad829b80ade60ea52f371edc0bffd282583 Reviewed-on: https://chromium-review.googlesource.com/934481 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539804}
-
Thomas Tangl authored
For the personalized sync promo in the user menu and the contextual promos "Sync as <FIRST>" should be displayed instead of "Sync as <FIRST> <LAST>". This CL fixes this. Bug: 810865 Change-Id: Idf3f40b9f9a7ecac8dff4d2ab293cafda8399249 Reviewed-on: https://chromium-review.googlesource.com/939396Reviewed-by:
-
Martin Sramek authored
Specifically, record the resource IDs of the strings the user saw and clicked on when giving consent for Chrome Sync on Android. See detailed explanation in this (internal) doc: https://docs.google.com/document/d/1Psl9VJ4Dbc1Dh5bXCTa85OF1_DE3viTTHYwybu3V6Uk/edit#bookmark=id.6zygb41dn9vl Bug: 781765 Change-Id: I55c04b7c206602d892dcfff34c47b79876000608 Reviewed-on: https://chromium-review.googlesource.com/880861Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#539802}
-
Thomas Tangl authored
This CL fixes a bug in the accounts submenu of the contextual promos to start sync with the correct account. Change-Id: Ib1dd02e66d900172bec38be6ee0449335fe77449 Reviewed-on: https://chromium-review.googlesource.com/941144Reviewed-by:
-
Daniel Bratell authored
If the same include guard is used twice, it becomes impossible to include both those headers in the same translation unit and that can be hard to debug and understand. This patch renames some include guards that have the same names (copy/paste) as existing include guards. Found while working on a PRESUBMIT test for include guards. It will not warn for these things, but it was easy to add that test locally. There are another few thousand files that have wrongly named include guards. Left as an exercise to the reader. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic7ba08558d3fbae0d3bee843f3092d472f8c643b Reviewed-on: https://chromium-review.googlesource.com/937712Reviewed-by:
-
Aleksandar Stojiljkovic authored
BUG=737410 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id977164b8acf715c0601b27bc70b54bf5d01d6a6 Reviewed-on: https://chromium-review.googlesource.com/940221Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Cr-Commit-Position: refs/heads/master@{#539799}
-
Sylvain Defresne authored
The testing::Test fixture (used by TEST macro) does not drain the autorelease pool after a test. PlatformTest should be used. Bug: none Change-Id: I7b33f0c53bc57fb8f2266bc58eb578d71da642b4 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/940132 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
"ahem" is causing flakiness on Windows, so this patch just replaces "ahem" by "Ahem" on css-ui WPT tests. BUG=724392,796733 Change-Id: I956e939790319ec956164f34af8c72f109c528ef Reviewed-on: https://chromium-review.googlesource.com/940133Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#539797}
-
Colin Blundell authored
This CL adds a convenience static function to hide casting of a SigninManagerBase instance to its corresponding SigninManager instance. This function follows in the grand tradition of Profile::FromBrowserContext. This CL also switches all applicable callsites to use the new function and removes unnecessary static_casts to SigninManagerBase that are scattered around the codebase. Note that there are some static_casts that cannot be switched: the ones in the various SigninManagerFactory instances. These are casting from KeyedService* rather than SigninManagerBase*. TBR=jam@chromium.org Change-Id: Ib150071b11a1558f96d06f184a83775acc8b088b Reviewed-on: https://chromium-review.googlesource.com/939400 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Per Åhgren authored
This CL adds a command line switch based on base::Feature to allow the user to explicitly specify when the setup used is such that the audio playout and capture are done on different clocks (has clock-drift). Bug: chromium:816742 Change-Id: I8a8e15ef479062a0ab30878ef3bde5b5c1f52d6e Reviewed-on: https://chromium-review.googlesource.com/938921 Commit-Queue: Per Åhgren <peah@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#539795}
-
Fredrik Söderquist authored
Since the 'pathLength' attribute moved to SVGGeometryElement, so should the attribute mutation handling. Bug: 815170 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I04bc19988f80f3c3fe4810897e3003403c6997c6 Reviewed-on: https://chromium-review.googlesource.com/939625 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#539794}
-
Colin Blundell authored
This reverts commit 1a37b165. Reason for revert: Causing components_unittests to fail compile due to missing definition of the static function. See https://bugs.chromium.org/p/chromium/issues/detail?id=817302#c1 for more details. Original change's description: > [MacViews] Shim |ShowModalDialog| for Polychrome > > Since "ViewsBrowserWindows" is a Chrome feature, this CL follows > CreateNativeWebModalManager in declaring a function in components > and defining it in c/b/ui/cocoa. > > Background: > Polychrome is an intermediate step to shipping MacViews browser. > Currently, switching between Cocoa browser and MacViews browser requires > a buildflag. Polychrome builds both Cocoa and MacViews into the same > binary and allows switching between them based on a feature flag. > More details at crbug.com/802257 > > As Cocoa and (much of) Views were not typically built together, > some symbols were reused. With Polychrome, these are duplicate symbols. > This CL resolves the issue by renaming the Cocoa symbols, and then > shimming them for the (regular, not Polychrome) Cocoa build. > > Bug: 808017 > Change-Id: I9bf1845aa22305928aafd74884793f0fa86afe56 > Reviewed-on: https://chromium-review.googlesource.com/929942 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538832} TBR=ellyjones@chromium.org,wittman@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 808017 Change-Id: I523fee5108b570a8e36bb5f5bc91a3896c916742 Reviewed-on: https://chromium-review.googlesource.com/941161Reviewed-by:
-
