- 10 Aug, 2020 40 commits
-
-
arthursonzogni authored
Past me found something wrong in the code, but didn't change its current behavior: ``` TODO(arthursonzogni): |redirect_status| refers to the redirect status of the |blocked_url|. This is unrelated to |source_url|. Why using it in this case? This is obviously wrong: ``` Removing this weirdness fixes the previously introduced WPT test and likely fix: https://crbug.com/1113163 Bug: 1113163 Change-Id: I22cfcdd0ae5a088c9079fe3a045c49f193159d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339745 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#796328}
-
chrome://appsAlexey Baskakov authored
The last compression step should take scaled skia image representation as the input: We should compress the image with the proper intended scale. Drive-by: Remove two duplicate apps_util::ConvertDipToPx() calls. Background: see previous change https://chromium-review.googlesource.com/c/chromium/src/+/2325349 Bug: 1112737 Change-Id: I16226014840408fc6b4792081fb528d411122de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338335 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#796327}
-
Miriam Polzer authored
Add a default value to the device policy enum for ChannelDowngradeBehavior. Bug: 1110808 Change-Id: Id5caf1988c0f2c4b9699a058213c772567316811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345145 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#796326}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbb7e0951a27..0fd4513a30ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I9951c079b16b1b83c9ef23387acfb3a1c4918ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346065Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796325}
-
Maksim Sisov authored
This change doesn't bring any changes for the current Ozone/Linux config as long as the UseOzonePlatform feature is enabled by default there and cannot be disabled. Though, when use_x11 && use_ozone will be set together, we will need to specify what path to use by enabling the OzonePlatform feature. That is, we are going away from separate non-Ozone x11 and Ozone Linux configs that allow to switch between Ozone and non-Ozone with a runtime flag instead. Thus, to save some time and relax my testing, explicitly pass the --enable-features=UseOzonePlatform to tests even though UseOzonePlatform is enabled by default for OS_LINUX && USE_OZONE. Bug: 1085700 Change-Id: I3b49b45ff23ba0ad6b2ede3e3586d3db741e88fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340962 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796324}
-
Gauthier Ambard authored
This reverts commit 6503bbcb. Reason for revert: SafeBrowsingServiceTest.PersistentCookies is failing on iPad-device https://ci.chromium.org/p/chrome/builders/ci/ipad-device/11375 Original change's description: > [iOS] Use a persistent cookie store for Safe Browsing > > This makes SafeBrowsingService use a persistent cookie store, > and clears this cookie store whenever cookies are cleared for > "all time". This makes the behavior on iOS consistent with > the behavior of Safe Browsing on other platforms. > > Change-Id: I37fec41b6929386ecf2ce1e29fdbb8e95ac89383 > Bug: 1103219 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291694 > Commit-Queue: Ali Juma <ajuma@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796057} TBR=ajuma@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1103219 Change-Id: Ia5dadc043993898ddc339701f2742207f98ef41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344446Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796323}
-
Mihai Sardarescu authored
AccountConsistencyService now uses the cookie manager directly to add or delete the CHROME_CONNECTED cookies for google web domains (this change landed in CL https://chromium-review.googlesource.com/c/chromium/src/+/2323901 ). This means that it can update the CHROME_CONNECTED cookies even when the incognito mode is active as it no longer relies on using a WKWebView to inject the CHROME_CONNECTED cookies. Bug: 1102794 Change-Id: I2064ca62f801f46c0d2dae9b87276f1f6dc9bceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339656 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#796322}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64aee0acaab2..530fc3bb4cba 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3831ac2043e4 to 48ba75ac6845 (14 revisions) 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2acf87cc to 4430c2c5 (515 revisions) 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a202c209bc91 to 59b4828f293e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1112986 Tbr: fmalita@google.com Test: Test: Test: CQTest: Test: Compile and link NBA2K20 trace for AndroidTest: Test: Release build of Capture/Replay sampleTest: Test: angle_perftests --gtest_filter="*Trace*"Test: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: I68cdcc0b6840faaa26d5614a0d0f6b23111c0127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796321}
-
Benoit Lize authored
Also add a CSV output to ease processing of the results. Bug: 998048 Change-Id: Iecbd99dd0ca3b468a9f954383fd6a59b709711a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341642Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796320}
-
Victor Hugo Vianna Silva authored
This CL introduces a per Gaia-account pref that keeps track of how many times a non-opted-in user has refused or ignored the bubble to move a password to the account. The pref is cleared when the user opts in. Bug: 1082152 Change-Id: I5b99f872ce30a86b65afd083c5a7f0e2285049f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340966 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#796319}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d3b414c97dd..330914341bd4 2020-08-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5bca4d9f5cd8114020af852e3a45fcf020cca78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345294Reviewed-by:
-
Victor Hugo Vianna Silva authored
Implementation: https://screenshot.googleplex.com/4Q2LOWL28un Mock: https://screenshot.googleplex.com/iNV6JAtE9t9 The CL also makes a change to <site-favicon> to allow embedding it as a round icon. Bug: 1102294 Change-Id: I70b702a1404b7c20bd0df65f7b0db06d3c999d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287297Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#796317}
-
Andrei-Laurențiu Olteanu authored
Update integration tests of GetAvailableRoutines to make them compliant. Change annotation types for Diagnostics and Telemetry to remove mojo dependency. Remove mojo dependency from untrusted.js. Change error handling for Diagnostics and Telemetry. Bug: b:153371185 Change-Id: Ia1f25b5a141551bcd37f92cc7cc895ab70aa0f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339984Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#796316}
-
Naoki Fukino authored
The rendering artifact mentioned in issue 1095864 is actually a horizontal scrollbar. It is shown unexpectedly when a single path component in the file location path is longer than the width of metadata box. Each path component's CSS overflow-wrap property is break-word (derived), but it should be OK for path component to break line in the middle of a word. Bug: 1095864 Test: Manually tested. Change-Id: I7e6a986511cf1828957e35fb3549f8c6417b23f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344330Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796315}
-
Morten Stenshorne authored
Mark 5 now-passing tests as such, and remove 3 all-pass expectation files. TBR=almaher@microsoft.com,kojii@chromium.org Change-Id: I0db2e3b503d0b9ff0b9182560fe158482ff103de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344466Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#796314}
-
Marc Treib authored
Bug: 1113713 Change-Id: I60253242c830519186f9513caf4f93737c6f990f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343025Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#796313}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c255306f7cd6..fbb7e0951a27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I612d68b3a0fb6f7ca670f7f78263ab15b6a3ad8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345288Reviewed-by:
-
Curtis McMullan authored
This CL adds the metrics for interactions with the virtual keyboard handwriting suggestion menu. The code to record the metrics is added in the following CL: cl/325364890 BUG=1114003 Change-Id: Id3fd1f9d2a44edce169e665a690b8627aec3ee51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342485Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796311}
-
Khushal authored
We were incorrectly using fences from the video buffer for initializing the fences used for the primary plane. While this was hitting a debug assert it didn't cause any errors in the metric since the primary plane is always scheduled last, so the fences eventually used in the metric did belong to the primary plane. R=vikassoni@chromium.org Bug: 1100442 Change-Id: I7412c4f81d6356849a1b3b42c9af94c06d565882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344007 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796310}
-
Mihai Sardarescu authored
The canonical cookie domain needs to start with a ".". This CL uses a helper function to create a domain for the cookie instead of having this inlined in each test. Bug: None Change-Id: If00f14e0f19ed9fc89fbc0ff93471f07e37a8f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332612 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Andy Paicu authored
TBR: jdeblasio@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113105 Change-Id: Iec8d55a08534d24fc5b4fc4fa612a1770ba669e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344445Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796308}
-
Karel Král authored
Use the newer LibTooling API (bind instead of id). Fix empty_string/tests for use with tools/clang/scripts/test_tool.py Bug: 1111787 Change-Id: I8cdd62f05afd9f41cc3eec22d638d39d39c32ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343065Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#796307}
-
Marc Treib authored
MockHostResolver::AllowDirectLookup("host_pattern") ensures that hosts matching the pattern are not affected by host resolver procedures (commonly used to map hosts to the embedded_test_server). These calls are important in E2E tests, but really have no business in regular browser tests, so let's get rid of them there. It turns out that two tests from SyncErrorTest.* depended, very indirectly, on the presence of the AllowDirectLookup() calls. These tests are updated here to become more robust. See more details on the linked bug. Bug: 1112789 Change-Id: I69430b6ceecb904d063e17f8ac8d59f15a1544d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339986 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796306}
-
Preethi Mohan authored
Bug: 1098096 Change-Id: Iad313e98c90616d2b2ab04ccb6682ecbdeb2274c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325082 Commit-Queue: Preethi Mohan <preethim@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#796305}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597017082-f8f51ec7c105c76c8c188f2df326b7b00c9b3e5a.profdata to chrome-mac-master-1597037945-c748d93b7b3b8df201950e67d57a776238968dea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I82719b0b5d037149b32096f4511538facd2d9a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345295Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3b46e8ff5b2b3ed83e5a1744b470a683fa2e056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345290Reviewed-by:
-
Zain Afzal authored
crrev/c/2316189 removed the need for a save copy delegate function by adding the save as code path, to make sure TOT wasn't broken it left the old save copy delegate function as is until the next version of the media app was rolled in. crrev/c/2344327 should update the version of media app so it no longer uses the "save copy" function and as such its now safe to delete it. Change-Id: I5f7a67ffec261a8d76c1c1e6e4ff2e82851f2743 BUG: b/161193454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344436Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#796302}
-
Omar Morsi authored
This CL refactors the enumerator chromeos::platform_keys::KeyAttributeType::CertificateProvisioningId to kCertificateProvisioningId so as to comply with Google C++ Style Guide and to be consistent with chromeos::platform_keys::KeyAttributeType::kKeyPermissions attribute that will be added in a future CL. Bug: None Change-Id: Idd46415a0140a56fd63636c75dcb6b3d68625332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343078Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#796301}
-
Alexander Hendrich authored
voit@ has left the team, replacing with general policy owners. Bug: none Change-Id: I218c0b531a38af59f0084099c88c022b7553871a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341130 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea2f3a43df40..5d3b414c97dd 2020-08-10 paulirish@chromium.org InspectorFrontendHostStub.close() should release createObjectURL memory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48e3108449c815a4b44fcd6b01b8af1ce05cb8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345289Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31954bf23f24..64aee0acaab2 2020-08-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 2cf5a08cfc1b to 1662e97f324e (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I7168658b559e7d66b6c1d311e3242e10fba0c93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345096Reviewed-by:
-
Jiewei Qian authored
This CL adds a RegisterAutoGrantedPermissions method WebUIAllowlist. This method allows registering a list of permissions, instead of doing a for-loop. Also adds a comment about permissions (and content settings) commonly wanted by WebUIs. Bug: 1109773 Change-Id: I50c05d3b2b7672978dbf53c267ddcaa0352c0545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336425Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#796297}
-
Maggie Cai authored
This CL fixes the sharesheet button type in file_manager.css. BUG=1097623 Change-Id: I902164400191bafcefe09489129e2441dd0a2838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335851Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bcddb0efbf60..ea2f3a43df40 2020-08-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia3c977f47e147e1e45161ddb139304b94bd0cfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345094Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dbe3f25ad27..c255306f7cd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: keishi@google.com Change-Id: I57aa3031ef6ed401b07caea1abfb157d618f0e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345093Reviewed-by:
-
Miyoung Shin authored
This is a reland of a7c54a0f Original change's description: > Fix a crash in WebUIMessageHandler::AllowJavascript > > If WebUI's JS is sending the message when we navigate cross-site, > then we use the new process ID from WebContents in > WebUIImpl::CanCallJavascript and a CHECK crash will happen. > > This CL changes to use the old process ID from RFH in > WebUIImpl::CanCallJavascript. > > Bug: 1110276 > Change-Id: Ie827060b637dbd3aa4c7ad771c0cb4862763ced2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326050 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#793816} Bug: 1110276, 1112189, 1112238 Change-Id: I02916364f8cb3871ab4cdf17cd2827a5f1cfbb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335213Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#796293}
-
Zhuoyu Qian authored
Bug: 1100751 Change-Id: I93cf812110c67bdd105678057af49469d24ebd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335716 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ibfa1420915f08f9afd0ca8c7bf11d92848d470b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345490Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796291}
-
Sergei Datsenko authored
Don't drop errors on the floor when can't identify of find the mentioned file. Bug: 1012031 Change-Id: I39111b68a6e719bdf989b4e29aba67f270d256ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342226Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#796290}
-
Ahmed Mehfooz authored
Bug: 1111969 Change-Id: I5fafeb1002852d5c584209e4da2bb492b72113fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343006 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796289}
-
