- 26 Oct, 2018 40 commits
-
-
Benjamin Ackerman authored
The webstore_api_constants is no longer being used, so removing it. Bug: 882045 Change-Id: If0ab15c26eb70c89a9bad3d236c0fa62b71ef2fb Reviewed-on: https://chromium-review.googlesource.com/c/1299545 Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603205}
-
Sam Maier authored
Bug: 872904 Change-Id: Ida80736a33c98bb9e4faea1864f921d7d0d58c81 Reviewed-on: https://chromium-review.googlesource.com/c/1302699 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603204}
-
Brian Salomon authored
This version of SkCanvas::drawImageRect doesn't use the constraint as there is no source rect. Bug: skia:5679 Change-Id: I16bc18690704e2c2bd30f509e2fc54422b78ed83 Reviewed-on: https://chromium-review.googlesource.com/c/1302656Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#603203}
-
Findit authored
This reverts commit c626ad1c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603187 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M2MjZhZDFjYjRiOTVjMTRkYzA4NGFlMjgyN2YzYjhkMTQzYTI4YWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8527 Sample Failed Step: compile Original change's description: > Support policy-pushed trust anchors on ChromeOS with network service. > > Also use CertVerifyProcChromeOS. > > Bug: 862043, 887007 > Change-Id: I42bc36d58065db35cc70a1a2c587affec25a955a > Reviewed-on: https://chromium-review.googlesource.com/c/1292830 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603187} Change-Id: I67243629f4caf63da6e1e943dd9321a4b0e9f7a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862043, 887007 Reviewed-on: https://chromium-review.googlesource.com/c/1303175 Cr-Commit-Position: refs/heads/master@{#603202}
-
Mohamed Amir Yosef authored
The APIs for storing the laziness information in InstanceIDBridge accept the app id and the sender id as parameters, and internally call buildSubscriptionUniqueId() However, the APIs for storing the messages themselves in GCMDriver accept the subscription ids directly. This CL does the following: 1- It unifies both APIs to accept subscription ids. 2- It also moves all APIs to the a new class LazySubscriptionsManager. This way all APIs live next to each other and also simplifies the dependencies between both the InstanceIDBridge and the GCMDriver. 3- Moves the relevant tests from InstanceIDBridgeTest.java and deletes it since it contains no other test. Bug: 882887 Change-Id: I4b7937ba1adce72a1312e49d541f9398bb7b9ec9 Reviewed-on: https://chromium-review.googlesource.com/c/1288432Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#603201}
-
Mina Almasry authored
Currently we return the video pts if available, and that causes complications if the audio is longer than the video. Instead, return the max of the audio and video pts. Bug: b/117606837 Test: curl problematic stream, cast youtube, cast_media_unittests Change-Id: Ic54dee250b9026417249aa9034665839d119dcdd Reviewed-on: https://chromium-review.googlesource.com/c/1302701 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#603200}
-
Mason Freed authored
NOTRY=true TBR=dmazzoni@chromium.org Here are the findit links: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjU3NzAvd2Via2l0X2xheW91dF90ZXN0cy9kbWx5ZEhWaGJDOTBhSEpsWVdSbFpDOW1ZWE4wTDNOamNtOXNiQzFpWldoaGRtbHZjaTl6Ylc5dmRHZ3RjMk55YjJ4c0wzTmpjbTlzYkMxa2RYSnBibWN0YzJWc1pXTjBhVzl1TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1Mjk1L3dlYmtpdF9sYXlvdXRfdGVzdHMvZG1seWRIVmhiQzkwYUhKbFlXUmxaQzltWVhOMEwzTmpjbTlzYkdsdVp5OXVieTFvYjNabGNpMWtkWEpwYm1jdGMyTnliMnhzTG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKqAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1Mjk1L3dlYmtpdF9sYXlvdXRfdGVzdHMvZG1seWRIVmhiQzltY21GamRHbHZibUZzWDNOamNtOXNiR2x1WjE5MGFISmxZV1JsWkM5bVlYTjBMM05qY205c2JHbHVaeTl1Ynkxb2IzWmxjaTFrZFhKcGJtY3RjMk55YjJ4c0xtaDBiV3c9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Bug: 899347 Change-Id: I8c0acfa91d22845c6020e4544c853b16bf85a712 Reviewed-on: https://chromium-review.googlesource.com/c/1302819Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603199}
-
chromium-autoroll authored
Note: net manually updated to include fix for new location for INFO_FEATURE_WLAN and _LOOPBACK. The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I506624881b41e75ca3dae289c545673a40c17f07 Reviewed-on: https://chromium-review.googlesource.com/c/1302854Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603198}
-
Matt Swartwout authored
Bug: None Test: None Change-Id: Ib19c2d505e63522ac1c2c1798c2de37a5afa53d1 Reviewed-on: https://chromium-review.googlesource.com/c/1303035Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#603197}
-
Xi Han authored
Bug: 899280 Change-Id: Ie3ac551233bfee2b4fc59fd87884eead21a1debf Reviewed-on: https://chromium-review.googlesource.com/c/1302102Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603196}
-
Xiaohan Wang authored
- Add "vp09" parsing in widevine_cdm_component_installer.cc - Add |supports_vp9_profile2| in media::CdmCapability and media::mojom::KeySystemCapability. - In chrome_key_system.cc, read |supports_vp9_profile2| and decide whether EME_CODEC_VP9_PROFILE2 is supported. CDM supports VP9 profile 2. Bug: 707127 Test: No functionality change for now. Will update test when Widevine Change-Id: I2441e65dbf29bdc0d30cdb3f5d26e38afd0e90df Reviewed-on: https://chromium-review.googlesource.com/c/1297462Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603195}
-
Xi Han authored
This reverts commit aa60c219. Reason for revert: it breaks network_service_webview_instrumentation_test_apk on Mojo Android Build: https://bugs.chromium.org/p/chromium/issues/detail?id=899376 Bug:899376 Original change's description: > Start ServiceManger before creating BrowserMainLoop. > > This CL instantiates the ServiceManagerContext before creating > the BrowserMainRunner. It splits the startup path into two, > with/without starting the full browser. The changes are implemented > behind a flag "allow-start-service-manager-only". > > Bug: 846846,729596 > Change-Id: I3584db0d89a10e59d6041e0f4412aaffdc840568 > Reviewed-on: https://chromium-review.googlesource.com/c/1113802 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603092} TBR=gab@chromium.org,jam@chromium.org,hanxi@chromium.org Change-Id: I866cc2148d529d0d7a02d0ac75b2817d1695a8c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846846, 729596 Reviewed-on: https://chromium-review.googlesource.com/c/1303042Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603194}
-
Tommy Steimel authored
This CL adds a check in MediaViewerUtils to prevent creating a pending view intent if the intent will throw a FileUriExposedException. This will prevent the "Open with" option from showing up. Bug: 893544 Change-Id: Id32d202a0bd9975bca7a93d2be7dc291cf8aab45 Reviewed-on: https://chromium-review.googlesource.com/c/1302104Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603193}
-
Luke Halliwell authored
Bits of code have snuck into the local branch without making it upstream. Add all of those bits here. Bug: None Test: Cast CQ Change-Id: I6e042ae5dd83653e3f3656fcc9559e7b71a77c9c Reviewed-on: https://chromium-review.googlesource.com/c/1300613Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603192}
-
Adam Langley authored
These names are already in the “cbor” namespace, thus we end up using a cbor::CBORReader to get a cbor::CBORWriter and it's stuttery. I defer entirely to the owner's personal preferences here because the above is obviously just my personal preference. But, thanks to clang-format, this only took five minutes to do. (TBR for web_package due to non-semantic change of underlying API.) TBR=kinuko@chromium.org Change-Id: I8b34506ebe2aad2779548da0fb451ced61381ccf Reviewed-on: https://chromium-review.googlesource.com/c/1289509 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603191}
-
Lucas Furukawa Gadani authored
Bug: 832879 Change-Id: Ib39e8caade4114b396337fa2efc04f4a54f69ed3 Reviewed-on: https://chromium-review.googlesource.com/c/1301843Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603190}
-
John Abd-El-Malek authored
Bug: 862043 Change-Id: I78c19396fbacfdf0bc1ee2bffa07b61e75f0ee4b Reviewed-on: https://chromium-review.googlesource.com/c/1300793Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
-
Jamie Walch authored
BUG=899253 Change-Id: I23075d551c70b72babdb1eb180fe920d748523e2 Reviewed-on: https://chromium-review.googlesource.com/c/1302655Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#603188}
-
John Abd-El-Malek authored
Also use CertVerifyProcChromeOS. Bug: 862043, 887007 Change-Id: I42bc36d58065db35cc70a1a2c587affec25a955a Reviewed-on: https://chromium-review.googlesource.com/c/1292830Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#603187}
-
Min Qin authored
BUG=765327 TBR=dtrainor@chromium.org Change-Id: Iff5b69d1afc4e8ef21e3a9802824fd15ad55862c Reviewed-on: https://chromium-review.googlesource.com/c/1302853Reviewed-by:
-
Jared Saul authored
Bug: 884817 Change-Id: Ie2535ee36d806801ecc98891c6ec37c53a339365 Reviewed-on: https://chromium-review.googlesource.com/c/1302329Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#603185}
-
John Budorick authored
Will promote back to non-experimental once pool:Chrome-quarantine has been folded back into pool:Chrome. Bug: 828031 Change-Id: Icb4f7da5b0aab18ec951bb612acf8d3e7e155a27 Reviewed-on: https://chromium-review.googlesource.com/c/1302657Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#603184}
-
Eugene But authored
Only 2 values of this enum were used and those values can now be represented as a BOOL. Also that BOOL will be passed as a method argument instead of attaching to NSError. Bug: None Change-Id: Ifd9985e74997e12cb87fa4d73cae0466b3a3c218 Reviewed-on: https://chromium-review.googlesource.com/c/1300755 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#603183}
-
Roger Tawa authored
Bug: None Change-Id: Id21ef278d400f11f12cdf5e62cdc40810d2d737b Reviewed-on: https://chromium-review.googlesource.com/c/1301954Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#603182}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fdee701fa8e4..99b71dfd4a7c git log fdee701fa8e4..99b71dfd4a7c --date=short --no-merges --format='%ad %ae %s' 2018-10-26 danilchap@webrtc.org Use function_video_(en|de)coder_factory from api 2018-10-26 ilnik@webrtc.org Use monotonic clock to derive NTP timestamps in RTCP module Created with: gclient setdep -r src/third_party/webrtc@99b71dfd4a7c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I76977c16a6bacd60ddff010f90147d1b57e2567c Reviewed-on: https://chromium-review.googlesource.com/c/1302376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603181}
-
Eric Orth authored
In addition to SO_REUSEADDR, that we were setting before, via AllowAddressReuse(), for sockets for use with multicast, now also set SO_REUSEPORT whenever that option is defined. On some non-Windows platforms, this is needed for multicast messages to be received by all sockets listening for them. This option is only set in a new AllowAddressSharingForMulticast() method as the SO_REUSEADDR and AllowAddressReuse() have other non-multicast uses where SO_REUSEPORT would not be appropriate. Also, for non-Windows platforms, bind the multicast sockets to the multicast group address rather than to a wildcard. This will make us more likely to only get messages from the relevant multicast group as some platforms will otherwise give the socket any multicast messages from groups joined by any sockets in the system. No change on Windows where binding to a multicast group is not allowed. TBR=thestig@chromium.org Change-Id: I24d9d4a0d85134074b2deb14914a41109d7f724a Bug: 899310 Reviewed-on: https://chromium-review.googlesource.com/c/1298298 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#603180}
-
Fabio Tirelo authored
This CL corrects the following outstanding UX polish concerns: * Tap effects are needed on footer rows * Footer icon should be 14dp (vs. 16dp elsewhere), and icons should have explicit sizes * Multiline items (e.g., http insecure warning) should wrap, not elide, and expand the popup height. BUG: 898927 Change-Id: Ibe50c6ddea98dcdf91bc1d82e548b651ba486b37 Reviewed-on: https://chromium-review.googlesource.com/c/1297400Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603179}
-
dpapad authored
In Polymer 2, the contents of an element are not stamped until after the ready callback, unlike Polymer 1 (because of differences within Shadow DOM v0 and v1). Bug: 897594 Change-Id: I51509d5823bbffe4fba3bbf3cf7db9aec6c81e8c Reviewed-on: https://chromium-review.googlesource.com/c/1297630Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603178}
-
Peter Kotwicz authored
This CL also deletes unused javatest_manifest_config.json BUG=899274 Change-Id: Icdf3992983af4a0a9b4a942b544570bebd64448a Reviewed-on: https://chromium-review.googlesource.com/c/1302094 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Kelvin Jiang authored
Add a placeholder page to show an activity log for an extension, hidden behind the "enable-extension-activity-logging" command line flag, and accessible via chrome://extensions/?id=<extension_id>. If the flag is disabled and a user navigates to the page, redirect to the extensions details page. Bug: 898309 Change-Id: Ib0f50487c323e8c07d6fddcd57df3b8e5477cfc6 Reviewed-on: https://chromium-review.googlesource.com/c/1295296Reviewed-by:
-
Dominic Mazzoni authored
This reverts commit 0e8f7da5. Reason for revert: still failing on bots, for example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75295 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/35731 Original change's description: > Enable http/tests/webaudio/autoplay-crossorigin.html > > This test can be enabled again. > > BUG=841933 > > Change-Id: I8729daf0584da308f089502f0730ae398befb022 > Reviewed-on: https://chromium-review.googlesource.com/c/1299550 > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603107} TBR=lukasza@chromium.org,beccahughes@chromium.org Change-Id: Icb53758085810a468770f4492ac43ed1639b140f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841933 Reviewed-on: https://chromium-review.googlesource.com/c/1302678Reviewed-by:
-
Robbie McElrath authored
This test was reenabled in crrev.com/c/1299550, and is breaking the Mojo Windows and Mojo Linux fyi try bots. Bug: 841933 Change-Id: I1bfb367a3145e55ed06d966d821f9e596069d7a3 Reviewed-on: https://chromium-review.googlesource.com/c/1302325 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603174}
-
Jeremy Roman authored
Bug: 670615 Change-Id: Ifd560c15fe8440d6501935753afb5f6eff6cd176 Reviewed-on: https://chromium-review.googlesource.com/c/1299735 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#603173}
-
Geoff Lang authored
BUG=882580 Change-Id: I1a065f608bdd709e74b4bbe83eb744bea5fcc9d2 Reviewed-on: https://chromium-review.googlesource.com/c/1302095Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603172}
-
Nico Weber authored
mini_installer.exe embeds chrome.7z, and chrome.7z contains timestamps of all files in the archive. To make chrome.7z more deterministic, give all files in it deterministic timestamps. Bug: 330260 Change-Id: Ia251dd38177acbebdde288b86826986f441b2d4d Reviewed-on: https://chromium-review.googlesource.com/c/1302393Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#603171}
-
Roger Tawa authored
Bug: 899239 Change-Id: I17dea00048fb3224dcfb17381ba6a1d5db689793 Reviewed-on: https://chromium-review.googlesource.com/c/1301839 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603170}
-
Xiaocheng Hu authored
Don't create VisiblePosition and VisibleSelection in FrameSelection::SelectFrameElementInParentIfFullySelected() This patch refactors the function's selection setting and validation part, so that: - It stops the problematic pattern of creating VisibleSelection before focusing parent frame, which may invalidate the VS - It no longer creates VisiblePosition and VisibleSelection for creating the selection. This is because for a frame owner element, the range [before_node, after_node] is already a canonicalized range, on which creating VP or VS is unnecessary. Bug: 657237, 897983 Change-Id: I5b046047071a4af7454cc1bfef52a457fe49d9c2 Reviewed-on: https://chromium-review.googlesource.com/c/1298179Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#603169}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07d9342e84c2..1ef5883ceab7 Created with: gclient setdep -r src-internal@1ef5883ceab7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia52f63ade549cf9dfe8b5267bda6487ce0ff4d9b Reviewed-on: https://chromium-review.googlesource.com/c/1302213Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603168}
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I6e561ba5f0e92758fb2922bd8e41c4feb70f2203 Reviewed-on: https://chromium-review.googlesource.com/c/1301696Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#603167}
-
Dominic Mazzoni authored
TBR=katie@chromium.org NOTRY=true Bug: 862710 Change-Id: I6d49841747cdd900570f97e128b647dc15060d04 Reviewed-on: https://chromium-review.googlesource.com/c/1302674Reviewed-by:
-
