GitLab

iOS 7 does not call any code at the "end" of an app so flushing should
be performed manually.

BUG=392265

Review URL: https://codereview.chromium.org/375033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282195 0039d316-1c4b-4281-b951-d872f2087c98

This likely won't affect metrics much, but someone asked me to do it
so I am.  It's easy.

BUG=350200

Review URL: https://codereview.chromium.org/245993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282194 0039d316-1c4b-4281-b951-d872f2087c98

Also added unittests for client code.

TEST=unittests

Review URL: https://codereview.chromium.org/320403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282193 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384426

Review URL: https://codereview.chromium.org/362903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/377343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282191 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282190 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/379443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282189 0039d316-1c4b-4281-b951-d872f2087c98

For Ozone, there is no default platform. Since the unittests use their own
delegates this simplifies things by not requiring an Ozone platform when
executing the unittests.

BUG=none

Review URL: https://codereview.chromium.org/383463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282188 0039d316-1c4b-4281-b951-d872f2087c98

Mostly cosmetic API changes. The guts of TimeDeltaInterpolator were
spruced up a bit.

BUG=370634

Review URL: https://codereview.chromium.org/376013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282186 0039d316-1c4b-4281-b951-d872f2087c98

Define the hit test mask for NewTabButton by implementing
MaskedTargeterDelegate instead of overriding
View::HasHitTestMask() and View::GetHitTestMaskDeprecated().

BUG=388838
TEST=none

Review URL: https://codereview.chromium.org/362843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282185 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/382553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390949

Review URL: https://codereview.chromium.org/377713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282182 0039d316-1c4b-4281-b951-d872f2087c98

Instead of calling DQ::Create() function and then push it into
RenderPass in unittest, use RenderPass's function call to create and
append a DQ while only pass out a raw pointer instead of ownership.

Follow CL 369623002.

BUG=344962
TEST=cc_unittests, content_unittests

Review URL: https://codereview.chromium.org/368403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282179 0039d316-1c4b-4281-b951-d872f2087c98

For outputting Telemtry results as JSON, we will want to be able to refer to a
Page by an ID that uniquely identifies it within a page set. This CL puts that
machinery in place.

R=nduca, dtu
BUG=375541

Review URL: https://codereview.chromium.org/384483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282178 0039d316-1c4b-4281-b951-d872f2087c98

This pref is currently registered in different places for Mac and
toolkit-views, resulting in problems for toolkit-views on Mac (i.e. it
gets registered twice).

The views pref moved into extension_prefs.cc in r183799. This moves the
mac pref to the same place for increased code cohesion, simplifying a
lot of things.

BUG=155525, 390755

Review URL: https://codereview.chromium.org/378153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282177 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a place where the wrong URL is used for the ld process when
performing PNaCl translation. I don't believe the effect of this is severe,
though it will cause the wrong url to be displayed when it's running.

This also removes an unnecessary string constant usage in the trusted plugin.

BUG=

Review URL: https://codereview.chromium.org/373003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282176 0039d316-1c4b-4281-b951-d872f2087c98

Probably broke Win7 Tests (dbg)(6). http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%286%29/builds/27654/steps/browser_tests/logs/SendQuery

[ RUN      ] GcdPrivateAPITest.SendQuery
[4036:2900:0709/150928:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[956:2412:0709/150928:WARNING:extension_apitest.cc(282)] Workaround for 177163, prematurely returning
c:\b\build\slave\win_builder__dbg_\build\src\chrome\browser\extensions\api\gcd_private\gcd_private_apitest.cc(276): error: Actual function call count doesn't match EXPECT_CALL(*test_service_discovery_client_, OnSendTo(std::string(reinterpret_cast\u003Cconst char*>(kQueryPacket), sizeof(kQueryPacket))))...
         Expected: to be called twice
           Actual: never called - unsatisfied and active
[  FAILED  ] GcdPrivateAPITest.SendQuery, where TypeParam =  and GetParam() =  (5746 ms)


Revert 282099 "Add API stubs for GCD device commands."

> Add API stubs for GCD device commands.
> Changed registration API to work for one network at once.
> Fixed comments.
> Replaced argument GCDDevice with just string id.
> 
> BUG=383167
> R=alexsemenov@chromium.org, asargent@chromium.org, asvitkine@chromium.org, noamsml@chromium.org
> 
> Review URL: https://codereview.chromium.org/363883002

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/385483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282175 0039d316-1c4b-4281-b951-d872f2087c98

This is two-sided prerequisite for
https://codereview.chromium.org/134623005/.  Once this lands, then
SetDeferCommits can be called regardless of threaded mode in
WebViewImpl.  This patch will make that not explode on NOTREACHED.

BUG=none

Review URL: https://codereview.chromium.org/380853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282173 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282171 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update smoothness_controller to use results.AddValue(...) (https://codereview.chromium.org/380803002/)

Reason for revert:
Possibly caused Android Tests failures. See http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14520/steps/telemetry_perf_unittests/logs/stdio

E.g.
Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:534
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:247
    self.ValidatePage(page, tab, results)
  ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:60
    self.MeasurePage(page, tab, results)
  MeasurePage at tools/perf/measurements/smoothness.py:36
    self._smoothness_controller.AddResults(tab, results)
  AddResults at tools/perf/measurements/smoothness_controller.py:100
    results.current_page, r.name, r.unit, r.value))
  __init__ at tools/telemetry/telemetry/value/scalar.py:19
    assert isinstance(value, numbers.Number)
AssertionError

Original issue's description:
> Update smoothness_controller to use results.AddValue(...)
> 
> BUG=391943
> TBR=nduca@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282131

TBR=nduca@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=391943

Review URL: https://codereview.chromium.org/382673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/377783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282169 0039d316-1c4b-4281-b951-d872f2087c98

I really managed to botch it. Surprisingly, the tests were all still
okay.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/382633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282168 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/381663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282167 0039d316-1c4b-4281-b951-d872f2087c98

Some drives do not report themselves as removable despite appearing to a user to be a removable drive. Particularly this is the case for some USB sticks. We are fixing this by changing the device listing to list all drives that are either removable or attached via USB. We have already done a similar change for Chrome OS due to some SD card readers listing themselves as non-removable. Chrome OS lists all SD or USB drives. However, we do not have a reliable way to detect SD cards on Windows and Mac so we will continue to use the removable flag.

BUG=391998

Review URL: https://codereview.chromium.org/375703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282166 0039d316-1c4b-4281-b951-d872f2087c98

This change collects contiguous processed frames for each track buffer
and appends them to track buffers' streams as groups of frames rather
than inefficiently appending each frame one at a time. One at a time
appends are still possible in the worst case, since collected processed
frames are appended at the end of ProcessFrames() and also prior to any
NotifyNewMediaSegmentStarting().

R=acolwell@chromium.org, damienv1@chromium.org
BUG=371197
TEST=no media_unittest, MSE layout test, or YT conformance unit test regression locally on Linux

Review URL: https://codereview.chromium.org/381443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282165 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282164 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/874a62acef5ec2ecccdbb99ec4d86402a3341e6a..1c577cd3ee331944b9061ee0eec147b211ee563c

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/375423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282163 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282162 0039d316-1c4b-4281-b951-d872f2087c98

1947: Introduce '--no-duplicate-basename-check' option to disable the check of duplicate basenames 
1946: Makes analyzer strip off a leading path separator
1945: msvs: ensure that failing actions make the build fail with multiple actions

BUG=gyp:303,chromium:383609,gyp:264,gyp:384
TEST=none
R=mark@chromium.org

Review URL: https://codereview.chromium.org/376263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282161 0039d316-1c4b-4281-b951-d872f2087c98

Fix a TODO in athena.gyp.

BUG=None
TEST=None
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/371573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282159 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes (https://codereview.chromium.org/364043002/)

Reason for revert:
revert this as all related CLs are submitted

Original issue's description:
> Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes
> 
> there are 2 changes needs to be submitted before we reenable the tests:
> 1. https://codereview.chromium.org/290643005/ and
> 2. https://codereview.chromium.org/292573004/
> 
> the blink change will break all the tests, so we need to reenable the tests after the chromium change lands
> 
> BUG=367346
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281165

TBR=boliu@chromium.org
BUG=367346

Review URL: https://codereview.chromium.org/383433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282158 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385673
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/375693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282157 0039d316-1c4b-4281-b951-d872f2087c98

This puts static libraries on mac next to their ninja files, i.e. in
locations like out/Debug/obj/base/libbase_static.a instead of directly
in the output directory. This matches what we do on other platforms and
avoids the need to give every static library a unique name in the GN
build. https://codereview.chromium.org/376773002/ has some discussion
of the history of why this is different in GYP.

Review URL: https://codereview.chromium.org/378123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282156 0039d316-1c4b-4281-b951-d872f2087c98

Deduplicate chrome.isolate items found in angle.isolate. Move comment about
D3DCompiler_43.dll to 32bits build. If it is going to be mapped, it is only for
32 bits builds and not 64 bits builds since this DLL doesn't seem to exist in 64
bits.

R=scheib@chromium.org,kbr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/379843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282155 0039d316-1c4b-4281-b951-d872f2087c98

Extra vsyncs after each rendering cause 1% more power consumption.
Modify VSyncMonitorTest to follow the rule 1 request == 1 vsync.

BUG=

Review URL: https://codereview.chromium.org/377483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282154 0039d316-1c4b-4281-b951-d872f2087c98

exposed to content scripts.

In some cases this dates way back pre-features to when they were incorrectly
first added with an {"unprivileged": true} annotation, like runtime.reload().

R=asargent@chromium.org

Review URL: https://codereview.chromium.org/375173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282153 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282152 0039d316-1c4b-4281-b951-d872f2087c98

This is to get update to checkdeps to update tree walking to not update a list while iterating over it.

TBR=qsr

Review URL: https://codereview.chromium.org/379923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282151 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/300573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282150 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/380913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282149 0039d316-1c4b-4281-b951-d872f2087c98