GitLab

BUG=317741,338563

Review URL: https://codereview.chromium.org/167153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339790
R=marja@chromium.org

Review URL: https://codereview.chromium.org/166303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251418 0039d316-1c4b-4281-b951-d872f2087c98

generating invalid JavaScript bindings. We now translate an enum value like
FOO_VALUE in a mojom file to proper_namespace.EnumName.FOO_VALUE in JS.

I also fixed enum declarations in JS so an enum value can be defined in terms
of itself, e.g.
  enum Foo { FOO_1, FOO_2 = FOO_1 * 2 };

BUG=320082
R=darin@chromium.org

Review URL: https://codereview.chromium.org/164873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251417 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251416 0039d316-1c4b-4281-b951-d872f2087c98

This is a clone of https://codereview.chromium.org/166753002/ + changes to handle OPT_RTP_SENDTIME_EXTN_ID in ipc_socket_factory.cc.

R=mallinath@chromium.org, wjia@chromium.org, xians@chromium.org
TBR=sergeyu

Review URL: https://codereview.chromium.org/167313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251415 0039d316-1c4b-4281-b951-d872f2087c98

Revert reason: cros unit test failures

See: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29

Sample output:

ersiveModeControllerAshTest.TabAndBrowserFullscreen (run #3):
[ RUN      ] ImmersiveModeControllerAshTest.TabAndBrowserFullscreen
Xlib:  extension "RANDR" missing on display ":9".
[21038:21038:0214/121606:1047752665:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
[21038:21038:0214/121606:1047752835:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
[21038:21038:0214/121606:1047752914:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
Received signal 11 SEGV_MAPERR 00020000002d
 [0x7f0b3aa767ce] base::debug::StackTrace::StackTrace()
 [0x7f0b3aa76cf8] base::debug::(anonymous namespace)::StackDumpSignalHandler()
 [0x7f0b34340cb0] \u003Cunknown>
 [0x00000379579c] PermissionBubbleViewViews::~PermissionBubbleViewViews()
 [0x00000373aafb] BrowserView::~BrowserView()
 [0x00000373ad69] BrowserView::~BrowserView()
 [0x7f0b38da5de2] views::View::~View()
 [0x7f0b38dbbcf0] views::NonClientView::~NonClientView()
 [0x7f0b38dbbd69] views::NonClientView::~NonClientView()
 [0x7f0b38da5bed] views::View::DoRemoveChildView()
 [0x7f0b38da5ce5] views::View::RemoveAllChildViews()
 [0x7f0b38da9dd8] views::internal::RootView::~RootView()
 [0x000003734aa0] BrowserRootView::~BrowserRootView()


> [WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed.
> 
> This bug meant that subsequent calls to AddRequest wouldn't show the bubble, since the manager still believed it was being shown.
> 
> R=leng@chromium.org
> 
> Review URL: https://codereview.chromium.org/162423002

TBR=gbillock@chromium.org

Review URL: https://codereview.chromium.org/167533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251414 0039d316-1c4b-4281-b951-d872f2087c98

This cl rearranges the directory layout for the memory_inspector tests.
This is to ensure that:
 - Every unittest lives side-by-side with the module being tested.
 - The mocks/helper class live in the unittest package.
 - Nobody has to hack the sys.path ever.
 - Every (test and non) module uses the "import memory_inspector.submodule"
   pattern consistently, without creating any namespace ambiguities.

BUG=340294

Review URL: https://codereview.chromium.org/167223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251413 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert, to see if this fixes CrOS MergeSession tests.

> Make all the files mapped in when running unit_tests read only on Linux and OSX.
> 
> This means no file can be opened for write during the test run.
> 
> Windows can't be done at the moment due to bug 342913.
> 
> R=vadimsh@chromium.org
> BUG=116251
> BUG=342913
> 
> Review URL: https://codereview.chromium.org/136973003

TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/166483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251411 0039d316-1c4b-4281-b951-d872f2087c98

In the LT2P/IPsec + user certificate VPN flow, if the UIData does not
contain any certificate properties, it is possible that the certificate
properties are still configured by shill (e.g. the properties were
previously configured and saved in the shill profile). However,
client_cert::IsCertificateConfigured() did not take that into account,
which caused NetworkConnectionHandler::VerifyConfiguredAndConnect() to
always throw a 'configuration required' error and the VPN configuration
dialog to pop up even when all the credentials information was
available. Also, VPNRequiresCredentials didn't check the from the
Provider.PassphraseRequired property to see if shill expects a user
passphrase for the VPN connection. This CL fixes these issues.

BUG=307665
TEST=Verified the following scenarios:
1. Add a 'L2TP/IPsec + user certificate' VPN with 'Save identity and
   password' unchecked. Connect to the VPN once and then reboot the system.
   Reconnect to the VPN and verify that it prompts for credentials.
2. Repeat 1 but with 'Save identity and password' checked and verify
   that it reconnects without prompting for credentials.

R=pneubeck@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/166063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251410 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [WebsiteSettings] Set view to null on manager to ensure no stale access. (https://codereview.chromium.org/162713003/)

Reason for revert:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23000

Original issue's description:
> [WebsiteSettings] Set view to null on manager to ensure no stale access.
> 
> R=leng@chromium.org, markusheintz@chromium.org
> BUG=343234
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251392

TBR=leng@chromium.org,markusheintz@chromium.org,gbillock@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=343234

Review URL: https://codereview.chromium.org/167613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251409 0039d316-1c4b-4281-b951-d872f2087c98

Wrap DocumentProperties into printing::CreateDevMode().

BUG=166587

Review URL: https://codereview.chromium.org/165993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251408 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we checked that GYP_GENERATORS was "ninja", but this
broke when using GYP_GENERATORS=ninja,msvs-ninja. As there are no
other supported genearators than those two now, there's no need
to check that we're using ninja at all, so just remove that
branch of the if.

BUG=323300
R=jschuh@chromium.org

Review URL: https://codereview.chromium.org/167373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251406 0039d316-1c4b-4281-b951-d872f2087c98

BUG=336614
TBR=thakis@chromium.org (since I "deleted" [read:moved] c/c/omaha/OWNERS, it needs an owner for those changes. cpu@ reviewed, deferred to sorin, who lg'd. But need an owner for CQ. Sorry for the convolution).

Review URL: https://codereview.chromium.org/153273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251403 0039d316-1c4b-4281-b951-d872f2087c98

Add a privet HTTP operation for reading the file contents, including the ability
to use range requests and save the contents to a file.

BUG=332182

Review URL: https://codereview.chromium.org/135513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251402 0039d316-1c4b-4281-b951-d872f2087c98

Apps, and NaCL, so that we can launch what we have now.

TBR=mkearney@chromium.org

Review URL: https://codereview.chromium.org/167573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251401 0039d316-1c4b-4281-b951-d872f2087c98

This brings Aura into line with Android behaviour.

BUG=334040
TEST=TouchEventQueueTest.*Suppression*

Review URL: https://codereview.chromium.org/163983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251400 0039d316-1c4b-4281-b951-d872f2087c98

Standalone functions replaced with InputDeviceSettings interface and
singleton implementation InputDeviceSettingsImpl.
Changing of input device settings became more efficient for two reasons:
1) InputDeviceSettingsImpl caches previously set values and doesn't
call tpcontrol/mousecontrol if client tries to set same values twice.
2) New methods for changing several settings at a time was implemented. For
example, If client wants to change several touchpad settings at a time,
he can use UpdateTouchpadSettings method that will result in one (or
zero) invocation of tpcontrol.

Implemented FakeInputDeviceSettings for use in tests.

These changes are needed for upcoming changes in chromeos::Preferences.

BUG=325564
TEST=manually
TBR=scheib

Review URL: https://codereview.chromium.org/147133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251399 0039d316-1c4b-4281-b951-d872f2087c98

This test is broken because it doesn't take into account that this
feature may be disabled by the blacklist (it is disabled pre-10.8.3 on
basically all vendors). It's only not failing on the main waterfall
because those bots have all features disabled, which the test does
actually handle.

TBR=zmo@chromium.org
BUG=314745
NOTRY=True

Review URL: https://codereview.chromium.org/164983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251398 0039d316-1c4b-4281-b951-d872f2087c98

[WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed.

This bug meant that subsequent calls to AddRequest wouldn't show the bubble, since the manager still believed it was being shown.

R=leng@chromium.org

Review URL: https://codereview.chromium.org/162423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251397 0039d316-1c4b-4281-b951-d872f2087c98

Failed on official build bots:

FAILED: /b/build/goma/gomacc cc -MMD -MF obj/sandbox/linux/suid/chrome_sandbox.sandbox.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -g -std=gnu99 --sysroot=/b/build/slave/google-chrome-rel-linux_64/build/src/chrome/installer/linux/debian_wheezy_amd64-sysroot -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables   -c ../../sandbox/linux/suid/sandbox.c -o obj/sandbox/linux/suid/chrome_sandbox.sandbox.o
../../sandbox/linux/suid/sandbox.c: In function 'ExitWithErrorSignalHandler':
../../sandbox/linux/suid/sandbox.c:63:3: error: ignoring return value of 'write', declared with attribute warn_unused_result [-Werror=unused-result]
cc1: all warnings being treated as errors

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/48305/steps/compile/logs/stdio

> Setuid sandbox: exit(2) on SIGABRT
> 
> The setuid sandbox waits on its one child and then dies
> afterwards.
> 
> When receiving SIGABRT, instead of dumping core, simply exit the
> process. There is no interesting information to be gathered from
> knowing that the process is inside waitid(2), one should look at
> the child process instead.
> 
> This patch is in hope to reduce red herrings.
> 
> BUG=334345
> TBR=jorgelo
> 
> Review URL: https://codereview.chromium.org/167293004

TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/167473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251396 0039d316-1c4b-4281-b951-d872f2087c98

I removed the "target_arm_thumb2" flag on the NaCl side, so this
change is necessary to update nacl_revision in DEPS.

Note that NaCl trusted code can still contain some Thumb code.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2224
TEST=nacl_integration
R=dschuff@chromium.org

Review URL: https://codereview.chromium.org/167323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251395 0039d316-1c4b-4281-b951-d872f2087c98

> Move the logic to update bounds for show type from WorkspaceLayoutManager to DefaultState
> 
> * Introduced WindowStateObserver::{Pre|Post}WindowShowTypeChange
>  We had implicit dependency between OnWindowShowTypeChanged implementations. This clearly separate the things that should happen before and after the window's bounds is updated.
> 
> This is another step to introduce state machine.
> 
> BUG=318325
> TEST=no functional change. all tests should pass.
> TBR=benwells@chromium.org
> 
> Review URL: https://codereview.chromium.org/149303003

This caused a failure on this bot:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10345/steps/browser_tests/logs/ActivateAfterSessionRestore

Here's the output:

[ RUN      ] ShelfAppBrowserTest.ActivateAfterSessionRestore
[3936:3936:0214/084215:8917601186:ERROR:audio_manager_pulse.cc(251)]
Failed to connect to the context.  Error: Connection refused
Xlib:  extension "RANDR" missing on display ":9".
[7:7:0214/084217:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: renderer.
[3977:3977:0214/164217:WARNING:sandbox_linux.cc(55)] Activated
seccomp-bpf sandbox for process type: gpu-process.
[3936:3936:0214/084218:8920849411:FATAL:window_state.cc(72)] Check
failed: false. No WMEvent defined for the show type:4
 [0x7f3255e5766c] base::debug::StackTrace::StackTrace()
 [0x7f3255ec617d] logging::LogMessage::~LogMessage()
 [0x7f32530bfa0b] ash::wm::(anonymous
 namespace)::WMEventFromShowState()
 [0x7f32530c0953] ash::wm::WindowState::OnWindowPropertyChanged()
 [0x7f324fe98662] aura::Window::SetPropertyInternal()
 [0x7f324fe6e5f1] aura::Window::SetProperty\u003C>()
 [0x7f32502503b3] views::NativeWidgetAura::InitNativeWidget()
 [0x7f3250258a21] views::Widget::Init()
 [0x000002c9a18c] BrowserFrame::InitBrowserFrame()
 [0x000002ca62cd] BrowserWindow::CreateBrowserWindow()
 [0x000002ba06a0] (anonymous namespace)::CreateBrowserWindow()
 [0x000002ba18c4] Browser::Browser()
 [0x0000014d986c]
 ShelfAppBrowserTest_ActivateAfterSessionRestore_Test::RunTestOnMainThread()
 [0x0000028f1208] InProcessBrowserTest::RunTestOnMainThreadLoop()
 [0x0000014e2ead] ShelfAppBrowserTest::RunTestOnMainThreadLoop()
 [0x0000047f4503]
 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
 [0x0000047f4f72] base::internal::RunnableAdapter\u003C>::Run()
 [0x0000047f4ebd] base::internal::InvokeHelper\u003C>::MakeItSo()
 [0x0000047f4de3] base::internal::Invoker\u003C>::Run()
 [0x000000c245d5] base::Callback\u003C>::Run()
 [0x000004a9a7f3] ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
 [0x000004a98c38] ChromeBrowserMainParts::PreMainMessageLoopRun()
 [0x00000408fd81]
 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
 [0x7f324800fd18] content::BrowserMainLoop::PreMainMessageLoopRun()
 [0x7f324801756e] base::internal::RunnableAdapter\u003C>::Run()
 [0x7f3248017164] base::internal::InvokeHelper\u003C>::MakeItSo()
 [0x7f3248016b31] base::internal::Invoker\u003C>::Run()
 [0x7f32483d8cf9] base::Callback\u003C>::Run()
 [0x7f324868587e] content::StartupTaskRunner::RunAllTasksNow()
 [0x7f324800f42e] content::BrowserMainLoop::CreateStartupTasks()
 [0x7f3248018046] content::BrowserMainRunnerImpl::Initialize()
 [0x7f324800ba0f] content::BrowserMain()
 [0x0000047f4469] content::BrowserTestBase::SetUp()
 [0x0000028f0380] InProcessBrowserTest::SetUp()
 [0x000001143b2f] ExtensionBrowserTest::SetUp()
 [0x000002a24f2c]
 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
 [0x000002a21109]
 testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
 [0x000002a15bcb] testing::Test::Run()
 [0x000002a16246] testing::TestInfo::Run()
 [0x000002a167a1] testing::TestCase::Run()
 [0x000002a1b213] testing::internal::UnitTestImpl::RunAllTests()
 [0x000002a260d7]
 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
 [0x000002a21e8f]
 testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
 [0x000002a1a201] testing::UnitTest::Run()
 [0x0000029131d3] RUN_ALL_TESTS()
 [0x000002912cec] base::TestSuite::Run()
 [0x0000028edcbb] (anonymous
 namespace)::ChromeTestLauncherDelegate::RunTestSuite()
 [0x000004846ddf] content::LaunchTests()
 [0x0000028ee00c] LaunchChromeTests()
 [0x0000016c75ca] main
 [0x7f32437e176d] __libc_start_main
 [0x000000b7f549] \u003Cunknown>

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/165953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251394 0039d316-1c4b-4281-b951-d872f2087c98

Update the list of supervised users in the import overlay
when the avatar of a supervised user is changed, or a new supervised user is created.

BUG=339060
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/140663014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251393 0039d316-1c4b-4281-b951-d872f2087c98

R=leng@chromium.org, markusheintz@chromium.org
BUG=343234

Review URL: https://codereview.chromium.org/162713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251392 0039d316-1c4b-4281-b951-d872f2087c98

The setuid sandbox waits on its one child and then dies
afterwards.

When receiving SIGABRT, instead of dumping core, simply exit the
process. There is no interesting information to be gathered from
knowing that the process is inside waitid(2), one should look at
the child process instead.

This patch is in hope to reduce red herrings.

BUG=334345
TBR=jorgelo

Review URL: https://codereview.chromium.org/167293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343692

Review URL: https://codereview.chromium.org/165113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340365

Review URL: https://codereview.chromium.org/165203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337426
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/166373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335790

Review URL: https://codereview.chromium.org/163633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333173
TEST=Changing between tabs with translate infobars for different source languages should redraw the infobars.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/138143023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251384 0039d316-1c4b-4281-b951-d872f2087c98

Previously if the file is opened from the gallery, it does not hanlde the case
that the window is opened in the desktop of the running proifle.

This CL adds lines to handle the case in the gallery.

BUG=336093
TEST=Execute a file handler task from the gallery in the teleported window.

Review URL: https://codereview.chromium.org/143153009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251383 0039d316-1c4b-4281-b951-d872f2087c98

Notable changes:
 * Make the EventRewriter a MessagePumpObserver. This is necessary to make sure
   that the event-rewrite happens before the event is dispatched.
 * Move the EventRewriter in chrome/browser/chromeos (and in chromeos namespace),
   since it does nothing on other platforms.
 * Get rid of the event-rewrite code from ash, since it just adds an extra layer
   of abstraction for no added value.

BUG=343639
R=derat@chromium.org, sky@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/165463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251382 0039d316-1c4b-4281-b951-d872f2087c98

NaCl uses 'minutes' to track the duration of builds.
Adding knowledge that shorter builds are better.

R=qyearsley@chromium.org
BUG=343607

Review URL: https://codereview.chromium.org/164923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251381 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
TBR=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/160573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335406

Review URL: https://codereview.chromium.org/140253008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251376 0039d316-1c4b-4281-b951-d872f2087c98

TBR=newt
BUG=326023
NOTRY=true

Review URL: https://codereview.chromium.org/165813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275292

Review URL: https://codereview.chromium.org/163433006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251374 0039d316-1c4b-4281-b951-d872f2087c98

Tasks need to be processed for painting to occur in other browser
windows while the modal dialog is up in Aura.

R=vitalybuka@chromium.org
BUG=342697,180997,343848

Review URL: https://codereview.chromium.org/164303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251373 0039d316-1c4b-4281-b951-d872f2087c98

We should not be sending a WM_MOUSELEAVE to the parent from the LegacyRenderWidgetHostHWND class when the parent has capture.

The LegacyRenderWidgetHostHWND class tracks WM_MOUSEMOVES to inform the parent when the mouse cursor moves outside the
bounds of the parent window. When the parent sets capture, Windows sends us a WM_MOUSELEAVE message. We should be ignoring this.

BUG=343844
R=sky@chromium.org
TBR=cpu

Review URL: https://codereview.chromium.org/166163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251370 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to see if this resolves a spike in update failures on
canary.

> Add quotes around executable pathes in the mini installer
> 
> BUG=340387
> TEST=N/A
> 
> Review URL: https://codereview.chromium.org/154113004

TBR=cdn@chromium.org

Review URL: https://codereview.chromium.org/167333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251369 0039d316-1c4b-4281-b951-d872f2087c98