- 21 Aug, 2019 40 commits
-
-
Donn Denman authored
Refactors the logic that allows insetting the Visual Viewport. Now the control is moved from RWHV to ViewAndroid and its delegates. This allows the setting to be established for an object with the same lifetime as a WebContents, so when a new RWHV is swapped in it will still apply. BUG=986384, 968150 Change-Id: I5cb3601ff460637f99e98a4edf090ad28321bc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714286Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689037}
-
Kevin Bailey authored
Adds -fsanitize=bool to the list of check flags. This adds code to verify that, when reading a bool, it is 0 or 1. Change-Id: I709eb462a53fc37014ed1fd261f783722e4ff2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699228Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689036}
-
Nazerke authored
Supports dark mode for tab grid. Bug: 988415 Change-Id: I1ceb5ae19e9480308b4df2a10b9716aad8e139a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726054Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#689035}
-
Andrew Lee authored
Change-Id: Ie7156b3b1e49b7dac4fa69c4b4f5ac089e6942c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762997Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Cr-Commit-Position: refs/heads/master@{#689034}
-
Elly Fong-Jones authored
TBR=marinaciocea@chromium.org Bug: 996235 Change-Id: I38b2c62887f708511baa3c0c2ae1a794246baaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762470Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689033}
-
Ryan Sleevi authored
As announced at https://security.googleblog.com/2019/08/protecting-chrome-users-in-kazakhstan.html Bug: 996164 Change-Id: Ibf0712105d6f86b283f73a15c7e45f4fecceb4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763229Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689032}
-
Adam Bujalski authored
This patch fixes one of three memory leaks found when page reloads NaCl module(s). In PepperPluginInstanceImpl ctor FrameHostMsg_DidCreateInProcessInstance message is sent to browser process, however message FrameHostMsg_DidDeleteInProcessInstance isn't sent from dtor. This is because PepperPluginInstanceImpl is created for unproxied module and later reinitialized as proxied one, which causes that PepperBrowserConnection::DidCreateInProcessInstance method is called in PepperPluginInstanceImpl ctor, however PepperBrowserConnection::DidDeleteInProcessInstance isn't called in PepperPluginInstanceImpl dtor. Bug: 922925 Change-Id: Ifb80108a99f591e7d30ec8013e94cef6d176eca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679692 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#689031}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/068e0cc6f357..78f41f5a6e33 git log 068e0cc6f357..78f41f5a6e33 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 zoddicus@users.noreply.github.com Fix some Python2 vs 3 issues in update_build_version.py (#783) Created with: gclient setdep -r src/third_party/shaderc/src@78f41f5a6e33 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Icd243637ad3a8a2bd4d7d01e33a80f87825892b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763941Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689030}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/92eb0415d0b1..f25a1c68473b git log 92eb0415d0b1..f25a1c68473b --date=short --no-merges --format='%ad %ae %s' 2019-08-21 capn@google.com Always rasterize lines as a rectangle Created with: gclient setdep -r src/third_party/swiftshader@f25a1c68473b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139755234 Change-Id: Id487fa7e4799a1ced86dbeecd14d51864174cf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763156Reviewed-by:
-
Alex Clarke authored
Split off from https://crrev.com/c/1751324 This test is no longer useful in the new model of consuming. Bug: 971191 Change-Id: I0bf1d55a1f801947f745f17e420926feb4af98e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760740Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#689028}
-
Sophie Chang authored
This is in preparation for supporting both the current and the Optimization Guide Keyed Service paths. The KeyedService path requires a navigation handle for any "CanApplyOptimization" decisions. Bug: 969558 Change-Id: If3b78c78d2ac655f114112bde24ef10673544009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762877Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689027}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e8ef87bdadcf..f69bd5f184cc git log e8ef87bdadcf..f69bd5f184cc --date=short --no-merges --format='%ad %ae %s' 2019-08-21 nisse@webrtc.org Delete AudioDeviceWindowsCore::WideToUTF8, replaced with rtc::ToUtf8 2019-08-21 sprang@webrtc.org Set local ssrc at construction of Rtp module 2019-08-21 hbos@webrtc.org Add implemented-but-missing members to RTCMediaStreamTrackStats::Members 2019-08-21 handellm@webrtc.org Simplify the VideoFrameDumpingDecoder API. 2019-08-21 sprang@webrtc.org Rename RtpRtcp::Configuration::media_send_ssrc to local_media_ssrc Created with: gclient setdep -r src/third_party/webrtc@f69bd5f184cc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:996146 Change-Id: Ia2a26f04d9cb7a59f8a93ef15664a21e12654e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763155Reviewed-by:
-
Christopher Thompson authored
We're removing the dangerous flag infobar for this for now in https://crrev.com/c/1760866. This change adds basic metrics for how common the use of SSLKeyLogger is. Bug: 991290 Change-Id: I74e932eef872c59f5b4c8b5de055a2197ac93f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761288Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#689025}
-
Jan Wilken Dörrie authored
This change implements logic rejecting forms with empty usernames for the leak detection feature. Also it adds a DCHECK that the password is non-empty. Bug: 986298 Change-Id: I178da166e0f7c0f9baa17ad6ed1452446c2e998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763692Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#689024}
-
Ian Kilpatrick authored
This patch was created by reverting: https://chromium-review.googlesource.com/c/chromium/src/+/1282724 And converting the tests to use promises, and switching the API to NG. I run the patch against the mac-bots a few times to determine if I could reproduced the flakiness which occurred initially to no avail. Bug: 726125 Change-Id: I5f6197699977c03d3efbd4ca0926815faabee19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761372Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#689023}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3f341e24. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I9a8825b4101ae3744135853985e51669915a54a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763870Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689022}
-
Alex Clarke authored
EXPECT_DCHECK_DEATH is flaky with promises. This patch wires up an alternate way of observing Promise API errors that still DCHECKS in normal code but has an escape hatch for AbstractPromiseTest which doesn't rely on fork(). Bug: 993723 Change-Id: I176cf9aa93703d3d03b7f1a25c4f68a4311d3fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762072 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#689021}
-
Matt Menke authored
The test was simulating the H2 server hanging up after sending an H2 challenge, and then negotiating a new H1 connection, regardless of whether net/ tried to negotiate H2 or H1 when re-establishing the connection. This CL keeps the H2 session open, and explicitly checks that when re-establishing a connection, we only try to negotiate H1. Bug: 996042 Change-Id: Icb2d0e39382f9173308582b19d836a9cd26f047f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762458 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#689020}
-
Chris Hamilton authored
BUG=971272 Change-Id: Iba0542b6233df32366ac895662a96a6a53e48802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758906Reviewed-by:
-
Kevin Ellis authored
This patch aligns the implementation of web-animations with the spec. Previously updates were performed via a PlayStateUpdateScope. This class depended on an extra state (kPending) that is not to spec. Support for microtasks is also introduced in this patch, which addresses most of the remaining timing issues with the finished state of an animation. Bug: 960944 Change-Id: I62aff2254d2b5265f869415e0f763e140b460c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739386Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#689018}
-
arthursonzogni authored
The GlobalRequestID used for a navigation request are generated by NavigationURLLoaderImpl::MakeGlobalRequestID(). Unfortunately, this is not what is used in TestNavigationURLLoader. Added in https://codereview.chromium.org/2885453003, the TestNavigationURLLoader simulates getting a new GlobalRequestID. To support the non-BrowserSideNavigation code path, it had to define GlobalRequestID::child_id to be the ID of the process that has initiated the navigation. With BrowserSideNavigation (aka PlzNavigate), this is now always -1, because the browser handle the navigation. The non-BrowserSideNavigation code path has been removed in M65. We can now use the NavigationURLLoader's GlobalRequestID() instead. Bug: 992846, 992846 Change-Id: I36b9058b4f6b369416a082278fc9274eaeae29f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748695 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#689017}
-
Edvard Thörnros authored
SMILTimeContainer::Elapsed() could return a negative time, this should not be possible anymore. Since if you now reinsert the SVG, it should resync. Nothing else should have changed. Bug: 996196 Change-Id: Id75b1604b8a087c5c046f842273cd8355075cb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763420 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#689016}
-
Finnur Thorarinsson authored
Bug: 993775, 860467 Change-Id: If9632021357c2deaf4e7dcfaa44f48e972f774fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760952Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#689015}
-
Guido Urdaneta authored
Add camera 05c8:0369 known to cause problems with MediaFoundation. Bug: 978852 Change-Id: Idb4b02e04514affa9e0d429aaf85b310435b2fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757937 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#689014}
-
Elly Fong-Jones authored
WebContentsSplitCacheBrowserTestEnabled.SplitCache is flaky under TSan. TBR=marinaciocea@chromium.org Bug: 995181 Change-Id: I411cae6ae40ac5c46b957cb26fa605aa720a7013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762457Reviewed-by:
-
Vadym Doroshenko authored
This CL introduces more proper processing of Chrome sign-in form and addresses TODO in code. Bug: 831123, 994291 Change-Id: I478d69d42d5f7da6f0f76035cce504480c67ea91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763412 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Darwin Huang authored
Avoid potential unnecessary copy by using emplace. No logic change. Bug: 995605 Change-Id: I5123038e6c032970c19787c8c11a64d671fcbeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763248 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#689011}
-
Jan Wilken Dörrie authored
This change integrates the leak detection feature with the Credential Management API. In particular, the CM API attempts to check a credential following a call to navigator.credentials.store(), which is used as a strong signal that the submitted credential resulted in a successful login. Bug: 991191 Change-Id: I37287cc3d7f6f2e67a2c22f3e5e7d35ff0498e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763671 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a622f6d5b9ae..206946fb061b Created with: gclient setdep -r src-internal@206946fb061b The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic5ea21aafc193c800aca09ab8986677450196f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763939Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689009}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80bff5b3a2d7..ea6c98081e94 git log 80bff5b3a2d7..ea6c98081e94 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 kjlubick@google.com Fix aggregators to use new gold objects Created with: gclient setdep -r src/third_party/skia@ea6c98081e94 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: Icaecf482d3cbb350af2c6da199febd1ec18c44fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763938Reviewed-by:
-
Tomasz Wiszkowski authored
Bug: 990865 Change-Id: I2e6535d6f7d33632b660a0f2a72b3c17a423bdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761343Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ender <ender@google.com> Auto-Submit: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#689007}
-
Marc Treib authored
It was unused. Bug: 955989 Change-Id: I7b5ede1608e69aad773a622ff4f1ef1d3d041f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763423 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#689006}
-
Brian Osman authored
This will create more color filters (and associated uniform data blocks), but fixes a bug where the offset + multiplier could change and we'd reuse the old (cached) values. Bug: chromium:795132,chromium:985500 Change-Id: I4628080989ba07653964baaedaea6fc246c8a348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762329Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#689005}
-
Rohit Agarwal authored
Clear browsing data under more tools is shown disabled for guest. This now extends for incognito as well. Bug: 965856 Change-Id: I35747ad8e2a8e1feb7a28509d4b154fe9d4918cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751783Reviewed-by:
-
Matt Menke authored
SetHttp2AlternativeService() and SetQuicAlternativeService() are convenience wrappers around SetAlternativeServices(). While they're currently only used in tests and cronet, which don't need NetworkIsolationKey support, add a NetworkIsolationKey parameter to reduce the chance future uses of the method overlook the need to add a NetworkIsolationKey. Bug: 969890 Change-Id: Ib26179c6a6562f391609408d95915e811492f31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757065 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689003}
-
Nicolás Peña Moreno authored
Bug: 994414 Change-Id: Ica33ea747b8985956ab791f9e55950f46016bda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762334Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#689002}
-
Denis Kuznetsov authored
Bug: 986498 Change-Id: Ifa44141709440e2f901f8357f0268f753ab67efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762228Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#689001}
-
Friedrich Horschig authored
For some unknown reason, the tining stopped working and icons assumed their untinted colors (too bright, too dark, too blue). Luckily, color filters still work. Things I tried (without success) before using color filters: - Use UiUtils method to retrieve tinted icons. - Defer the tinting until point of binding - revert a change that added a helper (IconProvider) which was the only recent change related to the icons. Why have we been using tints until now? Tints support ColorStateLists which automatically update colors when the tinted drawable is disabled, selected, etc. Since we don't need ColorStateLists here, the colors look as intended. Icon colors change only when the tabs are selected (which we have to handle anyway) and when dark mode is active. Screenshots? Look in a trybot run for ui_screenshots which opens the dialog. It will show uniform colors. Dark mode? Set compress_resources = false, enable the dark mode flag and set the Theme in settings. Screenshots are in the linked bug. Bug: 996126 Change-Id: I5c5020e622eef712d3b7879e524acadfff8316b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763676Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#689000}
-
Fritz Koenig authored
Left over from when DRM platform was switched to using a separate thread. BUG=none TEST=compile Change-Id: I017eb07494c957fdb88d4858f8edf5c139450362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762992 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#688999}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4aa6251e..880b6f75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I760155e79fc50090403d6a09db48c0d74bc5b943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763871Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688998}
-
