GitLab

Bug: 879208
Change-Id: I60eb7cf15b6817814addb6094ca1ff9c4c252b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1423352
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652389}

Bug: 919685
Change-Id: I8b890cf3601cdb2d2784b23b8f98f3929a7d7d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574878Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652388}

If BrowserSignin is set to Disabled (0):
  - "Already a Chrome user? Sign in" text will be replaced with "Skip"
  - The "signin-view" module will be skipped

Screenshot in bug.

Bug: 904875
Change-Id: I765cdf44513389111325c6aeb9c410707ac1c300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568316
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652387}

Bug: 848942
Change-Id: I55c8c9ba6c61dbdb5de894bbf8aadc1e98239d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571696
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652386}

This logic previously lived inside the NotificationManager making it
harder to test. By moving it to a separate class, the SharedPreference
logic can be tested more easily.

Furthermore, the new class supports versioning so that the information
stored in the SharedPreferences can be modified in the future in a
backwards compatible way.

Bug: 939026
Change-Id: I1953003ed3ef262c4aa7a5a038bc6d76875364bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568486
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652385}

https://chromium.googlesource.com/angle/angle.git/+log/d18c048ab5a6..85a239d09128


git log d18c048ab5a6..85a239d09128 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 jmadill@chromium.org Vulkan: Write docs on format tables.
2019-04-18 jmadill@chromium.org Vulkan: Rename Vulkan "Texture" format to "Image"
2019-04-18 jonahr@google.com Skipped tests not accumulated in dEQP stats output.


Created with:
  gclient setdep -r src/third_party/angle@85a239d09128

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: If1d5325d2e1819b4406aa5c79025adcca78fd02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574485Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652384}

Exposing it in the activate callback ensures that the portalHost is
exposed when the promise callback is executed.

Bug: 948118, 921776
Change-Id: Ie654fdefd3e75187a06e8c06eba3de52f8276ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548316Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652383}

Thanks to Eric Feiveson <ericfe@google.com> for suggesting to rely
on the typedefs in std::map<> which was critical for getting this working.

Bug: 947911
Change-Id: I2a73061698d45ace2eaf859534f696a86542d35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574820
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652382}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/86dcbc73338c..b76dd93cb5bb


git log 86dcbc73338c..b76dd93cb5bb --date=short --no-merges --format='%ad %ae %s'
2019-04-18 jrosenth@chromium.org chromeos-config: experimental/important changes


Created with:
  gclient setdep -r src/third_party/chromite@b76dd93cb5bb

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib27764b2a88be2ae7fdbef998133eb8c6256e399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574484Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652381}

Bug: 953090
Change-Id: Idd7b74c5e32ddb711910b9c178b1e33037c7ff48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570696Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652380}

Bug: 908139
Change-Id: Ib362d71f610a90fe094f3c4ed892ef578ebf85aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566417Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652379}

Change-Id: I8d9681685e2320626d44528ead716f44d1bc327e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572814
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652378}

BUG=933147
R=nhiroki@chromium.org,kinuko@chromium.org

Change-Id: I892b5dace7d56d55bd7087e75abc135793b7547a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569205
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652377}

DidUpdateState can be null if there is no key associated with a state
update. In these cases, since we only care about extracting the keypress
associated with edits, we can just ignore the DidUpdateState call and
return early.

Change-Id: I5a6ce0a5ef13b8afad89abf6dab3eaf39167e74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573083
Commit-Queue: Robert Lord <lard@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652376}

A callback is used to populate the DeviceInfo with the latest state
on support for SendTabToSelf feature on the device. The information is used
to determine which set of devices tabs can be shared to.

Change-Id: Ib0f9093ae20ff8fc05494222789107a215057d79
Bug: 937004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570478
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652375}

This will allow us to measure the performance difference and see
the difference in the user engagement metrics and extrapolate to
estimate the usefulness of bfcache.

One-pager: https://docs.google.com/document/d/10Ff_5oq7k-oYuXTTKdN0v_JKG3bU1GPgAWWF7i4nMvs/edit#

R=creis@chromium.org
BUG=954271

Change-Id: I54dfe4634739a6c1eb3d33eee5025ecfe8622945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572343
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652374}

This change ensures that observers are notified that the UsbService is
being destroyed as the very first step of the destructor, which
unfortunately means that an explicit call needs to be added as the first
line of every subclass destructor.

This allows the DeviceManagerImpl instance in the device service to
close all bindings before callbacks owned by the UsbService are
destroyed. Otherwise these trigger a DCHECK.

Bug: 953248
Change-Id: I0a05f29a6e759cb4340301b92f13ea90af76bcd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574142
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652373}

Function declaration (.h) and definition (.cc) orders should match.
Move them around so that they do match. Also, place helper functions
under the main read/write functions.

All changes affect only function declaration/definition order, except
changes marked with comments.

Change-Id: I546f8135e4f7ff9b597f31d316de64abda7deb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572759
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652372}

This change removes the flag and marks the feature for later removal.

Bug: 954178
Change-Id: Ieeb004efb6fed206109ee8e8dad5cb40f4e0fd17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572704
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652371}

This CL registered the database needed by notification scheduler in
leveldb proto.

TBR=peter@chromium.org

Bug: 930968
Change-Id: Ib397a706c0a91ca688f19bb98d022205b1e3ca14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566538Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652370}

Previously zx_handle_duplicate() was called with ZX_RIGHT_DUPLICATE.
This means that the duplicate handle cannot be used for anything other
than to create new handles. Fixed it to use ZX_RIGHT_SAME_RIGHTS.

Bug: 852011
Change-Id: I3e628430676e7da56044502c3142ed1c5600e2c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572371Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652369}

This reverts commit 1e6642b0.

Reason for revert: This change broke a translation extraction tool process outside of Chromium. It can probably be updated to handle the change, and better to not be broken in the meantime.  For details, see https://crbug.com/954348 : Translation extraction failure (components_strings.grd)

Original change's description:
> [omnibox] Add and load Pedal concept data for de, en, fr, ja, zh-CN
> 
> Previously, Pedal concept data was a singular resource in English but
> this CL restructures the resources to load localized data from a
> pak depending on selected language. Data for the first four non-English
> languages localized by the translation team is included.
> 
> Bug: 893183
> Change-Id: I0e88d23de65038720a4f3543613ff8bd83dc5444
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572526
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Orin Jaworski <orinj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652212}

TBR=tommycli@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,orinj@chromium.org

Change-Id: I0e3a37b3828b164f43275fa937e7a2a9d9a746bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574200Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652368}

TBR=zmo@chromium.org,magchen@chromium.org

Bug: 848093, 868561, 890227
Change-Id: Idb5362622787a3b32cfdfe5e585b71c92af4f7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574141
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652367}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b2943927c04..8dfc0bce4ac7


git log 7b2943927c04..8dfc0bce4ac7 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 btolsch@chromium.org Add openscreen gclient config copy-pasta


Created with:
  gclient setdep -r src/third_party/depot_tools@8dfc0bce4ac7

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I524f40b4f2c99256410e2e521d414b736591e095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574778Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652366}

Changes the behaviour of the Translate Manual Trigger entry so that the
page automatically gets translated when the entry is tapped.

Bug: 905816
Change-Id: I7cebd628039c1d45e66832f0381b6ec040f4f610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570528
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652365}

Clusterfuzz tries running this code with random inputs, and
we got a bug that one input made it time out - but the issue
was that the input was super large. It's not surprising that
it would time out if you give it enough nodes.

I set the limit at 500,000 nodes for release mode, which is larger
than any web page I've ever seen. For debug mode I set it at 50,000
nodes because larger than that can time out.

Bug: 944999
Change-Id: I50b57153876a65f92c5a88677bdffe64b8c7ae7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574622Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652364}

* This is branched off from: crrev.com/c/1524645

This CL implements a new inspector domain for WebAudio and inspector
agent class. In order to track activities of BaseAudioContext, a
tracker class (BaseAudioContextTracker) was newly introduced as a
supplement of Page object.

Bug: 837323
Change-Id: I90e8446f340c20ba0822de4723643185159717ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1456684
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652363}

This is a gtest equivalent of the private Python tests which simulate
assigning users to groups. The same expected results are hard-coded in
both places, to ensure the implementations match.

See internal change http://cr/243178499.

Change-Id: I1f70ab628f9579a450b54c90f8a7db7e2e6c1ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564645Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652362}

This includes implementation for supporting datagram APIs in the
RTCQuicTransport. Adds APIs to IDL, wires to P2PQuicTransport & adds
necessary implementation in JS binding code.

Bug: 874296
Change-Id: I402a3dbe742db3a9acb121d900de13137d3ec14c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567564
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652361}

+ Apply this to the VR dummy lib.

Bug: 921665
Change-Id: Iacb7d9125ec04fbf2baa678a44ca24a9731e80b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568245
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652360}

Implement BasicLoggingApi#OnTaskFinished, which will record the tasks
queuing time and executing time.

Bug: 924739
Change-Id: Icd54fc9dad6b2150180508e912699086fd0d2bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572554Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652359}

This is a reland of 2657e7df

Original change's description:
> Specify relative order of nodes in ukm.xml
>
> For each ObjectNodeType, specify alphabetization rules for all its child nodes types, which enforce their order relative to other types when pretty printed (sorting key is checked here: https://cs.chromium.org/chromium/src/tools/metrics/common/pretty_print_xml.py?q=_TransformByAlphabetizing&g=0&l=143). This patch fixes the issue where the pretty print script needs to be run more than once before the XML is sufficiently pretty for presubmit check.
>
>
> Bug: 801614
> Change-Id: I7e9076c8e55d300f346bde07db0b12d4c7533661
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561610
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Yue Ru Sun <yrsun@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#649863}

Bug: 801614
Change-Id: Ib209b5eb941348dee78c35c5614264999d69963d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564792Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Yue Ru Sun <yrsun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652358}

Manual roll + buildfix

https://android.googlesource.com/platform/external/perfetto.git/+log/3d46e0d12b17..7fa9a66b28ac

$ git log 3d46e0d12..7fa9a66b2 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 fmayer Remove gaps from intern ids.
2019-04-17 oysteine Exposed GetInProcessShmemArbiter() in ProducerEndpoint
2019-04-17 rsavitski heapprofd: large increase to spinlock timeout ~10ms -> ~1s

Created with:
  roll-dep src/third_party/perfetto

TBR=eseckler@chromium.org

Change-Id: I384ea91c0a5755a2b28d40b7001c231f7cb43bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574819Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652357}

This CL adds title, artist, and album names to MPRIS metadata. These
were left out of crrev.com/c/1562628 since there was a failing perf
unit test. However, it turns out the issue was just that the test
happened to use non-ASCII characters and this hit a DCHECK as we were
converting to ASCII. It turns out this conversion is unnecessary, as
MPRIS can handle wide strings. So this CL switches MPRIS to intake
base::string16s for the metadata so we can send the media session
metadata strings directly.

Bug: 951584, 952410
Change-Id: I3723554369d47041ac48e39a92bbd91c484eda21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566224Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652356}

Patchset 1: Simply reverts: https://crrev.com/c/1574143
Patchset 2: Edit commit message
Patchset 3: Adds a Finch flag and gates the GmsCore call
Patchset 4: Edit commit message

R=drubery

Bug: 954255
Change-Id: If518147b60b74d539d8a53e1e0a9b2492168ce82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574821
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652355}

The new exclusion space produced (for a layout result) gets its internal
derived geometry from the previous input constraint space.

However the patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1553646
... made it so we always copy the new constraint space into the layout
result first (moving hte derived geometry data-structure).

As such when we access the "old" input exclusion space, it didn't contain
the derived geometry data-structure.

This make MergeExclusionSpaces use the copied constraint space's
NGExclusionSpace instead.

Bug: 635619
Change-Id: If5c2c856af39ac6af7516713a7d90e41d08b3e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573523Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652354}

Also move ArcKioskSplashScreenView into arc_kiosk_splash_screen_handler.h.

Bug: 928555
Change-Id: I5f95c23cb11fa91e5a2380d4ab1e67fe50576971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566611
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652353}

Thr reported bug about NPE shows it is possible that
TabBrowserControlsState can be accessed before |Tab.initialize()|
is executed. This CL adds null checks in the class to make the call
no-op or return a reasonable default value when the situation occurs.

Bug: 953643
Change-Id: Ie38edba7d9a500f62735dfc9cc7f435ecf27604c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572982Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652352}

This reverts commit f4ba6c5b.

Reason for revert:
content_shell_test_apk failing on Android CFI
Example: https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/5101
FindIt analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/5101

Original change's description:
> java: Add a choreographer frame task trait
> 
> This is useful if you need to guarantee something like a layout pass has
> occurred before your task runs. Tasks posted with TaskTraits.CHOREOGRAPHER_FRAME
> will run next time there's a vsync and after all other ready tasks on the thread
> have run.
> 
> I put the trait under base because from what I understand there is some ui/ code
> that needs it but ui/ can't depend on content/.
> 
> Bug: 863341
> Change-Id: Ibcb7a843866c2b2c4f4394ebd18c8ef7aa33b5bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549114
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Karolina Soltys <ksolt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652215}

TBR=yfriedman@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,ksolt@chromium.org

Change-Id: I2340b5c6c7ce1ac41e87ef689470e798304eb8a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574939Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652351}

Change-Id: Idb4aac9c285643178bf2b06bec0e0039a15b10a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574363Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652350}