- 17 Jun, 2020 40 commits
-
-
Rachel Wong authored
After some discussion, we have decided that if the suggested content toggle is not present, then playstore recommendations will still be enabled. This change modifies the logic so that we disable playstore search only if both the following conditions are met: (a) The suggested content toggle feature is enabled, (b) The suggested content pref is disabled. Bug: 1079169 Change-Id: I15d542bec594b6ce3bdc8449fc09db1da43e9472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249280Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#779193}
-
Fergal Daly authored
This reverts commit 52e71572. Reason for revert: Test fixed in https://crrev.com/c/2248380 Change-Id: I6dc322d18627fd0a9638ec8d5c5073f1be4459ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248381Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#779192}
-
Yoshifumi Inoue authored
This patch gets rid of a space before <br> from "drag-in-iframe.html" to pass this test in both legacy layout and EditingNG for ease of enabling EditingNG. Space before <br> should be collapsed this test[1], but legacy layout does so and EditingNG does to follow the spec[1]. This differences isn't part of these test file to drag in <iframe>. [1] https://drafts.csswg.org/css-text-3/#white-space-property Bug: 707656 Change-Id: I42cc0f7b9cdc1c93dc64472669fc46c08b1a7c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248384 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779191}
-
Bartek Nowierski authored
Having make_unique (which calls malloc) won't work well once malloc starts using PartitionAlloc, due to reentrancy. Bug: 1086388 Change-Id: I037420ae3fa41f6340da38682c6a210b2b1ce33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246368Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#779190}
-
Peter Wen authored
Since cmdline-tools is now 2.0, it can be updated with DEPS changes according to the bot output: https://luci-scheduler.appspot.com/jobs/chromium/android-sdk-packager Fix NewApi issue in BackgroundTaskSchedulerJobService that was blocking this roll. Ignore two new lint errors: Instantiatable and MissingClass. Both of these checks require passing the transitive classpath, which we do not currently pass. Although we can consider turning these on, they do not seem to provide much value since if classes were missing then our compiles would already have failed (not to mention we have our bytecode checks). Thus ignore these two checks in favour of not slowing down lint any further. Bug: 1093896, 1069201 Change-Id: I14b59b18bb14de346a5cde5609caaad6c28826cd Fixed: 1093896, 1069201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246187 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#779189}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fbbd9ca81f96..a286a8469b97 2020-06-17 dberris@chromium.org operations: Add timestamps for extents If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: eseckler@google.com Change-Id: Iea458b30ac04b5764e23c416aa18892c41fbbe62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779188}
-
Yoshifumi Inoue authored
Get rid of a space before <br> in editing/selection/modify_move/move_{left,right}_word_05_{ltr,rtl}_multi_line.html This patch gets rid of a space before <br> from "move_{left,right}_word_05_{ltr,rtl}_multi_line.html" to pass these tests are both legacy layout and EditingNG for ease of enabling EditingNG. Space before <br> should be collapsed these tests[1], but legacy layout does so and EditingNG does to follow the spec[1]. This differences isn't part of these test files verifying Ctrl+Left/Right arrow key behavior. [1] https://drafts.csswg.org/css-text-3/#white-space-property Bug: 707656 Change-Id: If5f2224366d8e0832b3aa19ef1ba10c7ee232433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247945 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
tby authored
The Drive QuickAccess provider makes API calls to the backend, and each API call should first cancel any in-flight calls. Currently we do that by binding the call to a weak pointer, and invalidating all weak pointers before making the next API call. But this causes a bug: other parts of the provider rely on the same weak pointer factory for unrelated callbacks, which then get erroneously cancelled. This CL adds a second weak pointer factory, and splits the work between the two. This lets the API calls be cancelled independent of all other calls. Note I can only find one place in the codebase using two factories [1], but I can't think of an better fix here. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.h?l=1209 Bug: 1034842 Change-Id: I034c0fdaff580801bb147cbd1cba24d499bf0002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246002Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#779186}
-
Yoshifumi Inoue authored
This patch introuces |NGInluneCursor::PositionForPointInChild()| as replacement of existing verion with following differences: - It takes only one parameter |point_in_container|, because |child_item| is reduntant and as same as current cursor position. - It works both |NGPaintFragment| and |NGFragmentItem|. for preparation of the CL[1]. [1] http://crrev.com/2249278 [EditingNG] Make SelectionModifier:: {Next,Previous}LinePosition() to move editable to editalbe correctly Bug: 707656 Change-Id: If5605edd02bec664c331cecebc70c4723094ab56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247943 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Eric Willigers authored
We add a unit test for ShelfContextMenu involving a web app. Bug: 1086833 Change-Id: Ia853b273d8140d6ba2ca47bd98bc31b06d7d0b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249241 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#779184}
-
Francois Beaufort authored
This CL changes CameraHalDelegate::GetDeviceDescriptors on ChromeOS to advertise pan, tilt, or zoom support or no support depending on device capabilities. Test: https://ptz.glitch.me/ w/ Experimental Web Platform Features flag on a Krane device should prompt user with "Use and move camera". Bug: 934063 Change-Id: Ifb63658d3d2d79d89b432f13473ad0f0e95aae6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241542 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#779183}
-
Chris Hall authored
AX-Relnotes: N/A Bug: 1093651 Change-Id: Iabc78cb0eb2ca3f583cf5eeaf8c07502d50da280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239142Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779182}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3eb899a1e52d..a071cce7fd70 2020-06-17 nodir@chromium.org Roll lucicfg to 1.15.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0d5d31a96e009c4d56100065016992cb90c123fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249176Reviewed-by:
-
Jason Lin authored
This gives the buttons correct styling. Bug: 1094946 Test: manually install Change-Id: I537cc055d6d08f21ead400af5cedbfedc9398ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249239 Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#779180}
-
Rachel Wong authored
This change adds SuggestedContentInfoView, which is a notice in the launcher about Suggested Content. - Two synced prefs are added to ash_pref_names. One tracks whether or not the notice has been dismissed, and the other tracks the number of times the notice has been shown. - AppListViewDelegate/Controller manage these prefs and use them to check whether or not the notice should be displayed. The notice is displayed up to 3 times, and will not be displayed if it has been dismissed. - SearchResultPageView creates the notice if the conditions are met. - There are some layout modifications to PrivacyInfoView as the original parameters were not compatible with the longer text of this new notice. The layout changes should not affect the existing Assistant privacy notice. Bug: 1079169 Change-Id: I51f4b7d951edbfebf65e2fa9fdd6a9d64aef432c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226317 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#779179}
-
Hiroki Nakagawa authored
This CL adds the following time duration UMAs for 103 Early Hints experiment. - PageLoad.Experimental.EarlyHints.* - FirstRequestStartToEarlyHints - FinalRequestStartToEarlyHints - EarlyHintsToFinalResponseStart To record them, this CL captures the timing of receiving an early hints response in the new field on net::LoadTimingInfo in HttpStreamParser for HTTP/1.1 and SpdyStream for HTTP/2. HTTP/3 is out of the scope of this CL. This change is tested as follows: - Unit tests are available on both HTTP/1.1 and HTTP/2 (see http_stream_parser_unittest.cc and spdy_stream_unittest.cc). - Browser tests are available only on HTTP/1.1 because seemingly there are no handy ways to serve HTTP/2 on browser tests. Protocol specific parts are quite small, so the lack of the test coverage here should be fine. - The CL author manually tested the UMAs on HTTP/2. Change-Id: Id764751ed6851d0584d20ee6ef56f3d4e1409b70 Bug: 1093693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228634 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#779178}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592324603-595a5101027449adb0c10d8dfc4b4a112ba8b2ae.profdata to chrome-win64-master-1592351803-4940076c03ac19da5d52d5b5b79c0e1485ea8a61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id79c24e620521974d933114a39b77b60768a3348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246275Reviewed-by:
-
Weiliang Chen authored
|gpu::GpuTaskSchedulerHelper| is the interface to post tasks to the gpu thread that is shared by the output surface and the overlay processor. The ownership used to be managered by a scopred_refptr. Since viz::Display owns both the output surface and the overlay processor, move the shared gpu task scheduler to be owned by display as well. This will make |viz::Display| the single owner of this class, and this will make the lifetime of this class easier to understand. R=rjkroege TBR=kylechar Bug: 1093440 Change-Id: Ie5f3760ca6c7ee61e9adf6ce56eb3904f1b8d1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237996 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#779176}
-
Yunke Zhou authored
Bug: 1093221 Change-Id: I90e10e03e512ed2d984a903f2bb9ea77a6eff2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238930 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#779175}
-
Lambros Lambrou authored
This adds a VP9 codec with profile-1 support (lossless-color) to the WebrtcDummyVideoEncoderFactory. This also prepares for Chrome profile-1 support by setting the video stream to be unidirectional (sendonly). Bug: 706220 Change-Id: If3b86cebf998c5eda10e799a39373ad02d3ca774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240454 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#779174}
-
David authored
The changes in crrev/c/2239427 didn't use `--full` so it didn't format the last brace because it didn't think that was part of the diff. Bug: 996088 Change-Id: I637af5dd649545b75e84a1eb17f23429ebc477d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247936 Commit-Queue: David Lei <dlei@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Auto-Submit: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#779173}
-
Meilin Wang authored
Bug: b/158617675 Test: manually. Change-Id: Ibdb1b3bfdba72bb5eefbe1f841614e2fe3b10b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248924Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#779172}
-
calamity authored
This reverts commit 9c48a1c1. Reason for revert: Causing PDFExtensionAccessiblity tests to fail on Mac Debug. Example: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/18910 Change-Id: I8cdb44fb3a44257cdc61637ae1443aedf60822af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247941Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#779171}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9edc4da71626..7d12eb78c7c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071603,chromium:1083023 Tbr: calamity@google.com Change-Id: Ifcf6aeb966516a86249a1cc28efaff1e1ebe1e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779170}
-
Wan-Teh Chang authored
The bitmap_.setInfo() call in ImageFrame::AllocatePixelData() cannot fail. Assert that it succeeds. Change-Id: If58c6b2a750d1fdd0a9294386f9b1d28646eebcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248722Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#779169}
-
Nnamdi Theodore Johnson-Kanu authored
Change-Id: Idad74ffbdf2e288b00edf67160a73cc274ea4da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246785 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#779168}
-
calamity authored
This reverts commit 91f3b4a4. Reason for revert: Causing compile failures on win32-archive-rel https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/14033? TBR=dstaessens@chromium.org NOTRY=true NOTREECHECKS=true Change-Id: I7132deb1a4677d045a4c48f9a34a3e6d14c63d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249243Reviewed-by:
-
Min Qin authored
Chrome could launch an intent that targets itself. However, the initiatorOrigin and isRendererInitiated is not passed in the intent. As a result, when handling the incoming intent, Chrome will treat the intent as a fresh new navigation, which could cause some security issues. BUG=1092451, 1092025 Change-Id: I17a743861f081f4095c7d2688de164d07b104325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240040 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#779166}
-
Clark DuVall authored
This infobar will be used in WebLayer when popups are blocked. This CL componentizes the infobar delegate, and adds support to WebLayer for showing the infobar. Bug: 1019922 Change-Id: I21d0f0e40dac6af5f4c8e3d5a4067906f64a009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248075Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779165}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ief3921dd8e14816ae99fc10c6117c5f3441f6778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247214Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1073280 Change-Id: Ib0a2b3fdeec525c18ad7de78eafbd276977bbe29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238670 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779163}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4615971566e1..763957e6b4fc 2020-06-17 capn@google.com Ignore rasterization state pointers when rasterization is disabled 2020-06-17 capn@google.com Zero-initialize the context state and data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If501e80eb87d8ff218cae5cae5c84e226f7c05d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246274Reviewed-by:
-
Ella Ge authored
This CL adds a Uma metric to log error code when we gets location data from TWA client app. The added metric is similar to "Geolocation.LocationUpdate.ErrorCode", but more TWA version, to record how often we get an unexpected error with location delegation. This CL also adds a extra validation when we get new location data from TWA client app. If the geoposition is invalid, give it an error code. Otherwise it may fail a dcheck later in the pipeline because its position.valid == false and error_code == NONE. Since it's possible that TWA client app might feed invalid data format, we don't want to fail the dcheck or provide incorrect error code to javascript in that case. Bug: 1069506 Change-Id: Ib7dad8675ca9479d4da55d3f55c4eef24b086916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242891 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#779161}
-
Fergal Daly authored
It breaks All/RenderFrameHostManagerTest.DontSelectInvalidFiles. After re-enabling the content_browsertests --gtest_also_run_disabled_tests --gtest_filter="All/RenderFrameHostManagerTest.DontSelectInvalidFiles/0" --gtest_repeat=20 passes with this revert. Bug: 1094938 Change-Id: I965b7d604f8df277e631de938ebebee3ac898023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248380 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f4e6ae915eda..68fcfea37140 2020-06-17 timvp@google.com Vulkan: support format aliasing in texture images 2020-06-17 m.maiya@samsung.com Optimize thread specific storage and retrieval with native ASM 2020-06-16 joefspiro@google.com Fix includes to fuchsia headers 2020-06-16 timvp@google.com Remove ProgramExecutable::mProgram[Pipeline]State If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: Build/CQTest: Test: dEQP-GLES31.functional.image_load_store.*.format_reinterpret.* Change-Id: I4d8641623c68aeaed112a7c6007c1c56f80f4271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248929Reviewed-by:
-
Yu-Hsuan Hsu authored
The change is related to CL:2209009. Add histogram information in histograms.xml to make the histogram visible on chromedashboard. BUG=b:157116480 Change-Id: I351563cf94b6c960646337bfd21cca347e81b6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245854Reviewed-by:
-
Hirokazu Honda authored
This adds BitstreamFileWriter, which saves given bitstream in H264 AnnexB format for h264 and ivf format for vp8 and vp9. It enables saving the bitstream encoded by VideoEncodeAccelerator with --output_bitstream option in video_encode_accelerator_tests. Bug: 1045825 Test: video_encode_accelerator_tests --dump_bitstream on eve Change-Id: I78da9b53791599b9672c683afbe29b3f8cf8787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214870 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#779157}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I562f831f2a66596db52007f6b33f7543aa66c6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249044Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779156}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia0140e53dcd5f66735bcd44a6bca6395df28a177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248804Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f08a82b52dbf..de980231f62c 2020-06-16 csmartdalton@google.com Add a test for wide butt caps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I72bfc1e3e2bd6fab1a99a33c308d3c0bf54e43e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246273Reviewed-by:
-
