- 28 Mar, 2019 40 commits
-
-
Michael Giuffrida authored
Allow a few debug commands in KioskNext when --ash-debug-shortcuts is on the command line. Bug: 932054 Change-Id: Id27b9abe9ff6901355d512b6439785751399ec7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542782 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#645384}
-
Alexander Alekseev authored
This Cl removes unused "screen header" elements. Bug: 926638 Change-Id: If43bd996bf6cce70e5a7f760edef6b5a138906dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542729Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#645383}
-
Eugene But authored
Add missing expectation for DidChangeBackForwardState callback. Bug: 899827 Change-Id: I1977a31ea43ceb799ec155d6d35127613003f332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542560 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#645382}
-
A Olsen authored
Instead, use InstallAttributes. InstallAttributes is the better high-level interface to use and it can easily be stubbed during a test. Bug: 836857 Change-Id: I2910aaeb0c86dcab47bb74e42d46671afe92630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541057 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645381}
-
Adam Ettenberger authored
1. Add AXPlatformNodeWin::GetTextAttributeValue which is used to query the TEXTATTRIBUTEID 2. Implement AXPlatformNodeTextRangeProviderWin::GetAttributeValue a) Get all anchors in the range b) Query the TEXTATTRIBUTEID on each anchor b.1) If all the same value, return that value b.2) If there's multiple values, return a reserved mixed value b.3) If none support it, return a reserved not supported value 3. Implement UIA_IsHiddenAttributeId Bug: 847971 Change-Id: I7e315ab8ec2c01de62aa8cce51a697464424fc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542575Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#645380}
-
Dirk Pranke authored
Now that we can use CIPD to install GN binaries, we can finally roll GN and catch up w/ multiple months of changes :) https://gn.googlesource.com/gn.git/+log/0790d304..b85982b b85982b3 visual_studio_writer: Make OutDir equal to $(SolutionDir). 9434c3d2 Make gen.py compatible with python3 b199e54b [docs] : Split 'gn help' heading and usage summary when exceed 80 cols 5bc90b63 stdout: use dim colors 24411bec Make gn check faster 3941394b [docs] regenerate docs/reference.md 93ac4e04 Some documentation of gn check --check-generated fd1532f2 [docs] Fix Markdown format missing ` 74657a61 Add gn check --check-generated to check dependencies of generated files 6b943827 Fixed typo (missing parenthesis) in get_path_info documentation d062e74f Improve config documentation. e15f243a gen.py: Pass -pthread, not -lpthread, in ldflags. 013513c9 gn recipe: Do not pass libraries in LDFLAGS in the Linux recipe 1152229e gen.py: Pass -pthread via ldflags, not libs 01237e9c Remove references to ARM-optimized math implementation 0ac93dd2 For proper order put -lpthreads as a 'library' not a 'linker flag' 1ab6fa2c Attempt to unbreak build with MSVC 15.8.4 082fbe39 Pass -lpthread when linking instead of -pthread d69a9c37 [help] Fixing help issues. 04685d69 Add --dump-json-tree option for format subcommand. 57586fdb Suppress warning on VS2017. 4dcd2776 Port to FreeBSD. 5519dc2f Reintroduce the ICF flag, turn it on for bots 53107bfc [infra] Update XCode version 377ad041 Enable LTO for release builds 282a428c Disable ICF on Darwin, make it default for Release 71b537ce [format] Extend `gn format` to take a list of files. b5a2ac6e Improve help output. d837047a format: Ensure that formatting always reaches a fixedpoint in one run 8ed01d3b Docs: regenerate docs d84a862e More efficient Value implementation. bcfb6471 cleanup label_ptr.h 88bd8a8d build/gen.py: Add --no-strip option. 894143c3 format: Fix incorrect dewrap of `if` 45314e29 [metadata] Return metadata in postorder. e49432fa [metadata] Actually collect the metadata c1780c21 [metadata] Allow specification of rebase dir 5a9e0a2c [metadata] Adding metadata vars to write_data target d021d391 [metadata] Add generated_file target type 27b66b57 Allow whitespace in include directives. c6841d31 Fix a crash on invalid on `not_needed(scope)` without a 2nd argument. 54be6f11 Allow NOSORT to be the last line in a comment in addition to the first. a07831bb [metadata] Adding `meta` command 0587778f [metadata] Walk function 96c77296 [metadata] Add metadata walk to target a27e8dc0 [metadata] Adding basic metadata walking 2000587b [metadata] Adding metadata output to gn desc 0e1b8843 [metadata] Adding metadata variable to target ecc95221 Add links to the "Using GN build" presentation. 13ac6ca4 Test that not_needed works with forward_variables_from Change-Id: I8db493df2a27c9b8ffe066a11179ffedb2b0f47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522549 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#645379}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e5cc85b5c53f..20393ee9b7ba git log e5cc85b5c53f..20393ee9b7ba --date=short --no-merges --format='%ad %ae %s' 2019-03-28 nisse@webrtc.org Delete all stats-related logic from VCMJitterBuffer. 2019-03-28 kthelgason@webrtc.org Adds workaround for audio not restarting after interruption Created with: gclient setdep -r src/third_party/webrtc@20393ee9b7ba The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5acc50e8e9f99d5feabfe9fefccc798c6206b0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543421Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645378}
-
Hans Wennborg authored
This allows the compiler to run a little faster. Clang will still be running with assertions enabled on the Clang tip-of-tree waterfall to catch regressions in Clang, or to catch existing asserts getting triggered by code that's checked into Chromium. Below are build times (each build was run twice to warm up the cache, and the second build time was noted) of the 'chrome' target configured with 'is_debug=false is_component_build=true'. Linux ----- asserts enabled: real 43m51.506s user 2304m36.334s sys 93m34.650s asserts disabled: real 36m37.976s (-16%) user 1910m47.627s sys 87m37.474s Windows ------- asserts enabled: peak memory: 2341.99MB real: 64m3.234s qpc: 3843245179us asserts disabled: peak memory: 2343.40MB real: 50m59.093s (-20%) qpc: 3059111587us Mac --- asserts enabled: real 175m19.768s user 3960m35.641s sys 168m42.376s asserts disabled: real 148m50.279s (-17%) user 3336m16.310s sys 171m51.878s It also reduces the size of the Clang package: 59M clang-356356-1-linux.tgz 33M clang-356356-1-mac.tgz 57M clang-356356-1-win.tgz 50M (-15%) clang-356356-2-linux.tgz 28M (-15%) clang-356356-2-mac.tgz 45M (-21%) clang-356356-2-win.tgz Bug: 896306 Change-Id: I26068467119065a9d381f7f97f8dfac1defeb309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532107Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#645377}
-
Hwanseung Lee authored
SchedulePaintType was used to only argument of a function. and it has only two values. so it is possible change to bool arg. the change will make more shorter code at overall. and inlining all of BoundsChanged() into SetBoundsRect() to make this code clearer. Bug: 940736 Change-Id: I14bd47155aef0e71c9c17f9fd693901f1bd2bd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530504Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#645376}
-
Lukasz Anforowicz authored
Bug: 941230 Change-Id: Ibd8e2cfec9d1859a192e82332453fabbbee67b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531396 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#645375}
-
Anastasia Helfinstein authored
Bug: 946616 Change-Id: I5fa49fe568ab0aecbd2b270c32a714c463d92605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542162Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#645374}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68845f14d6d5..4dca0a0b7aaf Created with: gclient setdep -r src-internal@4dca0a0b7aaf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: Ieed2304f16e54ef736bed00694dad38df1b01bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541747Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645373}
-
Xianzhu Wang authored
Collecting them (after crrev.com/c/1512765) caused element id collision between element ids of the scrollbar layer and the effect nodes of the scrollbars. We should probably skip setting element ids of scrollbar layers in the future, but the element ids are still required even in layer list mode in LayerTreeHost::ApplyScrollAndScale(). Not collecting them won't break animation because scrollbar animation is controlled by cc::ScrollbarAnimationController instead of the classes under cc/animations. Bug: 946397 Change-Id: I8a713588e1ee3073b82ef5d8a95b296ff77747ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542460Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#645372}
-
Greg Kerr authored
To make the macOS V2 sandbox more robust, allow access to CoreTypes.bundle. Bug: 871280 Change-Id: I0de730ace30a18f3c3d8a3c12b13d2e968056ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540543 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#645371}
-
Sadrul Habib Chowdhury authored
BUG=none Change-Id: I62430a543623f957a7be1bc197b05978cc1bce76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543457 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#645370}
-
Miguel Casas authored
This CL renames the files and classes: s/{Vaapi,V4L2}JpegDecodeAccelerator/{...}MjpegDecodeAccelerator/ Also adapts the GpuJpegDecodeAccelerator factory file and renames the file+class FakeJDA. No new code intended, just semi-mechanical renames. Bug: 932860 Change-Id: Ib1c87de9edec0172531f41bfa59b63c96d8c7283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536008 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#645369}
-
Nicolas Ouellet-payeur authored
After the 'linux-annotator-rel' buildbot successfully validates the annotations, it will write annotation contents to a Google Sheets document. This is not modifying the original spreadsheet (just a copy of it), so we can test that the script works. Bug: 878759 Change-Id: Ia4c8096b200d9025d32ed869295e0c5620beb48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521240Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#645368}
-
Mark Yacoub authored
If a candidate content has not changed for 3 frames, do not promote it as Single On Top overlay as it can be just be flattened, allowing other strategies to kick in if possible. Bug: 885180 Test: SingleOverlayOnTopTest.DoNotPromoteIfPreviouslyPromoted Change-Id: I516dab628c129fe9fae09c713e2783a6ce889c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521591 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#645367}
-
Egor Pasko authored
Welcome! Bug: None Change-Id: I239dcf3730387dbb8b6f6e29f0a1138069485c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541170 Commit-Queue: Egor Pasko <pasko@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#645366}
-
Mike Dougherty authored
Bug: 733452 Change-Id: Ia98355334322eec4875200e2dec600fe79ebbd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542959 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#645365}
-
Mitsuru Oshima authored
This introduces PresentationTimeRecorder, which records the longest time between the time UI changes are requested and the time thoese changes are presented (~ user perceived latency). * Window/Tab dragging in overview mode * Launcher dragging * Divider dragging in splitview Bug: 923159 Test: covered by unit tests. more test to be added. Change-Id: Ic08bca5bc9cb06f0a25ffe7811524819618432c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1453364 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#645364}
-
Mohamed Amir Yosef authored
This is the first step in the effort of refactoring the ClientTagBasedModelTypeProcessor. Bug: 947044 Change-Id: I18acf64ba4edbd8e87cef08754be9460384db078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543510 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#645363}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/94f195b18776..0839cbda698f git log 94f195b18776..0839cbda698f --date=short --no-merges --format='%ad %ae %s' 2019-03-28 sugoi@google.com Proper mipmap size allocation for compressed textures 2019-03-28 sugoi@google.com Add support for compressed image copy Created with: gclient setdep -r src/third_party/swiftshader@0839cbda698f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I31964caf3e35d82fbe9691e8a2b37ae153ff8923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645362}
-
kyle Ju authored
Create a TestExpectation file and implement the logic where webdriver runner is able to read and compare existing expectations with test results. Bug: 881513 Change-Id: Ib829eed2c90223d1d861de460f3b0477b37befc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478932Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#645361}
-
BUG=762641 TBR=malaykeshav@google.com Change-Id: I2564fd05560038fde9532f9ba5c183897d208d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543669Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645360}
-
Roman Sorokin authored
Change-Id: Id9cf817d2ed48f35cdf0fca65ff061ab004fe587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543260Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645359}
-
Kush Sinha authored
The current dimensions sometimes cause the Chrome OS Account Manager's account addition modal to overflow the screen. Bug: 944186 Change-Id: I7960863e9b40c39a40151dc07c12fec193661382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539998Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#645358}
-
Adam Rice authored
Mark 15 web tests in external/wpt/fetch/sec-metadata as flaky. BUG=947023 TBR=mkwst@chromium.org Change-Id: I9edc49cd107dad8bab8e567e881238ee98b050a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543470Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#645357}
-
Marc Treib authored
This CL extracts helper functions GetEnterPassphraseBody and GetFullEncryptionBody, which makes PeopleHandler::PushSyncPrefs quite a bit more readable. One small behavior difference is that before, the "fullEncryptionBody" string was populated even if the passphrase type was IMPLICIT (i.e. no actual Sync passphrase in use), but a passphrase *date* was set. That situation should never occur in the first place, but if it did, then passing that string made no sense anyway. Bug: none Change-Id: I31631483ef14159636846bcf470dfcc74770a8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543259Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#645356}
-
Xiaoqian Dai authored
When a tab is dragged out from a browser window, a new browser window will be created for the dragged tab and then be activated, in this case SplitViewController should ignore the newly created window. Bug: 945935 Change-Id: I46aeef2abe7c0debee4b73a3d9a7a530fb31aa0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542472Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#645355}
-
Tommy C. Li authored
Now that kPreferHtmlOverPlugins feature has launched, enabled by default, and now removed from the code as a flag, we can delete this abstraction. This folds the mapping of ASK => DETECT logic into PluginUtils directly and cleans up the callsites. This CL should not change Chrome's behavior in any way. Bug: 945035 Change-Id: I4298aed3b4c5f95e4323cb658c9d42ead6c31cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542496Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#645354}
-
Hui(Andy) Wu authored
For some verticals we need to show the original image when user clicks on the image view in autobot bottom bar. It's a legal requirement. This CL implements such a dialog, but it's not shown by default. Future CLs should look into server response and check if the dialog should be shown. This does not exist today within server responses. Screencast when dialog is shown: https://drive.google.com/file/d/1kBlhITBLDte70JwVSyWy5fUL88xyhHOd/view?usp=sharing Change-Id: I02d53b08aa0b9979e46824fb220642dd73ed3e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536798 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#645353}
-
David Tseng authored
Bug: 946839 Change-Id: I9835ca0e969844e1a9a95ba0fb6b5422d7fc48bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542616 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645352}
-
Ahmed Fakhry authored
In preparation for removing the overview's shield widget, this CL extracts the DesksBarView into its own widget. BUG=866622, 942759 TEST=Manual, DesksTests still pass. Change-Id: Ic378e113dae4b7abdc1ce856655b74cfcd3337d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542664 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#645351}
-
Eric Stevenson authored
The generated bundle wrapper scripts don't change when the Python deps of the wrapper scripts are modified. This means that targets that depend on the wrapper scripts won't be rebuilt when Python deps of the wrapper scripts change. This CL changes create_bundle_wrapper_script.py to have a dependency on apk_operations so that the generated wrapper will be regenerated when Python deps change. Change-Id: I34d8fec0c324b19b6ffa39977668656088714ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543460Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#645350}
-
Eric Seckler authored
So we don't lose all data if the trace buffer wraps in ring-buffer mode. Bug: 928738 Change-Id: Ide4bed08f5209a94d00eb3347a567d1754b9c638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541786 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#645349}
-
Natalie Chouinard authored
This feature no longer needs a flag in chrome://flags. The feature can still be configured for debugging via command line flags: --enable-features=KeepPrefetchedContentSuggestions --disable-features=KeepPrefetchedContentSuggestions Bug: 946782 Change-Id: Id8f6d67f91b64b6a96199ba0879a270fbe67d6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541672Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#645348}
-
Lindsay Pasricha authored
Bug: 946891 Change-Id: I242023b9581a7e0e6515f5b2cac93e27cee887f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542428Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#645347}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/590a1c7799c9..9f16288b21a4 git log 590a1c7799c9..9f16288b21a4 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 lalitm@google.com Merge "perfetto: fix compile in GCC, debug and logspam in tests" 2019-03-28 fmayer@google.com Allow to specify heapprofd shmem size in config. 2019-03-28 fmayer@google.com Merge "Indicate whether process disconnected during profiling session." 2019-03-28 treehugger-gerrit@google.com Merge "protos: Deprecate ChromeTraceEvent & fix TrustedPacket field type" Created with: gclient setdep -r src/third_party/perfetto@9f16288b21a4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If7504aba9e35f700d9601f09dde4dca8d88d7b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645346}
-
Patrick Monette authored
A recent change made it so that only modules loaded in certain process types are considered for both the IncompatibleApplicationsUpdater and ModuleBlacklistCacheUpdater, but the tests were not updated. Bug: 946999 Change-Id: I522f7bbf00eb239de59a9e7401f74a6183f35d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542427Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#645345}
-