GitLab

it's not necessary after 7a379f73

Bug: none
Change-Id: I0bb31204eafcd258ce42be06f6da3b300e8125de
Reviewed-on: https://chromium-review.googlesource.com/889380Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533135}

Bug: 803700
Change-Id: Ie88645a2ec0244b6f5870fdb3187087e918e8855
Reviewed-on: https://chromium-review.googlesource.com/884561
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533134}

When PWA menu buttons are visible in the title bar we fail to animate the
minimize button to the correct position when exiting tablet mode.

This CL fixes the bug by removing the assumption that the minimize button
is the left-most button and generalises the slide animation to all buttons
left of the size button.

Bug: 802144
Change-Id: I8ad560c966f9b0fa04beabcf6b96850fe784b5aa
Reviewed-on: https://chromium-review.googlesource.com/892186
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533133}

The test is timeout-flaky.

TBR=rdevlin.cronin@chromium.org

Bug: 807471
Change-Id: Ie70d0217c21ce9ed3ae1c1a79b6a030dd70886f5
Reviewed-on: https://chromium-review.googlesource.com/894736Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533132}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/7f07816e463d..476698afdd0b

$ git log 7f07816e4..476698afd --date=short --no-merges --format='%ad %ae %s'
2018-01-09 shenghuazhang [ndk] Add android ndk deps in native_client/SConstruct
2017-10-12 tandrii Remove Rietveld CQ config.

Created with:
  roll-dep src/native_client


The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mseaborn@chromium.org

Change-Id: I045e06e136ddd154a84cfd5e3500758fa7c0522b
Reviewed-on: https://chromium-review.googlesource.com/894187
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533131}

This reverts commit 39dfc337.

Reason for revert: Switching V8 to use page_allocator is blocked on removal of RWX permissions on that side. Reverting this temporarily so we can switch V8 to page_allocator.

Original change's description:
> [page_allocator] Don't allow read/write/execute permissions.
> 
> - V8 is moving to a read/write read/execute system. We won't need
>   read/write/execute and should remove it from Chrome now.
> 
> Bug: chromium:756050
> Change-Id: Icc8a3ec334535c460e74a413cb265de2872db9f5
> Reviewed-on: https://chromium-review.googlesource.com/822514
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523663}

TBR=palmer@chromium.org,bbudge@chromium.org,haraken@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:756050
Change-Id: I3fd2b0172822af0ce7e5cf003c53f0b6f69305e8
Reviewed-on: https://chromium-review.googlesource.com/893609Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533130}

ContentViewCore::UpdateFrameInfo() must receive positions and sizes in CSS pixel
except top_shown_pix. When --use-zoom-for-dsf is enabled, those values given to
ContentViewCore::UpdateFrameInfo() are in physical pixel. It results in test
failures of ContentViewScrollingTest#testOverScroll and
ContentViewScrollingTest#testScrollTo. This CL scales down those values given to
ContentViewCore::UpdateFrameInfo() by the device scale factor.

TEST=run_content_shell_test_apk -f ContentViewScrollingTest#testOverScroll
(and ContentViewScrollingTest#testScrollTo) on NEXUS 5X

Bug: 737777
Change-Id: I95be3ed63d569ec9d620fa431c0d6bfa932410ba
Reviewed-on: https://chromium-review.googlesource.com/888183
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533129}

https://pdfium.googlesource.com/pdfium.git/+log/1917cdd8c90b..2334660053e0

$ git log 1917cdd8c..233466005 --date=short --no-merges --format='%ad %ae %s'
2018-01-30 npm Use unsigned for char width
2018-01-30 dsinclair Shuffle more code out of CXFA_Node
2018-01-30 dsinclair Move CheckButton code from CXFA_Node to CXFA_CheckButton
2018-01-30 rharrison Clean up CSS Data Table entries and access
2018-01-30 tsepez Remove bare new from JS_Define.h
2018-01-30 hnakashima Check if opj_image_data_alloc returned null.
2018-01-30 dsinclair Cleanup some param passing code
2018-01-30 hnakashima Guard usages of tellp(). It may return -1 in error cases.
2018-01-30 dsinclair Cleanup duplicate RunScript code
2018-01-30 thestig Remove not reachable branch in fxge code.
2018-01-30 thestig Use anonymous namespace in gdiplus code.
2018-01-30 dsinclair Cleanup some SDK code
2018-01-30 tsepez Revert "Revert "Use UnownedPtr instead of T* in MaybeOwned.""
2018-01-30 tsepez Revert "Use UnownedPtr instead of T* in MaybeOwned."
2018-01-30 tsepez Use UnownedPtr instead of T* in MaybeOwned.

Created with:
  roll-dep src/third_party/pdfium
BUG=807214,805881


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iccd05c3211b080fc7392a482d0c2be722c1ec683
Reviewed-on: https://chromium-review.googlesource.com/894482Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533128}

AndroidScrollIntegrationTest.testUiScrollReflectedInJs has a precision issue
when enabling --use-zoom-for-dsf. It is the same problem with the one described
in crrev.com/c/844266. In crrev.com/c/844266, I did not apply the same thing to
AndroidScrollIntegrationTest.testUiScrollReflectedInJs as a mistake.

Bug: 737777
Change-Id: I9474e8cf424ed2bf6b10578ab3c7ff7fbf8b6c4b
Reviewed-on: https://chromium-review.googlesource.com/892782Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533127}

It's expected that the providers are available when the service is
committed, so it make it explicit.

BUG=none
TEST=none

Change-Id: Ibc2f9be6ecec9261e1a2b9ebef18b16557882398
Reviewed-on: https://chromium-review.googlesource.com/890722
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533126}

Enabling --use-zoom-for-dsf scales parameters given to
OverscrollControllerAndroid::OnOverscrolled() by the device scale factor.
Accordingly, crrev.com/c/638510 updated values given to
glow_effect_->OnOverscrolled(), but related unit tests (i.e.,
OverscrollBehaviorContainPreventsNavigation and
OverscrollBehaviorNonePreventsNavigationAndGlow of
OverscrollControllerAndroidUnitTest) are not updated correctly. This CL changes
those unit tests and solve those unit tests' failures that occur when
--use-zoom-for-dsf is enabled.

Bug: 737777
Change-Id: Ia52fa1bef039fb234bd731ca1919cb850602a70f
Reviewed-on: https://chromium-review.googlesource.com/890141Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533125}

https://chromium.googlesource.com/angle/angle.git/+log/bd6ae4aa145d..199f42941ab5

$ git log bd6ae4aa1..199f42941 --date=short --no-merges --format='%ad %ae %s'
2018-01-19 ynovikov Vulkan: Enable on Android

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I00a1e9aaf6d69b996744ab032adcdff68e0bf85f
Reviewed-on: https://chromium-review.googlesource.com/894727Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533124}

This reverts commit e4c53ce3.

Reason for revert: Breaks Marshmallow Tester bot:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/19160

Original change's description:
> [Android] Cleanup ExternalNavigationHandlerTest
> 
> This CL:
> - Replaces calls to
>   ExternalNavigationDelegateImpl#isSpecializedHandlerAvailable() with calls to
>   #countSpecializedHandlers() because #isSpecializedHandlerAvailable() has just
>   one caller
> - Replaces ChromeBrowserTestRule with NativeLibraryTestRule
> - Uses a mock context for both ContextUtils#getApplicationContext() and for
>   TabRedirectHandler instead of just for TabRedirectHandler
> - Makes TestPackageManager#queryIntentActivities() and
>   TestExternalNavigationDelegate#queryIntentActivities() use same
>   implementation.
> - Changes tests to register relevant http:// and https:// handlers at the
>   beginning of the test. This is a change of behavior. Previously, most URLs
>   would be handled by the "foo" external app
> - Changes TestExternalNavigationDelegate#mQueryIntentOverride from tristate to
>   boolean. The "true behavior" was nuked but the "false behavior" was
>   preserved.
> 
> BUG=None
> 
> Change-Id: If212afde6e4c12d4f08576c4bd26392b8732bc09
> Reviewed-on: https://chromium-review.googlesource.com/891744
> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532970}

TBR=mariakhomenko@chromium.org,pkotwicz@chromium.org,thildebr@chromium.org

Change-Id: Ifb044a014ac4d94a74fffaf493cc3aad32b42ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/894684Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533123}

Change-Id: I73ed14280aa909fff24aae9a9bffc4fca330cb61
Reviewed-on: https://chromium-review.googlesource.com/894463
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533122}

This reverts commit b05f99c3.

Reason for revert: Crashes the Linux build -- 807487

Original change's description:
> sqlite: Disable unused features via compile-time options.
> 
> This CL shrinks the Linux binary by 34KB (138,266,816 to 138,232,320).
> Code savings aside, this makes sure we don't unintentionally start
> depending on these features.
> 
> The following compile-time options are recommended in the SQLite
> documentation [1]:
> 
> * SQLITE_LIKE_DOESNT_MATCH_BLOBS - The LIKE and GLOB operators don't
>   work on BLOB columns. This access pattern would be a performance
>   wrench, so it's nice to fail hard here.
> * SQLITE_OMIT_DEPRECATED - This removes support for deprecated SQLite
>   APIs. Note that SQLite promises to maintain indefinite backwards
>   compatbility for SQL queries (modulo features disabled via
>   compile-time options), so this only applies to the SQLite API. We
>   should never be using deprecated APIs.
> * SQLITE_OMIT_PROGRESS_CALLBACK - Remove sqlite3_progress_handler(). We
>   don't use this feature, and the documentation says it comes with a
>   small performance penalty.
> * SQLITE_OMIT_SHARED_CACHE - Using a shared cache sounds nice from a
>   memory consumption standpoint, and we already do that for LevelDB.
>   Unfortunately, Chromium's SQLite databases use a variety of page
>   sizes, which makes cache sharing impossible.
> * SQLITE_USE_ALLOCA - Use alloca() instead of malloc() for allocating
>   temporary spaces in functions. All of Chrome's platforms support this
>   option, and it results in a slightly smaller binary and less heap churn.
> 
> The following compile-time options disable features that happen not to
> be used.
> 
> * SQLITE_OMIT_AUTOINIT: We initialize SQLite manually in //sql/connection.cc.
> * SQLITE_OMIT_AUTORESET: We calls sqlite3_reset() correctly to reset prepared
>   statements.
> * SQLITE_OMIT_GET_TABLE: We don't use sqlite3_{get,free}_table().
> * SQLITE_OMIT_LOAD_EXTENSION: We don't use sqlite3_{enable_}load_extension().
>   Asides from the code savings, there's a tiny security benefit to
>   knowing that extension loading code is definitely not reachable from WebSQL.
> * SQLITE_OMIT_TCL_VARIABLE: We don't use TCL variables.
> * SQLITE_OMIT_TRACE: We don't use sqlite3_{profile,trace}().
> 
> Bug: 807093
> Change-Id: Ie5e59e55dd9b2ed52f7c27682a809c9f7c36d4a3
> Reviewed-on: https://chromium-review.googlesource.com/882961
> Commit-Queue: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Chris Mumford <cmumford@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532995}

TBR=cmumford@chromium.org,pwnall@chromium.org

Change-Id: Ib49bee7c6c815cafa9eef211c5dd154cd4dd2a8d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 807093
Reviewed-on: https://chromium-review.googlesource.com/894707Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533121}

This patch changes "5032095.html" to utilize |selection_test()| for ease of
maintenance.

Note: Following patch will rename this file to
"insert_html_at_end_of_paragraph.html".

This patch is a preparation for the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 679977
Change-Id: Ie25f8ffc08c581a52ecab0ab7f3cb715f95021a6
Reviewed-on: https://chromium-review.googlesource.com/892552Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533120}

These files are moved:
download_danger_type.h
download_save_info.h
download_save_info.cc
download_source.h

We are gradually moving all download related files from content/ to components/download.
This allows us to make download a standlone component,
and finally making it a service under services/download

BUG=803135

Change-Id: Id5be2a98beabd8bbd8be000a0fd1a36d633c6f7b
Reviewed-on: https://chromium-review.googlesource.com/891686
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533119}

This patch changes "smart-delete-across-editable-boundaries-2.html" to utilize
|selection_test()| for ease of maintenance.

This patch is a preparation for the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 679977
Change-Id: If0c815668d80ebfed826f4efd5e4bf9a428a627e
Reviewed-on: https://chromium-review.googlesource.com/892556Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533118}

This patch changes "move-by-word-001.html" to utilize |selection_test()| for
ease of maintenance.

This patch is a preparation for the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 679977
Change-Id: I197c5cdf3ef6848855f8c2e4257f67cc7574874a
Reviewed-on: https://chromium-review.googlesource.com/890882Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533117}

Utilize GetSelectionTextInFlatTreeFromBody() in VisibleSelectionTest.ExpandUsingGranularityWithEmptyCell

This patch changes |VisibleSelectionTest.ExpandUsingGranularityWithEmptyCell| to
use |GetSelectionTextInFlatTreeFromBody()| for ease of maintenance.

This patch is a preparation for the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Change-Id: Id4212be8044fe05a15abd77d72fd8bf9524fa646
Reviewed-on: https://chromium-review.googlesource.com/892800Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533116}

This patch changes "extend-by-word-001.html" to utilize |selection_test()| for
ease of maintenance.

This patch is a preparation for the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 679977
Change-Id: I5144d907927a936b5e7712d3fa404a2167b7e44d
Reviewed-on: https://chromium-review.googlesource.com/892580Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533115}

2x printer PNG images were checked in without optimization, and contain
metadata bloat. This CL removes the metadata and optimizes the
compression.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ica542a73e9735c06a444c1413175a36340a218aa
Reviewed-on: https://chromium-review.googlesource.com/894264Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533114}

Their content dependencies have been removed in previous changes.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62
Reviewed-on: https://chromium-review.googlesource.com/893651
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533113}

The method PermissionsSet::HasScriptableAccessToURL is currently not being used.
Remove it. Any access by clients should ideally be made through the
PermissionsData class or through the PermissionsSet::scriptable_hosts() method.

BUG=None

Change-Id: I22ca956315bb19de8e19dcd00f33baed460dd610
Reviewed-on: https://chromium-review.googlesource.com/894170Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533112}

Move the logic for calling NSDisableScreenUpdates into
BrowserCompositorView from RenderWidgetHostViewMac.

This is needed because we no longer will be getting
SubmitCompositorFrame in RWHVMac -- the new equivalent
is BrowserCompositorMac::OnFirstSurfaceActivation.

Simplify the logic of pausing during resize in
RenderWidgetHostImpl and its interactions with
RenderWidgetHostViewBase.

R=sdy
TBR=avi (content/)

Change-Id: I5276abade510b16b0b2c583b915ab248b48e5446
Reviewed-on: https://chromium-review.googlesource.com/890220
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533111}

This reverts commit 6d438d70.

Reason for revert: Causing errors in release scripts which is blocking canary release.

BUG: 807318

Original change's description:
> Add variable to conditionally fetch ios_internal.
> 
> Add variable checkout_ios_internal to conditionally fetch ios_internal.
> Use pinned revision to ensure build stays hermetic and reproducible.
> 
> Bug: 803846
> Change-Id: Id8ba650400b283645f8c00629dd269739d813195
> Reviewed-on: https://chromium-review.googlesource.com/880903
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532437}

TBR=rohitrao@chromium.org,mmoss@chromium.org,dpranke@chromium.org,sdefresne@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 803846
Change-Id: I15afba5e030ccd58b80a78c60ad452657c89169a
Reviewed-on: https://chromium-review.googlesource.com/894242Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533110}

Update the http-equiv and preload scanner code path as well. The client
hints are provided only on secure contexts if
ClientHintsPersistentEnabled() feature is enabled.

Bug: 782381
Change-Id: I28d75b6bfd14f36accdba8f87488ae687df049d7
Reviewed-on: https://chromium-review.googlesource.com/887924
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533109}

There was a rule that let anything components/viz/service have a
dependency on anything else. This wasn't intended. Invert that rule and
explicitly allow DEPS where they should exist.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ida5c3f86487807b8ae2ad9bee01cdd8227b6ed9d
Reviewed-on: https://chromium-review.googlesource.com/892101
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533108}

Adds a Python script for automatically bisecting VR perf regressions.
This is a temporary solution while we wait for automatic bisects on the
perf dashboard to support devices outside of the Telemetry lab. This is
only meant to run on a developer's workstation, not as part of any
automatation/on bots/etc.

Change-Id: I6887210cc2d83823c4a09efc9b5581578f5d1c7e
Reviewed-on: https://chromium-review.googlesource.com/894283Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533107}

The nested code section was not rendering correctly on the live
Markdown server, and didn't match the tools/md_browser preview.
Simplify the layout to avoid inconsistencies.

Bug: 801929
Change-Id: Id8f84f24407d39dd2d125d8f349d214fccbe254a
Reviewed-on: https://chromium-review.googlesource.com/892478Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533106}

outstanding sent packets. This was accidentally removed for QUIC versions
greater than 33 when introducing new ack format.

Manually merge internal change: 183736634

Bug: 806109

Change-Id: I60a86ebda2dbb45646221c40b393b5f825c99fe2
Reviewed-on: https://chromium-review.googlesource.com/892206
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533105}

BUG=802935

Change-Id: I7e935c623fc70e51e9989a80bde32135b0f0a1b8
Reviewed-on: https://chromium-review.googlesource.com/894643Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533104}

Merge flag changes.
https://chromium-review.googlesource.com/c/chromium/src/+/892464


Support serializing and parsing QUIC Transport Parameters

QUIC Transport Parameters are put in a TLS extension and used by each
endpoint to unilaterally inform the other peer what parameters it
supports. This change adds code to serialize them into the wire format
suitable to be passed into SSL_set_quic_transport_params, and to parse
the wire format that comes from SSL_get_peer_quic_transport_params.

currently unused support code for TLS 1.3 in QUIC

Merge internal change: 183139434
https://chromium-review.googlesource.com/c/892460/


In QUIC, replace is_unackable with an enum SentPacketState. No functional change expected. Not protected.

Merge internal change: 183132907
https://chromium-review.googlesource.com/c/892208/


Make some QUIC dlogs more informative.

Merge internal change: 182957865
https://chromium-review.googlesource.com/c/892358/


Refactor socket creation logic for quic client to take in receive/send buffer size as arguments. And take flag value for that in quic to backend connection.

n/a, refactor only. Modified code is not used in production, not flag protected.

Merge internal change: 182940277
https://chromium-review.googlesource.com/c/892120/


Deprecate FLAGS_quic_reloadable_flag_quic_allow_multiple_acks_for_data2.

Merge internal change: 182923175
https://chromium-review.googlesource.com/c/892207/


Deprecate FLAGS_quic_reloadable_flag_quic_strict_ack_handling.

Merge internal change: 182826376
https://chromium-review.googlesource.com/c/892281/


deprecate FLAGS_quic_reloadable_flag_quic_enable_hq_deframer.

Merge internal change: 182818920
https://chromium-review.googlesource.com/c/892105/

Change-Id: I54f0b3b28ec7b126904cb5da1cce59bccd66e0ae
Reviewed-on: https://chromium-review.googlesource.com/892401
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533103}

For context see
https://github.com/w3c/csswg-drafts/issues/2140

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/BLsXXiukAgAJ

Bug: 804187
Change-Id: I8a430943a5d873a55055654bcef2365d40dd71e3
Reviewed-on: https://chromium-review.googlesource.com/892838
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533102}

This CL changes the buckets for the Expected Queueing Time histograms in
microseconds. The reasoning behind this is to try to capture the 99.9 percentile
in Windows, which currently sometimes overflows, as shown by:
https://uma.googleplex.com/p/chrome/timeline_v2/?sid=6158e596fecaa96afaca0f52ed21ece5

The max bucket value is changed from 4 seconds to 30 seconds, and the number of
buckets is kept the same. Due to the exponential nature of the buckets, having
the same number of buckets is reasonable and increasing the number of buckets
does not really provide a huge advantage:
https://gist.github.com/npm1/7f530e176c66258e83fc27a62b6032ec

Change-Id: Id4a4efeb3f8921ef05028c8fb88a6d1de1ff64cf
Reviewed-on: https://chromium-review.googlesource.com/893704
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533101}

Attaching by default now.

Bug: none
Change-Id: I76a440a99d194ad64f77e8b39b541ed0836b351d
Reviewed-on: https://chromium-review.googlesource.com/894184
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533100}

Add a new experiment with warn_on_low_reputation set to true.

Change-Id: Iac7a2c1d1e91d2696011bb60beed2c81f1e2b1c7
Reviewed-on: https://chromium-review.googlesource.com/893905
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533099}

This reverts commit 92ffe77a.

Reason for revert: I suspect that the original revert was inappropriate – more detailed reasoning left as a review comment on the revert CL.

Original change's description:
> Revert "[Variations] Avoid duplication of the safe seed value stored in prefs."
> 
> This reverts commit 4db68ed9.
> 
> Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712).
> 
> Original change's description:
> > [Variations] Avoid duplication of the safe seed value stored in prefs.
> > 
> > When the safe seed and the latest seed have identical contents, use a sentinel
> > value to avoid storing a duplicate value for the two seeds. This is purely a
> > storage space optimization; no difference in observed functionality is expected.
> > 
> > R=​asvitkine@chromium.org
> > 
> > Bug: 727984
> > Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb
> > Reviewed-on: https://chromium-review.googlesource.com/880482
> > Commit-Queue: Ilya Sherman <isherman@chromium.org>
> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#532027}
> 
> TBR=isherman@chromium.org,asvitkine@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 727984, 806712
> Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456
> Reviewed-on: https://chromium-review.googlesource.com/891119
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Commit-Queue: vitaliii <vitaliii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532401}

TBR=isherman@chromium.org,asvitkine@chromium.org,vitaliii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 727984, 806712
Change-Id: I1627111dacc8d59bc43aa7b1b7ed76db8f165ee2
Reviewed-on: https://chromium-review.googlesource.com/894622Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533098}

- Extract global state initialization code into common API.
- Get cronet::EnsureInitialized to work properly if initialized from Cronet_Engine native API.
- Add accept_language to URLRequestContextConfig[Builder], but don't expose it to Java.

Bug: 786559
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I60b9cdd31837e1b15d4c2479427d5d0a77999536
Reviewed-on: https://chromium-review.googlesource.com/868076Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533097}

https://chromium.googlesource.com/catapult.git/+log/3f8c43b79487..9fd18084bd44

$ git log 3f8c43b79..9fd18084b --date=short --no-merges --format='%ad %ae %s'
2018-01-29 dtu [pinpoint] Decrease questionable threshold as repeats increase.
2018-01-30 benjhayden [results.html] Auto Show All when empty search results.
2018-01-30 perezju [Telemetry] Improve GetChildPids on android platform
2018-01-30 eakuefner [Telemetry] Add benchmark_duration histogram
2018-01-30 perezju [Telemetry] Improve GetPsOutput for android platform backend

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I69b5efbd55abb44970d8199d2ac3b7da38adc306
Reviewed-on: https://chromium-review.googlesource.com/894495Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533096}