- 10 Apr, 2020 40 commits
-
-
Sammie Quon authored
If a window is not animated, clipping will happen on first bounds update and without animation. Windows animated into overview remain unchanged. See bug for before and after videos [1]. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1069540#c11 Test: manual Bug: 1069540 Change-Id: I683b49e87c5fa4fe0bc6d27b2dee31389fbb0d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145233 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#758231}
-
Jiaxun Wei authored
Bug: 1061344 Change-Id: If8f966a92069e5d6a6a157e29c3a454678cc9590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141564 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Jiaxun Wei <leuisken@gmail.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758230}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb2c6c025366..647a242debd9 Created with: gclient setdep -r src-internal@647a242debd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1024588,chromium:1029346,chromium:1031465,chromium:1047869,chromium:1047876,chromium:1058017,chromium:1058152,chromium:1061193,chromium:1063948,chromium:1065041 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I073707be66294e8f0c8ef4f362e5624230a28157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145608Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758229}
-
Hongbo Song authored
We need to know total input delay and number of inputs for each page visit. To better align with `PageForegroundSession.ForegroundDuration`, we plan to add TotalInputDelay, TotalAdjustedInputDelay, NumInputEvents UKM for each PageForegroundSession. UKM privacy review: https://docs.google.com/document/d/1F4ZImXniH_YZA6Z4FcONHbwe-ze0q0Bp0W6RKxDf-Kg/edit?usp=sharing Change-Id: I010d8b7b35af3d3f611f8a29542dd10956c2ab7f Bug: 1069304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144362 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#758228}
-
Reilly Grant authored
This reverts commit 677e751d. Reason for revert: Failures on ios-simulator-noncq. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/3637 Original change's description: > [iOS] Fix NTP presentation on bad ssl pages > > This CL makes sure that we don't display the NTP if the loaded page is > an interstitial page. > This is caused by the behaviour of interstitial when the committed > interstitial feature isn't enabled. In that case the workflow is: > 1. about:newtab is loaded > 2. User loads bad.badssl.com > 3. Navigation did start for bad.badssl.com > 4. Navigation ends for bad.badssl.com > 5. This is a bad ssl page so Chrome actually reverts to about:newtab > 6. Load stops, but at this point the visible URL is about:newtab > 7. The interstitial is displayed and the visible URL is updated to > bad.badssl.com > 8. The observers are notified through DidChangeVisibleSecurityState > 9. No further callbacks > > So the main issue is that there is not callback notifying that the > visible URL has changed. > This CL fixes it by adding a callback on DidChangeVisibleSecurityState > and also on LoadStop to avoid having the NTP flashing between 6 and 7. > > Fixed: 1067250 > Change-Id: Ifc57addf5a6fa9e6295446da34e117028add73fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141971 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Livvie Lin <livvielin@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758163} TBR=justincohen@chromium.org,gambard@chromium.org,livvielin@chromium.org Change-Id: I62d19870a0ad15fbfc4725f43de6eae28950f04e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145763Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758227}
-
Roman Aleksandrov authored
Use new method for skipping screen. Add tests for UMA stats. Bug: 1064561 Change-Id: Ieabfdab904e6e83501a3188a3ff8d4184da0bb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142264 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758226}
-
Tao Bai authored
This patch also add a constructor to make unit test easy. Bug: 1064420 Change-Id: Ibeaa4bdab2c66f581360eea1a37e199b2c009313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140920 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758225}
-
Steven Bingler authored
SiteForCookies's function will, conditionally on the SchemefulSameSite feature, take scheme of the URLs into account when determining first-partyness and equivalency. Schemefully_same_ will also be used in determining IsNull() when SchemefulSameSite is enabled. Bug: 1030938 Change-Id: I4599555faddf3f294144023af50c1a0ade67cca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144258 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#758224}
-
Moe Ahmadi authored
Certain types of suggestions such as the proactive zero-prefix suggestions may be associated with suggestion group IDs that indicate their type, e.g., trending or onboarding PZPS. Since proactive zero-prefix suggestions cannot be individually deleted, users should be able to hide/show all suggestions belonging to a given group ID. This CL introduces a list pref that controls the visibility of suggestion group IDs. Convenience methods are added to the omnibox:: namespace to check whether a given suggestion group ID is hidden and to toggle visibility of a given suggestion group ID. This CL also renames the files omnibox_pref_names.h/cc to omnibox_prefs.h/cc as they contain more than just the pref names. Bug: 1046547 Change-Id: Iea9a03eb70b780c583e3cf8f48d819a9aa9c1f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137866Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758223}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a5c914b63a0c..97d7f070200a git log a5c914b63a0c..97d7f070200a --date=short --first-parent --format='%ad %ae %s' 2020-04-10 sonnysasaka@chromium.org Add -blueznext suffix as special images 2020-04-09 lamontjones@chromium.org api: update python bindings. 2020-04-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-09 kimjae@chromium.org build_dlc.py: Add DLC_DESCRIPTION flag 2020-04-09 saklein@chromium.org cros_build_lib: mute_output only used when set 2020-04-09 saklein@chromium.org cros_build_lib.run: Fix quiet argument. 2020-04-09 saklein@chromium.org run(mute_output): Remove usages of the argument. 2020-04-09 saklein@chromium.org flash-ap: Simplify and enumerate config checks. Created with: gclient setdep -r src/third_party/chromite@97d7f070200a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Iebec4597f73ffcd1c8e1e078fbae81b3dd168c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758222}
-
Adam Langley authored
Change-Id: I157f2b427d2f18d6687661bee941bc9e568d2530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145559 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758221}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I3c38b25403e3400eec7eb13c597a7e52be0b198a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144745 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#758220}
-
Wez authored
This reverts commit b163621e. Reason for revert: These tests no longer fail under Fuchsia. Original change's description: > [Fuchsia] Filter tests broken by getsockname(). > > Temporarily filter some tests which fail due to broken getsockname() > semantics on connect()ed UDP sockets. > > Bug: 989223 > Change-Id: I5ddd5783d33ce84999cced12f273d3680f56fae1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730653 > Auto-Submit: Wez <wez@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683366} Bug: 989223 Change-Id: I6c15a468c80ccceafe3c198cc333f0487a52404b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144175 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758219}
-
David Tseng authored
Bug: none Change-Id: I16fbd6b1d6a712e69628136d13884a38128d3121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144403 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758218}
-
Chris Lu authored
Bug: 790886 Change-Id: I90fdb3e503ca8792d54cf474ee59772ac9aeafe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142141Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#758217}
-
Chong Gu authored
Symbolize log_listener output, in order to get logs from WebEngine. Able to provide more information when tests fail. If system-log-file is not specified, we create a temp system log that Telemetry can consume. Bug: 1069256 Change-Id: I8a10a37356dc72206a40d985f548b29048b4ee31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142498 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758216}
-
Torne (Richard Coles) authored
I accidentally shadowed a variable in testDisconnectedViewLoadsContent leading to the test still flaking. Fix that, and also apply the same change to VisualStateTest which also uses a detached view and thus can be vulnerable to the same issue. Bug: 949391 Bug: 1058304 Change-Id: Ifc1d8305dca265368c1fa2dc7d8c1cc9bb487e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145754 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
-
Scott Violet authored
Calling WebContents::Stop() from WebContentsObserver::DidStartNavigation() or WebContentsObserver::DidRedirectNavigation triggers a crash. This patch works around this by installing a NavigationThrottle. The NavigationThrottle cancels the navigation as necessary. Does this ensures we don't attempt to call Stop() while servicing these functions, yet ends up with the same result. BUG=1068115 TEST=Covered by weblayer_browsertests Change-Id: I284842120c2466a2a74856c0f72201200137b9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141232 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#758214}
-
Alex Turner authored
The scripts added by createAdFrameWithWindowStopAbortedLoad must have async set to false to ensure that they are loaded in insertion order. This allows the last script's onload handler signal that all three scripts have loaded. The current behavior -- with non-deterministic ordering -- is believed to be the cause of a flaky test (AdTaggingBrowserTest. ChildrenOfFrameWithWindowStopAbortedLoad_StillCorrectlyTagged) Bug: 1069346 Change-Id: I854eeee46c924920b9842701a6256a119cf676ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144832Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758213}
-
Charlie Hu authored
Previously, |message| field in DocumentPolicyViolationReportBody was always set to "Document policy violation", which was not helpful in tracing down the issue. This CL includes the customized message set at callsite of IsFeatureEnabled(DocumentPolicyFeature...) to DocumentPolicyViolationReportBody. Change-Id: If6eaa87140df26f2e8bd1dd45a94a1cfec88e803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110430 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#758212}
-
Rainhard Findling authored
* Removes |IDS_SHORT_PRODUCT_NAME| from the strings, and moves the strings into the Chrome and Chromium string files. * This is done for translation reasons, see chrome/app/PRESUBMIT.py for details. Bug: 1067175 Change-Id: I963a94a6684f2a2dbdba76c4d790da6c1eb06a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141104 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758211}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/469c029a7c22..cf2c8e6068c8 git log 469c029a7c22..cf2c8e6068c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 m.maiya@samsung.com EGL: Relax test skip conditions for a few colorspace ImageTests Created with: gclient setdep -r src/third_party/angle@cf2c8e6068c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I5afeb3ec849767d3ba2ab8950d0f7392aba54930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145603Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib339e816175670df686263a95bedfe5da5060ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145607Reviewed-by:
-
Manu Cornet authored
Change-Id: Icd18465789966a8f00c4ad1884eafd84c5a4c5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144213Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#758208}
-
Tommy Li authored
This CL adds some mouse hover handling to the omnibox Views headers, analogous to what OmniboxResultView already has. The logic is slightly duplicative but I would hesitate to add any abstraction at this point, given the experimental nature of the feature, as well as the fact that it's just two locations. Bug: 1052522 Change-Id: Ib0211c1e168bf17e0ff6ad487cc43c986801e064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145077Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#758207}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7255d72f8da..f4403e7a7805 git log f7255d72f8da..f4403e7a7805 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 fmalita@chromium.org Revert "[SVG] Replace custom attribute value wrappers with std::variant" 2020-04-10 fmalita@chromium.org [SVG] Replace custom attribute value wrappers with std::variant Created with: gclient setdep -r src/third_party/skia@f4403e7a7805 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I2ab89250f0c28cbd18cb79fd269791bfe0c4dce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145604Reviewed-by:
-
Stepan Khapugin authored
Assigns IDs semi-randomly to created scenes and restores the session from a given session ID into a scene. This fixes a bug where opening a new window would restore the previous session from the first window. However, a permanent solution here would be to actually implement session restoration that is not based on non-persistent integer window IDs. Bug: 1069747 Change-Id: I4a5352d56f4a7d506ff618944b9868c688a5b612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144274 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#758205}
-
David Jean authored
Screenshots: https://drive.google.com/open?id=1wO5R_D_1ogzaLFIfoaj-puXGwgVGmt2g https://drive.google.com/open?id=1XViRY_5zc_K7zmvznBDsmOTKiJpOwRZD https://drive.google.com/open?id=1ppZj1vKlvHXd8HGxIAUczyCvD4DZ_4a6 Bug: 1052143 Change-Id: I883f97f34be0999171f16075abd975166a53f7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141900Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#758204}
-
Nate Fischer authored
This documents the cool stuff hiding in Dev UI's options menu. This also links to instructions for hooking up WebView to Chrome DevTools, in case folks find this page looking for that. Bug: 1058571 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I6ecd5ac4b8e102b36a5cbdd28c9ce60958057a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144263 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#758203}
-
Maksim Sisov authored
This is part of the effort to move X11WholeScreenMoveLoop and X11DesktopWindowMoveClient down to ui/base/x outside ui/views. To do so, we need to stop using such components as aura:: or views:: there. Bug: 1069469 Change-Id: Ifa32ed167720985ec24c40a246340799d7339bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144055Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#758202}
-
Koji Ishii authored
This patch adds `const` to the instances of |NGFragmentItem|. Bug: 982194 Change-Id: Id8262130e0e516c904c4f441fb05b04076d866d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139635Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758201}
-
Monica Basta authored
This CL implements showing the user manager on startup if |kNewProfilePicker| feature is enabled and there is no policy to force signin. The next step will be to create the profile picker and show it instead of the user manager. Bug: 1063856 Change-Id: I9a8efd1267191e590b2087a3bbfbf0b828c91584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133983 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#758200}
-
Dominic Farolino authored
This CL removes lazy load image placeholder logic and tests. It somewhat accompanies https://crrev.com/c/2125570, and the specific changes are summarized below: - Removes FetchParameters::SetAllowImagePlaceholder, which turns eligible image requests into range requests for the first 2k of the real image, such as to fetch the placeholder. This was originally added in codereview.chromium.org/2423683002. - Removes the LAZY_IMAGE_LOAD_DEFERRED previews state, and its associated Blink enum value. This was originally added in crrev.com/c/1260926, which also stored some lazy loaded image state in PlaceHolderImage, and added some placeholder creation logic. This CL removes those changes as well. - Removes the LAZY_IMAGE_AUTO_RELOAD previews state, and its associated Blink enum value. This was originally added in crrev.com/c/1529865, which also recorded estimated data savings of Lo-Fi and lazy loaded images whose placeholders were first fetched. The Lo-Fi recording was removed in crrev.com/c/1652012, and this CL removes the recording for lazy loaded images. - Removes FetchParameters::ImageRequestOptimization::kAllowPlaceholder, and replaces all invocations of CSSImageValue::CacheImage that pass in kAllowPlaceholder, with invocations that pass kNone. - [TEST]: Removes TestThatReloadIsStartedThenServeReload, and TestThatIsPlaceholderRequestAndServeResponse in the image resource tests, and the tests that use them, as they test placeholder/partial image fetching, and use FetchParameters::SetAllowImagePlaceholder which is going away in this CL. - [TEST]: Remove other tests that use FetchParameters::SetAllowImagePlaceholder. Bug: N/A Change-Id: Ic39036a5a240df483970375a89f35678e0f10866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137860Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#758199}
-
Benoit Lize authored
The lock only ensures that initialization is done once. This does not require a lock, and actually would not require to be done only once at all since the initialization is idempotent. This is part of a larger PartitionAlloc refactoring (see linked bug). Bug: 1061437, 787153 Change-Id: Ie2898b59114216ab76050c47e6d998051d3f3998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144138Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#758198}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05e2350de5a9..f7255d72f8da git log 05e2350de5a9..f7255d72f8da --date=short --first-parent --format='%ad %ae %s' 2020-04-10 bsalomon@google.com Try out plane/channel index scheme in wacky yuv format GMs. Created with: gclient setdep -r src/third_party/skia@f7255d72f8da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I3f66cf4b8e91b455230d1bee2d3328b5364eec40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145601Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ef5a232. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Idb4e0d7909f0e9a9782ee9cb977f423476d8c9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143856Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758196}
-
David Jean authored
Bug: 1045454 Change-Id: I187eec6794ba509f32560c0d422124a628ee4d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144176Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1260c0bbd0ae..cf9ec0ae80a4 git log 1260c0bbd0ae..cf9ec0ae80a4 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@cf9ec0ae80a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2b19436423b3b8df9a5c709a2d07078b1d08393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145596Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/75de196cecab..fd593d5f0834 git log 75de196cecab..fd593d5f0834 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 h.baensch.92@gmail.com Get rid of all warnings with MSVC and clang-cl (#2177) Created with: gclient setdep -r src/third_party/glslang/src@fd593d5f0834 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Id62467a67fb258ddd6f8ab148743654682d2b97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145440Reviewed-by:
-
Monica Basta authored
Bug: 1063856 Change-Id: Ic5ca250b80ee2a76c22d18ed2724f33550afb35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116190 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
-
